From dac137cf11af701af327573f444eb6efea3ff31d Mon Sep 17 00:00:00 2001 From: Arnaud Bienner Date: Fri, 31 Jan 2014 20:17:26 +0100 Subject: [PATCH] Remove useless check. No need to check isNull if you're checking isEmpty (see http://qt-project.org/doc/qt-4.8/qstring.html#distinction-between-null-and-empty-strings "A null string is always empty"). --- src/podcasts/podcastepisode.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/podcasts/podcastepisode.cpp b/src/podcasts/podcastepisode.cpp index 1b8f402d7..4924a7810 100644 --- a/src/podcasts/podcastepisode.cpp +++ b/src/podcasts/podcastepisode.cpp @@ -175,7 +175,7 @@ Song PodcastEpisode::ToSong(const Podcast& podcast) const { ret.set_album(podcast.title().simplified()); ret.set_art_automatic(podcast.ImageUrlLarge().toString()); - if (author().isNull() || author().isEmpty()) + if (author().isEmpty()) ret.set_artist(podcast.title().simplified()); } return ret;