diff --git a/src/musicbrainz/musicbrainzclient.h b/src/musicbrainz/musicbrainzclient.h index c91b5da12..e17065343 100644 --- a/src/musicbrainz/musicbrainzclient.h +++ b/src/musicbrainz/musicbrainzclient.h @@ -39,7 +39,8 @@ class MusicBrainzClient : public QObject { public: // The second argument allows for specifying a custom network access - // manager. It is used in tests. + // manager. It is used in tests. The ownership of network + // is not transferred. MusicBrainzClient(QObject* parent = nullptr, QNetworkAccessManager* network = nullptr); diff --git a/tests/musicbrainzclient_test.cpp b/tests/musicbrainzclient_test.cpp index ac0306539..52fc5c7c7 100644 --- a/tests/musicbrainzclient_test.cpp +++ b/tests/musicbrainzclient_test.cpp @@ -38,11 +38,13 @@ Q_DECLARE_METATYPE(ResultList); class MusicBrainzClientTest : public ::testing::Test { protected: - void SetUp() { - mock_network_.reset(new MockNetworkAccessManager); + static void SetUpTestCase() { qRegisterMetaType("MusicBrainzClient::ResultList"); } + void SetUp() { + mock_network_.reset(new MockNetworkAccessManager); + } // Reads the data from a file into a QByteArray and returns it. QByteArray ReadDataFromFile(const QString& filename) {