From ab37de5e8fa2f606bcfa27c543a4fc5f6fee7f34 Mon Sep 17 00:00:00 2001 From: John Maguire Date: Thu, 13 Jan 2022 21:30:42 +0000 Subject: [PATCH] Revert "Transcodedialog: moving things into more specific scope" This reverts commit dd1393ea3ab5ae58aff8f8cc444aee3c8e4830fb. --- src/transcoder/transcodedialog.cpp | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/transcoder/transcodedialog.cpp b/src/transcoder/transcodedialog.cpp index dcb93c179..e19d3643c 100644 --- a/src/transcoder/transcodedialog.cpp +++ b/src/transcoder/transcodedialog.cpp @@ -212,14 +212,13 @@ void TranscodeDialog::JobComplete(const QUrl& input, const QString& output, UpdateProgress(); bool overwrite_existing = ui_->remove_original->isChecked(); + QFileInfo input_fileinfo(input); + QFileInfo output_fileinfo(output); + bool same_extension = input_fileinfo.suffix() == output_fileinfo.suffix(); + bool same_path = + input_fileinfo.absolutePath() == output_fileinfo.absolutePath(); if (success && overwrite_existing) { - QFileInfo input_fileinfo(input); - QFileInfo output_fileinfo(output); - bool same_extension = input_fileinfo.suffix() == output_fileinfo.suffix(); - bool same_path = - input_fileinfo.absolutePath() == output_fileinfo.absolutePath(); - QFile(input).remove(); if (same_path && same_extension) { QFile(output).rename(input);