From 2dfb7f8f4cf60896af5657decce8adc6abca4c97 Mon Sep 17 00:00:00 2001 From: maximko Date: Thu, 4 Sep 2014 18:08:17 +0600 Subject: [PATCH 1/2] Increase cover image size. --- src/internet/soundcloudservice.cpp | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/internet/soundcloudservice.cpp b/src/internet/soundcloudservice.cpp index 82d703367..3d11a35f1 100644 --- a/src/internet/soundcloudservice.cpp +++ b/src/internet/soundcloudservice.cpp @@ -495,10 +495,15 @@ Song SoundCloudService::ExtractSong(const QVariantMap& result_song) { QVariant cover = result_song["artwork_url"]; if (cover.isValid()) { + // Increase cover size. + // See https://developers.soundcloud.com/docs/api/reference#artwork_url + QString big_cover = cover.toString().replace("large", "t500x500"); + QUrl cover_url; + cover_url.setUrl(big_cover); + // SoundCloud covers URL are https, but our cover loader doesn't seem to // deal well with https URL. Anyway, we don't need a secure connection to // get a cover image. - QUrl cover_url = cover.toUrl(); cover_url.setScheme("http"); song.set_art_automatic(cover_url.toEncoded()); } From d61688e1c5169c91cf804f9bbe22c11b8fe397eb Mon Sep 17 00:00:00 2001 From: maximko Date: Thu, 4 Sep 2014 18:48:49 +0600 Subject: [PATCH 2/2] QUrl fix. --- src/internet/soundcloudservice.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/internet/soundcloudservice.cpp b/src/internet/soundcloudservice.cpp index 3d11a35f1..82cbfce3f 100644 --- a/src/internet/soundcloudservice.cpp +++ b/src/internet/soundcloudservice.cpp @@ -498,8 +498,7 @@ Song SoundCloudService::ExtractSong(const QVariantMap& result_song) { // Increase cover size. // See https://developers.soundcloud.com/docs/api/reference#artwork_url QString big_cover = cover.toString().replace("large", "t500x500"); - QUrl cover_url; - cover_url.setUrl(big_cover); + QUrl cover_url(big_cover, QUrl::StrictMode); // SoundCloud covers URL are https, but our cover loader doesn't seem to // deal well with https URL. Anyway, we don't need a secure connection to