From 5983ecfac0328025f62815d5b9199f304304b0a5 Mon Sep 17 00:00:00 2001 From: Jim Broadus Date: Sat, 15 Feb 2020 16:12:30 -0800 Subject: [PATCH] Scrub gstreamer error strings for url query strings. Media URLs may include tokens or other auth info. --- src/engines/gstenginepipeline.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/engines/gstenginepipeline.cpp b/src/engines/gstenginepipeline.cpp index d0b321aca..335bc06a4 100644 --- a/src/engines/gstenginepipeline.cpp +++ b/src/engines/gstenginepipeline.cpp @@ -685,7 +685,10 @@ void GstEnginePipeline::ErrorMessageReceived(GstMessage* msg) { return; } - qLog(Error) << id() << debugstr; + for (const QString& l : debugstr.split("\n")) { + // Messages may contain URLs with auth info in query strings. + qLog(Error) << id() << Utilities::ScrubUrlQueries(l); + } emit Error(id(), message, domain, code); }