From 4fe845c2c543948b2c1eca660ef2dcbc5af71fd7 Mon Sep 17 00:00:00 2001 From: Power Snail Date: Fri, 6 Mar 2020 21:43:20 +0000 Subject: [PATCH] Use reference on a const loop var to avoid copy Clang 10 warns that ``s`` might be copied. Use a reference to avoid copying --- src/playlist/playlistlistcontainer.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/playlist/playlistlistcontainer.cpp b/src/playlist/playlistlistcontainer.cpp index 4fd8ac9fb..a8da3da01 100644 --- a/src/playlist/playlistlistcontainer.cpp +++ b/src/playlist/playlistlistcontainer.cpp @@ -286,7 +286,7 @@ void PlaylistListContainer::AddPlaylist(int id, const QString& name, QStandardItem* playlist_item = model_->NewPlaylist(name, id); QStandardItem* parent_folder = model_->FolderByPath(*ui_path); parent_folder->appendRow(playlist_item); - for (const Song s : app_->playlist_backend()->GetPlaylistSongs(id)) { + for (const Song& s : app_->playlist_backend()->GetPlaylistSongs(id)) { QStandardItem* track_item = model_->NewTrack(s); track_item->setDragEnabled(false); playlist_item->appendRow(track_item);