From 4b1de1a055f656e7d0a714c27137a0564ff1189b Mon Sep 17 00:00:00 2001 From: Arnaud Bienner Date: Wed, 23 Nov 2011 23:42:46 +0100 Subject: [PATCH] Always use 'Open %1 in browser' string; so just one string to translate: less work, and avoid discrepancies across translations --- src/internet/icecastservice.cpp | 2 +- src/internet/jamendoservice.cpp | 2 +- src/internet/somafmservice.cpp | 2 +- src/translations/translations.pot | 14 ++------------ 4 files changed, 5 insertions(+), 15 deletions(-) diff --git a/src/internet/icecastservice.cpp b/src/internet/icecastservice.cpp index 92a079bf4..2cfec0e27 100644 --- a/src/internet/icecastservice.cpp +++ b/src/internet/icecastservice.cpp @@ -297,7 +297,7 @@ void IcecastService::EnsureMenuCreated() { context_menu_ = new QMenu; context_menu_->addActions(GetPlaylistActions()); - context_menu_->addAction(IconLoader::Load("download"), tr("Open dir.xiph.org in browser"), this, SLOT(Homepage())); + context_menu_->addAction(IconLoader::Load("download"), tr("Open %1 in browser").arg("dir.xiph.org"), this, SLOT(Homepage())); context_menu_->addAction(IconLoader::Load("view-refresh"), tr("Refresh station list"), this, SLOT(LoadDirectory())); context_menu_->addSeparator(); diff --git a/src/internet/jamendoservice.cpp b/src/internet/jamendoservice.cpp index 19fb90e3a..22ea0a5a5 100644 --- a/src/internet/jamendoservice.cpp +++ b/src/internet/jamendoservice.cpp @@ -411,7 +411,7 @@ void JamendoService::EnsureMenuCreated() { download_album_ = context_menu_->addAction(IconLoader::Load("download"), tr("Download this album..."), this, SLOT(DownloadAlbum())); context_menu_->addSeparator(); - context_menu_->addAction(IconLoader::Load("download"), tr("Open jamendo.com in browser"), this, SLOT(Homepage())); + context_menu_->addAction(IconLoader::Load("download"), tr("Open %1 in browser").arg("jamendo.com"), this, SLOT(Homepage())); context_menu_->addAction(IconLoader::Load("view-refresh"), tr("Refresh catalogue"), this, SLOT(DownloadDirectory())); if (accepted_download_) { diff --git a/src/internet/somafmservice.cpp b/src/internet/somafmservice.cpp index f161154d0..13d55a75c 100644 --- a/src/internet/somafmservice.cpp +++ b/src/internet/somafmservice.cpp @@ -81,7 +81,7 @@ void SomaFMService::ShowContextMenu(const QModelIndex& index, const QPoint& glob if (!context_menu_) { context_menu_ = new QMenu; context_menu_->addActions(GetPlaylistActions()); - context_menu_->addAction(IconLoader::Load("download"), tr("Open somafm.com in browser"), this, SLOT(Homepage())); + context_menu_->addAction(IconLoader::Load("download"), tr("Open %1 in browser").arg("somafm.com"), this, SLOT(Homepage())); context_menu_->addAction(IconLoader::Load("view-refresh"), tr("Refresh channels"), this, SLOT(RefreshStreams())); } diff --git a/src/translations/translations.pot b/src/translations/translations.pot index 611a80a95..ed60ed9ac 100644 --- a/src/translations/translations.pot +++ b/src/translations/translations.pot @@ -2733,6 +2733,8 @@ msgid "Only show the first" msgstr "" #: internet/digitallyimportedservicebase.cpp:178 +#: internet/icecastservice.cpp:300 internet/jamendoservice.cpp:414 +#: internet/somafmservice.cpp:84 #, qt-format msgid "Open %1 in browser" msgstr "" @@ -2745,10 +2747,6 @@ msgstr "" msgid "Open device" msgstr "" -#: internet/icecastservice.cpp:300 -msgid "Open dir.xiph.org in browser" -msgstr "" - #: ui_mainwindow.h:666 msgid "Open file..." msgstr "" @@ -2759,18 +2757,10 @@ msgstr "" msgid "Open in new playlist" msgstr "" -#: internet/jamendoservice.cpp:414 -msgid "Open jamendo.com in browser" -msgstr "" - #: internet/magnatuneservice.cpp:271 msgid "Open magnatune.com in browser" msgstr "" -#: internet/somafmservice.cpp:84 -msgid "Open somafm.com in browser" -msgstr "" - #: ui_globalshortcutssettingspage.h:169 ui_globalshortcutssettingspage.h:171 msgid "Open..." msgstr ""