From 3440f90a6b599450f79e92ae3b3ce0ac4bfe15ec Mon Sep 17 00:00:00 2001 From: Jim Broadus Date: Sun, 11 Apr 2021 22:08:53 -0700 Subject: [PATCH] playbacksettings: Don't try to load empty icons When populating output options, don't attempt to load an icon if that field is empty. This cuts some log noise. --- src/ui/playbacksettingspage.cpp | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/ui/playbacksettingspage.cpp b/src/ui/playbacksettingspage.cpp index b2fc1abb2..8807af257 100644 --- a/src/ui/playbacksettingspage.cpp +++ b/src/ui/playbacksettingspage.cpp @@ -63,12 +63,14 @@ void PlaybackSettingsPage::Load() { ui_->gst_output->clear(); for (const GstEngine::OutputDetails& output : engine->GetOutputsList()) { - // Strip components off the icon name until we find one. - QStringList components = output.icon_name.split("-"); QIcon icon; - while (icon.isNull() && !components.isEmpty()) { - icon = IconLoader::Load(components.join("-"), IconLoader::Base); - components.removeLast(); + if (!output.icon_name.isEmpty()) { + // Strip components off the icon name until we find one. + QStringList components = output.icon_name.split("-"); + while (icon.isNull() && !components.isEmpty()) { + icon = IconLoader::Load(components.join("-"), IconLoader::Base); + components.removeLast(); + } } ui_->gst_output->addItem(icon, output.description,