From ddc8a5f0109339c46e19546261c83b29dfa39afc Mon Sep 17 00:00:00 2001 From: Jonas Kvinge Date: Sat, 4 Jan 2020 23:18:59 +0100 Subject: [PATCH] Initialize QObject in constructor and add explicit --- src/internet/seafile/seafileservice.h | 2 +- src/internet/seafile/seafiletree.cpp | 5 +++-- src/internet/seafile/seafiletree.h | 4 ++-- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/internet/seafile/seafileservice.h b/src/internet/seafile/seafileservice.h index 814167adf..1fe893708 100644 --- a/src/internet/seafile/seafileservice.h +++ b/src/internet/seafile/seafileservice.h @@ -62,7 +62,7 @@ class SeafileService : public CloudFileService { public: enum ApiError { NO_ERROR = 200, NOT_FOUND = 404, TOO_MANY_REQUESTS = 429 }; - SeafileService(Application* app, InternetModel* parent); + explicit SeafileService(Application* app, InternetModel* parent); ~SeafileService(); static const char* kServiceName; diff --git a/src/internet/seafile/seafiletree.cpp b/src/internet/seafile/seafiletree.cpp index 1a10eac20..f611b011f 100644 --- a/src/internet/seafile/seafiletree.cpp +++ b/src/internet/seafile/seafiletree.cpp @@ -24,9 +24,10 @@ #include "core/logging.h" -SeafileTree::SeafileTree() {} +SeafileTree::SeafileTree(QObject* parent) : QObject(parent) {} -SeafileTree::SeafileTree(const SeafileTree& copy) { +SeafileTree::SeafileTree(const SeafileTree& copy, QObject* parent) + : QObject(parent) { libraries_ = copy.libraries(); } diff --git a/src/internet/seafile/seafiletree.h b/src/internet/seafile/seafiletree.h index 5635156dc..1c38e9249 100644 --- a/src/internet/seafile/seafiletree.h +++ b/src/internet/seafile/seafiletree.h @@ -36,8 +36,8 @@ class SeafileTree : public QObject { Q_OBJECT public: - SeafileTree(); - SeafileTree(const SeafileTree& copy); + explicit SeafileTree(QObject* parent = nullptr); + explicit SeafileTree(const SeafileTree& copy, QObject* parent = nullptr); ~SeafileTree(); class Entry {