From 0f2e8946d63e42a9716c18f97c8393f91fadd4ff Mon Sep 17 00:00:00 2001
From: dmdmdm <dmckellar@gmail.com>
Date: Sat, 23 May 2020 15:49:48 -0400
Subject: [PATCH] Made parameter const

---
 ext/libclementine-tagreader/tagreader.cpp | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/ext/libclementine-tagreader/tagreader.cpp b/ext/libclementine-tagreader/tagreader.cpp
index 437642c77..1ae23ac02 100644
--- a/ext/libclementine-tagreader/tagreader.cpp
+++ b/ext/libclementine-tagreader/tagreader.cpp
@@ -137,8 +137,10 @@ QString WithoutExtension(const QString& s) {
   return s.left(i);
 }
 
-void ReplaceUnderscoresWithSpaces(QString &s) {
-  s.replace('_', ' ');
+QString ReplaceUnderscoresWithSpaces(const QString &s) {
+  QString ret(s);
+  ret.replace('_', ' ');
+  return ret;
 }
 
 }  // namespace
@@ -159,8 +161,8 @@ void TagReader::GuessArtistAndTitle(pb::tagreader::SongMetadata *song) const {
     title = WithoutExtension(bn);
   }
 
-  ReplaceUnderscoresWithSpaces(artist);
-  ReplaceUnderscoresWithSpaces(title);
+  artist = ReplaceUnderscoresWithSpaces(artist);
+  title = ReplaceUnderscoresWithSpaces(title);
   artist = artist.trimmed();
   title = title.trimmed();
   if (!artist.isEmpty()) { song->set_artist(artist.toUtf8().data()); }