diff --git a/src/internet/podcasts/gpoddersync.cpp b/src/internet/podcasts/gpoddersync.cpp index 9ef715ddf..79730d7fe 100644 --- a/src/internet/podcasts/gpoddersync.cpp +++ b/src/internet/podcasts/gpoddersync.cpp @@ -19,7 +19,6 @@ #include "gpoddersync.h" -#include #include #include #include @@ -51,11 +50,6 @@ GPodderSync::GPodderSync(Application* app, QObject* parent) get_updates_timer_(new QTimer(this)), flush_queue_timer_(new QTimer(this)), flushing_queue_(false) { - // Store the base URL in case we need to reset it. The config instance is a - // singleton and this is assuming that the configuration hasn't been modified - // before now. - default_base_url_ = mygpo::Config::instance()->mygpoBaseUrl(); - ReloadSettings(); LoadQueue(); @@ -103,38 +97,26 @@ void GPodderSync::ReloadSettings() { username_ = s.value("gpodder_username").toString(); password_ = s.value("gpodder_password").toString(); last_successful_get_ = s.value("gpodder_last_get").toDateTime(); - UpdateBaseUrl(s.value("gpodder_base_url").toUrl()); if (!username_.isEmpty() && !password_.isEmpty()) { - qLog(Debug) << "Using gpodder base URL" - << mygpo::Config::instance()->mygpoBaseUrl(); api_.reset(new mygpo::ApiRequest(username_, password_, network_)); } } void GPodderSync::Login(const QString& username, const QString& password, const QString& device_name) { - Login(username, password, device_name, QUrl()); -} - -void GPodderSync::Login(const QString& username, const QString& password, - const QString& device_name, const QUrl& custom_url) { - UpdateBaseUrl(custom_url); - qLog(Debug) << "Using gpodder base URL" - << mygpo::Config::instance()->mygpoBaseUrl(); api_.reset(new mygpo::ApiRequest(username, password, network_)); QNetworkReply* reply = api_->renameDevice( username, DeviceId(), device_name, Utilities::IsLaptop() ? mygpo::Device::LAPTOP : mygpo::Device::DESKTOP); NewClosure(reply, SIGNAL(finished()), this, - SLOT(LoginFinished(QNetworkReply*, QString, QString, QUrl)), reply, - username, password, custom_url); + SLOT(LoginFinished(QNetworkReply*, QString, QString)), reply, + username, password); } void GPodderSync::LoginFinished(QNetworkReply* reply, const QString& username, - const QString& password, - const QUrl& custom_url) { + const QString& password) { reply->deleteLater(); if (reply->error() == QNetworkReply::NoError) { @@ -145,7 +127,6 @@ void GPodderSync::LoginFinished(QNetworkReply* reply, const QString& username, s.beginGroup(kSettingsGroup); s.setValue("gpodder_username", username); s.setValue("gpodder_password", password); - s.setValue("gpodder_base_url", custom_url); DoInitialSync(); emit LoginSuccess(); @@ -155,15 +136,6 @@ void GPodderSync::LoginFinished(QNetworkReply* reply, const QString& username, } } -void GPodderSync::UpdateBaseUrl(const QUrl& custom_base_url) { - // If the custom URL is empty, use the default. - if (!custom_base_url.isEmpty()) { - mygpo::Config::instance()->setMygpoBaseUrl(custom_base_url); - } else { - mygpo::Config::instance()->setMygpoBaseUrl(default_base_url_); - } -} - void GPodderSync::Logout() { QSettings s; s.beginGroup(kSettingsGroup); @@ -375,7 +347,7 @@ void GPodderSync::FlushUpdateQueue() { username_, DeviceId(), queued_add_subscriptions_.values(), queued_remove_subscriptions_.values())); - qLog(Info) << "Sending" << all_urls.count() << "changes to gpodder service"; + qLog(Info) << "Sending" << all_urls.count() << "changes to gpodder.net"; NewClosure(reply, SIGNAL(finished()), this, SLOT(AddRemoveFinished(mygpo::AddRemoveResultPtr, QList)), diff --git a/src/internet/podcasts/gpoddersync.h b/src/internet/podcasts/gpoddersync.h index 93908c722..b81595450 100644 --- a/src/internet/podcasts/gpoddersync.h +++ b/src/internet/podcasts/gpoddersync.h @@ -64,9 +64,6 @@ class GPodderSync : public QObject { void Login(const QString& username, const QString& password, const QString& device_name); - void Login(const QString& username, const QString& password, - const QString& device_name, const QUrl& custom_url); - // Clears any saved username and password from QSettings. void Logout(); @@ -80,7 +77,7 @@ class GPodderSync : public QObject { private slots: void ReloadSettings(); void LoginFinished(QNetworkReply* reply, const QString& username, - const QString& password, const QUrl& custom_url); + const QString& password); void DeviceUpdatesFinished(mygpo::DeviceUpdatesPtr reply); void DeviceUpdatesParseError(); @@ -107,8 +104,6 @@ class GPodderSync : public QObject { void DoInitialSync(); - void UpdateBaseUrl(const QUrl& custom_base_url); - private: Application* app_; QNetworkAccessManager* network_; @@ -121,7 +116,6 @@ class GPodderSync : public QObject { QString password_; QDateTime last_successful_get_; QTimer* get_updates_timer_; - QUrl default_base_url_; QTimer* flush_queue_timer_; QSet queued_add_subscriptions_; diff --git a/src/internet/podcasts/podcastsettingspage.cpp b/src/internet/podcasts/podcastsettingspage.cpp index c4bfad3d0..1bd41ac06 100644 --- a/src/internet/podcasts/podcastsettingspage.cpp +++ b/src/internet/podcasts/podcastsettingspage.cpp @@ -44,8 +44,6 @@ PodcastSettingsPage::PodcastSettingsPage(SettingsDialog* dialog) connect(ui_->login_state, SIGNAL(LogoutClicked()), SLOT(LogoutClicked())); connect(ui_->download_dir_browse, SIGNAL(clicked()), SLOT(DownloadDirBrowse())); - connect(ui_->gpodder_advanced, SIGNAL(stateChanged(int)), - SLOT(GpodderAdvancedChanged(int))); GPodderSync* gsync = dialog->app()->gpodder_sync(); connect(gsync, SIGNAL(LoginSuccess()), SLOT(GpodderLoginSuccess())); @@ -91,16 +89,6 @@ void PodcastSettingsPage::Load() { s.value("gpodder_device_name", GPodderSync::DefaultDeviceName()) .toString()); - QUrl base_url = s.value("gpodder_base_url").toUrl(); - if (base_url.isEmpty()) { - ui_->gpodder_advanced->setCheckState(Qt::Unchecked); - ui_->gpodder_advanced_group->setEnabled(false); - } else { - ui_->gpodder_advanced->setCheckState(Qt::Checked); - ui_->gpodder_advanced_group->setEnabled(true); - } - ui_->gpodder_base_url->setText(base_url.toString()); - if (dialog()->app()->gpodder_sync()->is_logged_in()) { ui_->login_state->SetLoggedIn(LoginStateWidget::LoggedIn, ui_->username->text()); @@ -127,19 +115,8 @@ void PodcastSettingsPage::Save() { void PodcastSettingsPage::LoginClicked() { ui_->login_state->SetLoggedIn(LoginStateWidget::LoginInProgress); - if (ui_->gpodder_advanced->checkState()) { - QUrl url(ui_->gpodder_base_url->text()); - if (url.isEmpty() || !url.isValid()) { - GpodderLoginFailure("Invalid URL"); - return; - } - dialog()->app()->gpodder_sync()->Login(ui_->username->text(), - ui_->password->text(), - ui_->device_name->text(), url); - } else { - dialog()->app()->gpodder_sync()->Login( - ui_->username->text(), ui_->password->text(), ui_->device_name->text()); - } + dialog()->app()->gpodder_sync()->Login( + ui_->username->text(), ui_->password->text(), ui_->device_name->text()); } void PodcastSettingsPage::GpodderLoginSuccess() { @@ -168,7 +145,3 @@ void PodcastSettingsPage::DownloadDirBrowse() { ui_->download_dir->setText(QDir::toNativeSeparators(directory)); } - -void PodcastSettingsPage::GpodderAdvancedChanged(int state) { - ui_->gpodder_advanced_group->setEnabled(state != Qt::Unchecked); -} diff --git a/src/internet/podcasts/podcastsettingspage.h b/src/internet/podcasts/podcastsettingspage.h index f66d77dd0..44e757f64 100644 --- a/src/internet/podcasts/podcastsettingspage.h +++ b/src/internet/podcasts/podcastsettingspage.h @@ -45,8 +45,6 @@ class PodcastSettingsPage : public SettingsPage { void DownloadDirBrowse(); - void GpodderAdvancedChanged(int state); - private: Ui_PodcastSettingsPage* ui_; }; diff --git a/src/internet/podcasts/podcastsettingspage.ui b/src/internet/podcasts/podcastsettingspage.ui index 9a262be40..bb42912ee 100644 --- a/src/internet/podcasts/podcastsettingspage.ui +++ b/src/internet/podcasts/podcastsettingspage.ui @@ -7,7 +7,7 @@ 0 0 616 - 672 + 656 @@ -174,7 +174,7 @@ - + gpodder.net @@ -198,16 +198,7 @@ - - 0 - - - 0 - - - 0 - - + 0 @@ -245,45 +236,16 @@ - + Device name - + - - - - - - - - - - - - - Base URL - - - - - - - - - - Advanced Settings - - - false - - - @@ -324,6 +286,5 @@ device_name login -