From 3243f320b191b2e0519eb2ddd935bde552914f4b Mon Sep 17 00:00:00 2001 From: Andrew Rabert Date: Sun, 25 Aug 2019 16:00:36 -0400 Subject: [PATCH] Stop logging exceptions to text files Log cat is sufficent --- .../audinaut/activity/SubsonicActivity.java | 47 ------------------- 1 file changed, 47 deletions(-) diff --git a/app/src/main/java/net/nullsum/audinaut/activity/SubsonicActivity.java b/app/src/main/java/net/nullsum/audinaut/activity/SubsonicActivity.java index 8682fa2..8ad40da 100644 --- a/app/src/main/java/net/nullsum/audinaut/activity/SubsonicActivity.java +++ b/app/src/main/java/net/nullsum/audinaut/activity/SubsonicActivity.java @@ -125,7 +125,6 @@ public class SubsonicActivity extends AppCompatActivity implements OnItemSelecte touchscreen = false; } - setUncaughtExceptionHandler(); applyTheme(); applyFullscreen(); super.onCreate(bundle); @@ -885,50 +884,4 @@ public class SubsonicActivity extends AppCompatActivity implements OnItemSelecte return R.id.drawer_library; } } - - private void setUncaughtExceptionHandler() { - Thread.UncaughtExceptionHandler handler = Thread.getDefaultUncaughtExceptionHandler(); - if (!(handler instanceof SubsonicActivity.SubsonicUncaughtExceptionHandler)) { - Thread.setDefaultUncaughtExceptionHandler(new SubsonicActivity.SubsonicUncaughtExceptionHandler(this)); - } - } - - /** - * Logs the stack trace of uncaught exceptions to a file on the SD card. - */ - private static class SubsonicUncaughtExceptionHandler implements Thread.UncaughtExceptionHandler { - - private final Thread.UncaughtExceptionHandler defaultHandler; - private final Context context; - - private SubsonicUncaughtExceptionHandler(Context context) { - this.context = context; - defaultHandler = Thread.getDefaultUncaughtExceptionHandler(); - } - - @Override - public void uncaughtException(Thread thread, Throwable throwable) { - File file = null; - PrintWriter printWriter = null; - try { - - PackageInfo packageInfo = context.getPackageManager().getPackageInfo("net.nullsum.audinaut", 0); - file = new File(Environment.getExternalStorageDirectory(), "audinaut-stacktrace.txt"); - printWriter = new PrintWriter(file); - printWriter.println("Subsonic version name: " + packageInfo.versionName); - printWriter.println("Subsonic version code: " + packageInfo.versionCode); - printWriter.println(); - throwable.printStackTrace(printWriter); - Log.i(TAG, "Stack trace written to " + file); - } catch (Throwable x) { - Log.e(TAG, "Failed to write stack trace to " + file, x); - } finally { - Util.close(printWriter); - if (defaultHandler != null) { - defaultHandler.uncaughtException(thread, throwable); - } - - } - } - } }