fix behavior of external tools to also work as a solution for #332

This commit is contained in:
Martin Rotter 2021-08-31 08:49:03 +02:00
parent 23d3517c08
commit d511ed21e5
2 changed files with 7 additions and 2 deletions

View File

@ -57,7 +57,7 @@ SettingsBrowserMail::SettingsBrowserMail(Settings* settings, QWidget* parent)
connect(m_ui->m_btnAddTool, &QPushButton::clicked, this, &SettingsBrowserMail::addExternalTool);
connect(m_ui->m_btnEditTool, &QPushButton::clicked, this, &SettingsBrowserMail::editSelectedExternalTool);
connect(m_ui->m_btnDeleteTool, &QPushButton::clicked, this, &SettingsBrowserMail::deleteSelectedExternalTool);
connect(m_ui->m_listTools, &QTreeWidget::itemDoubleClicked, this, &SettingsBrowserMail::editSelectedExternalTool);
connect(m_ui->m_listTools, &QTreeWidget::itemDoubleClicked, m_ui->m_btnEditTool, &QPushButton::click);
connect(m_ui->m_listTools, &QTreeWidget::currentItemChanged, this, [this](QTreeWidgetItem* current, QTreeWidgetItem* previous) {
Q_UNUSED(previous)

View File

@ -70,5 +70,10 @@ void ExternalTool::setToolsToSettings(QVector<ExternalTool>& tools) {
}
bool ExternalTool::run(const QString& target) {
return IOFactory::startProcessDetached(executable(), QStringList() << parameters() << target);
if (parameters().isEmpty()) {
return IOFactory::startProcessDetached(executable(), { target });
}
else {
return IOFactory::startProcessDetached(executable(), QStringList() << parameters() << target);
}
}