From 429b2bf16d5a85014306d1010a8d0e52c4fd5ba1 Mon Sep 17 00:00:00 2001
From: Martin Rotter <rotter.martinos@gmail.com>
Date: Tue, 3 Nov 2020 20:12:39 +0100
Subject: [PATCH 1/2] Fix SQL foreign-key error when removing accounts on
 MySQL.

---
 src/librssguard/miscellaneous/databasequeries.cpp | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/librssguard/miscellaneous/databasequeries.cpp b/src/librssguard/miscellaneous/databasequeries.cpp
index b00ca5ff7..3e8d23d0e 100755
--- a/src/librssguard/miscellaneous/databasequeries.cpp
+++ b/src/librssguard/miscellaneous/databasequeries.cpp
@@ -1130,13 +1130,13 @@ bool DatabaseQueries::deleteAccount(const QSqlDatabase& db, int account_id) {
   query.setForwardOnly(true);
   QStringList queries;
 
-  queries << QSL("DELETE FROM Messages WHERE account_id = :account_id;")
+  queries << QSL("DELETE FROM MessageFiltersInFeeds WHERE account_id = :account_id;")
+          << QSL("DELETE FROM LabelsInMessages WHERE account_id = :account_id;")
+          << QSL("DELETE FROM Messages WHERE account_id = :account_id;")
           << QSL("DELETE FROM Feeds WHERE account_id = :account_id;")
           << QSL("DELETE FROM Categories WHERE account_id = :account_id;")
-          << QSL("DELETE FROM MessageFiltersInFeeds WHERE account_id = :account_id;")
-          << QSL("DELETE FROM Accounts WHERE id = :account_id;")
-          << QSL("DELETE FROM LabelsInMessages WHERE account_id = :account_id;")
-          << QSL("DELETE FROM Labels WHERE account_id = :account_id;");
+          << QSL("DELETE FROM Labels WHERE account_id = :account_id;")
+          << QSL("DELETE FROM Accounts WHERE id = :account_id;");
 
   for (const QString& q : queries) {
     query.prepare(q);

From 582c5bc6759c1fc59aa2a83bc4e1d32b3cca5ff6 Mon Sep 17 00:00:00 2001
From: Martin Rotter <rotter.martinos@gmail.com>
Date: Tue, 3 Nov 2020 20:44:41 +0100
Subject: [PATCH 2/2] Make columns menu for msg view non closable.

---
 src/librssguard/gui/labelsmenu.cpp          | 11 ++++++-----
 src/librssguard/gui/labelsmenu.h            |  2 +-
 src/librssguard/gui/nonclosablemenu.cpp     |  9 ++++++++-
 src/librssguard/gui/treeviewcolumnsmenu.cpp |  3 ++-
 src/librssguard/gui/treeviewcolumnsmenu.h   |  4 ++--
 5 files changed, 19 insertions(+), 10 deletions(-)

diff --git a/src/librssguard/gui/labelsmenu.cpp b/src/librssguard/gui/labelsmenu.cpp
index df944bb9d..d5646c637 100644
--- a/src/librssguard/gui/labelsmenu.cpp
+++ b/src/librssguard/gui/labelsmenu.cpp
@@ -50,7 +50,7 @@ void LabelsMenu::keyPressEvent(QKeyEvent* event) {
   LabelAction* act = qobject_cast<LabelAction*>(activeAction());
 
   if (act != nullptr && event->key() == Qt::Key::Key_Space) {
-    act->toggle();
+    act->toggleCheckState();
   }
 
   NonClosableMenu::keyPressEvent(event);
@@ -60,10 +60,11 @@ void LabelsMenu::mousePressEvent(QMouseEvent* event) {
   LabelAction* act = qobject_cast<LabelAction*>(activeAction());
 
   if (act != nullptr) {
-    act->toggle();
+    act->toggleCheckState();
+  }
+  else {
+    NonClosableMenu::mousePressEvent(event);
   }
-
-  NonClosableMenu::mousePressEvent(event);
 }
 
 void LabelsMenu::changeLabelAssignment(Qt::CheckState state) {
@@ -121,7 +122,7 @@ Label* LabelAction::label() const {
   return m_label;
 }
 
-void LabelAction::toggle() {
+void LabelAction::toggleCheckState() {
   if (m_checkState == Qt::CheckState::Unchecked) {
     setCheckState(Qt::CheckState::Checked);
   }
diff --git a/src/librssguard/gui/labelsmenu.h b/src/librssguard/gui/labelsmenu.h
index 27d545a46..a563cd46d 100644
--- a/src/librssguard/gui/labelsmenu.h
+++ b/src/librssguard/gui/labelsmenu.h
@@ -42,7 +42,7 @@ class LabelAction : public QAction {
     Label* label() const;
 
   public slots:
-    void toggle();
+    void toggleCheckState();
 
   signals:
     void checkStateChanged(Qt::CheckState state);
diff --git a/src/librssguard/gui/nonclosablemenu.cpp b/src/librssguard/gui/nonclosablemenu.cpp
index c15b883ee..b51bb25a8 100644
--- a/src/librssguard/gui/nonclosablemenu.cpp
+++ b/src/librssguard/gui/nonclosablemenu.cpp
@@ -15,7 +15,14 @@ void NonClosableMenu::keyPressEvent(QKeyEvent* event) {
 }
 
 void NonClosableMenu::mousePressEvent(QMouseEvent* event) {
-  Q_UNUSED(event)
+  auto* act = dynamic_cast<QAction*>(activeAction());
+
+  if (act != nullptr) {
+    act->toggle();
+  }
+  else {
+    QMenu::mousePressEvent(event);
+  }
 }
 
 void NonClosableMenu::mouseReleaseEvent(QMouseEvent* event) {
diff --git a/src/librssguard/gui/treeviewcolumnsmenu.cpp b/src/librssguard/gui/treeviewcolumnsmenu.cpp
index ad2243b9f..a874ca36d 100644
--- a/src/librssguard/gui/treeviewcolumnsmenu.cpp
+++ b/src/librssguard/gui/treeviewcolumnsmenu.cpp
@@ -4,7 +4,7 @@
 
 #include <QHeaderView>
 
-TreeViewColumnsMenu::TreeViewColumnsMenu(QHeaderView* parent) : QMenu(parent) {
+TreeViewColumnsMenu::TreeViewColumnsMenu(QHeaderView* parent) : NonClosableMenu(parent) {
   connect(this, &TreeViewColumnsMenu::aboutToShow, this, &TreeViewColumnsMenu::prepareMenu);
 }
 
@@ -17,6 +17,7 @@ void TreeViewColumnsMenu::prepareMenu() {
     act->setData(i);
     act->setCheckable(true);
     act->setChecked(!header_view->isSectionHidden(i));
+
     connect(act, &QAction::toggled, this, &TreeViewColumnsMenu::actionTriggered);
   }
 }
diff --git a/src/librssguard/gui/treeviewcolumnsmenu.h b/src/librssguard/gui/treeviewcolumnsmenu.h
index 963b58621..2f74aa51c 100644
--- a/src/librssguard/gui/treeviewcolumnsmenu.h
+++ b/src/librssguard/gui/treeviewcolumnsmenu.h
@@ -3,11 +3,11 @@
 #ifndef TREEVIEWCOLUMNSMENU_H
 #define TREEVIEWCOLUMNSMENU_H
 
-#include <QMenu>
+#include "gui/nonclosablemenu.h"
 
 class QHeaderView;
 
-class TreeViewColumnsMenu : public QMenu {
+class TreeViewColumnsMenu : public NonClosableMenu {
   public:
     explicit TreeViewColumnsMenu(QHeaderView* parent);