diff --git a/src/gui/basetoolbar.cpp b/src/gui/basetoolbar.cpp index a4124a5d4..7b719edbb 100755 --- a/src/gui/basetoolbar.cpp +++ b/src/gui/basetoolbar.cpp @@ -35,6 +35,10 @@ BaseToolBar::~BaseToolBar() { qDebug("Destroying BaseToolBar instance."); } +void BaseBar::loadSavedActions() { + loadSpecificActions(getSpecificActions(savedActions())); +} + QAction *BaseBar::findMatchingAction(const QString &action, const QList &actions) const { foreach (QAction *act, actions) { if (act->objectName() == action) { diff --git a/src/gui/basetoolbar.h b/src/gui/basetoolbar.h index 4b5c91309..d092c217d 100755 --- a/src/gui/basetoolbar.h +++ b/src/gui/basetoolbar.h @@ -34,8 +34,15 @@ class BaseBar { // state into the settings. virtual void saveChangeableActions(const QStringList &actions) = 0; + // Returns list of default actions. + virtual QStringList defaultActions() const = 0; + virtual QStringList savedActions() const = 0; + // Loads the toolbar state from settings. - virtual void loadChangeableActions() = 0; + virtual void loadSavedActions(); + + virtual QList getSpecificActions(const QStringList &actions) = 0; + virtual void loadSpecificActions(const QList &actions) = 0; protected: QAction *findMatchingAction(const QString &action, const QList &actions) const; diff --git a/src/gui/dialogs/formmain.cpp b/src/gui/dialogs/formmain.cpp index 86577f244..f3ae6801b 100755 --- a/src/gui/dialogs/formmain.cpp +++ b/src/gui/dialogs/formmain.cpp @@ -74,8 +74,8 @@ FormMain::FormMain(QWidget *parent, Qt::WindowFlags f) // Prepare tabs. //m_ui->m_tabWidget->initializeTabs(); - tabWidget()->feedMessageViewer()->feedsToolBar()->loadChangeableActions(); - tabWidget()->feedMessageViewer()->messagesToolBar()->loadChangeableActions(); + tabWidget()->feedMessageViewer()->feedsToolBar()->loadSavedActions(); + tabWidget()->feedMessageViewer()->messagesToolBar()->loadSavedActions(); // Establish connections. createConnections(); @@ -87,7 +87,7 @@ FormMain::FormMain(QWidget *parent, Qt::WindowFlags f) setupIcons(); loadSize(); - m_statusBar->loadChangeableActions(); + m_statusBar->loadSavedActions(); } FormMain::~FormMain() { diff --git a/src/gui/feedmessageviewer.cpp b/src/gui/feedmessageviewer.cpp index f7d3ace8a..780bfa439 100755 --- a/src/gui/feedmessageviewer.cpp +++ b/src/gui/feedmessageviewer.cpp @@ -229,8 +229,8 @@ void FeedMessageViewer::initialize() { m_toolBarMessages->setMovable(false); m_toolBarMessages->setAllowedAreas(Qt::TopToolBarArea); - m_toolBarFeeds->loadChangeableActions(); - m_toolBarMessages->loadChangeableActions(); + m_toolBarFeeds->loadSavedActions(); + m_toolBarMessages->loadSavedActions(); m_messagesBrowser->clear(); diff --git a/src/gui/feedstoolbar.cpp b/src/gui/feedstoolbar.cpp index b0144f7bd..7444bfa8c 100755 --- a/src/gui/feedstoolbar.cpp +++ b/src/gui/feedstoolbar.cpp @@ -21,6 +21,8 @@ #include "miscellaneous/settings.h" #include "miscellaneous/iconfactory.h" +#include + FeedsToolBar::FeedsToolBar(const QString &title, QWidget *parent) : BaseToolBar(title, parent) { // Update right margin of filter textbox. @@ -42,20 +44,12 @@ QList FeedsToolBar::changeableActions() const { void FeedsToolBar::saveChangeableActions(const QStringList &actions) { qApp->settings()->setValue(GROUP(GUI), GUI::FeedsToolbarActions, actions.join(QSL(","))); - loadChangeableActions(actions); + loadSpecificActions(getSpecificActions(actions)); } -void FeedsToolBar::loadChangeableActions() { - QStringList action_names = qApp->settings()->value(GROUP(GUI), SETTING(GUI::FeedsToolbarActions)).toString().split(',', - QString::SkipEmptyParts); - - loadChangeableActions(action_names); -} - -void FeedsToolBar::loadChangeableActions(const QStringList &actions) { +QList FeedsToolBar::getSpecificActions(const QStringList &actions) { QList available_actions = availableActions(); - - clear(); + QList spec_actions; // Iterate action names and add respectable actions into the toolbar. foreach (const QString &action_name, actions) { @@ -63,21 +57,49 @@ void FeedsToolBar::loadChangeableActions(const QStringList &actions) { if (matching_action != nullptr) { // Add existing standard action. - addAction(matching_action); + spec_actions.append(matching_action); } else if (action_name == SEPARATOR_ACTION_NAME) { // Add new separator. - addSeparator(); + QAction *act = new QAction(this); + act->setSeparator(true); + + spec_actions.append(act); } else if (action_name == SPACER_ACTION_NAME) { // Add new spacer. QWidget *spacer = new QWidget(this); spacer->setSizePolicy(QSizePolicy::Expanding, QSizePolicy::Expanding); - QAction *action = addWidget(spacer); + QWidgetAction *action = new QWidgetAction(this); + + action->setDefaultWidget(spacer); action->setIcon(qApp->icons()->fromTheme(QSL("system-search"))); action->setProperty("type", SPACER_ACTION_NAME); action->setProperty("name", tr("Toolbar spacer")); + + spec_actions.append(action); } } + + return spec_actions; +} + +void FeedsToolBar::loadSpecificActions(const QList &actions) { + clear(); + + foreach (QAction *act, actions) { + addAction(act); + } +} + +QStringList FeedsToolBar::defaultActions() const { + return QString(GUI::FeedsToolbarActionsDef).split(',', + QString::SkipEmptyParts); +} + +QStringList FeedsToolBar::savedActions() const { + return qApp->settings()->value(GROUP(GUI), SETTING(GUI::FeedsToolbarActions)).toString().split(',', + QString::SkipEmptyParts); + } diff --git a/src/gui/feedstoolbar.h b/src/gui/feedstoolbar.h index 68735e142..f754799eb 100755 --- a/src/gui/feedstoolbar.h +++ b/src/gui/feedstoolbar.h @@ -32,12 +32,12 @@ class FeedsToolBar : public BaseToolBar { QList availableActions() const; QList changeableActions() const; void saveChangeableActions(const QStringList &actions); - void loadChangeableActions(); - // Loads actions as specified by external actions list. - // NOTE: This is used primarily for reloading actions - // when they are changed from settings. - void loadChangeableActions(const QStringList &actions); + QList getSpecificActions(const QStringList &actions); + void loadSpecificActions(const QList &actions); + + QStringList defaultActions() const; + QStringList savedActions() const; }; #endif // FEEDSTOOLBAR_H diff --git a/src/gui/messagestoolbar.cpp b/src/gui/messagestoolbar.cpp index 9f9910cf2..6d93d140c 100755 --- a/src/gui/messagestoolbar.cpp +++ b/src/gui/messagestoolbar.cpp @@ -52,7 +52,7 @@ QList MessagesToolBar::changeableActions() const { void MessagesToolBar::saveChangeableActions(const QStringList& actions) { qApp->settings()->setValue(GROUP(GUI), GUI::MessagesToolbarDefaultButtons, actions.join(QSL(","))); - loadChangeableActions(actions); + loadSpecificActions(getSpecificActions(actions)); // If user hidden search messages box, then remove the filter. if (!changeableActions().contains(m_actionSearchMessages)) { @@ -60,10 +60,9 @@ void MessagesToolBar::saveChangeableActions(const QStringList& actions) { } } -void MessagesToolBar::loadChangeableActions(const QStringList& actions) { +QList MessagesToolBar::getSpecificActions(const QStringList &actions) { QList available_actions = availableActions(); - - clear(); + QList spec_actions; // Iterate action names and add respectable actions into the toolbar. foreach (const QString &action_name, actions) { @@ -71,31 +70,48 @@ void MessagesToolBar::loadChangeableActions(const QStringList& actions) { if (matching_action != nullptr) { // Add existing standard action. - addAction(matching_action); + spec_actions.append(matching_action); } else if (action_name == SEPARATOR_ACTION_NAME) { // Add new separator. - addSeparator(); + QAction *act = new QAction(this); + act->setSeparator(true); + + spec_actions.append(act); } else if (action_name == SEACRH_MESSAGES_ACTION_NAME) { // Add search box. - addAction(m_actionSearchMessages); + spec_actions.append(m_actionSearchMessages); } else if (action_name == HIGHLIGHTER_ACTION_NAME) { // Add filter button. - addAction(m_actionMessageHighlighter); + spec_actions.append(m_actionMessageHighlighter); } else if (action_name == SPACER_ACTION_NAME) { // Add new spacer. QWidget *spacer = new QWidget(this); spacer->setSizePolicy(QSizePolicy::Expanding, QSizePolicy::Expanding); - QAction *action = addWidget(spacer); + QWidgetAction *action = new QWidgetAction(this); + + action->setDefaultWidget(spacer); action->setIcon(qApp->icons()->fromTheme(QSL("go-jump"))); action->setProperty("type", SPACER_ACTION_NAME); action->setProperty("name", tr("Toolbar spacer")); + + spec_actions.append(action); } } + + return spec_actions; +} + +void MessagesToolBar::loadSpecificActions(const QList &actions) { + clear(); + + foreach (QAction *act, actions) { + addAction(act); + } } void MessagesToolBar::handleMessageHighlighterChange(QAction *action) { @@ -145,10 +161,13 @@ void MessagesToolBar::initializeHighlighter() { this, SLOT(handleMessageHighlighterChange(QAction*))); } -void MessagesToolBar::loadChangeableActions() { - QStringList action_names = qApp->settings()->value(GROUP(GUI), - SETTING(GUI::MessagesToolbarDefaultButtons)).toString().split(',', - QString::SkipEmptyParts); - - loadChangeableActions(action_names); +QStringList MessagesToolBar::defaultActions() const { + return QString(GUI::MessagesToolbarDefaultButtonsDef).split(',', + QString::SkipEmptyParts); +} + +QStringList MessagesToolBar::savedActions() const { + return qApp->settings()->value(GROUP(GUI), + SETTING(GUI::MessagesToolbarDefaultButtons)).toString().split(',', + QString::SkipEmptyParts); } diff --git a/src/gui/messagestoolbar.h b/src/gui/messagestoolbar.h index 1f625819a..8ce717ccd 100755 --- a/src/gui/messagestoolbar.h +++ b/src/gui/messagestoolbar.h @@ -45,12 +45,16 @@ class MessagesToolBar : public BaseToolBar { QList availableActions() const; QList changeableActions() const; void saveChangeableActions(const QStringList &actions); - void loadChangeableActions(); // Loads actions as specified by external actions list. // NOTE: This is used primarily for reloading actions // when they are changed from settings. - void loadChangeableActions(const QStringList &actions); + void loadSpecificActions(const QList &actions); + + QList getSpecificActions(const QStringList &actions); + + QStringList defaultActions() const; + QStringList savedActions() const; signals: void messageSearchPatternChanged(const QString &pattern); diff --git a/src/gui/statusbar.cpp b/src/gui/statusbar.cpp index f3672bb5d..458500087 100755 --- a/src/gui/statusbar.cpp +++ b/src/gui/statusbar.cpp @@ -72,7 +72,7 @@ StatusBar::StatusBar(QWidget *parent) : QStatusBar(parent), m_mutex(new Mutex(QM } StatusBar::~StatusBar() { - clear(); + clear(); qDebug("Destroying StatusBar instance."); } @@ -94,28 +94,26 @@ void StatusBar::saveChangeableActions(const QStringList &actions) { QMutexLocker locker(*m_mutex); qApp->settings()->setValue(GROUP(GUI), GUI::StatusbarActions, actions.join(QSL(","))); - loadChangeableActions(actions); + loadSpecificActions(getSpecificActions(actions)); } -void StatusBar::loadChangeableActions() { - QMutexLocker locker(*m_mutex); - - QStringList action_names = qApp->settings()->value(GROUP(GUI), SETTING(GUI::StatusbarActions)).toString().split(',', - QString::SkipEmptyParts); - - loadChangeableActions(action_names); +QStringList StatusBar::defaultActions() const { + return QString(GUI::StatusbarActionsDef).split(',', QString::SkipEmptyParts); } -void StatusBar::loadChangeableActions(const QStringList &action_names) { - clear(); +QStringList StatusBar::savedActions() const { + return qApp->settings()->value(GROUP(GUI), SETTING(GUI::StatusbarActions)).toString().split(',', QString::SkipEmptyParts); +} - bool progress_visible = actions().contains(m_barProgressFeedsAction) && +QList StatusBar::getSpecificActions(const QStringList &actions) { + bool progress_visible = this->actions().contains(m_barProgressFeedsAction) && m_lblProgressFeeds->isVisible() && m_barProgressFeeds->isVisible(); QList available_actions = availableActions(); + QList spec_actions; // Iterate action names and add respectable actions into the toolbar. - foreach (const QString &action_name, action_names) { + foreach (const QString &action_name, actions) { QAction *matching_action = findMatchingAction(action_name, available_actions); QAction *action_to_add; QWidget *widget_to_add; @@ -186,8 +184,32 @@ void StatusBar::loadChangeableActions(const QStringList &action_names) { if (action_to_add != nullptr && widget_to_add != nullptr) { action_to_add->setProperty("widget", QVariant::fromValue((void*) widget_to_add)); - addPermanentWidget(widget_to_add); - addAction(action_to_add); + spec_actions.append(action_to_add); + } + } + + return spec_actions; +} + +void StatusBar::loadSpecificActions(const QList &actions) { + foreach (QAction *act, this->actions()) { + QWidget *widget = act->property("widget").isValid() ? static_cast(act->property("widget").value()) : nullptr; + + if (widget != nullptr) { + removeWidget(widget); + } + } + + clear(); + + foreach (QAction *act, actions) { + QWidget *widget = act->property("widget").isValid() ? static_cast(act->property("widget").value()) : nullptr; + + addAction(act); + + // And also add widget. + if (widget != nullptr) { + addPermanentWidget(widget); } } } diff --git a/src/gui/statusbar.h b/src/gui/statusbar.h index 746317b29..671480f20 100755 --- a/src/gui/statusbar.h +++ b/src/gui/statusbar.h @@ -39,7 +39,10 @@ class StatusBar : public QStatusBar, public BaseBar { QList availableActions() const; QList changeableActions() const; void saveChangeableActions(const QStringList &actions); - void loadChangeableActions(); + QStringList defaultActions() const; + QStringList savedActions() const; + QList getSpecificActions(const QStringList &actions); + void loadSpecificActions(const QList &actions); public slots: // Progress bar operations @@ -54,7 +57,6 @@ class StatusBar : public QStatusBar, public BaseBar { private: void clear(); - void loadChangeableActions(const QStringList &action_names); Mutex *m_mutex; diff --git a/src/gui/toolbareditor.cpp b/src/gui/toolbareditor.cpp index 683cc9dbc..998cb632f 100755 --- a/src/gui/toolbareditor.cpp +++ b/src/gui/toolbareditor.cpp @@ -120,6 +120,12 @@ void ToolBarEditor::saveToolBar() { m_toolBar->saveChangeableActions(action_names); } +void ToolBarEditor::resetToolBar() { + if (m_toolBar != nullptr) { + + } +} + bool ToolBarEditor::eventFilter(QObject *object, QEvent *event) { if (object == m_ui->m_listActivatedActions) { if (event->type() == QEvent::KeyPress) { diff --git a/src/gui/toolbareditor.h b/src/gui/toolbareditor.h index aa470e0a0..d512dc914 100755 --- a/src/gui/toolbareditor.h +++ b/src/gui/toolbareditor.h @@ -40,6 +40,7 @@ class ToolBarEditor : public QWidget { // Toolbar operations. void loadFromToolBar(BaseBar *tool_bar); void saveToolBar(); + void resetToolBar(); inline QListWidget *activeItemsWidget() const { return m_ui->m_listActivatedActions;