diff --git a/src/core/feedsmodel.cpp b/src/core/feedsmodel.cpp index f75ddf96a..c10aa9a77 100755 --- a/src/core/feedsmodel.cpp +++ b/src/core/feedsmodel.cpp @@ -570,40 +570,6 @@ bool FeedsModel::mergeRootItem(FeedsModelRootItem *root_item, QString &output_me return true; } -bool FeedsModel::doesItemContainSameItem(FeedsModelRootItem *parent, FeedsModelRootItem *item) { - if (parent == NULL || item == NULL) { - return false; - } - - switch (item->kind()) { - case FeedsModelRootItem::Category: { - foreach (FeedsModelRootItem *child, parent->childItems()) { - if (child->kind() == FeedsModelRootItem::Category && child->title() == item->title()) { - return true; - } - } - - return false; - } - - case FeedsModelRootItem::Feed: { - foreach (FeedsModelRootItem *child, parent->childItems()) { - if (child->kind() == FeedsModelRootItem::Feed && - static_cast(child)->url() == static_cast(item)->url()) { - return true; - } - } - - return false; - } - - default: - return false; - } -} - - - void FeedsModel::reloadChangedLayout(QModelIndexList list) { while (!list.isEmpty()) { QModelIndex indx = list.takeFirst(); diff --git a/src/core/feedsmodel.h b/src/core/feedsmodel.h index 3195eb46a..7e8049a77 100644 --- a/src/core/feedsmodel.h +++ b/src/core/feedsmodel.h @@ -139,7 +139,6 @@ class FeedsModel : public QAbstractItemModel { // Takes structure residing under given root item and adds feeds/categories from // it to active structure. bool mergeRootItem(FeedsModelRootItem *root_item, QString &output_message); - bool doesItemContainSameItem(FeedsModelRootItem *parent, FeedsModelRootItem *item); public slots: // Feeds operations. diff --git a/src/core/feedsmodelcategory.cpp b/src/core/feedsmodelcategory.cpp index e976f6145..80098bb51 100755 --- a/src/core/feedsmodelcategory.cpp +++ b/src/core/feedsmodelcategory.cpp @@ -27,21 +27,20 @@ #include -FeedsModelCategory::FeedsModelCategory(FeedsModelRootItem *parent_item) - : FeedsModelRootItem(parent_item) { +FeedsModelCategory::FeedsModelCategory(FeedsModelRootItem *parent_item) : FeedsModelRootItem(parent_item) { m_kind = FeedsModelRootItem::Category; } FeedsModelCategory::FeedsModelCategory(const FeedsModelCategory &other) : FeedsModelRootItem(NULL) { m_kind = other.kind(); - m_title = other.title(); m_id = other.id(); + m_title = other.title(); + m_description = other.description(); m_icon = other.icon(); + m_creationDate = other.creationDate(); m_childItems = other.childItems(); m_parentItem = other.parent(); - m_creationDate = other.creationDate(); - m_description = other.description(); } FeedsModelCategory::~FeedsModelCategory() { @@ -58,7 +57,7 @@ QVariant FeedsModelCategory::data(int column, int role) const { m_description, m_childItems.size() == 0 ? tr("\n\nThis category does not contain any nested items.") : - ""); + QString()); } else if (column == FDS_MODEL_COUNTS_INDEX) { //: Tooltip for "unread" column of feed list. @@ -132,7 +131,7 @@ bool FeedsModelCategory::removeItself() { // Children are removed, remove this standard category too. QSqlDatabase database = qApp->database()->connection("FeedsModelCategory", - DatabaseFactory::FromSettings); + DatabaseFactory::FromSettings); QSqlQuery query_remove(database); query_remove.setForwardOnly(true); diff --git a/src/core/feedsmodelfeed.cpp b/src/core/feedsmodelfeed.cpp index 629ecbb81..f379c6ff9 100755 --- a/src/core/feedsmodelfeed.cpp +++ b/src/core/feedsmodelfeed.cpp @@ -38,13 +38,19 @@ FeedsModelFeed::FeedsModelFeed(FeedsModelRootItem *parent_item) : FeedsModelRootItem(parent_item), + m_passwordProtected(false), + m_username(QString()), + m_password(QString()), m_status(Normal), m_networkError(QNetworkReply::NoError), m_type(Rss0X), m_totalCount(0), m_unreadCount(0), m_autoUpdateType(DontAutoUpdate), - m_autoUpdateInitialInterval(DEFAULT_AUTO_UPDATE_INTERVAL) { + m_autoUpdateRemainingInterval(DEFAULT_AUTO_UPDATE_INTERVAL), + m_autoUpdateInitialInterval(DEFAULT_AUTO_UPDATE_INTERVAL), + m_encoding(QString()), + m_url(QString()) { m_kind = FeedsModelRootItem::Feed; } diff --git a/src/core/feedsmodelrootitem.cpp b/src/core/feedsmodelrootitem.cpp index f503b54f0..3ab022520 100755 --- a/src/core/feedsmodelrootitem.cpp +++ b/src/core/feedsmodelrootitem.cpp @@ -24,6 +24,12 @@ FeedsModelRootItem::FeedsModelRootItem(FeedsModelRootItem *parent_item) : m_kind(FeedsModelRootItem::RootItem), + m_id(NO_PARENT_CATEGORY), + m_title(QString()), + m_description(QString()), + m_icon(QIcon()), + m_creationDate(QDateTime()), + m_childItems(QList()), m_parentItem(parent_item) { setupFonts(); } diff --git a/src/gui/feedsview.cpp b/src/gui/feedsview.cpp index 3004e50de..a0e7c34b0 100755 --- a/src/gui/feedsview.cpp +++ b/src/gui/feedsview.cpp @@ -185,8 +185,7 @@ void FeedsView::executeNextAutoUpdate() { m_globalAutoUpdateRemainingInterval = m_globalAutoUpdateInitialInterval; } - qDebug("Starting auto-update event, pass %d/%d.", - m_globalAutoUpdateRemainingInterval, m_globalAutoUpdateInitialInterval); + qDebug("Starting auto-update event, pass %d/%d.", m_globalAutoUpdateRemainingInterval, m_globalAutoUpdateInitialInterval); // Pass needed interval data and lets the model decide which feeds // should be updated in this pass. diff --git a/src/gui/formimportexport.ui b/src/gui/formimportexport.ui index cc5267abf..d1b292c7a 100644 --- a/src/gui/formimportexport.ui +++ b/src/gui/formimportexport.ui @@ -96,7 +96,7 @@ Qt::Horizontal - QDialogButtonBox::Cancel|QDialogButtonBox::Ok + QDialogButtonBox::Close|QDialogButtonBox::Ok