fix unreachable code

This commit is contained in:
Martin Rotter 2021-08-05 08:57:29 +02:00
parent 53f78fb3c9
commit 5971287174
2 changed files with 7 additions and 3 deletions

View File

@ -30,7 +30,7 @@
<url type="donation">https://martinrotter.github.io/donate/</url> <url type="donation">https://martinrotter.github.io/donate/</url>
<content_rating type="oars-1.1" /> <content_rating type="oars-1.1" />
<releases> <releases>
<release version="3.9.2" date="2021-08-04"/> <release version="3.9.2" date="2021-08-05"/>
</releases> </releases>
<content_rating type="oars-1.0"> <content_rating type="oars-1.0">
<content_attribute id="violence-cartoon">none</content_attribute> <content_attribute id="violence-cartoon">none</content_attribute>

View File

@ -74,9 +74,10 @@ QList<Message> GreaderServiceRoot::obtainNewMessages(Feed* feed,
const QHash<ServiceRoot::BagOfMessages, QStringList>& stated_messages, const QHash<ServiceRoot::BagOfMessages, QStringList>& stated_messages,
const QHash<QString, QStringList>& tagged_messages) { const QHash<QString, QStringList>& tagged_messages) {
Feed::Status error = Feed::Status::Normal; Feed::Status error = Feed::Status::Normal;
QList<Message> msgs;
if (m_network->intelligentSynchronization()) { if (m_network->intelligentSynchronization()) {
return m_network->getMessagesIntelligently(this, msgs = m_network->getMessagesIntelligently(this,
feed->customId(), feed->customId(),
stated_messages, stated_messages,
tagged_messages, tagged_messages,
@ -84,12 +85,15 @@ QList<Message> GreaderServiceRoot::obtainNewMessages(Feed* feed,
networkProxy()); networkProxy());
} }
else { else {
return m_network->streamContents(this, feed->customId(), error, networkProxy()); msgs = m_network->streamContents(this, feed->customId(), error, networkProxy());
} }
if (error != Feed::Status::NewMessages && error != Feed::Status::Normal) { if (error != Feed::Status::NewMessages && error != Feed::Status::Normal) {
throw FeedFetchException(error); throw FeedFetchException(error);
} }
else {
return msgs;
}
} }
bool GreaderServiceRoot::wantsBaggedIdsOfExistingMessages() const { bool GreaderServiceRoot::wantsBaggedIdsOfExistingMessages() const {