determine root global node.js package location in runtime instead of hardcoding it

resources/desktop/com.github.rssguard.appdata.xml

@@ -26,7 +26,7 @@
   <url type="donation">https://github.com/sponsors/martinrotter</url>
   <content_rating type="oars-1.1" />
   <releases>
-    <release version="4.0.4" date="2021-12-16"/>
+    <release version="4.0.4" date="2021-12-20"/>
   </releases>
   <content_rating type="oars-1.0">
     <content_attribute id="violence-cartoon">none</content_attribute>

src/librssguard/core/filterutils.cpp

@@ -3,6 +3,7 @@
 #include "core/filterutils.h"
 
 #include "definitions/definitions.h"
+#include "miscellaneous/iofactory.h"
 #include "miscellaneous/textfactory.h"
 
 #include <QDomDocument>
@@ -87,19 +88,5 @@ QDateTime FilterUtils::parseDateTime(const QString& dat) const {
 }
 
 QString FilterUtils::runExecutableGetOutput(const QString& executable, const QStringList& arguments) const {
-  QProcess proc;
+  return IOFactory::startProcessGetOutput(executable, arguments);
-
-  proc.setProgram(executable);
-  proc.setArguments(arguments);
-
-  proc.start();
-
-  if (proc.waitForFinished() &&
-      proc.exitStatus() == QProcess::ExitStatus::NormalExit &&
-      proc.exitCode() == EXIT_SUCCESS) {
-    return proc.readAllStandardOutput();
-  }
-  else {
-    return proc.readAllStandardError().simplified();
-  }
 }

src/librssguard/miscellaneous/iofactory.cpp

@@ -93,6 +93,27 @@ bool IOFactory::startProcessDetached(const QString& program, const QStringList&
   return process.startDetached(nullptr);
 }
 
+QString IOFactory::startProcessGetOutput(const QString& executable, const QStringList& arguments) {
+  QProcess proc;
+
+  proc.setProgram(executable);
+  proc.setArguments(arguments);
+  proc.setProcessEnvironment(QProcessEnvironment::systemEnvironment());
+
+  proc.start();
+
+  if (proc.waitForFinished() &&
+      proc.exitStatus() == QProcess::ExitStatus::NormalExit &&
+      proc.exitCode() == EXIT_SUCCESS) {
+    return proc.readAllStandardOutput();
+  }
+  else {
+    QString err = proc.readAllStandardError().simplified();
+
+    return err;
+  }
+}
+
 QByteArray IOFactory::readFile(const QString& file_path) {
   QFile input_file(file_path);
   QByteArray input_data;

src/librssguard/miscellaneous/iofactory.h

@@ -31,6 +31,7 @@ class IOFactory {
                                      const QStringList& arguments,
                                      const QString& native_arguments = {},
                                      const QString& working_directory = {});
+    static QString startProcessGetOutput(const QString& executable, const QStringList& arguments = {});
 
     // Returns contents of a file.
     // Throws exception when no such file exists.

src/librssguard/network-web/adblock/adblockmanager.cpp

@@ -296,19 +296,20 @@ QProcess* AdBlockManager::startServer(int port) {
   proc->setProcessEnvironment(QProcessEnvironment::systemEnvironment());
 
   auto pe = proc->processEnvironment();
-  QString default_node_path =
-#if defined(Q_OS_WIN)
-    pe.value(QSL("APPDATA")) + QDir::separator() + QSL("npm") + QDir::separator() + QSL("node_modules");
-#elif defined(Q_OS_LINUX)
-    QSL("/usr/lib/node_modules");
-#elif defined(Q_OS_MACOS)
-    QSL("/usr/local/lib/node_modules");
-#else
-    QSL("");
-#endif
 
-  if (!pe.contains(QSL("NODE_PATH")) && !default_node_path.isEmpty()) {
+  if (!pe.contains(QSL("NODE_PATH"))) {
-    pe.insert(QSL("NODE_PATH"), default_node_path);
+    const QString system_node_prefix = IOFactory::startProcessGetOutput(
+#if defined(Q_OS_WIN)
+      QSL("npm.cmd")
+#else
+      QSL("npm")
+#endif
+      , { QSL("root"), QSL("--quiet"), QSL("-g") }
+      );
+
+    if (!system_node_prefix.isEmpty()) {
+      pe.insert(QSL("NODE_PATH"), system_node_prefix.simplified());
+    }
   }
 
   proc->setProcessEnvironment(pe);