From 2190b5ef0745ab0ec8389334ae6e30b10c1ef4c7 Mon Sep 17 00:00:00 2001
From: Martin Rotter <rotter@praktik.cz>
Date: Tue, 8 Feb 2022 07:59:46 +0100
Subject: [PATCH] nodejs download btn

---
 .../desktop/com.github.rssguard.appdata.xml   |  2 +-
 .../gui/settings/settingsnodejs.cpp           |  9 +++++++-
 .../gui/settings/settingsnodejs.ui            | 21 ++++++++++++-------
 3 files changed, 23 insertions(+), 9 deletions(-)

diff --git a/resources/desktop/com.github.rssguard.appdata.xml b/resources/desktop/com.github.rssguard.appdata.xml
index 7a9daa84f..b6ced2a1d 100644
--- a/resources/desktop/com.github.rssguard.appdata.xml
+++ b/resources/desktop/com.github.rssguard.appdata.xml
@@ -26,7 +26,7 @@
   <url type="donation">https://github.com/sponsors/martinrotter</url>
   <content_rating type="oars-1.1" />
   <releases>
-    <release version="4.1.2" date="2022-02-07"/>
+    <release version="4.1.2" date="2022-02-08"/>
   </releases>
   <content_rating type="oars-1.0">
     <content_attribute id="violence-cartoon">none</content_attribute>
diff --git a/src/librssguard/gui/settings/settingsnodejs.cpp b/src/librssguard/gui/settings/settingsnodejs.cpp
index 8bc50954c..484653e9f 100644
--- a/src/librssguard/gui/settings/settingsnodejs.cpp
+++ b/src/librssguard/gui/settings/settingsnodejs.cpp
@@ -6,6 +6,7 @@
 #include "exceptions/applicationexception.h"
 #include "miscellaneous/application.h"
 #include "miscellaneous/nodejs.h"
+#include "network-web/webfactory.h"
 
 #include <QDir>
 #include <QFileDialog>
@@ -18,7 +19,8 @@ SettingsNodejs::SettingsNodejs(Settings* settings, QWidget* parent) : SettingsPa
                                   "scalable network applications.\n\n"
                                   "%1 integrates Node.js to bring some modern features like Adblock.\n\n"
                                   "Note that usually all required Node.js tools should be available via your \"PATH\" "
-                                  "environment variable, so you do not have to specify full paths.").arg(APP_NAME),
+                                  "environment variable, so you do not have to specify full paths.\n\n"
+                                  "Also, relaunch \"Settings\" dialog after you install Node.js.").arg(APP_NAME),
                                false);
 
   m_ui.m_helpPackages->setHelpText(tr("%1 automatically installs some Node.js packages so that you do not have to. %1 does not "
@@ -26,6 +28,11 @@ SettingsNodejs::SettingsNodejs(Settings* settings, QWidget* parent) : SettingsPa
                                       "it uses subfolder placed in your \"user data\" folder.").arg(APP_NAME),
                                    false);
 
+  connect(m_ui.m_btnDownloadNodejs, &QPushButton::clicked,
+          this, [this]() {
+    qApp->web()->openUrlInExternalBrowser(QSL("https://nodejs.org/en/download/"));
+  });
+
   connect(m_ui.m_tbNodeExecutable->lineEdit(), &BaseLineEdit::textChanged,
           this, &SettingsNodejs::testNodejs);
   connect(m_ui.m_tbNpmExecutable->lineEdit(), &BaseLineEdit::textChanged,
diff --git a/src/librssguard/gui/settings/settingsnodejs.ui b/src/librssguard/gui/settings/settingsnodejs.ui
index 3522b627c..d2f8e25e8 100644
--- a/src/librssguard/gui/settings/settingsnodejs.ui
+++ b/src/librssguard/gui/settings/settingsnodejs.ui
@@ -17,7 +17,7 @@
    <item row="0" column="0" colspan="2">
     <widget class="HelpSpoiler" name="m_helpInfo" native="true"/>
    </item>
-   <item row="1" column="0">
+   <item row="2" column="0">
     <widget class="QLabel" name="label">
      <property name="text">
       <string>Node.js executable</string>
@@ -27,7 +27,7 @@
      </property>
     </widget>
    </item>
-   <item row="1" column="1">
+   <item row="2" column="1">
     <layout class="QHBoxLayout" name="horizontalLayout">
      <item>
       <widget class="LineEditWithStatus" name="m_tbNodeExecutable" native="true"/>
@@ -47,7 +47,7 @@
      </item>
     </layout>
    </item>
-   <item row="2" column="0">
+   <item row="3" column="0">
     <widget class="QLabel" name="label_2">
      <property name="text">
       <string>NPM executable</string>
@@ -57,7 +57,7 @@
      </property>
     </widget>
    </item>
-   <item row="2" column="1">
+   <item row="3" column="1">
     <layout class="QHBoxLayout" name="horizontalLayout_2">
      <item>
       <widget class="LineEditWithStatus" name="m_tbNpmExecutable" native="true"/>
@@ -77,7 +77,7 @@
      </item>
     </layout>
    </item>
-   <item row="3" column="0">
+   <item row="4" column="0">
     <widget class="QLabel" name="label_3">
      <property name="text">
       <string>Package folder </string>
@@ -87,7 +87,7 @@
      </property>
     </widget>
    </item>
-   <item row="3" column="1">
+   <item row="4" column="1">
     <layout class="QHBoxLayout" name="horizontalLayout_4">
      <item>
       <widget class="LineEditWithStatus" name="m_tbPackageFolder" native="true"/>
@@ -107,9 +107,16 @@
      </item>
     </layout>
    </item>
-   <item row="4" column="0" colspan="2">
+   <item row="5" column="0" colspan="2">
     <widget class="HelpSpoiler" name="m_helpPackages" native="true"/>
    </item>
+   <item row="1" column="0">
+    <widget class="QPushButton" name="m_btnDownloadNodejs">
+     <property name="text">
+      <string>&amp;Download Node.js</string>
+     </property>
+    </widget>
+   </item>
   </layout>
  </widget>
  <customwidgets>