From 7db8c6d6628dff0ea5bd2f3c053c2c26255904aa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jos=C3=A9=20Padarian?= Date: Sun, 12 Apr 2020 22:42:40 +1000 Subject: [PATCH 1/2] Added password helper (closes #58) --- .../java/com/readrops/app/activities/AddAccountActivity.java | 3 +++ app/src/main/res/values/strings.xml | 1 + 2 files changed, 4 insertions(+) diff --git a/app/src/main/java/com/readrops/app/activities/AddAccountActivity.java b/app/src/main/java/com/readrops/app/activities/AddAccountActivity.java index d503933d..f2d06574 100644 --- a/app/src/main/java/com/readrops/app/activities/AddAccountActivity.java +++ b/app/src/main/java/com/readrops/app/activities/AddAccountActivity.java @@ -68,6 +68,9 @@ public class AddAccountActivity extends AppCompatActivity { binding.providerImage.setImageResource(accountType.getIconRes()); binding.providerName.setText(accountType.getName()); binding.addAccountName.setText(accountType.getName()); + if (accountType.getName() == R.string.freshrss) { + binding.addAccountPasswordLayout.setHelperText(getString(R.string.password_helper)); + } } } catch (Exception e) { // TODO : see how to handle this exception diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 070b60a2..b14e4543 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -51,6 +51,7 @@ Account name Login Password + This is your FreshRSS API password (Configuration > Profile) Account settings Add account No feed From 65f89f6d2fee485a3b2caa0798f0c4003fe7e9f4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jos=C3=A9=20Padarian?= Date: Tue, 14 Apr 2020 09:07:33 +1000 Subject: [PATCH 2/2] Better accountType comparison --- .../java/com/readrops/app/activities/AddAccountActivity.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/src/main/java/com/readrops/app/activities/AddAccountActivity.java b/app/src/main/java/com/readrops/app/activities/AddAccountActivity.java index f2d06574..07e769ec 100644 --- a/app/src/main/java/com/readrops/app/activities/AddAccountActivity.java +++ b/app/src/main/java/com/readrops/app/activities/AddAccountActivity.java @@ -68,7 +68,7 @@ public class AddAccountActivity extends AppCompatActivity { binding.providerImage.setImageResource(accountType.getIconRes()); binding.providerName.setText(accountType.getName()); binding.addAccountName.setText(accountType.getName()); - if (accountType.getName() == R.string.freshrss) { + if (accountType == AccountType.FRESHRSS) { binding.addAccountPasswordLayout.setHelperText(getString(R.string.password_helper)); } }