From 83ca13249a09cfee22a03cffdc2ea0da46f3c499 Mon Sep 17 00:00:00 2001 From: Shinokuni Date: Sat, 23 Feb 2019 21:46:21 +0000 Subject: [PATCH] Not to hold a database instance in a viewmodel class --- .../java/com/readrops/app/viewmodels/ItemViewModel.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/app/src/main/java/com/readrops/app/viewmodels/ItemViewModel.java b/app/src/main/java/com/readrops/app/viewmodels/ItemViewModel.java index 3d5a1666..b89b4c44 100644 --- a/app/src/main/java/com/readrops/app/viewmodels/ItemViewModel.java +++ b/app/src/main/java/com/readrops/app/viewmodels/ItemViewModel.java @@ -6,19 +6,20 @@ import android.arch.lifecycle.LiveData; import android.support.annotation.NonNull; import com.readrops.app.database.Database; +import com.readrops.app.database.dao.ItemDao; import com.readrops.app.database.pojo.ItemWithFeed; public class ItemViewModel extends AndroidViewModel { - private Database db; + private ItemDao itemDao; public ItemViewModel(@NonNull Application application) { super(application); - db = Database.getInstance(application); + itemDao = Database.getInstance(application).itemDao(); } public LiveData getItemById(int id) { - return db.itemDao().getItemById(id); + return itemDao.getItemById(id); }