Flowinho
2ade0140bc
Set proper cell height for empty article array
...
Contains work related to #1800
This one took me a while to figure out since they amount of articles is tied to the coordinator.
- Fixed violation of single responsibility principle inside “resetEstimatedRowHeight()” by removing the applicance of tableViewRowHeight and instead return the correctly calculated rowHeight.
- Removed prototype strings from inside the function to a static struct to be able to switch parameters for this function more easy (might be useful later / in testing). Function looks cleaner.
Greetings from southern germany!
2020-03-15 22:31:54 +01:00
Maurice Parker
833c336f2f
Only show the timeline next read button when the root split view controller is collapsed. Issue #1822
2020-03-13 16:03:42 -05:00
Flowinho
0a3713e078
Align feedname and date correctly if there is no title or summary
2020-03-12 22:57:30 +01:00
Maurice Parker
9007ed4b06
Changed so that Feeds and Timeline clear read items if necessary on manual refresh commands. Issues #1834 , #1856 , and #1845
2020-03-11 14:47:00 -06:00
Maurice Parker
0e72811429
Implement mark as unread window for accounts that need it. Issue #1407
2020-02-18 13:49:29 -08:00
Maurice Parker
03c1ed2625
Make handling of programmatic feed selection when filtered or collapsed more consistent. Issues #1788 and #1792
2020-02-17 17:40:40 -08:00
Martin Hartl
83241cc329
Don’t show “Go to feed” action if already inside feed
2020-02-02 21:44:54 +01:00
Maurice Parker
ef79005d67
Change it so that we have the unread indicator and star hidden by default. Issue #1724
2020-01-27 22:26:49 -07:00
Maurice Parker
6ac6136612
Make animations individually selectable and no longer animate navigation selections. Issue #1439
2020-01-27 21:57:52 -07:00
Maurice Parker
050434023e
Fade out unread and star indicators when possible. Issue #1683
2020-01-21 11:41:03 -07:00
Maurice Parker
deab8f8c6c
Change to stop recycling the article view controller when switching panel modes on the iPad. Issue #1570
2020-01-21 11:05:47 -07:00
Maurice Parker
d68eccc55e
Exit search if Go To Feed is selected. Issue #1557
2020-01-15 17:53:12 -07:00
Brent Simmons
2df78f3cf1
Merge pull request #1605 from hartlco/1590-sharing-item-to-omnifocus-adds-extra-newline
...
Provide dedicated TitleActivityItemSource when sharing to Omnifocus and Things
2020-01-11 11:17:30 -08:00
Maurice Parker
21cf8415d2
Add confirmation for Mark As Read actions. Issue #1603
2020-01-11 11:30:16 -07:00
Martin Hartl
c739d77817
Provide dedicated TitleActivityItemSource when sharing to Omnifocus and Things
2020-01-11 09:12:41 +01:00
Maurice Parker
e93b916c50
Implement Refresh to Clear Articles option. Issue #1601
2020-01-10 18:14:21 -07:00
Maurice Parker
0e3c837b66
Change accessibility ordering of labels to make it more hierarchical when spoken in VoiceOver. Issue #1584
2020-01-09 17:54:13 -07:00
Maurice Parker
edd299a36d
Indicate that the header is a button when it is tappable. Issue #1583
2020-01-09 17:22:37 -07:00
Maurice Parker
3115abc72e
Enhance accessibility for toggle toolbar buttons. Issue #1581
2020-01-09 14:38:25 -07:00
Maurice Parker
b468bcfe58
Revert "Previewing articles"
2020-01-07 16:36:32 -07:00
Mihael Cholakov
593a802d79
Merge branch 'upstream-ios-candidate' into previewing-articles
2020-01-07 09:47:00 +02:00
Maurice Parker
746d061dcf
Refresh UI (including progress indicator) on Timeline when coming out of suspend.
2020-01-06 21:23:39 -07:00
Maurice Parker
c0f76d0dbb
Change Mark All as Read icon. Issue #1526
2020-01-06 18:07:04 -07:00
Mihael Cholakov
36230d930e
Context menu now previews selected article
2020-01-06 14:52:18 +02:00
Maurice Parker
5cd163e1e4
Add refresh indicator to the Timeline. Issue #15
2020-01-03 14:23:37 -07:00
Maurice Parker
5a7863d447
Rollback pull to refresh on the timeline and modified pull to refresh control. Issue #1520
2020-01-03 08:42:43 -07:00
Martin Hartl
5ee491ebee
Replace “Mark Older as Read” actions with “Mark Above/Below as Read” actions
2020-01-03 09:00:25 +01:00
Maurice Parker
e26a00ddfe
Enable pull to refresh on timeline and change refresh indicator to better show when it is successfully pulled. Issue #1520
2020-01-02 21:08:21 -07:00
Brent Simmons
26bb2b8eaf
Remove references to Article.bannerImageURL. We can bring it back if/when we start using it.
2019-12-28 20:53:36 -08:00
Maurice Parker
61370dd04d
Fix so that we don't try to scroll before the datasource has been fully applied to the table. Issue #1463
2019-12-24 17:34:47 -07:00
Brent Simmons
15184aa3f1
Finish changes mandated by DatabaseQueue changes.
2019-12-16 22:45:59 -08:00
Maurice Parker
43bf65b7a6
Rename occurrences of completionHandler to completion.
2019-12-14 17:14:55 -07:00
Maurice Parker
7a6b818f57
Only reset the timeline under certain conditions. Issue #1422
2019-12-08 18:14:33 -07:00
Brent Simmons
ebd7c68396
Merge mac-release — remove attachments.
2019-12-04 22:36:08 -08:00
Brent Simmons
3ead2c63bc
Remove attachments from the app, since we’re not using attachments in any way. We could always add it back later.
2019-12-03 23:03:15 -08:00
Maurice Parker
81c4756f97
Persist article read filters across application launches. Issue #1349
2019-11-27 11:43:36 -06:00
Maurice Parker
5c4cd072ce
Make next unread button work with new async feed functionality.
2019-11-24 13:37:56 -06:00
Maurice Parker
a052bbe74e
Fix title flashing in after navigation bar is shown. Issue #1336
2019-11-24 10:47:09 -06:00
Maurice Parker
b5525e1a9e
Restore back button items. Issue #1337
2019-11-24 10:33:13 -06:00
Maurice Parker
00094858fa
Remove filter button from All Unread timeline.
2019-11-24 03:47:29 -06:00
Maurice Parker
4296c243ff
Implement custom previews for context menus to crop cell separators. Issue #1221
2019-11-23 22:15:29 -06:00
Maurice Parker
d8b324e3da
Change nav bar so that if it is hidden and animating itself showing, you don't see the navbar items moving into place.
2019-11-23 18:00:51 -06:00
Maurice Parker
dd7431d5cb
Remove obsolete code.
2019-11-22 15:23:21 -06:00
Maurice Parker
eea5d6f327
Change ReadFilter to ReadFilterType and differentiate the ReadFilter from the query filter.
2019-11-22 09:40:39 -06:00
Maurice Parker
a5b4d570af
Change ReadFilter case unavailable to alwaysRead
2019-11-22 09:32:27 -06:00
Maurice Parker
654f40a98e
Add always on unread "filter" to Unread.
2019-11-21 20:31:58 -06:00
Maurice Parker
2d210a3f17
Delete dead code
2019-11-21 20:12:31 -06:00
Maurice Parker
6d8fca01ea
Filter async requests based on ReadFilter.
2019-11-21 19:54:35 -06:00
Maurice Parker
e8826130a4
Add timeline filter button
2019-11-21 18:22:43 -06:00
Maurice Parker
d1af8a9f0a
Increase height of timeline unread indicator. Issue #1320
2019-11-19 18:58:18 -06:00
