Maurice Parker
36841602a5
Change article rendering to use loadHTMLString instead of JavaScript. Issue #1923
2020-03-17 17:18:24 -05:00
Maurice Parker
37cf7fae1d
Fix regression that prevented Always Show Reader View from working.
2020-03-16 07:58:51 -05:00
Maurice Parker
07dc4f1f10
Don't start the article extractor if we only want to store the article. Issue #1494
2020-03-14 06:31:14 -05:00
Maurice Parker
7922efab1e
Merge pull request #1899 from flowinho/ios-release
...
Hide articleExtractor and actionBarButtonItem
2020-03-13 15:13:33 -05:00
Flowinho
ce428d2cc6
Hide articleExtractor and actionBarButtonItem
2020-03-13 20:21:18 +01:00
Maurice Parker
47e42fab0a
Removed old debugging statement.
2020-03-12 16:01:13 -05:00
Flowinho
da64f65c7b
Fixes close button icon distortion
...
This bug was caused by an inaccessible property of UIButton. Since the button was setup in IB using a system button with a custom icon, it’s imageView property is only accessible in code. The “view” content-mode in IB is misleading here, as it affects the UIButton.view NOT UIButton.ImageView.
- Set content-mode of the buttons imageview to scaleAspectFit.
2020-03-12 21:54:50 +01:00
Flowinho
feacda1c3b
HOTFIX silly me
2020-03-12 21:33:02 +01:00
Flowinho
91247b7f16
Adding dynamic width algorithm to the titleLabel
...
This commit adds multiple functionalities at once:
- The background of the image title now features rounded corners with a radius of 6 - which is consistent to iOS appearace.
- The background of the image title now is enlarged to make sure the letters do not touch the borders of the view. (This was a finding during implementation).
- The background of the image title is now removed when no title is present (memory optimization / prevention of unwanted optical glitches).
The title label now resizes itself depending on the devices it’s displazed on.
- On iPhone it will take 92% percent of available screen width.
- On iPhone it will 80% of available screen width.
- This works for all device orientations.
The numbers are derived from my personal preference when implementing it.
2020-03-12 21:23:57 +01:00
Maurice Parker
22b9e7b54b
Don't reset the windowScrollY position on every page render and don't set it if JavaScript returns it corrupted. Issue #1883
2020-03-11 19:45:45 -05:00
Maurice Parker
27b1443def
Remove dispatch code that didn't seem to help and caused us to not be able to find the correct view controller when setting the article. Issue #1881
2020-03-11 18:17:09 -06:00
Maurice Parker
76d5f4a073
Remove flush and restore of web view queues. Issue #1882
2020-03-11 17:02:16 -06:00
Maurice Parker
cd5e491f00
Fix issue where full screen wouldn't come back after being engaged and moving to the timeline. (Regression)
2020-02-26 16:02:36 -08:00
Maurice Parker
9e3f061fcb
Dispatch the page controller setting since it is unreliable. Issue #1756 & Issue #1808
2020-02-25 18:06:02 -08:00
Maurice Parker
5a5abb0b87
Ensure that the dom is fully loaded on *all* web views before being made available to process JavaScript. Issue #1756 & Issue #1808
2020-02-25 15:10:51 -08:00
Maurice Parker
0e72811429
Implement mark as unread window for accounts that need it. Issue #1407
2020-02-18 13:49:29 -08:00
Maurice Parker
8acd6a039a
Change event used to stop web view activity (video and image zooming) so that it doesn't interfere with the image zooming transition.
2020-02-18 11:08:38 -08:00
Maurice Parker
e3b32847f9
Stop image zooming on swipes and video playback on button presses. Issue #1801
2020-02-18 09:49:54 -08:00
Maurice Parker
58b8a9adb0
Render article on to be recycled web view and delay new web view showing to 0.3. Issue #1780
2020-02-13 17:35:34 -08:00
Maurice Parker
d01e9cef42
Remove unintended web view load when changing the article.
2020-02-13 16:08:44 -08:00
Maurice Parker
2ae021960b
Move account files to the documents directory and out of the shared container. Issue #1784
2020-02-12 16:21:48 -08:00
Maurice Parker
31b72221f8
Rollback delay that was causing blank articles to be shown. Issue #1780
2020-02-09 11:57:07 -08:00
Brent Simmons
eb770f4494
Merge branch 'ios-candidate' of https://github.com/Ranchero-Software/NetNewsWire into ios-candidate
2020-02-08 17:22:03 -08:00
Brent Simmons
cac67f8ac4
Use percent-encoding — via URLComponents — on the articleID in the nnwImageIcon URL scheme.
2020-02-08 17:21:55 -08:00
Maurice Parker
bdd79aead5
Delay swapping out the web view until the new web view has had a chance to render. Issue #1780
2020-02-08 16:55:16 -08:00
Maurice Parker
e5a9205747
Always reload the web view when the showing state changes. Issue #1775
2020-02-06 11:41:06 -08:00
Maurice Parker
268c20da56
Set all the web view delegates to nil when recycling to prevent unintended behaviors. Issue #1777
2020-02-06 10:36:39 -08:00
Maurice Parker
d1f1ca22b6
Add a hack to prevent horizontal scrolling on iPad. Issue #1714
2020-02-05 13:46:59 -08:00
Maurice Parker
dfd6be5fa6
Flush are rebuild web view queue when suspending and restoring the app. Issue #1563
2020-02-04 16:00:26 -08:00
Maurice Parker
8ed9958631
Change full article setting to enable or disable the feature. Issue #1773
2020-02-04 11:24:06 -08:00
Maurice Parker
596575c0e8
Delay making the initial web view available to give it some time to load the DOM. Issue #1756
2020-02-01 16:41:10 -08:00
Maurice Parker
8cb28b63b8
Always swap out the web view to prevent white flashing between articles and make loading faster.
2020-01-31 21:07:08 -07:00
Maurice Parker
a0f429448f
Call completions immediately if the previous WebViewController was deallocated because the iPad was rotated. Issue #1757
2020-01-30 18:48:51 -07:00
Maurice Parker
ab8deab726
Correct object ownership to remove retain cycle
2020-01-30 12:53:27 -07:00
Nate Weaver
447cc44b8e
Put <title> and <base> in the <head> instead of <body>
...
This also means renderHTML() is no longer needed.
2020-01-30 06:15:14 -06:00
Maurice Parker
f9589faa59
Keep queued WKWebViews in a hidden view until they are needed. Issue #1563
2020-01-29 17:39:40 -07:00
Maurice Parker
c293bc3a12
Animate timeline article selection and scrolling when done via article swiping. Issue #1732
2020-01-29 16:31:50 -07:00
Maurice Parker
f96bb9c3e0
Store more article view controller state when destroying and recreating them. Issue #1729
2020-01-29 11:30:52 -07:00
Maurice Parker
dd5633b5ae
Change to use the correct URL when reloading an image.
2020-01-27 16:27:13 -07:00
Maurice Parker
3a99e6430f
Make the article icon code specify the desired article so that it can't pull the wrong one by mistake. Issue #1707
2020-01-27 12:58:32 -07:00
Maurice Parker
470f2159e8
Remove dead code left from when WebViewController was split from ArticleViewController.
2020-01-27 11:50:28 -07:00
Maurice Parker
97d6c69431
Change to always reload the page when rendering an article. Issue #1713
2020-01-26 20:29:58 -07:00
Maurice Parker
4a63b28c73
Change how next and previous articles are selected so that animation timings can't impact them. Issue #1707
2020-01-26 14:21:04 -07:00
Maurice Parker
bc5a8c3705
Reset scroll position when article is reset. Issue #1716
2020-01-26 13:01:03 -07:00
Maurice Parker
785775801a
Don't force cast scrollY as it might not always be set. Issue #1685
2020-01-25 15:36:43 -07:00
Maurice Parker
deab8f8c6c
Change to stop recycling the article view controller when switching panel modes on the iPad. Issue #1570
2020-01-21 11:05:47 -07:00
Maurice Parker
61c854b031
Fix animation layer stripping. Issue #1668
2020-01-20 13:16:03 -07:00
Martin Hartl
3370b834b0
Stop media playback when article will disappear
2020-01-20 19:46:23 +01:00
Maurice Parker
7e35bd1ec4
Remove unused parameter. It was obsoleted, but not removed.
2020-01-19 15:36:19 -07:00
Maurice Parker
88f565e03f
Use the DOM Y position to restore the scroll offset. This mostly fixes Issue #1494 .
2020-01-19 11:48:26 -07:00
