Commit Graph

1066 Commits

Author SHA1 Message Date
Chris Campbell 364f3a7639
Prevent infinite loop in DetailWebView.setFrameSize()
DetailWebView.setFrameSize() calls bigSurOffsetFix(), which changes the window's frame, which ultimately calls setFrameSize() again (which calls bigSurOffsetFix(), etc). In practice, this isn't causing an infinite loop (I think NSWindow.setFrame(_:display:) is smart enough to prevent reentrancy) but it's still dangerous to have such a glaring logic error in the code.
2021-04-30 00:52:15 -04:00
Chris Campbell bf77d77669
Expand workaround for macOS 11 WebView origin offset bug. Fixes #2916
Move the code that twiddles the window frame from DetailWebView.viewDidEndLiveResize() into a new bigSurOffsetFix() API so it can also be called by setFrameSize() when the frame size is changed outside of a live resize.
2021-04-30 00:02:10 -04:00
Stuart Breckenridge 5af2643479
standardised naming 2021-04-19 11:21:00 +08:00
Stuart Breckenridge d4130e7c65
Corrects naming convention
[iOS]
Twitter: Notify about new tweets
Reddit: Notify about new posts
Default: Notify about new articles
+ Fixes alignment issues in the inspector view

[macOS]
Twitter: Show notifications for new tweets
Reddit: Show notifications for new posts
Default: Show notifications for new articles
2021-04-19 11:10:57 +08:00
Maurice Parker 77dd2e5e22 Merge branch 'mac-release' into main 2021-04-15 14:31:52 -05:00
Maurice Parker 3955151daf Make sure mark as read completes before searching for the next unread. Fixes #2952 2021-04-15 14:29:49 -05:00
Maurice Parker f0ab588c0f Update to latest Account API. 2021-04-12 19:46:59 -05:00
Stuart Breckenridge 4e517a6db4
Disable Reader View
This commit:
- adds a `isFeedProvider: Bool` property to `WebFeed`
- if `isFeedProvider` is `true`, the article extractor is disabled on the inspector, hidden from the context menu, and the toolbar button is disabled. Additionally, if `isFeedProvider` is `true`, `isArticleExtractorAlwaysOn` returns `false` and cannot be set to `true`.
2021-04-09 07:47:14 +08:00
Maurice Parker b1a0b649a5
Merge pull request #2972 from j-f1/read-unread
Update swipe actions on macOS to match iOS
2021-04-07 03:47:27 -05:00
Jed Fox 76cf335af1
Use the star SF Symbols as well 2021-04-06 17:37:15 -04:00
Jed Fox 3609b6f977
Add labels to swipe actions to match iOS 2021-04-06 17:34:05 -04:00
Jed Fox 0c2f79f1b5
Update read/unread swipe images to be SF Symbols on Big Sur 2021-04-06 17:31:42 -04:00
Maurice Parker ea6cece955 Merge branch 'mac-release' into main 2021-04-03 09:30:42 -05:00
Maurice Parker 5663d8549e
Merge pull request #2958 from stuartbreckenridge/mac-candidate
Layout changes to reduce height of add account sheet
2021-04-01 18:00:09 -05:00
Stuart Breckenridge 8da7d2173f
Layout changes to reduce size of add account sheet 2021-04-02 06:53:20 +08:00
Maurice Parker 1ab727a128 Make symbol images images scale correctly. Fixes #2957 2021-04-01 11:12:48 -05:00
Jed Fox 4750e9b93a
Add dir=auto to page.html 2021-03-29 17:20:09 -04:00
Maurice Parker 95234706e1 Fix issue where next unread wasn't wrapping around. Fixes #2942 2021-03-29 14:33:08 -05:00
Maurice Parker fb9114538c Modified the Timeline so that it can handle duplicate articleIDs 2021-03-28 06:30:49 -05:00
Maurice Parker ab5421f533 Merge branch 'mac-release' into main 2021-03-27 17:21:49 -05:00
Brent Simmons b1d62d1bb7 Return to the normal test build appcast feed URL. 2021-03-26 18:16:08 -07:00
Brent Simmons 87de7c51b5 Update the link for the 6.0 Mac help book. 2021-03-25 17:17:43 -07:00
Maurice Parker e62cb4847b Only update the timer when the refreshInterval changes 2021-03-25 13:51:40 -05:00
Maurice Parker 84ddd75107 Change refresh behavior so that it doesn't rely on the debug menu. Fixes #2905 2021-03-22 17:20:40 -05:00
Maurice Parker 42e6e1397d Signal that the mouse exited the link when an article gets reloaded. Fixes #2877 2021-03-15 20:14:30 -05:00
Maurice Parker 78b9444274 Remove extra unused parameter in delegate signature 2021-03-15 20:10:42 -05:00
Maurice Parker 52f11ff538 Add validateFeed parameter to createWebFeed 2021-03-15 18:01:12 -05:00
Maurice Parker f1e4d70481 Simplify the folder copy logic 2021-03-15 17:47:53 -05:00
Maurice Parker d57cb7b21f Delete obsolete code 2021-03-15 17:35:23 -05:00
Maurice Parker 7e4e7091e2 Delete obsolete code 2021-03-15 17:33:12 -05:00
Maurice Parker c1a6c42bd3 Remove Hide Unread Count preference. Fixes #2881 2021-03-14 14:06:09 -05:00
Maurice Parker bf76cb810d Change to always copy between accounts. Fixes #2871 2021-03-11 19:43:05 -06:00
Stuart Breckenridge e2f21c15c2
formatting 2021-03-08 14:12:32 +08:00
Stuart Breckenridge f630cb16db
comments 2021-03-08 10:30:58 +08:00
Stuart Breckenridge a59df3e6fc
Moves frame tweaking to end of liveResize 2021-03-08 10:28:51 +08:00
Stuart Breckenridge 27b9326d07
fixes #2823 2021-03-08 10:06:30 +08:00
Stuart Breckenridge 2e12f5a078
removes code comment 2021-03-07 21:34:52 +08:00
Stuart Breckenridge 86981a0c5b
#2597
Fixes #2597: Toggles a small window height change to get webview to behave on macOS 11.
2021-03-07 16:47:39 +08:00
Stuart Breckenridge 7a653db1dd
typo 2021-03-07 15:51:43 +08:00
Stuart Breckenridge 8dc6e4e332
Contraint Changes
Fixes #2850
• #2634: resizing vertically downards (expanding) is smooth
2021-03-07 14:21:30 +08:00
Brent Simmons f8ae8d2821 Merge branch 'mac-candidate' of https://github.com/Ranchero-Software/NetNewsWire into mac-candidate 2021-03-06 14:52:24 -08:00
Brent Simmons 91a825343a Add Debug > Force Crash command. Also: let the test for crash report sending work in production. 2021-03-06 14:44:58 -08:00
Maurice Parker a7abde04ab Fix variable name 2021-03-06 16:25:10 -06:00
Maurice Parker fa4f3ea818 Merge branch 'mac-candidate' of https://github.com/Ranchero-Software/NetNewsWire into mac-candidate 2021-03-05 12:45:21 -06:00
Maurice Parker 2ca06eeae7 Remove containing box for web view. Fixes #2848 2021-03-05 12:45:15 -06:00
Brent Simmons 586e6ed706 Merge branch 'mac-candidate' of https://github.com/Ranchero-Software/NetNewsWire into mac-candidate 2021-03-02 22:08:21 -08:00
Brent Simmons bb5a0abb9a Update crash log URL to the new crash log catcher on our new services.netnewswire.com server. 2021-03-02 22:08:11 -08:00
Collin Donnell 035759947a Fix #2833: Titlebar is overlapped by toolbar in fullscreen
Fix issue where detail web view would be overlapped by the toolbar in full screen by setting web view constraints to use the `safeAreaLayoutGuide` in macOS 11+.
2021-02-27 19:02:13 -06:00
Collin Donnell 593569175c Fix #2833: Titlebar is overlapped by toolbar in fullscreen
Fix issue where detail web view would be overlapped by the toolbar in full screen by setting web view constraints to use the `safeAreaLayoutGuide` in macOS 11+.
2021-02-27 16:32:57 -08:00
Maurice Parker 74298e7cde Add hidden GruberFeedDoubleClickMarkAsRead preference 2021-02-26 17:38:26 -06:00