Commit Graph

492 Commits

Author SHA1 Message Date
Jeremy Beker f54bc3569b
Merge branch 'master' into google_reader_compatible_syncing
# Conflicts:
#	Frameworks/Account/Account.swift
#	submodules/RSWeb
2019-06-15 12:34:50 -04:00
Maurice Parker 18b90ba93f Added How To Support NetNewsWire help menu item. Issue #753 2019-06-14 17:38:00 -05:00
Maurice Parker ed6dd249c3 add missed file in last commit 2019-06-14 15:35:12 -05:00
Maurice Parker 40b9be6709 center smaller avatars on a solid color background image to make all avatars a consistent size 2019-06-14 15:33:13 -05:00
Maurice Parker 6527ac852c Correct usage of BatchUpdate so that UI remains responsive after error messages Issue #752 2019-06-13 14:50:41 -05:00
Nate Weaver 3e8e7113c0 Make read/starred read/write via AppleScript 2019-06-11 19:17:50 -05:00
Brent Simmons 3e0f70f43e Update version to 5.0a3. Update appcast. 2019-06-10 21:52:13 -07:00
Maurice Parker e8199ed0a6 Change to not show alert dialog on automatic refreshes. Issue #729 2019-06-10 15:21:17 -05:00
Maurice Parker 93fbbd4cc3 Make sure that FeedFinder and InitialDownloader are running on the main thread. 2019-06-10 08:21:03 -05:00
Brent Simmons 45f6d8043a Add ellipsis where needed in import/export OPML sheets. Fix #731. 2019-06-09 20:18:10 -07:00
Brent Simmons 4a4fa6ed0e Fix crashing bug by not using an NSFont as a key in a Swift dictionary. Fix #734. 2019-06-09 16:03:08 -07:00
Brent Simmons 2d96544933 NetNewsWire 5.0a2. 2019-06-08 16:29:07 -07:00
Charles Parnot 4f02fe7401 Fix issue with 'Mark as Read' menu item in the Article menu.
There were 2 issues: the title of the menu item did not toggle between 'Mark As Read' and 'Mark As Unread', and it was not invalidated where there is no article selected. All the code was already in place in `MainWindowController` as part of the interface item validation, but the menu item was using the wrong selector: `markRead` instead of `toggleRead`. Just changing the action in the menu item was needed to get the validation and menu item update happening correctly.
2019-06-07 09:06:18 +02:00
Brent Simmons 364fc2760f Bump version to 5.0a1. That’s right — it’s alpha now. W00t! 2019-05-31 20:21:08 -07:00
Maurice Parker 3593d1c5d8 Update to the new icon 2019-05-31 13:52:15 -05:00
Jeremy Beker 98c32b9987
Merge branch 'master' into google_reader_compatible_syncing 2019-05-31 09:54:25 -04:00
Maurice Parker 88b2775076 Make sure that an account doesn't try persist to the disk in the time that it is logically deleted and when it is actually deallocated 2019-05-31 08:05:26 -05:00
Maurice Parker beacad1aeb Validate folder drop to make sure no folders with the same name are already in the target account 2019-05-30 17:57:06 -05:00
Maurice Parker a8f090656d Handle when a feed in a folder being copied/moved already is subscribed in target account 2019-05-30 14:44:13 -05:00
Maurice Parker 30c21bb125 Enable folders to be dropped in a move or copy between accounts 2019-05-30 14:36:21 -05:00
Maurice Parker 1352dda8aa Modify Feedbin feed deletes so that they emulate how the local account feed deletes work. 2019-05-30 10:12:34 -05:00
Jeremy Beker fdc0374c4f
Ensure credentials are available for use
Need to load metadad first
2019-05-30 07:48:34 -04:00
Maurice Parker 51284b5aa4 Rename deleteFeed to removeFeed to be more consistent with other API's 2019-05-29 21:04:44 -05:00
Maurice Parker 527e677934 Rename deleteFolder to removeFolder to make the API more consistent 2019-05-29 20:53:00 -05:00
Maurice Parker f4bc17c8f1 Refactor addFeed and removeFeed usages to be more consistent 2019-05-29 20:47:52 -05:00
Maurice Parker 5e3fcfd955 Correct how feeds were deleted so that only the feed in the correct container was deleted 2019-05-29 17:56:26 -05:00
Maurice Parker bead6ae123 Remove now unnecessary call to account structureDidChange in drop 2019-05-29 17:14:50 -05:00
Maurice Parker fa6b6a4769 Corrected move BatchUpdate usage to make move animation smoother 2019-05-29 17:08:41 -05:00
Maurice Parker b1bd8d2d90 Enable folder dragging between accounts 2019-05-29 15:43:33 -05:00
Jeremy Beker aa6dfe8a08
Rework to store endpoint URL in metadata
Endpoint URL did not belong with credentials. This breaks it out and stores it in the account metadata. Updates validation code to take it as a parameter.
2019-05-29 15:16:09 -04:00
Maurice Parker 8fc6e81ddf Update the Today timeline and unread count when the day changes. Issue #627 2019-05-29 10:24:30 -05:00
Jeremy Beker 0df86e5761
Authentication working
* Updates to use new API style per discussion with Maurice
* Credential validation functioning
2019-05-29 10:54:52 -04:00
Maurice Parker 0648053417 Enforce tag specific drop validation (can't copy to the account level) 2019-05-28 17:42:19 -05:00
Maurice Parker 83652c40de Handle scenario where moved/copied feed already exists somewhere else in account 2019-05-28 16:46:16 -05:00
Maurice Parker 01d5a95241 Remove redundant private keyword usage 2019-05-28 16:31:03 -05:00
Maurice Parker 112702020b Enable same account copying. 2019-05-28 13:11:29 -05:00
Jeremy Beker 84dbdf25e2
Google Reader API Account Provider and initial integration
* Creation of account classes (based on FeedBin)
* Integration on Mac side into account dialog
* Initial authentication call works and extracts auth token, but no where to put it right now.
2019-05-28 13:08:15 -04:00
Maurice Parker 78c19bda43 Remove restriction on only moving and copying between local accounts. 2019-05-28 11:09:47 -05:00
Maurice Parker b3c4c8de59 Correct how feeds were copied and moved between accounts to eliminate shared objects. 2019-05-28 10:59:06 -05:00
Maurice Parker 493abbb609 Refactor create feed functionality to increase code reuse and encapsulation 2019-05-28 09:45:02 -05:00
Maurice Parker c7b61f7d87 Enable copy between local accounts. 2019-05-27 18:01:24 -05:00
Maurice Parker 659c9e5271 Allow dragged feeds between local accounts only 2019-05-27 15:11:16 -05:00
Brent Simmons bfe41438fc Make default exported OPML file name Subscriptions-[accountName].opml. Fix #683. 2019-05-26 22:17:19 -07:00
Brent Simmons e5e9538318 Change column spacing in the grid view so that we use standard space between labels and content. 2019-05-26 22:12:09 -07:00
Brent Simmons 8322ea4f31 Tweak the explanotext for the Name field in Account > Preferences. 2019-05-26 22:01:50 -07:00
Brent Simmons 6cd8f42597 Add layout constraints for the table cells in Account > Preferences sidebar. 2019-05-26 21:59:41 -07:00
Brent Simmons 9e0187ca55 Fix tableView frame in Preferences > Accounts sidebar. For some reason IB wants it wider than the clip view. This leads to unwanted horizontal scrolling. 2019-05-26 21:38:13 -07:00
Brent Simmons 9f6b2bc63f Revise layout and add explanation for the import OPML choose-account sheet. 2019-05-26 16:29:46 -07:00
Brent Simmons 810e5b9aee Tweak layout and add explanation text for OPML export sheet. 2019-05-26 16:12:38 -07:00
Brent Simmons 31f8348d11 Add explanation text to the Name field in Account Information preferences. 2019-05-26 12:12:29 -07:00
Brent Simmons 4de509326f Change OPML menu items to Import Subscriptions… and Export Subscriptions. Change Close menu item to Close Window. 2019-05-26 11:55:24 -07:00
Maurice Parker c61949bc04 Add account name to network error messages and prevent background iOS errors from displaying alerts 2019-05-26 11:54:32 -05:00
Brent Simmons 68420bcfd1 Update Info.plist for new public build. 2019-05-25 10:33:23 -07:00
Brent Simmons ad841ee41e Remove Donate to App Camp from Help menu, since the donation page no longer exists. 2019-05-25 10:27:05 -07:00
Brent Simmons 8f48d8a726 Add Slack Group command in Help menu — it takes you to the signup page. 2019-05-25 10:21:25 -07:00
Maurice Parker c422b4b82c Merge branch 'master' of https://github.com/brentsimmons/NetNewsWire 2019-05-22 10:08:01 -05:00
Maurice Parker 43f8e9880c Change to mark all as unread for the selected article feed. Issue #657 2019-05-22 10:07:00 -05:00
Brent Simmons e05eb6e60c Use == instead of === when comparing feeds in the sidebar — you might have duplicate feeds. (Duplicate feeds are totally allowed.) 2019-05-21 22:23:26 -07:00
Maurice Parker be81fdae0a Send article statuses to Feedbin on app terminate 2019-05-21 17:20:49 -05:00
Maurice Parker 98a262e34b Update pseudo feed timeline when and account is deleted. 2019-05-21 16:47:32 -05:00
Maurice Parker 918eb746d5 Update pseudo feeds when account states change. Issues #645, #663, & #664. 2019-05-21 16:36:47 -05:00
Maurice Parker 46cd477ee0 Make unread indicator white for selected and emphasized rows in timeline. Issue #655 2019-05-21 16:08:16 -05:00
Maurice Parker 4667035e61 Remember last OPML export account, suggest account name for OPML export file name, allow export of inactive accounts. Issue #659 & Issue #652 2019-05-21 15:15:26 -05:00
Maurice Parker 0da916fa68 Add Mark All as Read contextual menu item. Issue #657 2019-05-21 14:57:22 -05:00
Maurice Parker af19b6dee0 Remember last selected account on OPML import. Issue #661 2019-05-21 14:56:41 -05:00
Maurice Parker 8816de4a0e Fix issue where new Feeds added to a folder also got left in the account container. 2019-05-21 10:26:11 -05:00
Maurice Parker fb33008b36 Remember account selection for Add Feed and Add Folder dialogs. Issue #651 & Issue #654 2019-05-21 09:36:33 -05:00
Maurice Parker e6680a23b9 Make move animation smoother by wrapping in a BatchUpdate 2019-05-21 09:03:28 -05:00
Maurice Parker 3207ebf6a5 Implement default timeline avatar. Issue #641 2019-05-21 05:42:40 -05:00
Brent Simmons 3ae9bdb74f Merge branch 'master' of https://github.com/brentsimmons/NetNewsWire 2019-05-20 14:30:08 -07:00
Brent Simmons 74953601dd Increase the duration of TimelineViewController’s database fetch queue from 0.5 to 2.0. This will still allow updates to appear in a timely way, but will help prevent fetching too often during a refresh. 2019-05-19 22:26:08 -07:00
Brent Simmons 4d27e5a338 Simplify representedObjectsContainsAnyPseudoFeed. 2019-05-19 20:49:24 -07:00
Phil Viso bce45d28e4 Updated all iOS references to default local account new to be device specific 2019-05-19 16:52:21 -05:00
Maurice Parker 80e1888244 Rename AccountsDidChangeNotification to AccountsDidChange to match other notification names. 2019-05-19 15:51:08 -05:00
Maurice Parker 07ac60cec3 Remove showAddFolderWindow and showAddFeedWindow functions from MainWindowController so that validations will run on AppDelegate. 2019-05-19 15:27:58 -05:00
Maurice Parker 10c5ca4e1a Disable refresh and add NNW app news when there are no active accounts. 2019-05-19 14:23:54 -05:00
Maurice Parker 86578775e0 Move menu validations to the app delegate. 2019-05-19 10:21:42 -05:00
Phil Viso eb5c1a49f7 Disable adding a new folder if there are no active accounts 2019-05-19 09:14:40 -05:00
Phil Viso 5ded56fc28 Fixed a crash that occurs when trying to add a new feed with no active accounts 2019-05-19 09:10:19 -05:00
Brent Simmons e98d28c770 Show favicon in the timeline, even though they look weird because they’re small. They’re still better than nothing. 2019-05-18 12:21:35 -07:00
Brent Simmons 36c6c70ba2 Scale avatar images down — they might be up to twice as large as expected. 2019-05-17 23:02:48 -07:00
Brent Simmons 3d253ce6d9 Align avatars to top in timeline. Fix #643. 2019-05-16 22:32:09 -07:00
Brent Simmons 6fc6850a79 Update URL for Help book. 2019-05-16 21:31:57 -07:00
Maurice Parker b759237fc1 Fix issue where moving from account to folder and the network is unavailable caused feeds to be lost. 2019-05-16 11:19:44 -05:00
Maurice Parker 6882b152d9 Add timer to trigger article status sync process. 2019-05-15 17:21:58 -05:00
Maurice Parker fb79309f95 Change import and export OPML so that they don't prompt to select an account if only one is active 2019-05-14 19:40:38 -05:00
Brent Simmons 51730d9b1c Set scaling to .scaleNone in the avatar image view in the timeline, since we’re pre-scaling the images. 2019-05-13 22:23:06 -07:00
Brent Simmons 5abe73331a Make TimelineTableView and TimelineTableRowView opaque in the interest of speeding up rendering during scrolling. 2019-05-13 21:42:47 -07:00
Brent Simmons 52b1ef2350 Place avatars on the left in the timeline. 2019-05-12 20:42:52 -07:00
Maurice Parker 521960a2c9 make sure that the account add view is shown after an account delete 2019-05-12 19:22:59 -05:00
Maurice Parker 6f92cd1a73 Refactor to differentiate between loading the Subscriptions.opml file and importing an external OPML file as they now need separate behaviors 2019-05-11 12:26:23 -05:00
Maurice Parker fe70723eb4 Use best feed specifier code to determine which Feedbin option to use when creating a feed 2019-05-10 10:14:24 -05:00
Maurice Parker a7d1014d5b Change account delete to use a standard alert dialog. 2019-05-10 08:42:44 -05:00
Maurice Parker 23b43ecc07 Add undo for feeds 2019-05-09 16:09:21 -05:00
Maurice Parker cda8acc66c Add the ability to move feeds between folders for Feedbin 2019-05-09 13:31:18 -05:00
Maurice Parker 50d3a5799c added subscription delete 2019-05-09 07:25:45 -05:00
Maurice Parker 06626f10a7 Add feed rename 2019-05-08 17:55:53 -05:00
Maurice Parker 43d32b1281 Add create Feedbin feed 2019-05-08 17:41:19 -05:00
Maurice Parker 7f9055fe78 Add download subscriptions and faviconURLs 2019-05-07 10:51:41 -05:00
Maurice Parker d6ae740305 Added folder (tag) delete for Feedbin 2019-05-06 17:34:41 -05:00
Maurice Parker b7e2df1a68 Add Folder rename for Feedbin 2019-05-06 10:53:20 -05:00
Maurice Parker 15a0ba89d7 Add folder syncing for Feedbin account 2019-05-05 15:41:20 -05:00
Maurice Parker fc7b6f2c6b refactor how Credentials work 2019-05-05 03:25:21 -05:00
Maurice Parker 261e2a951a Add ability to update credentials 2019-05-04 16:10:58 -05:00
Maurice Parker aaa4342494 Add encrypted credential storage 2019-05-04 15:14:49 -05:00
Maurice Parker 595db517a7 change func signitures to use Credentials protocol from RSWeb instead of username/password 2019-05-04 11:48:48 -05:00
Maurice Parker 38202ece8d Made credentials verification errors more descriptive. 2019-05-04 09:18:14 -05:00
Maurice Parker bb42e46887 Update to use latest webservice network layer in RSWeb 2019-05-04 08:54:07 -05:00
Maurice Parker 5a852c1615 validate Feedbin account credentials and add Feedbin account 2019-05-02 18:17:52 -05:00
Maurice Parker c25680ca5d Show add account after delete account 2019-05-02 06:57:45 -05:00
Maurice Parker eb89ee7128 Expand new or newly active accounts so that they don't look broken 2019-05-02 06:45:56 -05:00
Maurice Parker 141ec961e9 Tweak account detail UI 2019-05-02 06:28:40 -05:00
Maurice Parker 636468bbf0 Implement active account processing functionality 2019-05-02 06:01:30 -05:00
Maurice Parker 747079157b Implement account state UI 2019-05-02 05:41:44 -05:00
Maurice Parker f5523dd610 Add delete from disk 2019-05-01 19:22:07 -05:00
Maurice Parker 32eb6f6a17 Make the delete warning less comically large 2019-05-01 18:49:13 -05:00
Maurice Parker 1802f71572 Implement the delete UI 2019-05-01 18:26:23 -05:00
Maurice Parker 133398c240 Prevent dragging between accounts. 2019-05-01 17:49:25 -05:00
Maurice Parker 78e98e4c03 Make single non-local drops work with multiple accounts 2019-05-01 17:33:08 -05:00
Maurice Parker 73f035c5b7 Make OPML import and export respect multiple accounts 2019-05-01 16:04:56 -05:00
Maurice Parker 63eeeb55ca Refine visually the add local account dialog 2019-05-01 15:08:50 -05:00
Maurice Parker f5dbe7117e Delete dead code 2019-05-01 14:56:26 -05:00
Maurice Parker 6ede5b7c3d Enable add feed for multiple accounts 2019-05-01 14:03:59 -05:00
Maurice Parker f4180424e1 Add multiple local accounts 2019-05-01 12:37:13 -05:00
Maurice Parker 7cc4475596 Rename classes to match naming convention 2019-05-01 11:08:06 -05:00
Maurice Parker 4edffa488d Rename classes to match naming convention 2019-05-01 11:05:55 -05:00
Maurice Parker 68f5c1bfd1 Make account listing wider 2019-05-01 10:31:40 -05:00
Maurice Parker fe8e825c0d Add account add UI 2019-05-01 10:28:13 -05:00
Maurice Parker a845a96274 Add images to account table view 2019-05-01 06:49:50 -05:00
Maurice Parker 4bc7611721 Rename AccountManageer.localAccount to AccountManager.defaultAccount to make it different from other local accounts 2019-05-01 05:53:18 -05:00
Maurice Parker ba57a27a35 Make local account display names changeable 2019-04-30 06:38:18 -05:00
Maurice Parker 476bd7ec56 Fix release build compile error caused by recent RefreshTimer refactoring. 2019-04-24 14:46:01 -05:00
Maurice Parker 66e4180a8c Refactor RefreshTimer code out into a separate class from AppDelegate so that it can be reused on iOS. 2019-04-23 11:20:44 -05:00
Maurice Parker 23c69a9223 Make RefreshInterval shared code
Back out inadvertent macOS changes
2019-04-23 08:47:58 -05:00
Maurice Parker e81defb934 Implement detail next and prev article buttons. 2019-04-21 17:42:26 -05:00
Maurice Parker c5a891234d implement model controller pattern 2019-04-21 13:57:23 -05:00
Maurice Parker b01b45cf9c Renamed to DeleteCommand and implemented delete undo for iOS. 2019-04-18 08:54:48 -05:00
Maurice Parker 7083b5064b Refactored the TreeDelegates to be shared code. 2019-04-18 04:56:15 -05:00
Maurice Parker 615e183242 Combined all the "add"s into a single popover. 2019-04-16 13:38:07 -05:00
Maurice Parker 8526db8b4c Added initial POC version of NetNewsWire for iOS to use as a starting point for the actual app. 2019-04-15 15:03:05 -05:00
Brent Simmons 6c8481d805 Work around WKWebView latency that happens when specifying baseURL. Instead, make it nil, and add a base href tag to the actual HTML. 2019-04-14 12:54:17 -07:00
Brent Simmons 70312aa75c Major folder and project tree restructuring. 2019-04-13 16:18:54 -07:00