Commit Graph

264 Commits

Author SHA1 Message Date
Maurice Parker efcbdd642a Fix cell icon tint colors 2019-09-11 19:29:27 -05:00
Maurice Parker 7ec360a81e Delete unnecessary node reload 2019-09-11 17:20:33 -05:00
Maurice Parker be84fc5a6b Simplify the section and folder expand/collapse logic 2019-09-11 16:53:27 -05:00
Maurice Parker 1b97aad79c Simplify code by moving the expanded indicator to Node 2019-09-11 15:24:38 -05:00
Maurice Parker ab38e755d3 Move apply snapshot to the viewWillAppear callback to prevent table artifacts 2019-09-11 14:33:39 -05:00
Maurice Parker d8513385e1 More refactoring to remove IndexPath dependencies 2019-09-11 05:45:35 -05:00
Maurice Parker 7278a86523 Refactor to reduce usage of IndexPath's in SceneCoordinator 2019-09-11 05:33:54 -05:00
Maurice Parker aac3c86561 Ensure that selected feed is visible when transitioning to three panel mode 2019-09-10 16:38:59 -05:00
Maurice Parker e3361abc77 Force the scroll even if the currently selected row is the same 2019-09-10 07:48:40 -05:00
Maurice Parker 98761510dd Reload visible cells after expanding/collapsing folders since the folder row might not get updated 2019-09-09 10:06:13 -05:00
Maurice Parker 9dc8f8d37a Clear the timeline if the deleted feed is showing in the timeline 2019-09-08 08:40:15 -05:00
Maurice Parker 8b901819a6 Make table views scroll even if the root split is collapsed 2019-09-08 08:30:08 -05:00
Maurice Parker a6f6462afd Make arrow key scrolling work like it does on the Mac timeline 2019-09-06 13:45:45 -05:00
Maurice Parker c8b5b10edd Check if the split is collapsed to see if we are maintaining the selection 2019-09-06 11:22:35 -05:00
Maurice Parker aa7c60ee3a Prevent row selection on iPhone as keeping selected rows highlighted is an iPad only feature 2019-09-06 11:11:28 -05:00
Maurice Parker cc1c45095c Make feeds become first responder on load so that the keyboard is ready to go on initial app launch 2019-09-06 10:52:21 -05:00
Maurice Parker 9b17293f4e Fix bugs in automated routing on application launch 2019-09-06 07:29:36 -05:00
Maurice Parker 6d24ea642a Add expand and collapse all folders shortcuts 2019-09-05 16:38:33 -05:00
Maurice Parker 734ce4bc67 Rename expand and collapse functions to be more descriptive 2019-09-05 16:08:57 -05:00
Maurice Parker 953259f0d3 Add selected row expanding and collapsing keyboard shortcuts 2019-09-05 16:04:07 -05:00
Maurice Parker c9fd7d01d9 Add delete feed keyboard shortcut 2019-09-05 15:54:58 -05:00
Maurice Parker afce6ff26f Add keyboard shortcuts for Add Feed and Add Folder 2019-09-05 15:07:35 -05:00
Maurice Parker 73828e5115 Remove the coordinator dependency from KeyboadManager as it wasn't needed 2019-09-05 14:37:07 -05:00
Maurice Parker ac37443dbb Stubbed out menu item keyboard shortcuts and implemented the numbered ones 2019-09-05 13:14:14 -05:00
Maurice Parker 7a452e2a3c Add keyboard arrow key navigation 2019-09-04 21:06:29 -05:00
Maurice Parker 68143aa2c5 Implement keyboard shortcut infrastructure and first shortcuts 2019-09-04 16:24:16 -05:00
Maurice Parker 17a5d291f4 Remove become and resign first responder code in Feeds and Timeline 2019-09-03 20:39:00 -05:00
Maurice Parker e6a4338a86 Restore the feed selection if an account containing the selection is expanded 2019-09-03 13:59:22 -05:00
Maurice Parker bf572633f8 Enable drag and drop between accounts 2019-09-03 13:27:23 -05:00
Maurice Parker 960f09826b Add separator line to section headers so that they don't look smooshed together when collapsed 2019-09-03 13:00:31 -05:00
Maurice Parker 4bce625f18 Clear search results when no timeline fetcher is specified 2019-09-03 12:25:27 -05:00
Maurice Parker 2e71cc573d Cap the possible destination index used during Feed moves 2019-09-03 12:07:18 -05:00
Jim Correia 061872b7ff Simplified/corrected highlighted/selected appearance of feed and timeline cells.
- Set the highlighted text color on labels in table cells. This will be used
  for both the highlight and selected states automatically. (And since it is
  used for both states, we avoid anachronistic state where we have black
  text on a dark blue background in light mode as we transition from none ->
  highlighted -> selected.)

- Keep the selected/highlighted overrides to adjust colors for non-UIControl
  subelements.
2019-09-02 22:39:01 -07:00
Jim Correia 932f6fdd30 Added NNWTableViewCell; a base class for cells with the NNW selection color.
Defined a semantic color for the selection color which is identical to
netNewsWireBlue.

MasterFeedTableViewCell and MasterTimelineTableViewCell now subclass
NNWTableViewCell and no longer directly customize their selected background
view.
2019-09-02 22:38:42 -07:00
Maurice Parker 1a9acdcc50 Remove TreeController from Delete command as it is no longer used there 2019-09-01 14:56:27 -05:00
Maurice Parker 858bdb7f21 Rename AppCoordinator to SceneCoordinator as that name better defines its purpose 2019-09-01 12:43:07 -05:00
Maurice Parker 397d75c6f6 Restore animation when adds and deletes happen to feed items 2019-09-01 10:11:03 -05:00
Maurice Parker 27883632d0 Fix bug that prevented reading article user activities from being restored 2019-08-31 20:23:14 -05:00
Maurice Parker 87030a5921 Implement stateRestorationActivity to save most relevant current user activity 2019-08-31 19:30:21 -05:00
Maurice Parker 762710266d Reload all cells when a batch update completes because we might be out of sync even though we called apply on the datasource. This can happen when moving a feed into and out of a folder. 2019-08-30 16:19:06 -05:00
Maurice Parker 197fc0170e Optimize and fix unread count updates 2019-08-29 14:35:18 -05:00
Maurice Parker be8c14bc65 Change to reload the individual row instead of just changing its contents 2019-08-28 20:21:50 -05:00
Maurice Parker 7062744758 Make sure we manually correct some state when using diffable datasources 2019-08-28 20:08:30 -05:00
Maurice Parker 89a38fa2b5 Change Feeds to use diffable data sources 2019-08-28 18:06:27 -05:00
Maurice Parker 9c66f6160e Clean activities when the associated data is deleted 2019-08-28 11:30:40 -05:00
Maurice Parker 3d408d0b27 Prevent autolayout from messing around with our disclosure chevron 2019-08-25 20:06:45 -05:00
Maurice Parker cf5fd4fa89 Invalidate content size correctly 2019-08-25 20:06:02 -05:00
Maurice Parker a0b11da438 Prevent autolayout from messing with our manually set frames 2019-08-25 20:00:34 -05:00
Maurice Parker 0b48c3893d Change AppCoordinator to directly call controller API's since that matches the Coordinator pattern better than sending them notifications 2019-08-25 11:38:04 -05:00
Maurice Parker 7f024586bb Add navigation and toolbar theming for light mode. Issue #698 2019-08-23 12:27:45 -05:00
Maurice Parker 5a5a66d59f Remove unneeded notifications 2019-08-22 16:50:20 -05:00
Maurice Parker d67b9193c5 Add large titles to Feeds controller (again) 2019-08-22 11:16:07 -05:00
Maurice Parker c4e2420966 Change to get currently selected unread count item from total number of articles shown in timeline 2019-08-21 13:10:08 -05:00
Maurice Parker eb8de035d7 Work around bug where cell tintColor isn't always correctly inherited from the window 2019-08-20 16:37:31 -05:00
Maurice Parker 64fd5016a9 Commenting out feed context menus due to buggy implementation in Beta 6 2019-08-20 05:43:39 -05:00
Maurice Parker 6087951824 Remove context menu titles as they didn't provide any additional context 2019-08-19 15:49:42 -05:00
Maurice Parker 3245223b24 Add Select Feed context menu 2019-08-19 15:45:52 -05:00
Maurice Parker 3cbf9f45a3 Add weak self usage in a couple needed places 2019-08-16 13:54:19 -05:00
Maurice Parker 066616b005 Add new images used in context menus to AppAssets where they belong 2019-08-16 13:27:41 -05:00
Maurice Parker 2f5225163d Center the pop over arrow in the button the same way that Apple does in Mail 2019-08-16 12:14:55 -05:00
Maurice Parker 7ac18029ea Add additional swipe menu More to handle new actions 2019-08-15 19:46:31 -05:00
Maurice Parker e8bbe9efbf Add Folder context menu 2019-08-15 17:46:42 -05:00
Maurice Parker e88210bbb7 Add copy url actions for feeds 2019-08-15 15:19:23 -05:00
Maurice Parker c03c444997 Add initial context menu items for feeds. 2019-08-15 13:19:02 -05:00
Maurice Parker 1eb8da7749 Rearrange some code to put them in the correct sections 2019-08-15 12:42:25 -05:00
Maurice Parker 02575c31fe Change selected table row text to be white. Issue #693 2019-08-03 16:25:35 -05:00
Maurice Parker 54f6607621 Keep table selections when root split isn't collapsed 2019-08-02 10:25:47 -05:00
Maurice Parker 2ab3ff76fb Make settings button work second split controller is installed 2019-08-01 07:10:02 -05:00
Maurice Parker ccd0385220 Prevent flicker when selected feed's unread count changes. 2019-07-30 13:08:58 -05:00
Maurice Parker 978aeeee80 Restore selection when currently select feed unread count changes 2019-07-27 15:05:21 -05:00
Maurice Parker adb6309872 In Three Pane Mode only show the progress indicator on the Feeds controller 2019-07-27 14:49:07 -05:00
Maurice Parker b25e789aef Prevent refresh errors from keeping the refreshControl visible when error dialogs are displayed. 2019-07-18 15:16:54 -05:00
Maurice Parker 6e59c56515 Move more logic out of MasterFeedViewController and into AppCoordinator 2019-07-06 12:25:45 -05:00
Maurice Parker 4884aebbfd Encapsulate more of the AppCoordinate API 2019-07-06 11:32:19 -05:00
Maurice Parker 15754684a4 Move more navigation responsibilities into the AppCoordinator 2019-07-05 17:45:39 -05:00
Maurice Parker 19f8f8bc97 Fix missing settings button on iPhone 2019-06-29 13:53:34 -05:00
Maurice Parker fcf2937394 Rename NavStateController to AppCoordinator because we are redesigning it to be the Coordinator pattern 2019-06-29 13:35:12 -05:00
Maurice Parker 188bacee25 Move nav state ownership to MasterFeedViewController 2019-06-27 16:30:24 -05:00
Maurice Parker 5f045706e4 Removed usaged of UIApplication.present 2019-06-27 14:21:07 -05:00
Maurice Parker 95d4395416 Fix feed / folder rename for iOS 2019-06-26 06:23:08 -05:00
Maurice Parker b877e4dc83 Move NavState ownership to the AppDelegate 2019-06-25 12:10:07 -05:00
Maurice Parker e8e0f3b8bd Temporarily disabled SwiftUI compiling 2019-06-23 17:41:41 -05:00
Stuart Breckenridge ec609bbe7d Adds section header background view
Stops collapsing sections from appearing under the section view header.
2019-06-20 17:24:23 +08:00
Maurice Parker 716653c235 Implement NetNewsWire Blue for cell selection and tint. Issue #691 & #692 2019-06-18 18:31:37 -05:00
Maurice Parker 58459631e4 Add SwiftUI account detail view 2019-06-13 14:30:56 -05:00
Maurice Parker 902304c723 Convert Settings to use SwiftUI 2019-06-11 16:59:16 -05:00
Maurice Parker e8992dac95 Fix issue where deletes were crashing the app. Issue #702 2019-06-05 17:42:35 -05:00
Maurice Parker e7c339fb09 Update iOS to work with the latest Account API 2019-05-30 17:41:56 -05:00
Maurice Parker c61949bc04 Add account name to network error messages and prevent background iOS errors from displaying alerts 2019-05-26 11:54:32 -05:00
Phil Viso 1271fc9081 Update UI when accounts change or when account state changes 2019-05-19 19:18:28 -05:00
Phil Viso 8c28160f91 Always clear selection on viewWillAppear 2019-05-19 18:39:15 -05:00
Phil Viso 2f82f05721 Improved sizing of add feed modal on iPad 2019-05-19 17:47:33 -05:00
Phil Viso 90ea9ebb50 Disable add new item button when there are no active accounts 2019-05-19 16:08:48 -05:00
Maurice Parker 0398021345 Restore feed if second part of move fails. 2019-05-16 12:42:01 -05:00
Maurice Parker 2401c96c99 Update iOS to work with latest from the Accounts framework 2019-05-09 17:30:36 -05:00
Maurice Parker e45362bffc Update iOS to work with new delete API. 2019-05-09 07:28:51 -05:00
Maurice Parker 636468bbf0 Implement active account processing functionality 2019-05-02 06:01:30 -05:00
Maurice Parker d2482233ab Change indent width to match other iOS outline view indent widths 2019-04-29 09:20:45 -05:00
Maurice Parker bf50c7a7e3 Update the nav controller title so that the back bar button item in iPad portrait has a valid title 2019-04-28 18:53:57 -05:00
Maurice Parker a071bf0f6e Slightly increased the favicon size 2019-04-28 16:54:45 -05:00
Maurice Parker c8b3442854 Change favicon placement so that it no longer centers on multiline rows 2019-04-28 16:51:34 -05:00
Maurice Parker dcb65f6454 Fix table section header background color 2019-04-28 15:53:16 -05:00
Maurice Parker c9d9045a7f Respond in realtime to dynamic type changes with the unread indicator 2019-04-28 15:44:35 -05:00
Maurice Parker 00cb29c5c1 Align separator insets with first letter of name 2019-04-28 14:56:36 -05:00
Maurice Parker 00f19f47aa Deleted debugging code that crept into the repo 2019-04-28 14:47:14 -05:00
Maurice Parker c4c67dec6e Fix typo that was causing unread counts to go missing. 2019-04-28 12:52:40 -05:00
Maurice Parker 38a3cde8a6 Force unread count updates to reload cells as they can change the height of cells now by reflowing the name 2019-04-28 12:37:53 -05:00
Maurice Parker 95430913bd Fix dynamic type edit cell layout bug 2019-04-28 12:08:50 -05:00
Maurice Parker 2662352541 Fix dynamic type bug in account section header layouts where the account name needed to wrap 2019-04-28 11:25:21 -05:00
Maurice Parker d7391b208d implement dynamic type for master feed list 2019-04-28 10:31:35 -05:00
Maurice Parker 7127f9a911 Change master feed list to use preferred fonts. 2019-04-27 09:49:26 -05:00
Maurice Parker 81f7332f3c Add settings scene. 2019-04-25 18:06:53 -05:00
Maurice Parker cabd2b8efc Implement Settings layout. 2019-04-25 06:05:49 -05:00
Maurice Parker 12d4d2dbb1 Rename classes to more accurately describe their usage in the application. 2019-04-23 08:00:27 -05:00