Commit Graph

4648 Commits

Author SHA1 Message Date
Maurice Parker 6500df159c Merge branch 'ios-candidate' of https://github.com/brentsimmons/NetNewsWire into ios-candidate 2020-01-07 14:17:13 -07:00
Maurice Parker dff6c1b9c4 Change to use correct favicon downloader function. Issue #1552 2020-01-07 14:17:00 -07:00
Mihael Cholakov af5fd716fd Reset unintended CodingGuidelines changes 2020-01-07 09:51:09 +02:00
Mihael Cholakov 593a802d79 Merge branch 'upstream-ios-candidate' into previewing-articles 2020-01-07 09:47:00 +02:00
Brent Simmons 97b188bac3 Bump build to 26. 2020-01-06 20:27:53 -08:00
Maurice Parker 8a670afbe5 Merge branch 'ios-candidate' of https://github.com/brentsimmons/NetNewsWire into ios-candidate 2020-01-06 21:23:55 -07:00
Maurice Parker 746d061dcf Refresh UI (including progress indicator) on Timeline when coming out of suspend. 2020-01-06 21:23:39 -07:00
Brent Simmons 2176ebece2 Bump build to 25. 2020-01-06 18:50:28 -08:00
Brent Simmons 7cf9ae3229 Delete a blank line. (Maybe got pushing working now?) 2020-01-06 18:24:57 -08:00
Brent Simmons 7a7557ac39 Delete empty line. (Trying to debug why I can’t push.)) 2020-01-06 18:23:46 -08:00
Brent Simmons c583c4d474 Fetch both read and unread orphaned statuses. 2020-01-06 18:18:27 -08:00
Maurice Parker 9ba0b37cf9 Make progress bar less jumpy. Issue #14 2020-01-06 19:09:46 -07:00
Maurice Parker bd7449cc84 Change refresh indicator to never use seconds. Issue #1524 2020-01-06 18:43:23 -07:00
Maurice Parker 9550b29a01 Move filter button to bottom left. Issues #1525 and #1527 2020-01-06 18:32:17 -07:00
Maurice Parker c0f76d0dbb Change Mark All as Read icon. Issue #1526 2020-01-06 18:07:04 -07:00
Maurice Parker 7824939c30 Make OPML generate in a consistent order when the Web Feed name is the same. Issue #1545 2020-01-06 13:58:51 -07:00
Mihael Cholakov 36230d930e Context menu now previews selected article 2020-01-06 14:52:18 +02:00
Mihael Cholakov d1004569b2 Merge branch 'upstream-ios-candidate' into previewing-articles 2020-01-06 14:45:10 +02:00
Brent Simmons f84abb81e2
Merge pull request #1538 from kielgillard/feedly-operation-string-keypaths
Use string-based key paths instead of Swift key paths…
2020-01-05 17:09:14 -08:00
Kiel Gillard 6922b6ddec Use string-based key paths instead of Swift key paths for FeedlyOperation. #1481 2020-01-06 08:59:08 +11:00
Brent Simmons 4184202806
Merge pull request #1533 from hartlco/1517-sharing-article-to-omnifocus-leaves-new-item-title-blank
Share string with subject and URL instead of plain URL for Omnifocus and Things
2020-01-05 12:54:03 -08:00
Martin Hartl 12731c2e39 Share string with subject and URL instead of plain URL for Omnifocus and Things 2020-01-05 07:36:30 +01:00
Brent Simmons a405951f6d
Merge pull request #1529 from hartlco/1485-Add-mark-above-as-read-keyboard-shortcut
Add keyboard shortcut for “Mark Above as Read” #1485
2020-01-04 15:41:09 -08:00
Martin Hartl d96a2b4097 Add keyboard shortcut for “Mark Above as Read” 2020-01-04 09:42:29 +01:00
Maurice Parker 5cd163e1e4 Add refresh indicator to the Timeline. Issue #15 2020-01-03 14:23:37 -07:00
Maurice Parker 5a7863d447 Rollback pull to refresh on the timeline and modified pull to refresh control. Issue #1520 2020-01-03 08:42:43 -07:00
Maurice Parker b7f3612686
Merge pull request #1522 from hartlco/1485-Add-mark-below-mark-above-as-read
Replace “Mark Older as Read” actions with “Mark Above/Below as Read” actions #1485
2020-01-03 08:27:17 -07:00
Martin Hartl 5ee491ebee Replace “Mark Older as Read” actions with “Mark Above/Below as Read” actions 2020-01-03 09:00:25 +01:00
Maurice Parker e26a00ddfe Enable pull to refresh on timeline and change refresh indicator to better show when it is successfully pulled. Issue #1520 2020-01-02 21:08:21 -07:00
Maurice Parker c3fbf88fbb Add check so that we don't update article statuses for articles that we have pending statuses to send. Issue #1515 2020-01-02 18:21:18 -07:00
Brent Simmons e773c11571
Merge pull request #1509 from timothyekl/account-test-api-updates
Update Account tests for new async API
2020-01-02 16:12:17 -08:00
Tim Ekl 44e920b18b Don't explicitly name error variables
Following the resolution of #1512, start using the implicit `error`
variable inside `catch` blocks instead of explicitly declaring `e`
everywhere.
2020-01-02 13:31:06 -08:00
Maurice Parker c2d1f1c85a
Merge pull request #1514 from hartlco/1503-delete-should-be-at-the-bottom-of-the-context-menu
Switch order of context menu items to show delete at the bottom #1503
2020-01-02 11:02:37 -07:00
Martin Hartl 7b0261b401 Switch order of context menu items to show delete at the bottom 2020-01-02 08:16:29 +01:00
Brent Simmons 3d09345ea3 Update to latest RSParser, which fixes a crashing bug. 2020-01-01 22:25:40 -08:00
Brent Simmons a2005fce88 Add note to coding guidelines about using the magic error, oldValue, and newValue variables. It’s totally okay to use these. Fix #1512. 2020-01-01 17:36:08 -08:00
Brent Simmons 5709c1c58a Remove references to DB5. 2020-01-01 17:30:42 -08:00
Brent Simmons a5a3d9309b
Merge pull request #1511 from kielgillard/feedly-operation-fixup
Indicate FeedlyOperation is asychronous.
2020-01-01 15:19:01 -08:00
Kiel Gillard 2ee50054dc Indicate FeedlyOperations are asynchronous. 2020-01-02 10:00:09 +11:00
Kiel Gillard f455bcec16 Models the feed website url of feedly articles as an optional since it seems the Feedly API will not always provide one. Issue #1449. 2020-01-02 09:34:24 +11:00
Tim Ekl 5ac18b14a7 Add missing expectations to send statuses tests
f82be27666 flipped around calls to `selectPendingCount(_:)` so that it
respected the new async nature of the method; however, it neglected to
add enough XCTestExpectations to keep the test methods running through
the callbacks. Add those here.
2020-01-01 13:39:17 -08:00
Brent Simmons b9d68d4ac0 Merge branch 'ios-candidate' of https://github.com/brentsimmons/NetNewsWire into ios-candidate 2019-12-31 18:59:04 -08:00
Brent Simmons cea34c9e49 Update RSCore. 2019-12-31 18:58:57 -08:00
Brent Simmons df13d108aa Update to latest RSCore. 2019-12-31 18:46:13 -08:00
Brent Simmons fedfb24220
Merge pull request #1506 from Wevah/ios-blockquote-tweaks
iPhone 8 Plus viewport is actually 414px wide
2019-12-31 18:37:58 -08:00
Nate Weaver 53b2ebab78 iPhone 8 Plus viewport is actually 414px wide 2019-12-31 20:30:37 -06:00
Brent Simmons c2a7f8501e
Merge pull request #1505 from Wevah/ios-blockquote-tweaks
Don't shrink margins for wider viewports (e.g., landscape)
2019-12-31 18:11:37 -08:00
Nate Weaver b5467bb81c Don't shrink margins for wider viewports (e.g., landscape) 2019-12-31 20:08:40 -06:00
Brent Simmons dcb6f06792
Merge pull request #1504 from Wevah/ios-blockquote-tweaks
Tweak blockquote margins for small viewports
2019-12-31 17:56:14 -08:00
Nate Weaver 95db828986 Tweak blockquote margins for small viewports 2019-12-31 19:47:09 -06:00