Kiel Gillard
39c7bdb5e2
Give this test a bit more time to execute on a stressed system.
2019-11-09 21:44:13 +11:00
Kiel Gillard
b8f7e3f519
Use ASWebAuthenticationSession to authenticate Feedly users and grant NNW access tokens.
2019-11-09 21:44:13 +11:00
Maurice Parker
9846428071
Update Feedbin tests to match latest functionality.
2019-11-07 19:36:31 -06:00
Maurice Parker
6b2ecdaca0
Merge branch 'mac-release'
2019-11-07 19:17:53 -06:00
Maurice Parker
e2434e620c
Get extended subscription information from Feedbin. Issue #917
2019-11-07 19:07:10 -06:00
Kiel Gillard
4c9e98c150
Ensures refresh tokens occurs before syncing. Implements cancelAll for Feedly.
2019-11-07 20:44:51 +11:00
Kiel Gillard
6bef313937
Feedly accounts now refresh their access tokens on initialisation.
2019-11-07 18:55:05 +11:00
Kiel Gillard
434b11ed17
Ensures Feedly status operations finish at the right time. In part, this is achieved by adding and using completion handlers to the asynchronous ensure status API.
2019-11-06 13:26:12 +11:00
Kiel Gillard
1a1ee0fa17
Fixes an issue where sending article statuses to Feedly was finishing prematurely.
2019-11-06 11:22:10 +11:00
Maurice Parker
098f5050eb
Cancel local account network activity when told to shutdown by the OS. Issue #1232
2019-11-04 20:41:08 -06:00
Maurice Parker
f6e48bddbe
Merge branch 'master' of https://github.com/brentsimmons/NetNewsWire
2019-11-04 20:24:27 -06:00
Maurice Parker
c6e3ed6692
Cancel network activity when told to shutdown by the OS. Issue #1232
2019-11-04 20:24:21 -06:00
Kiel Gillard
bfac176372
Modifies SyncDatabase to synchronously create tables so clients can reliably use an instance immediately after initialisation.
2019-11-05 10:03:29 +11:00
Maurice Parker
219e5751a1
Merge pull request #1144 from kielgillard/master
...
Syncs articles in pages, decouples article syncing from status syncin…
2019-11-04 14:29:22 -06:00
Maurice Parker
2f2efb5eac
Change Feedbin to no longer clear lastFetchDate on errors. Issue #1233
2019-11-02 16:21:37 -05:00
Kiel Gillard
4f70cb6040
Improves test coverage in Feedly. Adds callbacks to SyncDatabase. Content is paged from Feedly. Unread status is set before articles are ingested.
2019-11-02 10:29:34 +11:00
Brent Simmons
4cb602f24a
Merge mac-release.
2019-10-26 12:44:33 -07:00
Brent Simmons
3354d5a569
Delete articles and statuses from feeds no longer subscribed-to. At startup. Fix #899 .
2019-10-24 22:28:26 -07:00
Brent Simmons
cd4135bf9a
Remove old, comment-out update method in ArticlesTable.
2019-10-24 21:48:24 -07:00
Jonathan Bennett
48e47ec40b
Allow adding of feeds
2019-10-24 11:48:12 -04:00
Jonathan Bennett
77fc1bd8fe
Merge branch 'master' into feature/feed-wrangler
...
# Conflicts:
# submodules/RSCore
2019-10-23 21:10:57 -04:00
Ryan Dotson
48fb3ebc18
Curled some quotes
2019-10-22 19:58:05 +09:00
Daniel Jalkut
79d641e6ee
Remove the binary Sparkle framework and add newer sandboxing-compatible Sparkle branch as a submodule dependency. Update to get it roughly building and working with the direct build.
2019-10-21 23:41:57 -04:00
Maurice Parker
af16731ecd
Add the ability to specify folder in Add Feed shortcut
2019-10-20 18:49:17 -05:00
Brent Simmons
68687059d3
Avoid embedding frameworks in extensions and in Account.framework. Fix some Info.plist glitches.
2019-10-19 22:31:06 -07:00
Jonathan Bennett
4dea5e2cbb
use URLQueryItem helper
2019-10-17 13:59:43 -04:00
Jonathan Bennett
2c150ae685
Merge branch 'master' into feature/feed-wrangler
...
# Conflicts:
# Frameworks/Account/Account.xcodeproj/project.pbxproj
# submodules/RSWeb
2019-10-17 13:34:54 -04:00
Maurice Parker
579717dd86
Move extensions for compositing query items to RSWeb
2019-10-17 06:01:08 -05:00
Jonathan Bennett
d70c996c06
use the URLQueryItem helper
2019-10-17 01:56:42 -04:00
Jonathan Bennett
ae014375ed
QueryItem helper
2019-10-17 01:37:22 -04:00
Jonathan Bennett
09faf1a0c2
start supporting article sync
2019-10-17 01:05:18 -04:00
Jonathan Bennett
c7d0d23146
add page size configuration option
2019-10-16 15:06:01 -04:00
Jonathan Bennett
81bffda093
allow removal of feeds
2019-10-16 11:43:49 -04:00
Jonathan Bennett
36861f2eb3
allow renaming of feeds
2019-10-16 11:32:22 -04:00
Jonathan Bennett
d1b4c20494
append query items, don't overwrite everything
2019-10-16 11:12:55 -04:00
Jonathan Bennett
d26b3b9917
Merge branch 'feature/feed-wrangler-refresh-feeds' into feature/feed-wrangler
2019-10-16 10:05:31 -04:00
Maurice Parker
acbbee870e
Rename Feedbin specific tests to reflect the specificity and move them to a Feedbin folder
2019-10-16 08:36:21 -05:00
Maurice Parker
f17a278349
Fix randomly failing Feedbin test
2019-10-16 08:30:37 -05:00
Jonathan Bennett
1d6519cce9
Merge branch 'master' into feature/feed-wrangler
2019-10-16 09:24:14 -04:00
Jonathan Bennett
51dc82ffef
use swiftier property names
2019-10-16 09:04:24 -04:00
Jonathan Bennett
d80aeefdb3
Allow refreshing of Feed Wrangler subscriptions
2019-10-16 08:30:11 -04:00
Kiel Gillard
05cb3773de
Follows the continuation until the starred articles stream has been consumed.
2019-10-16 22:12:37 +11:00
Jonathan Bennett
86caa869fc
Merge branch 'master' into feature/feed-wrangler
...
# Conflicts:
# Frameworks/Account/Account.xcodeproj/project.pbxproj
2019-10-16 05:48:03 -04:00
Kiel Gillard
16be64c440
Feedly: removes redundant mapping of articles to feed IDs.
2019-10-16 17:35:28 +11:00
Kiel Gillard
2b0413224a
Fixes failing Feedly tests and improves debugging mock network responses.
2019-10-16 09:37:35 +11:00
Kiel Gillard
2ecdf92f40
Tweaking the logging to be more useful.
2019-10-15 18:39:09 +11:00
Kiel Gillard
0d20bccc55
Send and receive starred articles, refactoring status syncing code into operations for better code reuse.
2019-10-15 18:31:24 +11:00
Brent Simmons
7b09c86858
Use the new article saving function for both Feedly and ReaderAPI.
2019-10-13 19:32:46 -07:00
Brent Simmons
c04322990c
Merge branch 'mac-release'
2019-10-13 19:24:06 -07:00
Brent Simmons
fcb0f0c439
Remove a no-longer-used Account.update function — we have a new one that’s way faster. Also: assert that we’re in the main thread in that new update function.
2019-10-13 19:23:36 -07:00
Brent Simmons
c5e0d96adb
Merge changes from mac-release, including performance fix.
2019-10-13 19:08:27 -07:00
Brent Simmons
1d0cacd5fc
When syncing, update the database by articleIDs rather than by feeds — this means *far* fewer fetches and much less data pulled from the database. It should help app responsiveness dramatically during sync, and especially during an initial sync.
2019-10-13 19:02:56 -07:00
Brent Simmons
099172d9d2
Empty the database articles cache when NetNewsWire moves to the background. This helps prevent the cache from growing forever.
2019-10-12 15:06:21 -07:00
Maurice Parker
ee1f26899c
Add Test build configuration
2019-10-11 17:38:01 -05:00
Kiel Gillard
438338ac9f
Refactor add and create feeds since they differ only by refreshing after adding.
2019-10-11 20:32:21 +11:00
Kiel Gillard
e0b35d6854
Add feed request
2019-10-11 18:14:23 +11:00
Maurice Parker
02128b8b12
Add VerifyNoBS script on framework projects
2019-10-10 13:58:31 -05:00
Kiel Gillard
d1e4c84a9e
Refactoring create feed
2019-10-10 21:25:14 +11:00
Kiel Gillard
7cac3e6238
Simplifying operations to improve their reusability and composability
2019-10-10 21:25:14 +11:00
Maurice Parker
df79422185
Remove provisioning profile
2019-10-10 00:32:18 -05:00
Maurice Parker
0b5be9057f
Correct build configuration for CI build
2019-10-10 00:24:36 -05:00
Kiel Gillard
3089f2332e
Show progress while fetching the content of a newly created feed.
2019-10-09 19:47:15 +11:00
Kiel Gillard
13197054bf
Implement restore folders. Not sure how to test this.
2019-10-09 19:44:52 +11:00
Kiel Gillard
dedce600a4
Implement restore feeds. Not sure how to test this.
2019-10-09 19:42:12 +11:00
Kiel Gillard
a965677687
Fetch the contents of the feed when first adding it
2019-10-09 19:38:16 +11:00
Kiel Gillard
614628883f
Use a suitable error for unexpectedly failing to add a feed
2019-10-09 19:15:48 +11:00
Kiel Gillard
92fa66f345
Refresh progress updates for changes which cannot be applied immediately and restored on failure
2019-10-09 19:06:59 +11:00
Kiel Gillard
41ca023c31
Implements creating, updating, moving and removing feeds.
2019-10-09 18:38:28 +11:00
Maurice Parker
590b2d5874
Remove explicit dependencies and fix iOS sync database dependency
2019-10-07 10:53:05 -05:00
Jonathan Bennett
0c2185ae25
fix db file extension
2019-10-07 10:22:10 -04:00
Maurice Parker
88f5ca24dd
Remove problematic build settings
2019-10-06 19:29:43 -05:00
Maurice Parker
c43599d4c9
Fix default team for framework projects
2019-10-06 18:58:28 -05:00
Maurice Parker
6d2667de24
Remove build settings from sync database project file
2019-10-06 18:36:39 -05:00
Brent Simmons
50276233d1
Add feeds all in one go when processing Feedbin subscriptions. This is a performance enhancement.
2019-10-06 12:37:46 -07:00
Kiel Gillard
39d3999a0d
2019-10-06 13:22:36 +11:00
Maurice Parker
0000e03083
Add the ability to handoff from iOS to Mac
2019-10-03 15:49:27 -05:00
Maurice Parker
0c9a1ba8d0
Add notification deep linking for iOS
2019-10-03 09:53:21 -05:00
Kiel Gillard
e1b0e17b6a
Allows folders to efficient add and remove many feeds.
2019-10-03 18:45:16 +10:00
Kiel Gillard
56a92e7938
Adds unit testing and implements fixes for unread counts, icons, missing metadata and more.
2019-10-03 18:06:49 +10:00
Brent Simmons
1cfafe3014
Add feeds from Feedbin all in one go, which helps performance by not triggering Account’s rebuilding of its feedDictionary.
2019-10-02 23:05:35 -07:00
Maurice Parker
cc187875d9
Add initial support for per feed notifications
2019-10-02 19:42:16 -05:00
Maurice Parker
aba0d15cb6
Modify background fetch so that it doesn't have to use a background process
2019-10-02 16:41:32 -05:00
Maurice Parker
281416eaee
Make sure metadata gets saved if background fetch is performed.
2019-10-02 15:32:34 -05:00
Kiel Gillard
8f53916a79
Make Account framework tests compile and pass.
2019-09-30 17:17:58 +10:00
Brent Simmons
13eb6450c7
Merge branch 'mac-release'
2019-09-28 13:52:07 -07:00
Brent Simmons
37c9818cad
Create and use a cache for DatabaseArticle — this will make fetches faster, since we can skip pulling the same data from the database over and over. Articles in the cache are removed when articles are updated, so the cache is never stale.
2019-09-28 13:51:33 -07:00
Brent Simmons
2b491217f3
Create statusWithRow(_ row: FMResultSet, articleID: String) — it allows us to avoid pulling articleID from the row twice every time we’re creating a DatabaseArticle.
2019-09-28 12:18:08 -07:00
Brent Simmons
d7b45a1413
Change parseDatePublished() to a lazy var parsedDatePublished — it appeared that it was getting called more than once, and date parsing is expensive. Also: use RSDateWithString rather than an NSDateFormatter, since NSDateFormatter is so massively slow.
2019-09-27 23:01:31 -07:00
Jonathan Bennett
59c768abae
externalize keys
2019-09-28 01:59:49 -04:00
Jonathan Bennett
50428f3179
Allow adding Feed Wrangler accounts
2019-09-28 01:59:49 -04:00
Kiel Gillard
060366f447
Implements creating, updating and deleting Folders/Collections. Issues #1044 #1048
2019-09-27 21:47:30 +10:00
Maurice Parker
6536dbf2a5
Use correct account method for adding folders
2019-09-27 06:38:43 -05:00
Kiel Gillard
465b6e789b
Sends and receives unread statuses #1058 . Also implements OMPL import #1043 .
2019-09-27 08:26:18 +10:00
Maurice Parker
e60ce37dc9
Merge branch 'mac-release'
2019-09-26 11:49:53 -05:00
Maurice Parker
90834fe6b1
Delete conditional get information for taggings if it looks like Feedbin may have renamed a folder. Issue #1050
2019-09-26 11:35:07 -05:00
Maurice Parker
b721f74e17
Merge branch 'mac-release'
2019-09-25 17:09:21 -05:00
Maurice Parker
c4ee1edb69
Add externalID to Folder and persist it to OPML file. Issue #1060
2019-09-25 17:01:09 -05:00
Maurice Parker
833a789e6e
Merge branch 'mac-release'
2019-09-25 15:39:14 -05:00
Maurice Parker
08a8b8f6c2
Update to Swift 5.1
2019-09-25 15:32:30 -05:00
Maurice Parker
8b5cc817c6
Override code_sign_identity
2019-09-25 10:49:55 -05:00
Maurice Parker
d096c44ef5
Fixed Articles xcconfig parameters
2019-09-25 10:38:13 -05:00
Maurice Parker
e2a25e6239
Require 13.0 deployment target for iOS in frameworks
2019-09-25 10:13:15 -05:00
Maurice Parker
46c737c777
Make sure delegates get set even if a metadata file isn't found. Issue #1051
2019-09-24 06:56:39 -05:00
Maurice Parker
cb394a2a61
add APPLICATION_EXTENSION_API_ONLY build setting
2019-09-23 19:56:16 -05:00
Maurice Parker
eaf798991f
Remove name from the feed metadata as we manage it using the OPML file instead
2019-09-23 12:29:48 -05:00
Maurice Parker
59991d0478
Save resource files immediately in the share extension
2019-09-23 11:09:40 -05:00
Maurice Parker
de994a305e
Remove dead code.
2019-09-23 10:35:48 -05:00
Maurice Parker
0424ba3bb7
Make unread counts show up for new feeds added by share extension
2019-09-23 10:27:17 -05:00
Maurice Parker
6f9d3953f1
Ensure that account metadata gets propagated to delegates when it reloads
2019-09-23 09:57:50 -05:00
Maurice Parker
0709b006f4
Add feed meta data did change notification
2019-09-22 21:42:49 -05:00
Maurice Parker
124997feca
Reset feed to feed metadata relationship on reload
2019-09-22 21:20:01 -05:00
Maurice Parker
20fa5d9e48
Implement keychain groups
2019-09-22 16:00:06 -05:00
Maurice Parker
43bed44d46
Merge branch 'mac-release'
2019-09-20 11:42:06 -05:00
Maurice Parker
ea13f911f1
Change to ignore unsupported accounts instead of crashing
2019-09-20 11:41:28 -05:00
Maurice Parker
af0d6c9022
Implement AccountBehaviors so that we don't have to keep adding boolean flags to account
2019-09-20 11:34:31 -05:00
Maurice Parker
f3a1b074ac
Call download progress on the main queue
2019-09-20 10:16:51 -05:00
Kiel Gillard
1d965142d9
Initial implementation FeedlySyncStrategy and basic usability improvements to allow for downloading and reading articles without crashing.
2019-09-20 16:56:51 +10:00
Maurice Parker
5e48c45d78
Make article extract feed flag optional
2019-09-19 20:12:55 -05:00
Maurice Parker
d67c9144f5
Add Reader View is always on preference for Feeds
2019-09-19 19:49:11 -05:00
Kiel Gillard
9cc5fa3608
Initial implementation allowing Feedly accounts to be added given the Feedly user's consent.
2019-09-19 10:11:53 +10:00
Maurice Parker
8e939e9942
Change Credentials to be a struct instead of an enum
2019-09-15 10:03:47 -05:00
Maurice Parker
530e9ca60f
Change writing options for resource files to none
2019-09-13 16:58:10 -05:00
Maurice Parker
82d4e0e3b3
Fixed metadata name suffixes
2019-09-13 16:41:08 -05:00
Maurice Parker
7b29eaab7a
Make feed metadata a managed resource file
2019-09-13 16:35:53 -05:00
Maurice Parker
b24e6a4725
Make account metadata a managed resource file
2019-09-13 16:12:19 -05:00
Maurice Parker
f7bb58ea4d
Modify OPMLFile to use the new ManagedResourceFile utility class
2019-09-13 15:46:22 -05:00
Maurice Parker
f924eb91ff
Fix log category name
2019-09-13 14:56:24 -05:00
Maurice Parker
762e230200
Add file coordination for the OPML file
2019-09-13 10:48:04 -05:00
Maurice Parker
4d118d89db
Move more OPML file management functions to the OPMLFile class
2019-09-13 10:15:11 -05:00
Maurice Parker
7de08e992e
Add the ability to observe OPML file changes
2019-09-12 18:41:42 -05:00
Maurice Parker
83476baa5b
Move OPML I/O functions into a separate OPMLFile class
2019-09-12 18:05:29 -05:00
Maurice Parker
5985b00480
Inject the Accounts folder name so that it can be in different locations between the iOS and Mac Apps.
2019-09-12 10:59:26 -05:00
Brent Simmons
03bf97df90
Fix parts of ReaderAPI implementation that I broke with an API change in Account.
2019-09-08 21:52:02 -07:00
Brent Simmons
2eccfbb90e
Merge branch 'mac-release'
2019-09-08 21:44:28 -07:00
Brent Simmons
41c82eca15
Rename existingFeed(with:) to existingFeed(withFeedID:) to make it more clear. Make account.idToFeedDictionary private — callers should use existingFeed(withFeedID:).
2019-09-08 21:44:05 -07:00
Brent Simmons
f5f306f60f
Add comments to feed.iconURL and feed.faviconURL, explaining that these are set only if that info was part of the feed (which is a JSON-Feed-only feature).
2019-09-08 21:17:57 -07:00
Maurice Parker
c4f7090b9c
Automatically expand any activated accounts and clean up the expandedNodes table for inactivated accounts
2019-09-08 09:58:27 -05:00
Maurice Parker
e61efbe47a
Split AccountsDidChange notification into both add and delete notifications and automatically expanded new accounts on iOS
2019-09-08 09:43:51 -05:00
Maurice Parker
d9ea35b6f6
Merge branch 'mac-release'
2019-09-08 04:29:37 -05:00
Maurice Parker
7ca2226669
Move credentials classes to the Account framework in NetNewsWire
2019-09-08 04:28:43 -05:00
Maurice Parker
ab0ca49882
Added new OAuth credentials
2019-09-06 17:38:48 -05:00
Maurice Parker
6cf1e4539d
Merge branch 'mac-release'
2019-09-01 10:51:22 -05:00
Maurice Parker
e31dec7c44
Call completion handler when there are no feeds associated with the folder being removed. Issue #938
2019-09-01 10:49:35 -05:00
Maurice Parker
fe2e0155da
Add scoped searching of articles
2019-08-31 15:53:47 -05:00
Maurice Parker
995fca5d6a
Updated FreshRSS to pull statuses before articles and to work with the new sync status API's
2019-08-30 11:47:08 -05:00
Maurice Parker
ea1f21797c
Merge branch 'mac-release'
2019-08-30 11:28:16 -05:00
Maurice Parker
a69be4117a
Retrieve statuses before articles during sync process and default starred articles to read if there isn't an unread status Issue #868
2019-08-30 10:39:52 -05:00
Daniel Jalkut
a5a36e0986
Fix for #885 : Include 403 status code in list of errors to prompt with 'update credentials' error message, and expand that message to cover the possibility an account is no longer valid with the service, i.e. in the case of an expired Feedbin subscription.
2019-08-28 11:40:12 -04:00
Brent Simmons
1ab0f7c25c
Merge mac-candidate.
2019-08-21 21:44:07 -07:00
Brent Simmons
bffda93700
Give has(feed) a default implementation in Container.swift.
2019-08-21 21:07:40 -07:00
Brent Simmons
fe2d329301
Make has(feed) a Container protocol method.
2019-08-21 21:05:47 -07:00
Brent Simmons
f513741ddb
Start work on filtering timeline so that articles from deleted feeds never show up.
2019-08-21 13:23:46 -07:00
Brent Simmons
2027e83504
Merge branch 'mac-candidate'
2019-08-12 09:43:48 -07:00
Brent Simmons
f8c8fc5f34
Fix crashing bug with marking all as read via contextual menu. Implement feed.fetchUnreadArticles.
2019-08-12 09:43:29 -07:00
Brent Simmons
7732eff01e
Merge branch 'mac-candidate'
2019-07-27 12:30:34 -07:00
Brent Simmons
f824be2f16
Change Today feed from 28 hours to 24 hours, since 24 hours is less weird and more easily explainable.
2019-07-27 12:30:13 -07:00
Brent Simmons
4667e533fc
Merge branch 'mac-candidate'
2019-07-24 09:27:34 -07:00
Brent Simmons
9edc726065
Make the Today smart feed show articles from the last 28 hours, so it doesn’t surprise people by emptying out at midnight.
2019-07-24 09:27:03 -07:00
Maurice Parker
e263665a21
Merge branch 'mac-candidate'
2019-07-23 16:36:46 -05:00
Maurice Parker
4fc1998cf3
Make Account and AccountDelegate interfaces more consistent by requiring the container parameter on removeFeed. Resolves #802
2019-07-17 15:41:21 -05:00
Jeremy Beker
9b552d8003
Remove DispatchQueue.main.sync calls that are not appropriate anymore
2019-07-13 08:47:00 -04:00
Jeremy Beker
fe9129ac4a
Use Feed Finder before attempting to add feed urls
2019-07-13 08:37:08 -04:00
Brent Simmons
0d5ebad782
Merge branch 'mac-candidate'
2019-07-08 23:10:41 -07:00
Brent Simmons
055e0f09ad
Update code formatting in Account.
2019-07-08 23:06:40 -07:00
Brent Simmons
1e998543a5
Use right single curly quote instead of foot mark in error messages.
2019-07-08 22:59:29 -07:00
Brent Simmons
21faa0ddc0
Update code formatting in some files in Account.framework.
2019-07-08 22:58:19 -07:00
Brent Simmons
d1c9fc02d8
Merge branch 'mac-candidate'
2019-07-08 22:31:11 -07:00
Brent Simmons
1a03bcf03c
Make code formatting match current style.
2019-07-08 22:22:31 -07:00
Brent Simmons
cc458ecab7
Make code formatting match current style.
2019-07-08 22:20:57 -07:00
Brent Simmons
5d3cd8889f
Make optionalIntForColumn an extension method on FMResultSet.
2019-07-08 22:20:46 -07:00
Brent Simmons
c6907b73f9
Make code formatting in AttachmentsTable match current style.
2019-07-08 22:13:30 -07:00
Brent Simmons
bed1620ae4
Make code formatting in AuthorsTable match current style.
2019-07-08 22:11:24 -07:00
Brent Simmons
1d2ea8a4af
Make code formatting in StatusesTable match ourrent style.
2019-07-08 22:09:28 -07:00
Brent Simmons
8422122816
Delete a few unused lines of code.
2019-07-08 21:47:11 -07:00
Brent Simmons
72fa80956a
Make code formatting in ArticlesTable match current style. Also: normalize MARK comments.
2019-07-08 21:35:29 -07:00
Brent Simmons
011054b345
Remove some unused code.
2019-07-08 21:22:06 -07:00
Brent Simmons
3c4379dfeb
Merge branch 'mac-candidate'
2019-07-08 21:13:00 -07:00
Brent Simmons
33ff7c94c3
Make articlesTable.ensureStatuses non-blocking.
2019-07-08 21:09:54 -07:00
Brent Simmons
3d0d6fa8a9
Mark function as having @discardableResult, because we don’t always care about the result.
2019-07-08 21:09:16 -07:00
Brent Simmons
b1c96fddf8
Use async article ID fetches.
2019-07-07 19:56:52 -07:00
Brent Simmons
783477c58e
Merge branch 'mac-candidate'
2019-07-07 15:07:21 -07:00
Brent Simmons
36791fc3ad
Make fetching article IDs async — use a callback rather than a fetch sync and a returned value.
2019-07-07 15:05:36 -07:00
Brent Simmons
424daa0a5c
Merge branch 'mac-candidate'
2019-07-07 14:26:05 -07:00
Brent Simmons
597c57e61c
Remove references to DispatchQueue.main.sync and assert that we’re on the main thread.
2019-07-07 14:24:50 -07:00
Brent Simmons
1e82ad4845
Note that AccountManager is main thread only. Add an assert in a strategic location (activeAccounts property).
2019-07-07 14:05:27 -07:00
Brent Simmons
590961fb2c
Add comment that Account is main-thread-only, and assert that we’re on the main thread in flattenedFeeds().
2019-07-07 14:01:44 -07:00
Brent Simmons
a5bf148d82
Make Transport callbacks run on the main thread, which is consistent with NetNewsWire’s general pattern for these types of callbacks. This helps avoid situations where we touch model objects (which are main-thread-only) on a background thread.
2019-07-07 13:42:24 -07:00
Brent Simmons
fe5570fbea
Merge branch 'mac-candidate'
2019-07-06 11:54:14 -07:00
Brent Simmons
a68ca58242
Remove a precondition that is no longer valid when doing async fetches.
2019-07-06 11:50:22 -07:00
Brent Simmons
aab318023c
Update ReaderAPI to use changed database fetch API.
2019-07-05 22:46:02 -07:00
Brent Simmons
3999c7b3c5
Merge branch 'mac-candidate'
2019-07-05 22:42:01 -07:00
Brent Simmons
7a204ad6ed
Run database fetches async, in the timeline, when appropriate — for instance, when All Unread is selected and new articles come in.
2019-07-05 20:06:31 -07:00
Maurice Parker
5f045706e4
Removed usaged of UIApplication.present
2019-06-27 14:21:07 -05:00
Maurice Parker
9653befb94
Retrieve credentials if necessary. On iOS credentials aren't always available when the delegate initializes.
2019-06-23 13:56:11 -05:00
Maurice Parker
1ac1144b2d
Reduce footprint of Account credentials API
2019-06-20 11:19:15 -05:00
Maurice Parker
2756e8f204
Ensure that invalid username/password combinations throw an error
2019-06-20 11:18:09 -05:00
Maurice Parker
fa62acb585
Rebrand Reader API to FreshRSS
2019-06-20 07:22:51 -05:00
Maurice Parker
74f84dc000
Restrict OPML import for Account types that don't support it
2019-06-19 17:50:32 -05:00
Maurice Parker
b4b80c51bc
Renamed google reader api to just reader api to make it consistent everywhere we use it
2019-06-19 15:40:03 -05:00
Jeremy Beker
15ae97f7c9
Merge branch 'master' into google_reader_compatible_syncing
2019-06-19 13:53:30 -04:00
Maurice Parker
d794240bd9
Merge branch 'mac-candidate'
2019-06-19 11:31:38 -05:00
Jeremy Beker
d87f68a006
Renamed GoogleReaderCompatible to just Reader
2019-06-19 12:25:37 -04:00
Jeremy Beker
52cb066dd4
Cleanup unused objects
2019-06-19 07:56:25 -04:00
Jeremy Beker
97585326c8
Merge branch 'master' into google_reader_compatible_syncing
...
# Conflicts:
# iOS/Settings/SettingsAddAccountView.swift
2019-06-18 15:38:59 -04:00
Maurice Parker
35866d558d
Only display active accounts for OPML import on iOS
2019-06-17 15:50:17 -05:00
Maurice Parker
47a7fa420d
Fixed error caused by updating to the latest from RSWeb
2019-06-16 14:55:48 -05:00
Maurice Parker
f6677367ec
use refresh indicator to track all network activity. Issue #759
2019-06-16 14:48:50 -05:00
Jeremy Beker
42203c0170
FIrst pass at OPML import. Broken.
2019-06-16 15:14:20 -04:00
Jeremy Beker
adf53add3a
removed unused page number function.
2019-06-16 13:15:36 -04:00
Jeremy Beker
17439c8c5e
Disbale and rename tags functional.
2019-06-16 13:14:23 -04:00
Jeremy Beker
41af536212
Rename feeds
2019-06-15 16:13:08 -04:00
Jeremy Beker
62afd312f0
Subscribing and loading initial articles functioning.
2019-06-15 15:46:13 -04:00
Jeremy Beker
029bcbda96
Merge cleanup.
2019-06-15 13:30:12 -04:00
Jeremy Beker
f54bc3569b
Merge branch 'master' into google_reader_compatible_syncing
...
# Conflicts:
# Frameworks/Account/Account.swift
# submodules/RSWeb
2019-06-15 12:34:50 -04:00
Jeremy Beker
e5eb8df333
Add feed working on backend, thread crash inside account code.
2019-06-15 12:27:21 -04:00
Maurice Parker
1208e319de
Updated to the Sparkle 1.21.3
2019-06-15 09:54:16 -05:00
Jeremy Beker
5490dac86d
Need to use rawValue to properly mark starred/read
2019-06-15 08:21:13 -04:00
Jeremy Beker
2128afd465
Refactor endpoints into an enum
2019-06-13 12:44:20 -04:00
Jeremy Beker
dac166cf58
Refactor status change calls.
2019-06-13 09:35:01 -04:00
Maurice Parker
871dbbb752
moved dispatch group notify to background thread as it was deadlocked with the dispatch group wait on app exit
2019-06-12 17:28:54 -05:00
Jeremy Beker
45c15c96aa
Marking read/unread functioning.
2019-06-12 16:41:44 -04:00
Maurice Parker
c1e89a2ae0
Updated to the latest RSWeb
2019-06-12 15:09:06 -05:00
Jeremy Beker
69c947bd65
Mark read/unread structure.
2019-06-11 16:42:28 -04:00
Jeremy Beker
dc60ebf1f8
Unread status is properly set when articles are downloaded from backend
2019-06-11 15:37:21 -04:00
Maurice Parker
17c04b2aef
Show the refresh progress bar when an OPML import starts. Issue #732
2019-06-10 16:17:54 -05:00
Jeremy Beker
9144ee71e5
Request article IDs and content.
2019-06-10 16:53:35 -04:00
Maurice Parker
93fbbd4cc3
Make sure that FeedFinder and InitialDownloader are running on the main thread.
2019-06-10 08:21:03 -05:00
Maurice Parker
f4e0cfaf2b
Fix folder renaming issue that occurs for Feedbin when the tag doesn't exist at Feedbin. Issue #724
2019-06-07 05:03:54 -05:00
Maurice Parker
eb71e88845
Resolved issue where local account feed finder could lock up the UI if an error was thrown. Issue #720
2019-06-06 19:46:42 -05:00
Maurice Parker
e7ec59f31f
Merge pull request #725 from tgt/tgt/feedbin-fixes
...
Various Minor Feedbin Fixes
2019-06-06 15:27:06 -05:00
Maurice Parker
1cfc3bceef
Fixed restore folder functionality for Feedbin.
2019-06-06 15:22:25 -05:00
Tom Grimwood-Taylor
b0a24b6f17
Revert "Fix updating local feed list when no remote feeds."
...
cd85e52fdd
2019-06-06 14:23:06 +01:00
Tom Grimwood-Taylor
534da0bca6
Move call to sendArticleStatus to delegate.
2019-06-06 14:22:29 +01:00
Tom Grimwood-Taylor
0447694142
Fix feed selection when the max feed score is 0.
...
This occurs, for example, when searching for “macrumors.com” and adding
to the Feedbin account. All four feeds have a score of 0 since their
source is set as HTMLLink. This would also fix a case in which there are
two feeds: one with a negative score and one with a score of 0.
Since the method uses a Set the feed selected when there are multiple
feeds with an identical maximum score will be random.
2019-06-06 10:31:00 +01:00
Tom Grimwood-Taylor
ac9057299a
Remove edited name when remote feed name changes.
2019-06-06 10:31:00 +01:00
Tom Grimwood-Taylor
f3505e4537
Fix posting name notifications when name changes.
2019-06-06 10:31:00 +01:00
Tom Grimwood-Taylor
b4d7042a7b
Ensure status changes are sent before refresh.
...
When the refresh button was manually clicked a full refresh would occur,
but locally changed statuses wouldn't be sent. This meant the statuses
of items in NetNewsWire would revert to their remote values until an
automatic status sync was triggered.
2019-06-06 10:31:00 +01:00
Tom Grimwood-Taylor
3c1b84dd73
Fix a Feedbin subscriptionID going out of sync.
...
If, for example, a user deleted a feed and recreated it on the server
without a sync in between, the subscription ID for the feed would update
on the server, but remain unchanged locally. If the user then wanted to
delete or rename the feed they'd get a 404 error.
2019-06-06 10:31:00 +01:00
Tom Grimwood-Taylor
cd85e52fdd
Fix updating local feed list when no remote feeds.
...
When there were no remote feeds the logic to remove local
feeds was skipped.
2019-06-03 17:09:17 +01:00
Jeremy Beker
6b147e7dc9
Add feeds to tags. Set iconURLs
...
remove unused functions.
2019-06-01 17:05:55 -04:00
Jeremy Beker
a0efc7fda9
Cleanup tag names, fetch subscriptions
2019-06-01 08:08:19 -04:00
Jeremy Beker
76d1daf122
Cleanup merge issues/API changes
2019-06-01 06:54:10 -04:00
Maurice Parker
2d91e64148
Provide a better error message when encountering feed not found and already subscribed errors
2019-05-31 17:24:43 -05:00
Maurice Parker
8e0c857810
Update the extract page number function to make it more readable
2019-05-31 13:38:33 -05:00
Jeremy Beker
98c32b9987
Merge branch 'master' into google_reader_compatible_syncing
2019-05-31 09:54:25 -04:00
Maurice Parker
88b2775076
Make sure that an account doesn't try persist to the disk in the time that it is logically deleted and when it is actually deallocated
2019-05-31 08:05:26 -05:00
Maurice Parker
fec3c69f4a
Remove Feedbin api workaround for unpropagated mode=extended parameter
2019-05-31 07:54:12 -05:00
Maurice Parker
10296a1b74
Clear the feed metadata on Feedbin feed delete
2019-05-31 07:47:05 -05:00
Maurice Parker
d602f894f6
Fix link parsing bug that causes crash
2019-05-31 07:22:28 -05:00
Maurice Parker
0ddb47aa32
Refactor feed finder to make it threadsafe
2019-05-30 17:35:08 -05:00