Commit Graph

233 Commits

Author SHA1 Message Date
Maurice Parker 560f36621f Add IconImage to encapsulate our icon processing logic 2019-11-05 18:05:57 -06:00
Brent Simmons 4cb602f24a Merge mac-release. 2019-10-26 12:44:33 -07:00
Brent Simmons 759f89ec84
Merge pull request #1170 from Wevah/row-swipe-icons
Use glyphs from SF Symbols for table row swipe actions
2019-10-26 12:25:22 -07:00
Daniel Jalkut 2903e4507b Remove references to WebKit preferences that are not pertinent in 10.15. 2019-10-26 14:23:44 -04:00
Brent Simmons f8376b807a Restore two-step process for OPML exporting. 2019-10-24 21:12:58 -07:00
Brent Simmons 1c06eb27e8 Create separate private extension. Make misc. code formatting changes to match current thinking. 2019-10-23 22:33:21 -07:00
Brent Simmons 6f29497ec8 Move NSTextFieldDelegate conformance to separate extension.
Handle the optional nil case in controlTextDidChange.
2019-10-23 22:27:08 -07:00
Brent Simmons c01b2c6269
Merge pull request #1145 from Wevah/add-folder-button-fix
Disable "Add Folder" button when the text field is empty
2019-10-23 22:22:12 -07:00
Brent Simmons 06b0e35739 Move Protocol declaration to top of ExportOPMLAccessoryViewController.swift. As critical API, it needs to be easy to spot.
Create separation extensions — one for protocol conformance, one for private methods — ExportOPMLController.

Make minor code formatting change: instead of { return } — which is hard to set a breakpoint on — move the return to its own line.

Remove an internal access qualifier, since internal is default and implied.
2019-10-23 22:00:14 -07:00
Nate Weaver 4b1a19360c Use glyphs from SF Symbols for table row swipe actions
(Thin font weight.)
2019-10-23 15:05:12 -05:00
Nate Weaver 37e77a9596 Make delegate-less init() fail since a delegate is currently required 2019-10-22 12:14:38 -05:00
Nate Weaver e7278017d9 Forgo notifications entirely, and use a delegate instead 2019-10-22 12:14:38 -05:00
Nate Weaver a762052264 Don't use block-based notification observing 2019-10-22 12:14:38 -05:00
Nate Weaver 7e98869080 Use an accessory view instead of an intermediate sheet for OPML export 2019-10-22 12:14:38 -05:00
Maurice Parker 00f100e3a3 Renamed TimelineStringFormatter to ArticleStringFormatter now that it is used for much more than the timelines 2019-10-20 02:28:00 -05:00
Nate Weaver b5d7ce8e8c Disable "Add Folder" button when the text field is empty 2019-10-19 12:31:47 -05:00
Brent Simmons 74b1d56cbf Merge branch 'mac-release' 2019-10-18 17:38:22 -07:00
Brent Simmons a11e900a93 Get the y scroll position in the detail view using window.pageYOffset instead of document.body.scrollTop. It appears the latter may be broken — at any rate, it just returns 0 on Catalina. (On Mojave, use the same method as before, so as not to risk a regression.) 2019-10-18 17:37:56 -07:00
Brent Simmons 1d45796220 Merge mac-release. 2019-10-17 22:11:35 -07:00
Brent Simmons 56fab24cec Make importing NetNewsWire 3 subscriptions a one-step process — use an accessory view in the NSOpenPanel. Also: refactor to use immutable structs instead of classes; use static methods on structs; reduce API surface; don’t flatten sub-folders (let the OPML importer handle the flattening, which it already does). 2019-10-17 13:25:11 -07:00
Maurice Parker 51373885b4 Change javascript event handlers to use event.target.matches instead of walking the dom to install event handlers 2019-10-15 09:04:21 -05:00
Maurice Parker 9e18361043 Merge branch 'mac-release' 2019-10-14 20:59:26 -05:00
Maurice Parker 19145505c5 Add the ability to import NNW 3 Subscription plist files. Issue #1129 2019-10-14 20:45:58 -05:00
Brent Simmons 427c0da0d3 Fix build error in FetchRequestQueue. 2019-10-13 22:19:49 -07:00
Brent Simmons 31a2afb067 Fix crashing bug in FetchRequestQueue by making sure the completion is called not more than once from FetchRequestOperation. Fix #1133. 2019-10-13 22:08:05 -07:00
Maurice Parker a1f26898c8 Split Mac and iOS specific javascript into individual files. 2019-10-13 15:47:11 -05:00
Phil Dokas 31c1dc40e3 Fix leading for super and subscript in the article view 2019-10-08 22:15:49 -07:00
Maurice Parker f7e235a1fb Remove padding from code blocks that was causing weird indentation 2019-10-07 11:05:22 -05:00
Kiel Gillard 6707fdcbd1 Double clicking a feed in the side bar opens the feed's homepage in the browser. Issue #1099 2019-10-05 11:44:21 +10:00
Maurice Parker c4b6cbe49e Allow article extractor to be tried again after Mercury parser failure 2019-10-04 07:55:42 -05:00
Maurice Parker 3d343eb91d Prevent pre tags from wrapping. Issue #1089 2019-10-03 18:27:48 -05:00
Maurice Parker 0000e03083 Add the ability to handoff from iOS to Mac 2019-10-03 15:49:27 -05:00
Maurice Parker 9203444552 Add deep linking to Mac app. 2019-10-03 11:39:48 -05:00
Nate Weaver ef29334a41 Use os_log() instead of NSLog() 2019-10-02 11:18:52 -05:00
Nate Weaver f67b7df5a9 Add row swipe action for Mark/Unmark Starred 2019-10-02 11:16:01 -05:00
Nate Weaver bc32fc1cb9 Add row swipe action for Mark Read/Unread 2019-10-02 11:16:01 -05:00
Brent Simmons 27478b0f6f Make r and u both just toggle read status. Update keyboard shortcuts HTML documentation to match. 2019-09-29 22:44:32 -07:00
Brent Simmons b62a7afa10 Add keyboard shortcut for toggling starred status — s key. Fix #875. 2019-09-29 22:34:31 -07:00
Maurice Parker 6536dbf2a5 Use correct account method for adding folders 2019-09-27 06:38:43 -05:00
Maurice Parker d961a73f28 Removed inadvertent code change 2019-09-26 15:30:38 -05:00
Maurice Parker 0a2cbfde22 Knock the corner off the inner image when it is visible 2019-09-26 14:31:43 -05:00
Andrew Brehaut f25c0e0b57 Original implementation was only aware of multimarkdown style footnote markup.
This commit includes support for DaringFireball style footnotes
2019-09-26 20:20:53 +12:00
Andrew Brehaut a381361b56 Merge branch 'master' of https://github.com/brentsimmons/NetNewsWire 2019-09-25 12:18:28 +12:00
Maurice Parker 98befac78c Animate reader view button 2019-09-24 16:34:11 -05:00
Andrew Brehaut 0d99136961 544 Simple darkmode style for popovers 2019-09-23 20:38:46 +12:00
Andrew Brehaut 4c54d2c4ff 544 adds and positions the arrow on the popover bubble
An arrow element is now inserted into the dom to orient the bubble to the fnref
element that opened it. This is offset in the opposite direction to the bubble
if the bubble overhangs one side or the other.

Additionally, if both sides overhang then no positioning takes place. This
is the first step towards supporting more narrow windows and mobile clients.
2019-09-23 20:25:00 +12:00
Andrew Brehaut af5d510c80 #544 Better handling of the footnote reverse links
* Uses a stylesheet to hide the reverse link in the popover rather than monkeying around with the dom in JS
* Javascript event handler catches clicks on the reverse buttons in the footnote list at the bottom of the page
  and scrolls the document back to the source, rather than opening the document in a browser window.
2019-09-23 19:56:58 +12:00
Andrew Brehaut 5fea81971b #554 newsfoot.js and css are included in the page
These changes are the bare minimum required to get footnotes to appear and function on the article page.
 * The newsfoot.js script now wraps everything in an IIFE to prevent bleed to other scripts
 * Stylesheets are included in the main stylesheet, with the colors extracted out into separate selectors

Currently missing the arrow pointing to the footnote link, and no consideration exists for mobile presentation
beyond a max-width: 100vh on the footnote popover.
2019-09-22 14:06:51 +12:00
Maurice Parker 9d54a1de74 Enable always on Reader View for feeds 2019-09-21 15:03:42 -05:00
Maurice Parker b49aeca577 Moved page.html location information to ArticleRenderer 2019-09-21 12:36:35 -05:00