Commit Graph

69 Commits

Author SHA1 Message Date
Nate Weaver 9de27febf0 Fix favicon loading for sites with multiple/invalid favicons
Load the next favicon if a favicon is invalid

Iterate through multiple favicons and use the first that actually loads

- Add a homePageURL property to SingleFaviconDownloader that notification observers can use.
- Only add a URL to the favicon cache when we're sure it's valid.

Post notification even if the icon failed to load

Update RSParser

Remove single-favicon helper methods

Only load the next favicon if the current load failed

Update RSParser

Make sure to try the default favicon.ico

RSParser test fix update

Update RSParser
2019-11-27 13:02:49 -06:00
Brent Simmons 56fab24cec Make importing NetNewsWire 3 subscriptions a one-step process — use an accessory view in the NSOpenPanel. Also: refactor to use immutable structs instead of classes; use static methods on structs; reduce API surface; don’t flatten sub-folders (let the OPML importer handle the flattening, which it already does). 2019-10-17 13:25:11 -07:00
Maurice Parker c4ee1edb69 Add externalID to Folder and persist it to OPML file. Issue #1060 2019-09-25 17:01:09 -05:00
Ben Ubois cdf643c2a6 Make iFrames responsive. 2019-09-20 17:21:01 -07:00
Nate Weaver 4a0bbeacc2 Disable Web Inspector for App Store builds
- Hide the "Enable Web Inspector" menu item.
- #if-out notifications/defaults/etc.
- Make toggleWebInspectorEnabled(_) a no-op.
2019-09-19 10:38:17 -05:00
Maurice Parker 9c9517d7d9
Merge pull request #1026 from Wevah/enable-inspector
Enable inspector
2019-09-17 14:44:06 -05:00
Maurice Parker 8a8dcde387 Add javascript to remove styling from articles. Issues ##499, #999, and #947 2019-09-17 14:32:18 -05:00
Nate Weaver e39fa31bf7 Add a menu item to the Debug menu to enable the Web Inspector
Just enables the "Inspect Element" item in a WKWebView's contextual menu at the moment.
2019-09-17 05:04:05 -05:00
Brent Simmons a05fd61085 Merge branch 'imagecache' into mac-release 2019-09-16 20:07:31 -07:00
Brent Simmons 2d22f061a5 Remove no-longer-needed functions for compositing the avatar on a background. 2019-09-16 20:07:07 -07:00
Maurice Parker 0458fd3838 Delete avatar and favicon image caches every three days 2019-09-16 16:26:40 -05:00
Brent Simmons 8a2d1f5f6a Create TimelineAvatarView, which draws the background for images that need it. 2019-09-15 23:02:13 -07:00
Maurice Parker 7c3c78b796 Remove debug print statement 2019-09-15 04:08:10 -05:00
Maurice Parker 20dda3727b Change to use the scaled avatar version of the favicon. 2019-09-15 04:05:11 -05:00
Maurice Parker b07bf73f78 Revert "Scale images, when needed, before generating inline HTML data in ArticleRenderer — this keeps us from getting huge amounts of data, which slows down rendering."
This reverts commit c3e26ea307.
2019-09-15 04:00:24 -05:00
Brent Simmons c3e26ea307 Scale images, when needed, before generating inline HTML data in ArticleRenderer — this keeps us from getting huge amounts of data, which slows down rendering. 2019-09-14 22:41:13 -07:00
Brent Simmons 41c82eca15 Rename existingFeed(with:) to existingFeed(withFeedID:) to make it more clear. Make account.idToFeedDictionary private — callers should use existingFeed(withFeedID:). 2019-09-08 21:44:05 -07:00
Brent Simmons 5b15285e8e Make sure that article.preferredLink doesn’t return an empty string. 2019-09-07 18:27:48 -07:00
Maurice Parker 3279a25581 Cache home page to feed icon relationship 2019-08-26 19:40:30 -05:00
Maurice Parker 1a3e2784ae Optimize table cell reloading when feed images are made available 2019-08-26 12:54:23 -05:00
Brent Simmons 98ec923c67 Replace, in default feeds for new users, Om Malik and Xcoders with Rose Orchard and Michael Tsai. 2019-08-21 13:06:26 -07:00
Brent Simmons 2bbd135c9e Update appropriate counts in the sidebar when the timeline’s unread count changes. Fix #829. 2019-08-13 21:07:39 -07:00
Brent Simmons cf1b3843ee Add a SmartFeedType to smart feeds so the sidebar can tell them apart. 2019-08-13 20:28:28 -07:00
Brent Simmons 13797c6693 Remove no-longer-needed removal of that weird character Six Colors uses in some of their headlines. 2019-08-04 23:02:09 -07:00
Maurice Parker 4fc1998cf3 Make Account and AccountDelegate interfaces more consistent by requiring the container parameter on removeFeed. Resolves #802 2019-07-17 15:41:21 -05:00
Brent Simmons fbb7b9961c Change an import Cocoa to import AppKit. 2019-07-06 11:52:15 -07:00
Brent Simmons 7a204ad6ed Run database fetches async, in the timeline, when appropriate — for instance, when All Unread is selected and new articles come in. 2019-07-05 20:06:31 -07:00
Maurice Parker 40b9be6709 center smaller avatars on a solid color background image to make all avatars a consistent size 2019-06-14 15:33:13 -05:00
Maurice Parker 46bc867241 Add additional sort criteria for when published date is equal. Issue #644 2019-06-13 15:51:28 -05:00
Maurice Parker e4ee311227 Revert "escape title HTML in web view. Issue #722"
This reverts commit a087410177.
2019-06-12 10:51:15 -05:00
Maurice Parker e8199ed0a6 Change to not show alert dialog on automatic refreshes. Issue #729 2019-06-10 15:21:17 -05:00
Maurice Parker a087410177 escape title HTML in web view. Issue #722 2019-06-07 15:53:13 -05:00
Maurice Parker e8992dac95 Fix issue where deletes were crashing the app. Issue #702 2019-06-05 17:42:35 -05:00
Maurice Parker 51284b5aa4 Rename deleteFeed to removeFeed to be more consistent with other API's 2019-05-29 21:04:44 -05:00
Maurice Parker 527e677934 Rename deleteFolder to removeFolder to make the API more consistent 2019-05-29 20:53:00 -05:00
Maurice Parker 5e3fcfd955 Correct how feeds were deleted so that only the feed in the correct container was deleted 2019-05-29 17:56:26 -05:00
Maurice Parker 493abbb609 Refactor create feed functionality to increase code reuse and encapsulation 2019-05-28 09:45:02 -05:00
Maurice Parker c61949bc04 Add account name to network error messages and prevent background iOS errors from displaying alerts 2019-05-26 11:54:32 -05:00
Maurice Parker 5d1c7d08ac Remove strong reference to Account that was preventing Accounts from being deallocated 2019-05-22 15:08:22 -05:00
Maurice Parker 3207ebf6a5 Implement default timeline avatar. Issue #641 2019-05-21 05:42:40 -05:00
Maurice Parker 31cc3b609c Make delete animation correct for deletes and restores by wrapping them in BatchUpdates. Issue #667 2019-05-20 18:05:28 -05:00
Brent Simmons 1ee0ab5a73 Fix logic in FeedIconDownloader so that we check the home page metadata. (I had broken this recently.) 2019-05-17 23:02:18 -07:00
Maurice Parker 6882b152d9 Add timer to trigger article status sync process. 2019-05-15 17:21:58 -05:00
Brent Simmons f5f8d67411 Scale images always on a background queue. Fix #642. 2019-05-14 22:44:06 -07:00
Brent Simmons 7b40ca221b Use the articleID + accountID as a key for truncated summaries. This is *way* faster than using the entire body. It avoids a hash of a long string. (Note: we still need to toss the cache at the appropriate time.) 2019-05-13 22:16:44 -07:00
Brent Simmons 7c78d914be Speed up timeline scrolling by only going up to 150 characters with summary calculation. 2019-05-13 22:06:03 -07:00
Maurice Parker 6d5b3884fc Put folder pop up menu for add feed in the correct order 2019-05-13 11:31:04 -05:00
Brent Simmons b211eda05d Make the feed URL for inessential.com use the new https version. 2019-05-12 21:11:02 -07:00
Maurice Parker 6f92cd1a73 Refactor to differentiate between loading the Subscriptions.opml file and importing an external OPML file as they now need separate behaviors 2019-05-11 12:26:23 -05:00
Maurice Parker 23b43ecc07 Add undo for feeds 2019-05-09 16:09:21 -05:00