3ead2c63bc
Remove attachments from the app, since we’re not using attachments in any way. We could always add it back later.
2019-12-03 23:03:15 -08:00
f8376b807a
Restore two-step process for OPML exporting.
2019-10-24 21:12:58 -07:00
1c06eb27e8
Create separate private extension. Make misc. code formatting changes to match current thinking.
2019-10-23 22:33:21 -07:00
6f29497ec8
Move NSTextFieldDelegate conformance to separate extension.
...
Handle the optional nil case in controlTextDidChange.
2019-10-23 22:27:08 -07:00
c01b2c6269
Merge pull request #1145 from Wevah/add-folder-button-fix
...
Disable "Add Folder" button when the text field is empty
2019-10-23 22:22:12 -07:00
06b0e35739
Move Protocol declaration to top of ExportOPMLAccessoryViewController.swift. As critical API, it needs to be easy to spot.
...
Create separation extensions — one for protocol conformance, one for private methods — ExportOPMLController.
Make minor code formatting change: instead of { return } — which is hard to set a breakpoint on — move the return to its own line.
Remove an internal access qualifier, since internal is default and implied.
2019-10-23 22:00:14 -07:00
37e77a9596
Make delegate-less init() fail since a delegate is currently required
2019-10-22 12:14:38 -05:00
e7278017d9
Forgo notifications entirely, and use a delegate instead
2019-10-22 12:14:38 -05:00
a762052264
Don't use block-based notification observing
2019-10-22 12:14:38 -05:00
7e98869080
Use an accessory view instead of an intermediate sheet for OPML export
2019-10-22 12:14:38 -05:00
b5d7ce8e8c
Disable "Add Folder" button when the text field is empty
2019-10-19 12:31:47 -05:00
a11e900a93
Get the y scroll position in the detail view using window.pageYOffset instead of document.body.scrollTop. It appears the latter may be broken — at any rate, it just returns 0 on Catalina. (On Mojave, use the same method as before, so as not to risk a regression.)
2019-10-18 17:37:56 -07:00
56fab24cec
Make importing NetNewsWire 3 subscriptions a one-step process — use an accessory view in the NSOpenPanel. Also: refactor to use immutable structs instead of classes; use static methods on structs; reduce API surface; don’t flatten sub-folders (let the OPML importer handle the flattening, which it already does).
2019-10-17 13:25:11 -07:00
19145505c5
Add the ability to import NNW 3 Subscription plist files. Issue #1129
2019-10-14 20:45:58 -05:00
427c0da0d3
Fix build error in FetchRequestQueue.
2019-10-13 22:19:49 -07:00
31a2afb067
Fix crashing bug in FetchRequestQueue by making sure the completion is called not more than once from FetchRequestOperation. Fix #1133 .
2019-10-13 22:08:05 -07:00
27478b0f6f
Make r and u both just toggle read status. Update keyboard shortcuts HTML documentation to match.
2019-09-29 22:44:32 -07:00
b62a7afa10
Add keyboard shortcut for toggling starred status — s key. Fix #875 .
2019-09-29 22:34:31 -07:00
cdf643c2a6
Make iFrames responsive.
2019-09-20 17:21:01 -07:00
4a0bbeacc2
Disable Web Inspector for App Store builds
...
- Hide the "Enable Web Inspector" menu item.
- #if-out notifications/defaults/etc.
- Make toggleWebInspectorEnabled(_) a no-op.
2019-09-19 10:38:17 -05:00
0c89bc43c1
Use a bridging header for the Web Inspector API instead of KVC
2019-09-17 06:55:55 -05:00
4f405009f5
Use a selector instead of a block for the notification observation
2019-09-17 05:04:05 -05:00
e39fa31bf7
Add a menu item to the Debug menu to enable the Web Inspector
...
Just enables the "Inspect Element" item in a WKWebView's contextual menu at the moment.
2019-09-17 05:04:05 -05:00
66d9333999
Make minor code formatting changes so that TimelineViewController matches our current thinking. Also delete some commented-out and unused code.
2019-09-16 22:27:17 -07:00
f7c9cc1dbd
Remove no-longer needed machinery for updating the timeline on dark-mode/light-mode appearance changes.
2019-09-16 22:09:58 -07:00
a05fd61085
Merge branch 'imagecache' into mac-release
2019-09-16 20:07:31 -07:00
a225d52ba3
Use the new TimelineAvatarView instead of an NSImageView in TimelineTableCellView.
2019-09-16 20:01:30 -07:00
506b621e5d
Draw the avatar background in TimelineAvatarView only if the icon is too short vertically.
2019-09-16 20:00:32 -07:00
1d7cbe5596
Fix super wide div's. Issue #1010
2019-09-16 18:12:56 -05:00
8a2d1f5f6a
Create TimelineAvatarView, which draws the background for images that need it.
2019-09-15 23:02:13 -07:00
57542592cb
Correct which view should become the first responder. Issue #1014
2019-09-11 17:47:02 -05:00
7ad0b6b604
Always update the unread count in the timeline after doing a sync fetch after representedObjects changes. Reload visible cells whenever showFeedNames changes. Fix #923 .
2019-09-10 20:28:16 -07:00
8dda681409
Add accessibility labels to Sidebar, Timeline, and Article. Issue #934
2019-09-10 11:09:17 -05:00
0961753357
Merge pull request #998 from hisaac/mac-release
...
Add command arrow key shortcuts to sidebar shortcuts plist
2019-09-08 13:02:58 -05:00
8b635fc04c
Add command arrow key shortcuts to sidebar shortcuts plist
2019-09-08 12:54:26 -05:00
58c2fad2fd
Stop blocking links containing the string “feedburner” — there are legitimate cases where that string appears. Fix #976 .
2019-09-06 19:28:06 -07:00
0e7d971e65
Queue a reload of all visible cells anytime a favicon is downloaded. Issue #995
2019-09-06 16:52:31 -05:00
ce3ec10c95
Enforcing automatic height for images in the template
2019-09-05 10:59:16 -07:00
7a8d23958b
Restrict iframe width to be at most 100%
2019-09-04 17:41:58 -05:00
d3ad4b52a3
Set a sensible line height for figure captions
2019-09-04 19:58:29 +01:00
5976923f23
Add figures to Mac detail stylesheet
2019-09-04 19:58:29 +01:00
0ba8f3b4e1
Call the completion block once and only once from FetchRequestOperation. This is a probable fix for #898 .
2019-09-03 22:58:17 -07:00
c8920ca5a6
Added optional separators in the timeline view.
...
The timeline now optionally includes "Mail style" separators (behind a
hidden default — "CorreiaSeparators" — which defaults to NO).
2019-09-02 09:13:21 -07:00
e7e77d362c
Fix for bug #901 — first web view load flashes white in dark mode
...
The fix used for iOS (keep a queue of preloaded web views) isn't appropriate
for macOS since the first view is used immediately. That approach would
solve the flash of white when first searching, but not the flash of white
when launching the application.
Instead, use a modification of the original solution used for iOS:
- wrap the web view in a box with an appropriate background color
- hide the web view at creation
- show the web view after* the first load
This doesn't suffer the latency problem that the same solution on iOS had
because the first load is always local, "No Selection" HTML.
[*] Showing the view immediately after the first load still causes the flash
to white. Waiting 0.05 seconds avoids this. That's a fairly terrible hack,
but I don't have a better solution at present.
2019-08-31 22:14:56 -07:00
cdfdc06142
Only enable "Open in Browser" when a single article is selected.
...
Fixes bug #921 .
2019-08-31 16:02:21 -07:00
1a3e2784ae
Optimize table cell reloading when feed images are made available
2019-08-26 12:54:23 -05:00
3447ebcec0
Reload data after a batch update. Fix #872 .
2019-08-23 15:52:07 -07:00
849830f494
Refetch articles for smart feeds and folders, if selected, when a feed or folder is deleted. Fix #838 .
2019-08-21 21:41:56 -07:00
f513741ddb
Start work on filtering timeline so that articles from deleted feeds never show up.
2019-08-21 13:23:46 -07:00
2bbd135c9e
Update appropriate counts in the sidebar when the timeline’s unread count changes. Fix #829 .
2019-08-13 21:07:39 -07:00
Brent Simmons
Nate Weaver
Maurice Parker
Ben Ubois
Isaac Halvorson
Brian Warren
Thomas Pritchard
Jim Correia