Commit Graph

1361 Commits

Author SHA1 Message Date
Maurice Parker
d4cffa28f2 Rollback disclosure button reference hold since it does nothing to stop the crash 2020-05-06 14:58:47 -05:00
Maurice Parker
502ff3e019 Don't multiply by the device pixel ratio if that will put us over the canvas limit 2020-05-06 14:55:34 -05:00
Maurice Parker
5f60b84b8b Reset all the web views when coming back to the foreground incase one of them is unavailable now 2020-05-06 14:53:09 -05:00
Maurice Parker
e2267d14ee Hold a reference to the pointer interaction to try to get it to stop crashing. Issue #2034 2020-05-01 16:34:19 -05:00
Maurice Parker
d5a4f1625a Take device pixel ratio into consideration when drawing the image to zoom. Issue #2032 2020-05-01 16:24:29 -05:00
Maurice Parker
37bbee9fcc Remove calls to dismiss delegate function on cancel. Issue #2010 2020-04-28 17:58:06 -05:00
Maurice Parker
e77abf42c3
Revert "Removes AddAccountDismissDelegate" 2020-04-28 17:53:24 -05:00
Maurice Parker
31f3487d7a Reset focus when returning to the app from another app or the safari view controller. Issue #1963 2020-04-28 17:16:34 -05:00
Maurice Parker
6f29b21ddc
Merge pull request #2013 from rizwankce/fix/missing-add-account-title
Add title for AddAccountViewController
2020-04-24 10:30:31 -05:00
Rizwan Mohamed Ibrahim
54fc60aa51
Add title for AddAccountViewController
view controller title via storyboard
2020-04-24 20:56:29 +05:30
Maurice Parker
a46609b564
Merge pull request #2014 from rizwankce/fix/add-account-cell-high-lighting
Deselect the cell row when selected for add account view controller
2020-04-24 09:11:28 -05:00
Rizwan Mohamed Ibrahim
43f175d71a
Removes AddAccountDismissDelegate
Delegate which was responsible to dismiss AddAccountViewController
whenever presented view controller dismissed is not needed. So removing
it simply will go to previous screen from where user comes.
2020-04-24 18:49:49 +05:30
Rizwan Mohamed Ibrahim
c7e3162c22
Deselect the cell row when selected for add account view controller
To avoid the highlighting even after the row is selected
2020-04-24 18:39:18 +05:30
Maurice Parker
947c4f04d7 Implement fix that prevents wiggling on both the timeline and the article views. 2020-04-22 22:03:15 -05:00
Maurice Parker
a5583fc655 Validate that the selected row hasn't been removed when trying to select or scroll to it. Issue #1976 2020-04-22 18:18:20 -05:00
Maurice Parker
82e7d4eaf0 Merge branch 'ios-release' of https://github.com/Ranchero-Software/NetNewsWire into ios-release 2020-04-21 20:24:01 -05:00
Maurice Parker
2454b807bb Always update the status sync timer when returning to the foreground. Issue #2005 2020-04-21 20:23:46 -05:00
Rizwan Mohamed Ibrahim
108da4ccf4
Fix buttons a11y label for close and share button for image vc
Image View Controller buttons both close and share don't have correct
a11y label. This will add the localised label
2020-04-21 22:14:58 +05:30
Maurice Parker
f7bdf9d47c Correct text resizing issues in color palette settings. Issue #2000 2020-04-21 01:57:19 -05:00
Maurice Parker
7afcf681fe Stablize swipe back gesture for timeline. Issue #2002 2020-04-21 01:52:39 -05:00
Maurice Parker
a4c672bb46 Merge branch 'ios-release' of https://github.com/Ranchero-Software/NetNewsWire into ios-release 2020-04-16 16:27:04 -05:00
Maurice Parker
928e93c074 Remove web view recycling as this seems to contribute to the blank article problem on iPadOS 2020-04-16 16:26:53 -05:00
Brent Simmons
f9a11198f0 Remove Omni from credits and about text. 2020-04-16 13:24:20 -07:00
Brent Simmons
1321f0b9ff Loop through through rows using the count of rows in that section, rather than the count of rows in the initial indexPath’s section. Fix #1987. 2020-04-12 18:23:20 -07:00
Brent Simmons
6d9eda442f Remove userDeleted support. The read-items filter seems to fill the need to hide things. We’re simplifying the backend by removing this unused feature. 2020-04-12 17:12:36 -07:00
Maurice Parker
7064d5d8f5 Fix regression where navigating back and paging back from an article happened at the same time. 2020-04-12 11:48:14 -05:00
Maurice Parker
7c266d65ee Force the frame to center when displaying. Issue #1983 2020-04-11 15:58:48 -05:00
Maurice Parker
02f62bbb61 Fix image cropping. Issue #1967 2020-04-11 15:11:12 -05:00
Maurice Parker
f0ec7c5e19 Fix problem where back swiping wouldn't work anymore for full screen. Issue #1970 2020-04-06 08:47:01 -05:00
Maurice Parker
41acb716bd Remove activity donation for next unread. Issue #1957 2020-03-30 15:42:42 -05:00
Maurice Parker
715671edad Rebuild the Feeds list when coming back to it from the Timeline while the root split is collapsed to filter read Feeds. 2020-03-28 01:43:54 -05:00
Maurice Parker
bd1c73c1d3 Automatically remove Feed items if they should be filtered. Issue #1949 2020-03-27 18:24:57 -05:00
Maurice Parker
a13f10441f Change pointer interaction to encompass the complete button. 2020-03-26 11:20:13 -05:00
Maurice Parker
6c06c7791c Add interaction to buttons that were missing it. Issue #1945 2020-03-25 08:55:02 -05:00
Maurice Parker
450ddbd364 Refactored new pointer interaction code to be more simple. 2020-03-24 18:27:54 -05:00
Maurice Parker
bd75df7294 Add pointer interaction for timeline header button. Issue #1943 2020-03-24 16:42:46 -05:00
Maurice Parker
d615a0a894 Fix bug where clean up shortcut wouldn't clear articles if wrong setting was off. 2020-03-24 16:00:01 -05:00
Maurice Parker
85cbd204b3 Fixed clean up keyboard shortcut 2020-03-22 10:23:31 -05:00
Maurice Parker
97226f543b Assign keyboard shortcuts to filters and change clean up shortcut. Issue #1842 2020-03-22 10:18:07 -05:00
Maurice Parker
9f516caa35 Don't use borders on nested tables. Issue #1936 2020-03-21 17:19:03 -05:00
Maurice Parker
e7436925ad Don't remove filtered feeds on article downloads. 2020-03-20 10:34:18 -05:00
Maurice Parker
316e4e62b2 Removed separator insets from layout code as they were no longer needed. 2020-03-20 06:58:11 -05:00
Maurice Parker
8a75defee9 Set row height when table is empty and set to automatic when articles are present. Issue #1919 2020-03-18 16:06:05 -05:00
Maurice Parker
1d26bc8c70
Revert "Set proper cell height for empty article array" 2020-03-18 15:55:33 -05:00
Maurice Parker
36841602a5 Change article rendering to use loadHTMLString instead of JavaScript. Issue #1923 2020-03-17 17:18:24 -05:00
Maurice Parker
37cf7fae1d Fix regression that prevented Always Show Reader View from working. 2020-03-16 07:58:51 -05:00
Maurice Parker
07042b8a2a Implemented Clean Up keyboard shortcut. Issue #1915 2020-03-15 18:15:52 -05:00
Flowinho
47dc34db5d Fix Typo
This contains work related to issue #1910
2020-03-15 22:44:12 +01:00
Flowinho
2ade0140bc Set proper cell height for empty article array
Contains work related to #1800

This one took me a while to figure out since they amount of articles is tied to the coordinator.

- Fixed violation of single responsibility principle inside “resetEstimatedRowHeight()” by removing the applicance of tableViewRowHeight and instead return the correctly calculated rowHeight.
- Removed prototype strings from inside the function to a static struct to be able to switch parameters for this function more easy (might be useful later / in testing). Function looks cleaner.

Greetings from southern germany!
2020-03-15 22:31:54 +01:00
Maurice Parker
acaf3fac9f Add user agent to plist. Issue #1913 2020-03-15 11:48:07 -05:00