Commit Graph

116 Commits

Author SHA1 Message Date
Maurice Parker 4f401099b6 Fix empty space that sometimes appeared between the first section and the navigation bar of Feeds 2019-09-14 19:51:23 -05:00
Maurice Parker 979fcbc013 Don't update feed selection for zero rows. 2019-09-12 13:49:23 -05:00
Maurice Parker efcbdd642a Fix cell icon tint colors 2019-09-11 19:29:27 -05:00
Maurice Parker 7ec360a81e Delete unnecessary node reload 2019-09-11 17:20:33 -05:00
Maurice Parker be84fc5a6b Simplify the section and folder expand/collapse logic 2019-09-11 16:53:27 -05:00
Maurice Parker 1b97aad79c Simplify code by moving the expanded indicator to Node 2019-09-11 15:24:38 -05:00
Maurice Parker ab38e755d3 Move apply snapshot to the viewWillAppear callback to prevent table artifacts 2019-09-11 14:33:39 -05:00
Maurice Parker d8513385e1 More refactoring to remove IndexPath dependencies 2019-09-11 05:45:35 -05:00
Maurice Parker 7278a86523 Refactor to reduce usage of IndexPath's in SceneCoordinator 2019-09-11 05:33:54 -05:00
Maurice Parker aac3c86561 Ensure that selected feed is visible when transitioning to three panel mode 2019-09-10 16:38:59 -05:00
Maurice Parker e3361abc77 Force the scroll even if the currently selected row is the same 2019-09-10 07:48:40 -05:00
Maurice Parker 98761510dd Reload visible cells after expanding/collapsing folders since the folder row might not get updated 2019-09-09 10:06:13 -05:00
Maurice Parker 9dc8f8d37a Clear the timeline if the deleted feed is showing in the timeline 2019-09-08 08:40:15 -05:00
Maurice Parker 8b901819a6 Make table views scroll even if the root split is collapsed 2019-09-08 08:30:08 -05:00
Maurice Parker a6f6462afd Make arrow key scrolling work like it does on the Mac timeline 2019-09-06 13:45:45 -05:00
Maurice Parker c8b5b10edd Check if the split is collapsed to see if we are maintaining the selection 2019-09-06 11:22:35 -05:00
Maurice Parker aa7c60ee3a Prevent row selection on iPhone as keeping selected rows highlighted is an iPad only feature 2019-09-06 11:11:28 -05:00
Maurice Parker cc1c45095c Make feeds become first responder on load so that the keyboard is ready to go on initial app launch 2019-09-06 10:52:21 -05:00
Maurice Parker 9b17293f4e Fix bugs in automated routing on application launch 2019-09-06 07:29:36 -05:00
Maurice Parker 6d24ea642a Add expand and collapse all folders shortcuts 2019-09-05 16:38:33 -05:00
Maurice Parker 734ce4bc67 Rename expand and collapse functions to be more descriptive 2019-09-05 16:08:57 -05:00
Maurice Parker 953259f0d3 Add selected row expanding and collapsing keyboard shortcuts 2019-09-05 16:04:07 -05:00
Maurice Parker c9fd7d01d9 Add delete feed keyboard shortcut 2019-09-05 15:54:58 -05:00
Maurice Parker afce6ff26f Add keyboard shortcuts for Add Feed and Add Folder 2019-09-05 15:07:35 -05:00
Maurice Parker 73828e5115 Remove the coordinator dependency from KeyboadManager as it wasn't needed 2019-09-05 14:37:07 -05:00
Maurice Parker ac37443dbb Stubbed out menu item keyboard shortcuts and implemented the numbered ones 2019-09-05 13:14:14 -05:00
Maurice Parker 7a452e2a3c Add keyboard arrow key navigation 2019-09-04 21:06:29 -05:00
Maurice Parker 68143aa2c5 Implement keyboard shortcut infrastructure and first shortcuts 2019-09-04 16:24:16 -05:00
Maurice Parker 17a5d291f4 Remove become and resign first responder code in Feeds and Timeline 2019-09-03 20:39:00 -05:00
Maurice Parker e6a4338a86 Restore the feed selection if an account containing the selection is expanded 2019-09-03 13:59:22 -05:00
Maurice Parker bf572633f8 Enable drag and drop between accounts 2019-09-03 13:27:23 -05:00
Maurice Parker 960f09826b Add separator line to section headers so that they don't look smooshed together when collapsed 2019-09-03 13:00:31 -05:00
Maurice Parker 4bce625f18 Clear search results when no timeline fetcher is specified 2019-09-03 12:25:27 -05:00
Maurice Parker 2e71cc573d Cap the possible destination index used during Feed moves 2019-09-03 12:07:18 -05:00
Jim Correia 061872b7ff Simplified/corrected highlighted/selected appearance of feed and timeline cells.
- Set the highlighted text color on labels in table cells. This will be used
  for both the highlight and selected states automatically. (And since it is
  used for both states, we avoid anachronistic state where we have black
  text on a dark blue background in light mode as we transition from none ->
  highlighted -> selected.)

- Keep the selected/highlighted overrides to adjust colors for non-UIControl
  subelements.
2019-09-02 22:39:01 -07:00
Jim Correia 932f6fdd30 Added NNWTableViewCell; a base class for cells with the NNW selection color.
Defined a semantic color for the selection color which is identical to
netNewsWireBlue.

MasterFeedTableViewCell and MasterTimelineTableViewCell now subclass
NNWTableViewCell and no longer directly customize their selected background
view.
2019-09-02 22:38:42 -07:00
Maurice Parker 1a9acdcc50 Remove TreeController from Delete command as it is no longer used there 2019-09-01 14:56:27 -05:00
Maurice Parker 858bdb7f21 Rename AppCoordinator to SceneCoordinator as that name better defines its purpose 2019-09-01 12:43:07 -05:00
Maurice Parker 397d75c6f6 Restore animation when adds and deletes happen to feed items 2019-09-01 10:11:03 -05:00
Maurice Parker 27883632d0 Fix bug that prevented reading article user activities from being restored 2019-08-31 20:23:14 -05:00
Maurice Parker 87030a5921 Implement stateRestorationActivity to save most relevant current user activity 2019-08-31 19:30:21 -05:00
Maurice Parker 762710266d Reload all cells when a batch update completes because we might be out of sync even though we called apply on the datasource. This can happen when moving a feed into and out of a folder. 2019-08-30 16:19:06 -05:00
Maurice Parker 197fc0170e Optimize and fix unread count updates 2019-08-29 14:35:18 -05:00
Maurice Parker be8c14bc65 Change to reload the individual row instead of just changing its contents 2019-08-28 20:21:50 -05:00
Maurice Parker 7062744758 Make sure we manually correct some state when using diffable datasources 2019-08-28 20:08:30 -05:00
Maurice Parker 89a38fa2b5 Change Feeds to use diffable data sources 2019-08-28 18:06:27 -05:00
Maurice Parker 9c66f6160e Clean activities when the associated data is deleted 2019-08-28 11:30:40 -05:00
Maurice Parker 3d408d0b27 Prevent autolayout from messing around with our disclosure chevron 2019-08-25 20:06:45 -05:00
Maurice Parker cf5fd4fa89 Invalidate content size correctly 2019-08-25 20:06:02 -05:00
Maurice Parker a0b11da438 Prevent autolayout from messing with our manually set frames 2019-08-25 20:00:34 -05:00