Commit Graph

750 Commits

Author SHA1 Message Date
Maurice Parker 00a84ce6b5 Fix bug that prevented timeline from being restored after searching ends 2019-09-04 10:42:28 -05:00
Maurice Parker a29f69c0cb Create separate launch storyboard for iPad since we don't use large titles on iPad in three panel mode which is the only one you will see while launching 2019-09-04 04:46:13 -05:00
Maurice Parker 17a5d291f4 Remove become and resign first responder code in Feeds and Timeline 2019-09-03 20:39:00 -05:00
Maurice Parker fc872cf88f Add missing activity type 2019-09-03 19:58:48 -05:00
Maurice Parker 640faaa114 Simplify the article replacement logic 2019-09-03 16:07:02 -05:00
Maurice Parker 5cb099aee6 Add next unread as a user activity and more aggressively invalidate user activities 2019-09-03 15:52:59 -05:00
Maurice Parker e6a4338a86 Restore the feed selection if an account containing the selection is expanded 2019-09-03 13:59:22 -05:00
Maurice Parker b7ba2c809c Use better function for looking up article index 2019-09-03 13:43:59 -05:00
Maurice Parker bf572633f8 Enable drag and drop between accounts 2019-09-03 13:27:23 -05:00
Maurice Parker 960f09826b Add separator line to section headers so that they don't look smooshed together when collapsed 2019-09-03 13:00:31 -05:00
Maurice Parker 4bce625f18 Clear search results when no timeline fetcher is specified 2019-09-03 12:25:27 -05:00
Maurice Parker 2a00c879f8 Change to animate search results changes 2019-09-03 12:12:42 -05:00
Maurice Parker 2e71cc573d Cap the possible destination index used during Feed moves 2019-09-03 12:07:18 -05:00
Maurice Parker d5adbccd5b
Merge pull request #949 from correia/issue-948
Fix for issue #948 — bad highlight state for table cell views in light mode.
2019-09-03 11:56:14 -05:00
Jim Correia 061872b7ff Simplified/corrected highlighted/selected appearance of feed and timeline cells.
- Set the highlighted text color on labels in table cells. This will be used
  for both the highlight and selected states automatically. (And since it is
  used for both states, we avoid anachronistic state where we have black
  text on a dark blue background in light mode as we transition from none ->
  highlighted -> selected.)

- Keep the selected/highlighted overrides to adjust colors for non-UIControl
  subelements.
2019-09-02 22:39:01 -07:00
Jim Correia 932f6fdd30 Added NNWTableViewCell; a base class for cells with the NNW selection color.
Defined a semantic color for the selection color which is identical to
netNewsWireBlue.

MasterFeedTableViewCell and MasterTimelineTableViewCell now subclass
NNWTableViewCell and no longer directly customize their selected background
view.
2019-09-02 22:38:42 -07:00
Maurice Parker 0d6dbb6df3 Fix broken select next where it wasn't going to the next available fetcher in the Feeds scene 2019-09-02 17:28:28 -05:00
Maurice Parker 613cea5c7a Change next unread function so that it skips the current article even if that article is marked as unread 2019-09-02 17:24:20 -05:00
Maurice Parker fafb7de868 Remove Refresh shortcut item 2019-09-02 16:05:55 -05:00
Maurice Parker 93b702f170 Automatically copy any url in the pasteboard to the feed field for feed adds 2019-09-02 15:54:49 -05:00
Maurice Parker c5fed06581 Add refresh home screen shortcut. 2019-09-02 15:45:09 -05:00
Maurice Parker 2c4531f481 Add the Add scene as a home page quick action. 2019-09-02 15:14:26 -05:00
Maurice Parker b768877e23 Use correct delegate methods to begin and end searching 2019-09-02 12:40:14 -05:00
Maurice Parker 746c06d147 Prevent automated scrolling when selecting an article in the timeline 2019-09-02 12:05:11 -05:00
Maurice Parker c405fdf583 Implement search home page quick action 2019-09-01 17:41:46 -05:00
Maurice Parker 33882ab276 Add Home Page Quick Actions 2019-09-01 16:54:07 -05:00
Maurice Parker 189af8d816 Invalidate user activities when collapsed and returning to Feeds scene 2019-09-01 15:31:11 -05:00
Maurice Parker 1a9acdcc50 Remove TreeController from Delete command as it is no longer used there 2019-09-01 14:56:27 -05:00
Maurice Parker dfc3046bf0 Clear the timeline when the user begins searching 2019-09-01 14:49:56 -05:00
Maurice Parker a5298f0381 Refactor mark as read for articles to be in the SceneCoordinator instead of in the DetailViewController 2019-09-01 12:52:06 -05:00
Maurice Parker 858bdb7f21 Rename AppCoordinator to SceneCoordinator as that name better defines its purpose 2019-09-01 12:43:07 -05:00
Maurice Parker 43fb7dff9f Fix bug that prevented new folders from appearing in the Feeds 2019-09-01 10:29:30 -05:00
Maurice Parker 397d75c6f6 Restore animation when adds and deletes happen to feed items 2019-09-01 10:11:03 -05:00
Maurice Parker 27883632d0 Fix bug that prevented reading article user activities from being restored 2019-08-31 20:23:14 -05:00
Maurice Parker 87030a5921 Implement stateRestorationActivity to save most relevant current user activity 2019-08-31 19:30:21 -05:00
Maurice Parker 407bd296db Merge branch 'master' of https://github.com/brentsimmons/NetNewsWire 2019-08-31 17:37:49 -05:00
Maurice Parker 988ac1bbd8 Correct label color to specify correct platform 2019-08-31 17:37:42 -05:00
Maurice Parker 6caff148dd
Merge pull request #928 from correia/placeholder-content
Use noContentHTML rather than noSelectionHTML for prepared web views.
2019-08-31 17:20:52 -05:00
Jim Correia 5f11c42fc2 Use noContentHTML rather than noSelectionHTML for prepared web views.
Added a noContentHTML to ArticleRenderer. Use that for the initial content
for queued web views so that we don't see a temporary flash of "No
Selection" when pushing to an article that doesn't load instantly.
2019-08-31 15:03:03 -07:00
Maurice Parker c9858a0457 Show and hide scope bar based on editing state 2019-08-31 16:39:59 -05:00
Maurice Parker fe2e0155da Add scoped searching of articles 2019-08-31 15:53:47 -05:00
Maurice Parker ba36572497
Merge pull request #927 from correia/correia/webview-layout
Added missing constraints to the web container view in the Detail scene.
2019-08-31 15:27:52 -05:00
Jim Correia 77cf92ec13 Added missing constraints to the web container view in the Detail scene. 2019-08-31 13:20:23 -07:00
Jim Correia 52ad2623a8 Limit the size of the queue maintained by DetailViewControllerWebViewProvider. 2019-08-31 13:16:46 -07:00
Jim Correia f7b53283d6 Maintain a queue of "prepared" web views for use in DetailWebViewController.
WKWebView has an awful behavior of a flash to white on first load when in
dark mode.

Keep a queue of WebViews where we've already done a trivial load so that by
the time we need them in the UI, they're past the flash-to-shite part of
their lifecycle.
2019-08-31 12:53:03 -07:00
Jim Correia a5b2c759ec Create the WKWebView instance at runtime.
Specify a container view in the storyboard and create+install the web view
at viewDidLoad time.

This lets us experiment with solutions for providing a web view that avoids
the flash-to-white problem.
2019-08-31 12:30:01 -07:00
Jim Correia e5782ca464 Removed the hide the webview workaround to expose the flash to white problem. 2019-08-31 11:27:59 -07:00
Maurice Parker 67b9721a10 Made article search go fast 2019-08-31 12:12:50 -05:00
Maurice Parker 8002839941 Remove disclosure chevron from launch storyboard 2019-08-31 11:51:14 -05:00
Maurice Parker d9ce01591f Implement full article search 2019-08-31 11:50:34 -05:00
Maurice Parker 061dfe931b Restrict access to rebuildShadowTable function 2019-08-31 11:38:03 -05:00
Maurice Parker 2cf6550226 Implemented launch storyboard. Issue #742 2019-08-30 17:39:39 -05:00
Maurice Parker 762710266d Reload all cells when a batch update completes because we might be out of sync even though we called apply on the datasource. This can happen when moving a feed into and out of a folder. 2019-08-30 16:19:06 -05:00
Maurice Parker ca0bdb3d35 Change to not animate on timeline fetcher changes 2019-08-30 14:42:33 -05:00
Maurice Parker 07ca61f7cf Convert the timeline to use diffable datasources 2019-08-30 14:17:05 -05:00
Maurice Parker 3ab1412dc6 Preserve article selection when articles are downloaded (for iPad only) 2019-08-30 02:39:54 -05:00
Maurice Parker 86a302f787 Prevent selecting of items that may not show the current article selection as is done on the iPhone 2019-08-29 17:49:21 -05:00
Maurice Parker 6844762dfc Refresh smart feeds when they are selected and articles are downloaded 2019-08-29 15:02:45 -05:00
Maurice Parker b98877c7df Fix bug where Feeds wasn't getting updated when adding/subtracting or activating/inactivating accounts 2019-08-29 14:46:51 -05:00
Maurice Parker 197fc0170e Optimize and fix unread count updates 2019-08-29 14:35:18 -05:00
Maurice Parker 8e583c2fad Prevent scrolling when reloading and reselecting a cell. 2019-08-29 14:04:15 -05:00
Maurice Parker 379ba49fd5 Fix select position getting lost on refreshes 2019-08-29 11:53:36 -05:00
Maurice Parker be8c14bc65 Change to reload the individual row instead of just changing its contents 2019-08-28 20:21:50 -05:00
Maurice Parker 7062744758 Make sure we manually correct some state when using diffable datasources 2019-08-28 20:08:30 -05:00
Maurice Parker 89a38fa2b5 Change Feeds to use diffable data sources 2019-08-28 18:06:27 -05:00
Maurice Parker 9c66f6160e Clean activities when the associated data is deleted 2019-08-28 11:30:40 -05:00
Maurice Parker ba9f7ac426 Add navigation support for Folder and Feed view activities 2019-08-27 17:43:15 -05:00
Maurice Parker d641223536 Add Activities for viewing Feeds and Folders 2019-08-27 14:20:34 -05:00
Maurice Parker a1c74a03d1 Update to work with the enhanced FeedIconDownloader 2019-08-26 19:48:12 -05:00
Maurice Parker 6c98abb289 Fix image and favicon caching 2019-08-26 16:58:06 -05:00
Maurice Parker d7c90106d1 Change to directly modify the avatar image instead of calling reload on the cells 2019-08-26 15:37:15 -05:00
Maurice Parker c3e93f4b8c Fix scenario where multiple timelines could get pushed onto the navigation stack 2019-08-26 09:07:41 -05:00
Maurice Parker 3d408d0b27 Prevent autolayout from messing around with our disclosure chevron 2019-08-25 20:06:45 -05:00
Maurice Parker cf5fd4fa89 Invalidate content size correctly 2019-08-25 20:06:02 -05:00
Maurice Parker a0b11da438 Prevent autolayout from messing with our manually set frames 2019-08-25 20:00:34 -05:00
Maurice Parker 31715ad4f0 Handle user activities on a cold launch 2019-08-25 17:49:09 -05:00
Maurice Parker 1e1208f54d Update function name to match other like named functions 2019-08-25 17:08:39 -05:00
Maurice Parker a0636b8f47 Add Smart Feeds as User Activities 2019-08-25 17:04:15 -05:00
Maurice Parker dc6bf05ae4 Rename ActivityFactory to ActivityManager because it will also handle activity deletes in the future 2019-08-25 14:43:11 -05:00
Maurice Parker 0b48c3893d Change AppCoordinator to directly call controller API's since that matches the Coordinator pattern better than sending them notifications 2019-08-25 11:38:04 -05:00
Maurice Parker 313518698c add the ability to respond to NSActivityRequests 2019-08-24 19:31:29 -05:00
Maurice Parker 5b1c0485c5 Add NSUserActivity for reading articles 2019-08-24 14:57:51 -05:00
Maurice Parker 1ba60e2846 Fix bug that could cause a crash when an invalid indexPath was used to find a node in the shadow table 2019-08-23 13:23:13 -05:00
Maurice Parker 7f024586bb Add navigation and toolbar theming for light mode. Issue #698 2019-08-23 12:27:45 -05:00
Maurice Parker 5a5a66d59f Remove unneeded notifications 2019-08-22 16:50:20 -05:00
Maurice Parker 5088878721 Hack around WKWebView's white flashing that it does while loading content 2019-08-22 12:10:50 -05:00
Maurice Parker d67b9193c5 Add large titles to Feeds controller (again) 2019-08-22 11:16:07 -05:00
Maurice Parker c752d0b699 Optimize table cell loading so that we are no longer reloading all visible cells when an image is downloaded 2019-08-21 19:37:19 -05:00
Maurice Parker af98311c63 Change to use async fetch for major account changes 2019-08-21 15:58:55 -05:00
Maurice Parker 2719772701 Port async timeline fetching from desktop NNW 2019-08-21 15:27:53 -05:00
Maurice Parker b025b3ae46 fix typo in comment 2019-08-21 13:13:03 -05:00
Maurice Parker c4e2420966 Change to get currently selected unread count item from total number of articles shown in timeline 2019-08-21 13:10:08 -05:00
Maurice Parker eb8de035d7 Work around bug where cell tintColor isn't always correctly inherited from the window 2019-08-20 16:37:31 -05:00
Maurice Parker 9988847fba Fix bug where mark older than caused all articles in the timeline to be marked as read 2019-08-20 05:46:44 -05:00
Maurice Parker 64fd5016a9 Commenting out feed context menus due to buggy implementation in Beta 6 2019-08-20 05:43:39 -05:00
Maurice Parker b475f52871 Move show share dialog back to detail controller from coordinator 2019-08-19 18:13:21 -05:00
Maurice Parker 71343b9e72 Add Share context menu for timeline 2019-08-19 18:09:38 -05:00
Maurice Parker badc2d3e25 Add open in browser context menu item 2019-08-19 17:38:30 -05:00
Maurice Parker de7970314d Add mark all as read for feed functionality 2019-08-19 17:26:09 -05:00
Maurice Parker 40a80356f1 Move business logic out of controller into coordinator where we typically keep it 2019-08-19 16:03:07 -05:00
Maurice Parker 6087951824 Remove context menu titles as they didn't provide any additional context 2019-08-19 15:49:42 -05:00
Maurice Parker 3245223b24 Add Select Feed context menu 2019-08-19 15:45:52 -05:00
Maurice Parker eeebb30467 Implement Mark Older as Read for timeline 2019-08-18 17:34:53 -05:00
Maurice Parker 3cbf9f45a3 Add weak self usage in a couple needed places 2019-08-16 13:54:19 -05:00
Maurice Parker 066616b005 Add new images used in context menus to AppAssets where they belong 2019-08-16 13:27:41 -05:00
Maurice Parker aabe950b2b Add initial support for timeline context menus 2019-08-16 13:19:06 -05:00
Maurice Parker 2f5225163d Center the pop over arrow in the button the same way that Apple does in Mail 2019-08-16 12:14:55 -05:00
Maurice Parker 7ac18029ea Add additional swipe menu More to handle new actions 2019-08-15 19:46:31 -05:00
Maurice Parker e8bbe9efbf Add Folder context menu 2019-08-15 17:46:42 -05:00
Maurice Parker e88210bbb7 Add copy url actions for feeds 2019-08-15 15:19:23 -05:00
Maurice Parker c03c444997 Add initial context menu items for feeds. 2019-08-15 13:19:02 -05:00
Maurice Parker 1eb8da7749 Rearrange some code to put them in the correct sections 2019-08-15 12:42:25 -05:00
Maurice Parker 99e2a44eed Fix crash that could happen on launch because the background task wasn't registered before it was triggered 2019-08-14 19:48:18 -05:00
Maurice Parker 659597e5e4 Fix about box for dark mode 2019-08-04 13:43:35 -05:00
Maurice Parker f8eb750d56 Fix background color to respect dark mode 2019-08-04 13:23:34 -05:00
Maurice Parker 55da318503 Fix bug that was causing new feeds to be created with and empty string name 2019-08-04 13:20:37 -05:00
Maurice Parker 0b9522261e Removed unused color for folders. This has been replaced with the tint color. 2019-08-03 17:28:45 -05:00
Maurice Parker e39972bd64 Correct First Unread button to select the first unread in the timeline and show article in detail view. Issue #695 2019-08-03 17:07:43 -05:00
Maurice Parker 0269683b16 Reenable tinting now that at the beta OS releases don't crash when using them 2019-08-03 16:34:35 -05:00
Maurice Parker 02575c31fe Change selected table row text to be white. Issue #693 2019-08-03 16:25:35 -05:00
Maurice Parker 4ece4173ba Fix show back bar button bug introduced in last refactoring 2019-08-03 13:56:18 -05:00
Maurice Parker 9aa8ea7dc9 Refactor some common code and wrote copious comments 2019-08-03 13:53:30 -05:00
Maurice Parker 43d0d0c889 Reformat statement 2019-08-03 13:24:51 -05:00
Maurice Parker 9768d8ca55 Fix bugs in detail back button when transitioning from collapsed mode 2019-08-03 11:44:05 -05:00
Maurice Parker a30b03bcea Remove obsolete code 2019-08-03 11:43:21 -05:00
Maurice Parker e4c3590111 Made code formatting more consistent 2019-08-03 11:09:12 -05:00
Maurice Parker d5094dd103 Deleted obsolete code 2019-08-03 11:06:55 -05:00
Maurice Parker 0baf15b588 Fix root split view controller collapsing and splitting when no in all visible mode 2019-08-03 10:55:46 -05:00
Maurice Parker e52b3531d9 Add missing shim controller 2019-08-02 18:14:49 -05:00
Maurice Parker 7acf77f572 Enable collapsing and splitting of root split view controller 2019-08-02 16:46:55 -05:00
Maurice Parker 8753790a19 Fix bug that lost detail view when transitioning to three panel mode 2019-08-02 10:34:32 -05:00
Maurice Parker 54f6607621 Keep table selections when root split isn't collapsed 2019-08-02 10:25:47 -05:00
Maurice Parker 52055d83f5 Made the detail panel slightly larger than the others in three panel mode 2019-08-02 09:12:15 -05:00
Maurice Parker d7afc30ed3 Remove dead code 2019-08-02 04:42:48 -05:00
Maurice Parker e0832260b8 Fix timeline selected transition to three panel mode 2019-08-02 04:29:42 -05:00
Maurice Parker 4f49a4bcf6 Fix code formatting 2019-08-02 04:23:41 -05:00
Maurice Parker 7da1aacf28 Fix transition to three panel mode 2019-08-02 04:22:47 -05:00
Maurice Parker 7b7fb7ef2a Adjust font to silence dynamic type warning 2019-08-01 20:24:54 -05:00
Maurice Parker 9e0a4aed00 Correctly handle showing the detail view when the root view controller is collapsed 2019-08-01 20:06:55 -05:00
Maurice Parker e22088b284 Implemented Shim Controller so that we can change out the secondary split view controller when the display mode changes 2019-08-01 19:59:56 -05:00
Maurice Parker d16386d205 Add transitioning for three panel mode 2019-08-01 16:14:34 -05:00
Maurice Parker 2ab3ff76fb Make settings button work second split controller is installed 2019-08-01 07:10:02 -05:00
Maurice Parker 88c6f2274b Refactor how the No Selection message is displayed 2019-08-01 06:53:34 -05:00
Maurice Parker ccd0385220 Prevent flicker when selected feed's unread count changes. 2019-07-30 13:08:58 -05:00
Maurice Parker 978aeeee80 Restore selection when currently select feed unread count changes 2019-07-27 15:05:21 -05:00
Maurice Parker adb6309872 In Three Pane Mode only show the progress indicator on the Feeds controller 2019-07-27 14:49:07 -05:00
Maurice Parker cf674d67b1 Show no selection when timeline is selected in Three Panel Mode 2019-07-27 14:36:01 -05:00
Maurice Parker e009a31ed7 Rename isThreePane to isThreePanelMode 2019-07-27 14:25:10 -05:00
Maurice Parker 59537c5705 Automatically hide the overlay and only add the navigation controller to detail views when not collapsed 2019-07-26 16:26:22 -05:00
Maurice Parker 306af515ea Remove duplicate split view controller initialization on launch 2019-07-26 09:58:46 -05:00
Maurice Parker d2a09a92ae Fix timeline selection in three pane mode 2019-07-19 17:27:56 -05:00
Maurice Parker 1ddf4189d3 Initial support for three pane mode 2019-07-19 15:59:46 -05:00
Maurice Parker 871ccbd728 Fix variable name 2019-07-19 14:47:25 -05:00
Maurice Parker a47e4cab77 Show No Selection system message when selection is cleared by returning to the Feeds list 2019-07-19 12:29:17 -05:00
Maurice Parker 11d74372b1 Change how the AppCoordinator is initialized 2019-07-19 11:59:08 -05:00
Maurice Parker dd8c70f558 Hook up initial detail view controller back button 2019-07-18 18:51:40 -05:00
Maurice Parker b5411cde42 Fix detail navigation controller code 2019-07-18 18:49:27 -05:00
Maurice Parker d01f356869 Add System Message view controller 2019-07-18 18:20:15 -05:00
Maurice Parker c034aac385 Added system message view controller 2019-07-18 18:19:32 -05:00
Maurice Parker b25e789aef Prevent refresh errors from keeping the refreshControl visible when error dialogs are displayed. 2019-07-18 15:16:54 -05:00
Maurice Parker 5773e5b39c Updated to use new fetchArticles API 2019-07-12 13:01:34 -05:00
Maurice Parker 8e278ea843 Merge branch 'master' of https://github.com/brentsimmons/NetNewsWire 2019-07-12 12:31:36 -05:00
Brent Simmons 304250e127 Use updated iOS app icon assets from Brad. 2019-07-10 22:53:45 -07:00
Maurice Parker 8b6e2fa517 Move more logic out of MasterTimelineViewController and into AppCoordinator 2019-07-06 12:31:07 -05:00
Maurice Parker 6e59c56515 Move more logic out of MasterFeedViewController and into AppCoordinator 2019-07-06 12:25:45 -05:00
Maurice Parker d543b979ac Move more logic out of the DetailViewController and into the AppCoordinator 2019-07-06 11:49:53 -05:00
Maurice Parker 4884aebbfd Encapsulate more of the AppCoordinate API 2019-07-06 11:32:19 -05:00
Brent Simmons 6f669c2aba Add new app icon resources. 2019-07-05 23:09:54 -07:00
Maurice Parker 15754684a4 Move more navigation responsibilities into the AppCoordinator 2019-07-05 17:45:39 -05:00
Maurice Parker 19f8f8bc97 Fix missing settings button on iPhone 2019-06-29 13:53:34 -05:00
Maurice Parker fcf2937394 Rename NavStateController to AppCoordinator because we are redesigning it to be the Coordinator pattern 2019-06-29 13:35:12 -05:00
Maurice Parker 3fc3903758 Change to use helper property 2019-06-28 13:05:19 -05:00
Maurice Parker 178e89b1fb Add basic multi window support to iOS 2019-06-28 10:28:02 -05:00
Maurice Parker 55ab50289c Temporally comment out tint code because it is crashing on iPadOS 13 beta 2 2019-06-27 17:56:33 -05:00
Maurice Parker 188bacee25 Move nav state ownership to MasterFeedViewController 2019-06-27 16:30:24 -05:00
Maurice Parker 5f045706e4 Removed usaged of UIApplication.present 2019-06-27 14:21:07 -05:00
Maurice Parker 95d4395416 Fix feed / folder rename for iOS 2019-06-26 06:23:08 -05:00
Maurice Parker 19df44058b Fix white flashing in WKWebView on iOS 2019-06-26 06:06:10 -05:00
Maurice Parker 975d17e32d Correct colors for dark mode 2019-06-25 18:16:04 -05:00
Maurice Parker 0ac9abdd52 Navigate back to feeds after marking all as read 2019-06-25 17:39:07 -05:00
Maurice Parker aff14b19ee Force unread indicator to be redisplayed to get rid of missing unread indicators 2019-06-25 15:43:30 -05:00
Maurice Parker b877e4dc83 Move NavState ownership to the AppDelegate 2019-06-25 12:10:07 -05:00
Maurice Parker e8e0f3b8bd Temporarily disabled SwiftUI compiling 2019-06-23 17:41:41 -05:00
Stuart Breckenridge d6ea5bd636 Deletes assets not required 2019-06-21 22:40:17 +08:00
Stuart Breckenridge 5e5c0e0e3d Rolls back low power changes. 2019-06-21 22:16:02 +08:00
Stuart Breckenridge 183490d3b0 SF Symbols
SF Symbols

• Updates more of AppAssets to use SF Symbols and tints using `withTintColor` rather than `maskWithColor` to stop the aliasing appearing.

• Updates Storyboard to use SF Symbols where appropriate.
2019-06-21 15:29:20 +08:00
Stuart Breckenridge 7d226c46a4 Merge remote-tracking branch 'upstream/master'
# Conflicts:
#	iOS/AppAssets.swift
2019-06-21 15:27:44 +08:00
Stuart Breckenridge 11961605d5 SF Symbols
• Updates more of AppAssets to use SF Symbols and tints using `withTintColor` rather than `maskWithColor` to stop the aliasing appearing.

• Updates Storyboard to use SF Symbols where appropriate.
2019-06-21 14:24:52 +08:00
Stuart Breckenridge fbf2da0ab5 Set bgtask to complete 2019-06-21 12:58:36 +08:00
Stuart Breckenridge d9a4d42ca0 Low Power: Stops background feed refresh 2019-06-21 10:54:53 +08:00
Maurice Parker 2ee72125ba Support dark mode for small avatars on iOS 2019-06-20 11:58:26 -05:00
Maurice Parker 6c55fdd8ec Make progress indicator NetNewsWire blue 2019-06-20 11:30:55 -05:00
Maurice Parker 9f47139011 Update iOS to work with the latest Account API 2019-06-20 11:27:35 -05:00
Maurice Parker 6765206a1b Update iOS to use FreshRSS branding 2019-06-20 07:33:17 -05:00
Stuart Breckenridge ddfb5a8aaa Switches folder image to SFSymbol folder.fill 2019-06-20 20:18:43 +08:00
Stuart Breckenridge ec609bbe7d Adds section header background view
Stops collapsing sections from appearing under the section view header.
2019-06-20 17:24:23 +08:00
Stuart Breckenridge 7b99c0f4af Switches from folder image to tag. 2019-06-20 16:58:27 +08:00
Stuart Breckenridge f19b4ee780 Merge remote-tracking branch 'upstream/master' 2019-06-20 07:10:09 +08:00
Stuart Breckenridge 3e54482952 Corrects issues related to PR #767 2019-06-20 07:09:42 +08:00
Maurice Parker 74f84dc000 Restrict OPML import for Account types that don't support it 2019-06-19 17:50:32 -05:00
Maurice Parker b4b80c51bc Renamed google reader api to just reader api to make it consistent everywhere we use it 2019-06-19 15:40:03 -05:00
Jeremy Beker 15ae97f7c9
Merge branch 'master' into google_reader_compatible_syncing 2019-06-19 13:53:30 -04:00
Maurice Parker d794240bd9 Merge branch 'mac-candidate' 2019-06-19 11:31:38 -05:00
Jeremy Beker d87f68a006
Renamed GoogleReaderCompatible to just Reader 2019-06-19 12:25:37 -04:00
Stuart Breckenridge 449dde54c5 Merge remote-tracking branch 'upstream/master' 2019-06-19 23:26:11 +08:00
Stuart Breckenridge ace8197814 Adds support for BGAppRefreshTask 2019-06-19 23:26:03 +08:00
Jeremy Beker c8b9cf4d2c
Merge branch 'master' into google_reader_compatible_syncing 2019-06-19 07:56:54 -04:00
Maurice Parker 716653c235 Implement NetNewsWire Blue for cell selection and tint. Issue #691 & #692 2019-06-18 18:31:37 -05:00
Maurice Parker ae2c4b9d25 Update timeline to use new semantic colors (darkmode support) 2019-06-18 17:47:13 -05:00
Maurice Parker 86e1a58b06 Move About section to bottom of Settings and add build number 2019-06-18 17:38:20 -05:00
Maurice Parker ba41d0dee0 Change Settings to use Form instead of List/grouped 2019-06-18 16:54:51 -05:00
Jeremy Beker 97585326c8
Merge branch 'master' into google_reader_compatible_syncing
# Conflicts:
#	iOS/Settings/SettingsAddAccountView.swift
2019-06-18 15:38:59 -04:00
Jeremy Beker 596e9c4537
Use proper google credential. 2019-06-18 15:37:39 -04:00
Maurice C Parker 231011685c Remove deprecated API use 2019-06-17 18:26:37 -05:00
Maurice C Parker e6b8056402 Merge remote-tracking branch 'refs/remotes/origin/master' 2019-06-17 17:49:41 -05:00
Maurice C Parker 011a93a41f Update to work with the latest SwiftUI API's 2019-06-17 17:48:32 -05:00
Maurice Parker 35866d558d Only display active accounts for OPML import on iOS 2019-06-17 15:50:17 -05:00
Maurice Parker c966d3c7ed Begin work on porting the add feed/folder dialog to SwiftUI 2019-06-17 09:03:21 -05:00
Maurice Parker fb29d006aa Code formatting changes 2019-06-17 07:20:39 -05:00
Jeremy Beker 125ea59cd6
Wiring up iOS add account settings 2019-06-16 18:22:00 -04:00
Maurice Parker d4e2d44d8f Add OPML Export for SwiftUI 2019-06-16 11:19:15 -05:00
Maurice Parker 3af60f0edc Add Import OPML functionality 2019-06-16 10:54:18 -05:00
Maurice Parker b8b2f23333 Move SafariView to Wrappers group since it is a reusable SwiftUI View 2019-06-16 10:21:03 -05:00
Maurice Parker 8cb46eb1d3 Merge branch 'pr/757' 2019-06-16 07:03:06 -05:00
Stuart Breckenridge 2f4d1145f4 Opens Settings option in SFSafariViewController
Fixes #754
Fixes #756
2019-06-16 07:23:32 +08:00
Maurice Parker dc75737c97 Add Import/Export OPML action sheet. 2019-06-15 18:19:20 -05:00
Maurice Parker 8dcf4966fb Port Feedbin credential update too SwfitUI. 2019-06-15 16:03:41 -05:00
Maurice Parker 40b9be6709 center smaller avatars on a solid color background image to make all avatars a consistent size 2019-06-14 15:33:13 -05:00
Maurice Parker 58459631e4 Add SwiftUI account detail view 2019-06-13 14:30:56 -05:00
Maurice Parker ddb61489c4 Add a little padding around the account selectors. 2019-06-12 13:25:14 -05:00
Maurice Parker 37f42e2ad8 Added Feedbin add account logic. 2019-06-12 08:33:14 -05:00
Maurice Parker 50ab15f2cc Dismiss view after adding account or canceling. 2019-06-12 03:08:51 -05:00
Maurice Parker 902304c723 Convert Settings to use SwiftUI 2019-06-11 16:59:16 -05:00
Maurice Parker e8992dac95 Fix issue where deletes were crashing the app. Issue #702 2019-06-05 17:42:35 -05:00
Maurice Parker e428a4f785 Prevent add controllers from using the whole screen. Issue #710 2019-06-03 05:13:55 -05:00
Maurice Parker 6afd65858a Add the ability to update iOS account credentials 2019-06-03 05:04:03 -05:00
Maurice Parker a697f98228 Pop add controller to go back to settings after an account add 2019-06-03 04:22:58 -05:00
Maurice Parker fd02f8be11 Make about label uneditable 2019-06-03 04:13:58 -05:00
Maurice Parker 00ee775170 Made timeline layout tweaks to make indicator, avatar, and first line of text line up better. Issue #689 2019-05-31 17:58:39 -05:00
Maurice Parker e348a1f9ed Remove layout caching that was causing seemly random layout issues. Issue #714 2019-05-31 16:59:02 -05:00
Maurice Parker e7c339fb09 Update iOS to work with the latest Account API 2019-05-30 17:41:56 -05:00
Maurice Parker 493abbb609 Refactor create feed functionality to increase code reuse and encapsulation 2019-05-28 09:45:02 -05:00
Phil Viso 6168f01822 Updated margins and sizing of unread indicator to match the mail app. Issue #690 2019-05-27 18:46:57 -05:00
Phil Viso 092b72d44c Updated timeline to default to 3 lines for the title. Issue #694 2019-05-27 18:46:53 -05:00
Maurice Parker c61949bc04 Add account name to network error messages and prevent background iOS errors from displaying alerts 2019-05-26 11:54:32 -05:00
Aaron Raimist 256b805684
Set email text field content type to username so iOS offers to autofill passwords
This is what Apple says to do for email fields. https://developer.apple.com/documentation/security/password_autofill/enabling_password_autofill_on_a_text_input_view

> For example, if your site uses email addresses as user names, set the input view’s textContentType property to .username, and set the keyboardType property to .UIKeyboardType.emailAddress.
2019-05-25 16:04:48 -05:00
Maurice Parker 202b7ff5f4 Remove App Camp for Girls donation link. 2019-05-25 14:52:31 -05:00
Maurice Parker 08310aacc9 Reformat add scene so that it looks like the Settings app add scene. 2019-05-25 14:49:34 -05:00
Phil Viso bae17df0e9 Use modal presentation for add account view controllers 2019-05-24 10:07:17 -05:00
Phil Viso 19881427c9 Fixed a crash that occurs when presenting the share sheet on iPad. Issue #639 2019-05-24 09:56:26 -05:00
Maurice Parker e8645ab0c8 Made add account icons tint match 2019-05-23 09:08:48 -05:00
Phil Viso cee87ab25a Centered email and password text 2019-05-22 21:20:56 -05:00
Phil Viso 071bfd6a45 Show disclosure indicator for add account cells 2019-05-22 21:19:13 -05:00
Phil Viso 13c0f3a09c UI improvements for add feedbin account 2019-05-22 21:17:50 -05:00
Phil Viso 3e97754ab9 Removed navigation controller from storyboard for add account view controller 2019-05-22 20:31:01 -05:00
Phil Viso d1684a1c69 Improved the UI of adding a new local account 2019-05-22 20:29:00 -05:00
Phil Viso fd88f94959 Left align add account selection 2019-05-22 20:00:18 -05:00
Phil Viso 490b84719a Cleaned up margins and added dynamic type support to account detail screen 2019-05-22 19:43:12 -05:00
Phil Viso 336d7a8cc7 Use default account name as placeholder text 2019-05-22 19:42:06 -05:00
Maurice Parker 3207ebf6a5 Implement default timeline avatar. Issue #641 2019-05-21 05:42:40 -05:00
Maurice Parker 59ea5cadec Add status syncing to iOS 2019-05-20 13:51:08 -05:00
Phil Viso 633e291c2e Decrement the static row count instead of using hard-coded values 2019-05-19 19:20:35 -05:00
Phil Viso 1271fc9081 Update UI when accounts change or when account state changes 2019-05-19 19:18:28 -05:00
Phil Viso 719fb54311 Allow delete account row to be tapped 2019-05-19 19:08:49 -05:00
Phil Viso 1f8463d091 Merge branch 'master' of https://github.com/brentsimmons/NetNewsWire into iPadPopover
# Conflicts:
#	iOS/Settings/AddLocalAccountViewController.swift
#	iOS/Settings/DetailAccountViewController.swift
#	iOS/Settings/Settings.storyboard
2019-05-19 19:03:50 -05:00
Phil Viso db3d8e484b Made the preferred size wider 2019-05-19 18:41:28 -05:00
Phil Viso 8c28160f91 Always clear selection on viewWillAppear 2019-05-19 18:39:15 -05:00
Phil Viso 02a7130415 Moved Add NetNewsWire feed to about section, and hide it if they don’t have any active feeds 2019-05-19 18:35:45 -05:00
Phil Viso 8ca14e2b95 Add a vertical spacing constraint between the folder labels, so they don’t overlap for larger names 2019-05-19 18:24:07 -05:00
Phil Viso 32d572307f Updated labels to use dynamic type 2019-05-19 18:19:03 -05:00
Phil Viso 99010e8e3e Made text size larger and updated label margins to use standard value 2019-05-19 18:13:10 -05:00
Maurice Parker 50b68096cd Add Feedbin account and delete account functionality added to iOS 2019-05-19 18:04:32 -05:00
Phil Viso 5280d1c75d Made text size larger and fixed trailing margin for account name label 2019-05-19 18:04:12 -05:00
Phil Viso 34c6341b4c Further sizing improvements on iPad. Only show add feed / folder pickers when there is more than 1 item to display. 2019-05-19 17:48:03 -05:00
Phil Viso 2f82f05721 Improved sizing of add feed modal on iPad 2019-05-19 17:47:33 -05:00
Phil Viso bce45d28e4 Updated all iOS references to default local account new to be device specific 2019-05-19 16:52:21 -05:00
Maurice Parker 16f2f43cc7 Rename AccountsDidChangeNotification to AccountsDidChange to match other notification names 2019-05-19 16:36:33 -05:00
Phil Viso 890c146c7e Dismiss keyboard when text fields are done editing 2019-05-19 16:17:10 -05:00
Phil Viso 9d72fede05 Don’t reference nameTextField directly when dismissing the keyboard 2019-05-19 16:14:23 -05:00
Phil Viso 90ea9ebb50 Disable add new item button when there are no active accounts 2019-05-19 16:08:48 -05:00
Phil Viso 438745f246 Removed empty cell 2019-05-19 16:05:20 -05:00
Phil Viso 40358f5801 Don’t allow the cells to be selected 2019-05-19 16:02:31 -05:00
Phil Viso 4383f269a5 Dismiss the keyboard after account name is finished editing 2019-05-19 16:01:14 -05:00
Maurice Parker a40842d928 Add multiple local accounts to iOS 2019-05-19 14:18:11 -05:00
Maurice Parker da7dcc2405 Remove quality assurance checks from avatar image in timeline 2019-05-19 13:03:07 -05:00
Maurice Parker f36b5a7970 Add account detail so that we can edit account name and account active on iOS. 2019-05-17 17:25:47 -05:00
Maurice Parker 970b7535dc Add add account selection scene for iOS 2019-05-16 17:45:38 -05:00
Maurice Parker 53f65d39bb Update settings to begin to support multiple accounts 2019-05-16 15:48:55 -05:00
Maurice Parker 0398021345 Restore feed if second part of move fails. 2019-05-16 12:42:01 -05:00
Maurice Parker 7de24e1d53 Fix compile error in iOS caused by recent changes to Account 2019-05-14 14:02:49 -05:00
Maurice Parker fd8a973084 Add already subscribed error to LocalAccountDelegate and updated iOS to work with latest Account API 2019-05-10 10:22:28 -05:00
Maurice Parker 2401c96c99 Update iOS to work with latest from the Accounts framework 2019-05-09 17:30:36 -05:00
Maurice Parker e45362bffc Update iOS to work with new delete API. 2019-05-09 07:28:51 -05:00
Maurice Parker 43d32b1281 Add create Feedbin feed 2019-05-08 17:41:19 -05:00
Maurice Parker 7f9055fe78 Add download subscriptions and faviconURLs 2019-05-07 10:51:41 -05:00
Maurice Parker 636468bbf0 Implement active account processing functionality 2019-05-02 06:01:30 -05:00
Maurice Parker f5dbe7117e Delete dead code 2019-05-01 14:56:26 -05:00
Maurice Parker 6ede5b7c3d Enable add feed for multiple accounts 2019-05-01 14:03:59 -05:00
Maurice Parker 4bc7611721 Rename AccountManageer.localAccount to AccountManager.defaultAccount to make it different from other local accounts 2019-05-01 05:53:18 -05:00
Maurice Parker a5a5eb1df0 Reuse layout calcs when possible on timeline 2019-04-29 17:45:12 -05:00
Maurice Parker f357f27ae1 Fix typo in timeline text setting 2019-04-29 17:25:41 -05:00
Maurice Parker ac93b91df9 Add accessibility layout to timeline 2019-04-29 17:19:08 -05:00
Maurice Parker bf45cb89e9 Set table estimated row height to improve scrolling performance 2019-04-29 16:29:53 -05:00
Maurice Parker 0451ed9e70 Made number of lines in timeline configurable. 2019-04-29 15:29:00 -05:00
Maurice Parker b4e2acb5ce Make responsive to dynamic font changes. 2019-04-29 14:50:56 -05:00
Maurice Parker e37d4ddd2f Implement new timeline layout. 2019-04-29 14:40:14 -05:00
Maurice Parker 2efbd44811 Fix to stop background refresh when interval set to manually. 2019-04-29 09:29:57 -05:00
Maurice Parker d2482233ab Change indent width to match other iOS outline view indent widths 2019-04-29 09:20:45 -05:00
Maurice Parker 2dcde1ab8e Create generic feed icon and timeline avatar 2019-04-29 07:07:57 -05:00
Maurice Parker ffc364f7cf Change to have mark as read be the default action on timeline swiping instead of starred 2019-04-29 06:01:53 -05:00
Maurice Parker da8c40d38f Change how avatars are selected so that poor quality avatars are passed up for their feed favicon 2019-04-29 05:51:47 -05:00
Maurice Parker 2e178dbebc Add content mode to prevent stretching of avatar images less than 48x48 2019-04-28 19:27:58 -05:00
Maurice Parker bf50c7a7e3 Update the nav controller title so that the back bar button item in iPad portrait has a valid title 2019-04-28 18:53:57 -05:00
Maurice Parker 5cdbaafc8e Use a higher resolution folder graphic 2019-04-28 17:33:38 -05:00
Maurice Parker 3d1c0d3e28 Changed default feed favicon to a globe so that it matches the desktop default feed favicon 2019-04-28 17:22:54 -05:00
Maurice Parker 37c25e33c2 Increase the resolution of the smart feed icon so that it doesn't look terrible on retina displays 2019-04-28 17:07:01 -05:00
Maurice Parker a071bf0f6e Slightly increased the favicon size 2019-04-28 16:54:45 -05:00
Maurice Parker c8b3442854 Change favicon placement so that it no longer centers on multiline rows 2019-04-28 16:51:34 -05:00
Maurice Parker 2724dbf4f2 Align separator start with the text on the timeline 2019-04-28 16:08:02 -05:00
Maurice Parker dcb65f6454 Fix table section header background color 2019-04-28 15:53:16 -05:00
Maurice Parker c9d9045a7f Respond in realtime to dynamic type changes with the unread indicator 2019-04-28 15:44:35 -05:00
Maurice Parker a5cfeb1f12 Make smart feed icon color configurable 2019-04-28 15:11:02 -05:00
Maurice Parker 00cb29c5c1 Align separator insets with first letter of name 2019-04-28 14:56:36 -05:00
Maurice Parker 00f19f47aa Deleted debugging code that crept into the repo 2019-04-28 14:47:14 -05:00
Maurice Parker 44eae7e70c Deselect table row on settings table click 2019-04-28 14:45:09 -05:00
Maurice Parker 9b17f3394f Made settings selection color match app selection color. 2019-04-28 14:39:35 -05:00
Maurice Parker c4c67dec6e Fix typo that was causing unread counts to go missing. 2019-04-28 12:52:40 -05:00
Maurice Parker 38a3cde8a6 Force unread count updates to reload cells as they can change the height of cells now by reflowing the name 2019-04-28 12:37:53 -05:00
Maurice Parker 95430913bd Fix dynamic type edit cell layout bug 2019-04-28 12:08:50 -05:00
Maurice Parker 2662352541 Fix dynamic type bug in account section header layouts where the account name needed to wrap 2019-04-28 11:25:21 -05:00
Maurice Parker d7391b208d implement dynamic type for master feed list 2019-04-28 10:31:35 -05:00
Maurice Parker 5fc3fee12d Rename a couple functions that needed clarification 2019-04-28 06:46:50 -05:00
Maurice Parker 48173fe43c Delete old unused image assets and preserve vector data for ones in bar button items 2019-04-27 17:22:40 -05:00
Maurice Parker 653c221328 Provide titles for bar button items that were missing them 2019-04-27 17:22:05 -05:00
Maurice Parker df43dad23e Hack around UIKit bug in static tables with dynamic type 2019-04-27 17:21:29 -05:00
Maurice Parker 97c62f7546 Tweak to refresh interval layout to make it work better with dynamic type. 2019-04-27 16:24:43 -05:00
Maurice Parker ae63805479 Change property to have correct swift naming convention name 2019-04-27 16:16:46 -05:00
Maurice Parker a5c065fcb9 Add debug statement for OS killing the process when it runs too long. 2019-04-27 13:59:57 -05:00
Maurice Parker 9400ea361e Add notification for downloaded article(s). 2019-04-27 13:54:52 -05:00
Maurice Parker a576111e46 Tweak some of the detail toolbar item images 2019-04-27 11:23:10 -05:00
Maurice Parker 8be54564e4 Enable dynamic type on detail view. 2019-04-27 10:49:54 -05:00
Maurice Parker 1730ffb0cc Add accessibility labels to bar button image items. 2019-04-27 10:27:36 -05:00
Maurice Parker 7127f9a911 Change master feed list to use preferred fonts. 2019-04-27 09:49:26 -05:00
Maurice Parker b62565f651 Remove content mode from avatar as they are prescaled. 2019-04-27 09:47:36 -05:00
Maurice Parker 6355e3f007 Made settings dynamic type compliant 2019-04-27 08:16:37 -05:00
Maurice Parker da856a14e1 Added CSS to break long words that squish content. Issue #624 2019-04-26 17:59:47 -05:00
Maurice Parker 072ff110f3 Add copyright to about scene footer. 2019-04-26 17:55:41 -05:00
Maurice Parker eae202a7ff Enable refresh if none has happened in 15 minutes when application becomes active 2019-04-26 15:24:39 -05:00
Maurice Parker e10bfde6d9 Rollback code created to support background downloads that are no longer needed 2019-04-26 14:21:17 -05:00
Maurice Parker 76b922546c Add build info to settings scene. 2019-04-26 14:04:52 -05:00