Commit Graph

412 Commits

Author SHA1 Message Date
Maurice Parker b25c8634ca Add missing subscription command 2020-07-18 23:13:57 -05:00
Maurice Parker a243601695 Fetch and merge articles for the timeline. Issue #2281 2020-07-18 23:09:39 -05:00
Maurice Parker c4ec9606f3 Delete empty lines 2020-07-18 21:38:00 -05:00
Maurice Parker 859d9fc972 Change to use the standard cancellables set 2020-07-18 21:33:24 -05:00
Maurice Parker 16555d829a Clear the timeline when there are no feeds selected. 2020-07-18 21:16:55 -05:00
Maurice Parker 8291230561 Fix the iPad which seems to like to set the selected value to nil after setting it to the correct selection 2020-07-18 21:02:38 -05:00
Maurice Parker 9240c8e8a9 Add space between section header and feed url, since macOS doesn't add it like it should 2020-07-18 20:22:41 -05:00
Maurice Parker 68f4ea88c9 Hide home url section if one isn't available 2020-07-18 20:18:57 -05:00
Maurice Parker 86a38edabd
Merge pull request #2283 from stuartbreckenridge/hotfix/inspector-tweaks
Inspector tweaks
2020-07-18 19:57:18 -05:00
Maurice Parker 8cbc18c45e Refactor TimelineModel to use Combine more fully 2020-07-18 19:56:30 -05:00
Stuart Breckenridge 03c60a2979
Adds default cancel keyboard shortcut 2020-07-19 08:25:26 +08:00
Stuart Breckenridge 526a98f326
Switches to AppAssets 2020-07-19 08:12:20 +08:00
Stuart Breckenridge 4d227e7e2c
Inspector tweaks
- [x] Account Inspector should have an Active toggle (see iOS)
 - [x] Feed Inspector Home Page should open the link in browser when tapped
- [x] Feed Inspector Home Page should have a browser icon (see iOS)
- [x] Feed Inspector Home Page URL should line wrap
- [x] Feed Inspector Feed URL should be copiable (currently this is a long press on iOS)
- [x] Feed Inspector Feed URL should line wrap
- [x] Inspector should use inset style on iOS
2020-07-19 07:57:25 +08:00
Maurice Parker 9732ca10f3 Made Sidebar Combine correct 2020-07-18 17:10:45 -05:00
Maurice Parker d36870028a Refactor Combine code to make it more readable 2020-07-18 16:53:30 -05:00
Maurice Parker 271f7433d4 Use a table to look up TimelineItem position instead of spinning through the TimelineItems 2020-07-18 16:36:20 -05:00
Maurice Parker 3899fe7fd9 Use the fetch filter option to speed up timeline rendering 2020-07-18 16:12:10 -05:00
Maurice Parker 6a33060473 Fix sidebar rename bug 2020-07-18 15:24:48 -05:00
Maurice Parker 876f978347 Standardize notification handling on Combine instead of selectors 2020-07-18 15:20:15 -05:00
Maurice Parker 5845925b3a
Merge pull request #2278 from stuartbreckenridge/feature/feed-inspector
Notifications/Reader View/InspectorModel
2020-07-18 10:57:22 -05:00
Stuart Breckenridge 5fb44a30ea
actually updates readerview value 2020-07-18 21:46:39 +08:00
Stuart Breckenridge 5a7c3111ce
Removes rename 2020-07-18 21:24:06 +08:00
Stuart Breckenridge 0e2b8fd514
Adds `InspectorModel`
`InspectorModel` covers previous management of notifications, reader view, and name changes.
2020-07-18 21:21:59 +08:00
Stuart Breckenridge dece406f56
Confirm changed to Done 2020-07-18 19:31:56 +08:00
Maurice Parker 1a46167355
Merge pull request #2277 from stuartbreckenridge/feature/feed-inspector
Update InspectorView.swift
2020-07-18 05:24:20 -05:00
Stuart Breckenridge f525081f6e
Update InspectorView.swift 2020-07-18 18:23:07 +08:00
Maurice Parker 69c92e795b
Merge pull request #2276 from stuartbreckenridge/feature/feed-inspector
Inspector Views
2020-07-18 05:00:15 -05:00
Maurice Parker e391b29353 Implement the Mark All as Read button 2020-07-18 04:58:46 -05:00
Maurice Parker 40e0a1b676 Launch with correct views instead of using placeholder text views 2020-07-18 04:35:44 -05:00
Stuart Breckenridge 8f8afb5dbb
Inspector View
Inspector Views for macOS and iOS
2020-07-18 17:34:04 +08:00
Maurice Parker be60b112d0 Remove computed properties from TimelineItem 2020-07-17 20:55:18 -05:00
Maurice Parker 2a4a13ed13 Implement mark all as read in feed context menu for timeline 2020-07-17 20:29:53 -05:00
Maurice Parker 644e9da1c0 Implement open in browser timeline context menu item. 2020-07-17 20:08:49 -05:00
Maurice Parker a102b9f63d Add marking starred and read context menu items to Timeline 2020-07-17 19:46:05 -05:00
Maurice Parker 538d886bf4 Correct about/below mark as read to take into account multiple select 2020-07-17 18:15:42 -05:00
Maurice Parker 11bd3dce22 Change sidebar context menu to use trailing closure syntax 2020-07-17 18:05:26 -05:00
Maurice Parker 067041195d Implement Mark Above and Mark Below context menu items. 2020-07-17 17:59:35 -05:00
Maurice Parker 37a84395fe Add in missing file 2020-07-17 17:34:11 -05:00
Maurice Parker 048da0bf79 Separate the sidebar context menu into a standalone different file 2020-07-17 17:27:08 -05:00
Maurice Parker 78fdf0a0d0 Enable open in browser toolbar button. 2020-07-17 17:08:08 -05:00
Maurice Parker 74b878fa6f Disable safari and share toolbar buttons when no articles are selected 2020-07-17 13:55:54 -05:00
Stuart Breckenridge 19d4afc467
On macOS, just change the colorScheme 2020-07-17 22:33:38 +08:00
Stuart Breckenridge b739f6dd61
Improves behaviour of dark/light changes on iOS 2020-07-17 22:18:10 +08:00
Stuart Breckenridge ee69714b90
Adds timeline preview to viewing pane 2020-07-17 20:47:49 +08:00
Stuart Breckenridge cda315aa6b
Adds a separate pane for viewing preferences
Fixes #2183
2020-07-17 10:01:20 +08:00
Maurice Parker 8f7b8160a1 Make Timeline text layout like current apps 2020-07-16 19:36:20 -05:00
Maurice Parker cdf8ad1277 Remove web provider queue flush on multiplatform 2020-07-16 13:44:19 -05:00
Maurice Parker 2b0f6f4e77 Deselect articles when switching selected feeds 2020-07-16 12:27:40 -05:00
Maurice Parker 0425bb8ae3 Fix compile error caused by API change 2020-07-16 11:53:26 -05:00
Maurice Parker e5bf13edca Tweak API to stop web view controller rebuiding 2020-07-16 11:51:33 -05:00
Maurice Parker 364bcf9d4d Implement new ArticleView API for iOS 2020-07-16 11:42:07 -05:00
Maurice Parker 5f573fc985 Make article rendering stop flashing! 2020-07-16 11:14:05 -05:00
Maurice Parker 9836fb781c Rename variable to make its intent clear 2020-07-16 10:53:54 -05:00
Maurice Parker 92f6ee3f42 Coalesce refresh progress updates 2020-07-15 21:32:56 -05:00
Maurice Parker 46762bf297 Implement refresh progress bar for macOS 2020-07-15 21:24:22 -05:00
Maurice Parker 69fa598d99 Enable refresh button on macOS 2020-07-15 20:09:11 -05:00
Maurice Parker e34dbd48ee Move error handling to SceneNavigationView 2020-07-15 20:06:29 -05:00
Maurice Parker cf233f4825
Merge pull request #2259 from stuartbreckenridge/feature/mac-preferences
Mac Preferences
2020-07-15 19:16:19 -05:00
Stuart Breckenridge c453882b4b
Adds Test/Release build downloading
Fixes #2182
2020-07-16 07:29:58 +08:00
Stuart Breckenridge 310cfaf66b
Tidies up AdvancedPreferences 2020-07-16 07:02:55 +08:00
Stuart Breckenridge 995278ac58
Enables check for updates 2020-07-16 06:43:11 +08:00
Maurice Parker 30d1f77405 Implement pull to refresh on iOS 2020-07-15 16:52:57 -05:00
Maurice Parker 2b84469fb4 Refactored refresh progress so that it doesn't crash on the mac anymore 2020-07-15 15:32:04 -05:00
Maurice Parker f32b0bfdc3 Change to use a view instead of a function for the navigation wrapper 2020-07-15 15:25:41 -05:00
Maurice Parker 367bd90ec9 Fix refresh progress compile error 2020-07-15 13:43:24 -05:00
Maurice Parker deee6c13f5 Remove progress indicator and next unread from timeline until we can properly show and hide them. 2020-07-15 13:00:38 -05:00
Maurice Parker c8077ad214 Separated refresh progress model from SceneModel again 2020-07-15 12:56:19 -05:00
Maurice Parker 6e60156f0e Move browser class up a level 2020-07-15 12:44:03 -05:00
Maurice Parker 160b0476f7 Port web view navigation over for the mac app 2020-07-15 12:41:49 -05:00
Stuart Breckenridge 0904ff519f
moves preferredColorScheme to App level. 2020-07-15 11:16:16 +08:00
Stuart Breckenridge d8c5d3719c
Refactors GeneralPrefs Model 2020-07-15 10:54:18 +08:00
Stuart Breckenridge c630bf3b9f
Account restrictions removed. 2020-07-15 10:26:03 +08:00
Stuart Breckenridge 99b2d3bb01
removes dead code
& correctly dismisses sheets
2020-07-15 09:14:04 +08:00
Stuart Breckenridge dfe314f214
Adds Feedly and Restricts Accounts 2020-07-15 09:04:33 +08:00
Maurice Parker 31068f90a0 Implement macOS share button 2020-07-14 17:10:53 -05:00
Maurice Parker e6bd17f8f9 Remove commented code 2020-07-14 13:53:23 -05:00
Stuart Breckenridge ade441af74
[weak self] 2020-07-14 21:14:16 +08:00
Stuart Breckenridge aca43090f8
Edit account
Edit account now has its own model
Refactored account creation and updated errors into separate enum
Renamed some structs
2020-07-14 16:25:37 +08:00
Stuart Breckenridge 06af59fb2b
fixes dark mode on accounts overlay 2020-07-14 15:05:11 +08:00
Stuart Breckenridge 4982211e27
WiP on Edit Accounts and ColorScheme 2020-07-14 14:57:55 +08:00
Stuart Breckenridge 64848a9421
look and feel of edit account matches production 2020-07-14 11:33:13 +08:00
Stuart Breckenridge 39a71077b4
WiP on Edit Account 2020-07-14 10:44:59 +08:00
Maurice Parker dc023e681b Implement share/activity button on iOS 2020-07-13 20:18:39 -05:00
Maurice Parker da08219ca3 Add more button state and standardize button syntax 2020-07-13 17:24:40 -05:00
Maurice Parker 7643ddc173 Remove specific button state enums as they were overkill 2020-07-13 16:26:53 -05:00
Maurice Parker 4bb88363e7 Change to only resort when sort parameters change 2020-07-13 16:06:42 -05:00
Maurice Parker 1a74701052
Merge pull request #2260 from rizwankce/show-password-for-feedbin-accouunt-view
Add show/hide password for feedbin account view
2020-07-13 16:00:01 -05:00
Maurice Parker 1e2a749cc4
Merge pull request #2258 from rizwankce/add-cloudkit-settings
Add cloudkit view for settings accounts
2020-07-13 15:58:48 -05:00
Maurice Parker ffa579446e Only add section header padding for macOS 2020-07-13 12:00:59 -05:00
Maurice Parker b79a1aef0c Put in the padding that Apple left off of the section headers 2020-07-13 11:58:44 -05:00
Maurice Parker 543048b981 Add context menu divider to match existing macOS design 2020-07-13 11:43:27 -05:00
Maurice Parker c29960ddda Clean up navigation handling for the timeline 2020-07-13 11:37:21 -05:00
Rizwan Mohamed Ibrahim b95697bf0d
Add show/hide password for feedbin account view 2020-07-13 20:52:05 +05:30
Stuart Breckenridge 15b980cabf
removed preview 2020-07-13 23:12:08 +08:00
Stuart Breckenridge 01c1df0a6b
refactoring 2020-07-13 23:10:50 +08:00
Rizwan Mohamed Ibrahim de0edd3c0b
Add cloud kit view for settings accounts 2020-07-13 20:39:19 +05:30
Stuart Breckenridge 587acfcb1c
correctly places accountAdded call 2020-07-13 23:02:09 +08:00
Stuart Breckenridge 8a66c368cd
fixes enum ==, changes frames 2020-07-13 22:51:09 +08:00
Stuart Breckenridge f4d776688b
Toolbar is in a much better shape. 2020-07-13 22:29:33 +08:00
Stuart Breckenridge 122249d716
Updates to add account model 2020-07-13 21:43:41 +08:00
Stuart Breckenridge a53500f643
Adding and deleting accounts works 2020-07-13 21:41:02 +08:00
Stuart Breckenridge 564f96ae47
Add Account Picker now displays accounts 2020-07-13 10:57:42 +08:00
Maurice Parker 17e1247ff0 Add sort control for macOS 2020-07-12 19:43:25 -05:00
Maurice Parker 3a67f2cd8e Change navigation title for macOS so that it shows the Feed 2020-07-12 17:45:38 -05:00
Maurice Parker 809e6542e0 Fix bug in unfiltering a filtered timeline 2020-07-12 17:30:35 -05:00
Maurice Parker d7a4bddc72 Make timeline filter maintain it state for each timeline individually 2020-07-12 16:48:39 -05:00
Maurice Parker 2ebec7801c Fix read filter accessibility labels (help) 2020-07-12 15:03:43 -05:00
Maurice Parker 6c236fc0e3 Implement Timeline read filter 2020-07-12 14:43:52 -05:00
Maurice Parker 22e2c0b0e6 Add sidebar read filter 2020-07-12 10:52:42 -05:00
Maurice Parker 9f4a037c8f Rebuild sidebar items when the unread count changes 2020-07-12 09:54:39 -05:00
Stuart Breckenridge cbeb74ab76
redesigned account pane 2020-07-12 22:49:55 +08:00
Stuart Breckenridge 235da781db
adds (old version) to other NNW entries 2020-07-12 21:47:29 +08:00
Stuart Breckenridge 2636a5cc72
Can set default RSS reader in the General pane 2020-07-12 21:37:27 +08:00
Stuart Breckenridge c2c138218d
Default RSS feeds now displayed 2020-07-12 18:53:37 +08:00
Stuart Breckenridge 31b93c5d13
small refactoring 2020-07-12 14:07:52 +08:00
Maurice Parker 2eb20c86af Refactor timeline code to be more clear 2020-07-11 20:11:01 -05:00
Maurice Parker 6891f76241 Fix smart feed feed lookup 2020-07-11 19:56:42 -05:00
Maurice Parker 7998b5450b Enabled toolbar buttons for read and star 2020-07-11 19:52:28 -05:00
Maurice Parker 92ac91d9d5 Delete dead code 2020-07-11 18:47:44 -05:00
Maurice Parker 184ef57576 Implement Timeline multiselect 2020-07-11 18:22:47 -05:00
Maurice Parker cf79d3f508 Merge branch 'master' of https://github.com/Ranchero-Software/NetNewsWire 2020-07-11 12:48:58 -05:00
Maurice Parker 360f7a07bf Implement Sidebar multiselect for macOS 2020-07-11 12:47:13 -05:00
Stuart Breckenridge 61c42171c7
2237
Fixes #2237 accent colours on web feeds.
2020-07-12 00:07:37 +08:00
Maurice Parker 20d989f1b8
Revert "Widget Work in Progress" 2020-07-11 09:48:34 -05:00
Maurice Parker 3eda1de825
Merge pull request #2249 from stuartbreckenridge/feature/widget
Widget Work in Progress
2020-07-11 09:36:50 -05:00
Stuart Breckenridge c3d4834879
Moves to monitoring changes in scene phase 2020-07-11 21:02:46 +08:00
Stuart Breckenridge 9991b3760e
Removes print statements and reorgs code 2020-07-11 20:22:21 +08:00
Stuart Breckenridge 1cc5f3cc30
Widget Updates
• Can now read data written by main app
• Has preview capability in widget gallery
• Still to solve using ORGANIZATION_IDENTIFIER
2020-07-11 17:01:09 +08:00
Maurice Parker 2f99cd01c1 Fix the width of the indicator so that it would stop reflowing the cell when changed to star 2020-07-10 10:13:18 -05:00
Stuart Breckenridge a45ba35b24
Initial widget work
• Latest data is saved out to JSON at various points.
• Technote on widget usage.
• Widget target added.
2020-07-10 23:10:12 +08:00
Maurice Parker bf8a52d710 Update the timeline with status changes 2020-07-09 20:10:52 -05:00
Maurice Parker 2d57945e98 Implement Read and Star button functionality 2020-07-09 18:44:51 -05:00
Maurice Parker 3e61c7044b Stub out mark as read and star functionality 2020-07-09 16:34:47 -05:00
Alex Faber 5b50e8cdd2 OPT: Cleanup Add Folder view on Mac, change SceneNavigationView to support multiple sheet types. 2020-07-09 21:09:50 +02:00
Maurice Parker aa4d191d1d Fixed Article Toolbar item placement on iPad 2020-07-09 09:57:39 -05:00
Maurice Parker d16c1678f2
Merge pull request #2239 from rizwankce/fix/add-account-action
Fix account selection
2020-07-09 09:31:06 -05:00
Maurice Parker 4fe41b57c5
Merge pull request #2236 from rizwankce/account-details-settings
Add settings account details view and implementations
2020-07-09 09:27:37 -05:00
Rizwan Mohamed Ibrahim 7c30749625
Fix account selection showing wrong sheet upon selection 2020-07-09 19:55:58 +05:30
Maurice Parker 91f2479b96
Merge pull request #2234 from stuartbreckenridge/fix/2193
Fix 2193
2020-07-09 08:10:42 -05:00
Maurice Parker 897474a637 Fixed the font for macOS article view 2020-07-09 07:47:47 -05:00
Rizwan Mohamed Ibrahim 2c7663870a
Add settings account details view and implementations 2020-07-09 16:14:53 +05:30
Stuart Breckenridge 771fe21422
Tidy up 2020-07-09 17:36:17 +08:00
Stuart Breckenridge f4deab1361
Updates title to match current app 2020-07-09 17:04:04 +08:00
Stuart Breckenridge 9830a977a0 Add Web Feed Colours
Icons in the picker now use accent colour.
2020-07-09 16:58:04 +08:00
Maurice Parker f5855f032d Revert to a less obnoxious status bar color 2020-07-08 22:43:16 -05:00
Maurice Parker f2e29de7b6 Trying a different color for the web status background 2020-07-08 22:41:13 -05:00
Maurice Parker 107a8fd550 Implement macOS web view mouse over events 2020-07-08 22:27:59 -05:00
Maurice Parker 5abf222c8a Merge branch 'swiftui' of https://github.com/Ranchero-Software/NetNewsWire into swiftui 2020-07-08 20:13:08 -05:00
Maurice Parker 5583b21616
Merge pull request #2232 from stuartbreckenridge/swiftui
Multi-selection on macOS #2164
2020-07-08 20:12:23 -05:00
Stuart Breckenridge 4c11667ff7
Moves selection to SidebarModel 2020-07-09 07:15:47 +08:00