Commit Graph

422 Commits

Author SHA1 Message Date
Ben Ubois
0b6683d073 Render with evaluateJavaScript.
Replaced loadHTMLString based rendering for improved performance.
2019-09-18 22:03:23 -07:00
Maurice Parker
20ecba1649 Add tooltip to Reader button 2019-09-18 20:40:58 -05:00
Maurice Parker
3b5a6f2576 Don't allow the article extraction button to toggle if it isn't working. 2019-09-18 20:03:01 -05:00
Maurice Parker
7ec3160273 Made article extractor button brighter 2019-09-18 19:45:22 -05:00
Maurice Parker
1da17fc5a9 Merge branch 'master' of https://github.com/brentsimmons/NetNewsWire 2019-09-18 19:24:14 -05:00
Kiel Gillard
9cc5fa3608 Initial implementation allowing Feedly accounts to be added given the Feedly user's consent. 2019-09-19 10:11:53 +10:00
Maurice Parker
8cd6f107e5 Add basic Article Content extraction 2019-09-18 18:15:55 -05:00
Maurice Parker
372fb06716 Implement different icons for each individual smartfeed 2019-09-17 20:26:49 -05:00
Maurice Parker
786a4e48c4 Merge branch 'mac-release' 2019-09-17 15:01:01 -05:00
Nate Weaver
93f7972441 Add some spacing around a comment 2019-09-17 13:58:45 -05:00
Nate Weaver
1e840f3090 Move WebKit "inspector starts attached" user default to AppDefaults 2019-09-17 13:42:18 -05:00
Nate Weaver
4a2724bcc4 Fix comment capitalization 2019-09-17 13:27:11 -05:00
Nate Weaver
0c89bc43c1 Use a bridging header for the Web Inspector API instead of KVC 2019-09-17 06:55:55 -05:00
Nate Weaver
4f405009f5 Use a selector instead of a block for the notification observation 2019-09-17 05:04:05 -05:00
Nate Weaver
e39fa31bf7 Add a menu item to the Debug menu to enable the Web Inspector
Just enables the "Inspect Element" item in a WKWebView's contextual menu at the moment.
2019-09-17 05:04:05 -05:00
Brent Simmons
b075226685 Merge mac-release. 2019-09-16 22:32:08 -07:00
Brent Simmons
66d9333999 Make minor code formatting changes so that TimelineViewController matches our current thinking. Also delete some commented-out and unused code. 2019-09-16 22:27:17 -07:00
Brent Simmons
d16acfcca8 Merge branch 'mac-release' 2019-09-16 22:10:17 -07:00
Brent Simmons
f7c9cc1dbd Remove no-longer needed machinery for updating the timeline on dark-mode/light-mode appearance changes. 2019-09-16 22:09:58 -07:00
Brent Simmons
1ece325112 Merge mac-release. 2019-09-16 20:09:04 -07:00
Brent Simmons
a05fd61085 Merge branch 'imagecache' into mac-release 2019-09-16 20:07:31 -07:00
Brent Simmons
a225d52ba3 Use the new TimelineAvatarView instead of an NSImageView in TimelineTableCellView. 2019-09-16 20:01:30 -07:00
Brent Simmons
506b621e5d Draw the avatar background in TimelineAvatarView only if the icon is too short vertically. 2019-09-16 20:00:32 -07:00
Brent Simmons
2f9f4e263c Restore color for light avatar background. 2019-09-16 19:59:33 -07:00
Maurice Parker
444771dfae Merge branch 'mac-release' 2019-09-16 18:16:13 -05:00
Maurice Parker
1d7cbe5596 Fix super wide div's. Issue #1010 2019-09-16 18:12:56 -05:00
Maurice Parker
18d6a278c7 Merge branch 'mac-release' 2019-09-16 16:37:18 -05:00
Maurice Parker
0458fd3838 Delete avatar and favicon image caches every three days 2019-09-16 16:26:40 -05:00
Brent Simmons
8a2d1f5f6a Create TimelineAvatarView, which draws the background for images that need it. 2019-09-15 23:02:13 -07:00
Maurice Parker
8e939e9942 Change Credentials to be a struct instead of an enum 2019-09-15 10:03:47 -05:00
Phil Viso
cc6767e0f6 Removed duplicate sort parameter change handling functions 2019-09-13 08:29:56 -05:00
Phil Viso
8a6e3c9f37 Merge branch 'master' of https://github.com/brentsimmons/NetNewsWire into GroupArticlesByFeed
# Conflicts:
#	Mac/MainWindow/Timeline/TimelineViewController.swift
2019-09-13 08:23:31 -05:00
Maurice Parker
5985b00480 Inject the Accounts folder name so that it can be in different locations between the iOS and Mac Apps. 2019-09-12 10:59:26 -05:00
Maurice Parker
57542592cb Correct which view should become the first responder. Issue #1014 2019-09-11 17:47:02 -05:00
Brent Simmons
3b501e9f4e Merge branch 'mac-release' 2019-09-10 20:28:42 -07:00
Brent Simmons
7ad0b6b604 Always update the unread count in the timeline after doing a sync fetch after representedObjects changes. Reload visible cells whenever showFeedNames changes. Fix #923. 2019-09-10 20:28:16 -07:00
Maurice Parker
8dda681409 Add accessibility labels to Sidebar, Timeline, and Article. Issue #934 2019-09-10 11:09:17 -05:00
Phil Viso
045bc61684 Renamed Sort By menu item to Sort Articles By 2019-09-08 17:12:18 -05:00
Phil Viso
32d6678fdd Added group by feed menu item 2019-09-08 17:09:26 -05:00
Maurice Parker
0961753357
Merge pull request #998 from hisaac/mac-release
Add command arrow key shortcuts to sidebar shortcuts plist
2019-09-08 13:02:58 -05:00
Isaac Halvorson
8b635fc04c Add command arrow key shortcuts to sidebar shortcuts plist 2019-09-08 12:54:26 -05:00
Maurice Parker
e61efbe47a Split AccountsDidChange notification into both add and delete notifications and automatically expanded new accounts on iOS 2019-09-08 09:43:51 -05:00
Brent Simmons
0d25f2331a Merge branch 'mac-release' 2019-09-06 19:28:31 -07:00
Brent Simmons
58c2fad2fd Stop blocking links containing the string “feedburner” — there are legitimate cases where that string appears. Fix #976. 2019-09-06 19:28:06 -07:00
Brent Simmons
d39d7a0fe4 Merge branch 'mac-release' 2019-09-06 19:12:03 -07:00
Brent Simmons
d49b212bc2 Delete unused EvergreenLarge.png. 2019-09-06 19:11:41 -07:00
Maurice Parker
a4b01fda35 Merge branch 'mac-release' 2019-09-06 17:03:38 -05:00
Maurice Parker
0e7d971e65 Queue a reload of all visible cells anytime a favicon is downloaded. Issue #995 2019-09-06 16:52:31 -05:00
Daniel Jalkut
d79bbefeb8 mac-release targeted version of the fix for #989 2019-09-06 15:40:59 -04:00
Daniel Jalkut
f3ce5116e7 Factor out the common build settings from Mac targets into a new shared xcconfig file, which includee the shared marketing version and bundle version for NetNewsWire and any extensions that may be built. 2019-09-06 14:52:03 -04:00
Maurice Parker
546917a866 Merge branch 'mac-release' 2019-09-06 08:38:58 -05:00
Daniel Jalkut
8e01e8e45a Instantiate an RSAppMovementMonitor to track user movement of the application while running. Fixes #897. 2019-09-06 09:13:09 -04:00
Maurice Parker
00b2756526 Merge branch 'mac-release' 2019-09-05 13:15:04 -05:00
Brian Warren
ce3ec10c95 Enforcing automatic height for images in the template 2019-09-05 10:59:16 -07:00
Brent Simmons
b4e5968025 Merge branch 'mac-release' 2019-09-04 21:33:08 -07:00
Brent Simmons
f0d080b0be Remove blank line from near top of About window credits. 2019-09-04 21:04:21 -07:00
Brent Simmons
5ad307411d Bump version to 5.0.1d1 2019-09-04 21:00:59 -07:00
Maurice Parker
da8250ac5a Merge branch 'mac-release' 2019-09-04 17:42:30 -05:00
Maurice Parker
7a8d23958b Restrict iframe width to be at most 100% 2019-09-04 17:41:58 -05:00
Maurice Parker
dabb78cde4 Merge branch 'mac-release' 2019-09-04 17:20:37 -05:00
Thomas Pritchard
d3ad4b52a3 Set a sensible line height for figure captions 2019-09-04 19:58:29 +01:00
Thomas Pritchard
5976923f23 Add figures to Mac detail stylesheet 2019-09-04 19:58:29 +01:00
Maurice Parker
fa5840811a Change the view that gets made the first responder so that keyboard shortcuts work again 2019-09-04 03:12:50 -05:00
Maurice Parker
722d486018 Move keyboard config files to Shared location in repo as they will now be used in the iOS app as well as the Mac app 2019-09-04 03:11:55 -05:00
Maurice Parker
a59f223043 Moved FetchRequestOperation and FetchRequestQueue to Shared section of the repo since they are used by both Mac and iOS 2019-09-04 02:40:35 -05:00
Brent Simmons
2ec55e6587 Merge branch 'mac-release' 2019-09-03 22:59:29 -07:00
Brent Simmons
0ba8f3b4e1 Call the completion block once and only once from FetchRequestOperation. This is a probable fix for #898. 2019-09-03 22:58:17 -07:00
Brent Simmons
0bfafc2da3 Merge branch 'mac-release' 2019-09-03 22:18:00 -07:00
Brent Simmons
cbaad4bdeb Add checkbox to Preferences > General for turning off the unread count in the Dock. 2019-09-03 22:17:31 -07:00
Brent Simmons
ed91776097 Merge branch 'mac-release' 2019-09-03 21:24:52 -07:00
Brent Simmons
5efbe6a4f0 Add NNW website link to top of About window text. 2019-09-03 21:24:17 -07:00
Jim Correia
c8920ca5a6 Added optional separators in the timeline view.
The timeline now optionally includes "Mail style" separators (behind a
hidden default — "CorreiaSeparators" — which defaults to NO).
2019-09-02 09:13:21 -07:00
Maurice Parker
1a9acdcc50 Remove TreeController from Delete command as it is no longer used there 2019-09-01 14:56:27 -05:00
Maurice Parker
6cf1e4539d Merge branch 'mac-release' 2019-09-01 10:51:22 -05:00
Jim Correia
e7e77d362c Fix for bug #901 — first web view load flashes white in dark mode
The fix used for iOS (keep a queue of preloaded web views) isn't appropriate
for macOS since the first view is used immediately. That approach would
solve the flash of white when first searching, but not the flash of white
when launching the application.

Instead, use a modification of the original solution used for iOS:

    - wrap the web view in a box with an appropriate background color
    - hide the web view at creation
    - show the web view after* the first load

This doesn't suffer the latency problem that the same solution on iOS had
because the first load is always local, "No Selection" HTML.

[*] Showing the view immediately after the first load still causes the flash
    to white. Waiting 0.05 seconds avoids this. That's a fairly terrible hack,
    but I don't have a better solution at present.
2019-08-31 22:14:56 -07:00
Maurice Parker
ecec048716 Merge branch 'mac-release' 2019-08-31 18:31:10 -05:00
Jim Correia
cdfdc06142 Only enable "Open in Browser" when a single article is selected.
Fixes bug #921.
2019-08-31 16:02:21 -07:00
Maurice Parker
3baca1d7c0 Merge branch 'master' of https://github.com/brentsimmons/NetNewsWire 2019-08-30 11:47:16 -05:00
Maurice Parker
ea1f21797c Merge branch 'mac-release' 2019-08-30 11:28:16 -05:00
Kiel Gillard
f27b7029de Explicity identify the addable account types, allowing for a contingent list given factors such as macOS API availability. 2019-08-30 15:17:25 +10:00
Brent Simmons
29efae42fd Update Apple events privacy statement to refer to article instead of news item. 2019-08-28 21:40:56 -07:00
Brent Simmons
d468961d81 Update version and build number. 2019-08-28 21:40:21 -07:00
Maurice Parker
2b206e098a Move the location of the home page to feed icon cache to the cache directory instead of the temp directory 2019-08-27 13:29:34 -05:00
Daniel Jalkut
42168ed3b9 Revise the layout of new account xibs to reduce the distance between labels and text fields, standardize the distance from the service header to the first text field, and move the feedback error string field to beneath the input fields, configured to word-wrap and grow in height as needed. 2019-08-27 12:45:10 -04:00
Daniel Jalkut
526f21a26b Left-align the accounts in the Add Account UI. 2019-08-27 12:35:27 -04:00
Maurice Parker
3c86bf0614
Merge pull request #871 from mbernson/master
Simplify sharing delegate logic
2019-08-27 11:13:00 -05:00
Maurice Parker
17fef112d6 Merge branch 'mac-release' 2019-08-26 19:40:56 -05:00
Maurice Parker
3279a25581 Cache home page to feed icon relationship 2019-08-26 19:40:30 -05:00
Maurice Parker
8de9b355c7 Merge branch 'mac-release' 2019-08-26 12:54:53 -05:00
Maurice Parker
1a3e2784ae Optimize table cell reloading when feed images are made available 2019-08-26 12:54:23 -05:00
Maurice Parker
f8c01107d5 Merge branch 'master' of https://github.com/brentsimmons/NetNewsWire 2019-08-24 15:01:40 -05:00
Maurice Parker
ea55aa5bef Leverage new avatarImage function from ArticleUtilities to reduce code duplication between macOS and iOS 2019-08-24 15:01:28 -05:00
Brent Simmons
d75f1ca73b Merge branch 'mac-candidate' 2019-08-23 22:03:27 -07:00
Brent Simmons
c3aebe7868 Bump version and build. 2019-08-23 21:59:44 -07:00
Brent Simmons
ed56376d03 Merge branch 'mac-candidate' 2019-08-23 18:55:09 -07:00
Brent Simmons
739eb5183e Bump version and build numbers. 2019-08-23 18:31:04 -07:00
Brent Simmons
dd62a3325a Center the main window on first run. 2019-08-23 18:30:28 -07:00
Brent Simmons
4bead42b5a Center prefs window after switching to the proper view. 2019-08-23 18:30:14 -07:00
Brent Simmons
cc7321e936 Center the preferences window. Fix #769. 2019-08-23 16:22:06 -07:00
Brent Simmons
3447ebcec0 Reload data after a batch update. Fix #872. 2019-08-23 15:52:07 -07:00
Mathijs Bernson
9214e3d65e Simplify sharing item subject logic 2019-08-23 13:05:20 +02:00
Brent Simmons
1ab0f7c25c Merge mac-candidate. 2019-08-21 21:44:07 -07:00
Brent Simmons
e140d51e4b Bump version and build number. 2019-08-21 21:42:48 -07:00
Brent Simmons
849830f494 Refetch articles for smart feeds and folders, if selected, when a feed or folder is deleted. Fix #838. 2019-08-21 21:41:56 -07:00
Brent Simmons
f513741ddb Start work on filtering timeline so that articles from deleted feeds never show up. 2019-08-21 13:23:46 -07:00
Brent Simmons
925aa5af70 Merge branch 'mac-candidate' 2019-08-19 14:38:38 -07:00
Brent Simmons
e524d48c1d Add credit to Joe Heck in the About window for difficult infrastructure. 2019-08-19 14:38:18 -07:00
Brent Simmons
2cc5e20fad Merge branch 'mac-candidate' 2019-08-18 16:08:04 -07:00
Brent Simmons
588dbb0ce5 Add prefs to Advanced prefs pane to 1) check for updates automatically, and 2) choose to download test or release builds. The default will be release builds only, since most people don’t want test builds. 2019-08-18 16:07:37 -07:00
Brent Simmons
5670989c29 Do initial layout of revised Advanced preferences (which now include updates preferences). 2019-08-17 16:58:39 -07:00
Brent Simmons
8d7e238386 Change default SUFeedURL to release builds appcast. Add FeedURLForTestBuilds to store the URL for test builds. 2019-08-17 11:04:54 -07:00
Brent Simmons
defa32708c Merge branch 'mac-candidate' 2019-08-14 00:33:07 -07:00
Brent Simmons
3aae7ad328 Now using manual build numbers, because I messed up and built from the wrong branch. I should be able to figure out how to get back to automated build numbers — but it can wait till after 5.0 ships. 2019-08-14 00:20:42 -07:00
Brent Simmons
9ff1e48d37 Merge branch 'mac-candidate' 2019-08-14 00:14:07 -07:00
Brent Simmons
f86c32b414 Bump version to b4. 2019-08-14 00:13:50 -07:00
Brent Simmons
9530ad7d58 Merge branch 'mac-candidate' 2019-08-13 21:24:28 -07:00
Brent Simmons
8cb9aefeec Bump version to 5.0b3. 2019-08-13 21:24:15 -07:00
Brent Simmons
7b3c08f521 Merge branch 'mac-candidate' 2019-08-13 21:07:59 -07:00
Brent Simmons
2bbd135c9e Update appropriate counts in the sidebar when the timeline’s unread count changes. Fix #829. 2019-08-13 21:07:39 -07:00
Brent Simmons
fc0fc2055e Get the unread count from the timeline, instead of the database, only for the Today feed and only if it’s selected and it’s the only node selected. 2019-08-13 20:29:04 -07:00
Brent Simmons
cf1b3843ee Add a SmartFeedType to smart feeds so the sidebar can tell them apart. 2019-08-13 20:28:28 -07:00
Brent Simmons
62258683c8 Add Ryan’s word-wrap change to mac-candidate. 2019-08-13 20:07:42 -07:00
Ryan Dotson
6eb27abc13 Break long words or URLs to prevent horizontal overflow 2019-08-13 09:27:36 +09:00
Ryan Dotson
c8f5a24b95 Use proper quotes in timeline contextual menu 2019-08-13 07:41:14 +09:00
Brent Simmons
27fed1cb60 Merge branch 'mac-candidate' 2019-08-12 09:54:05 -07:00
Brent Simmons
bfe3a15b9d Bump version to 5.0b2. Remove how-to-support thing from About box. 2019-08-12 09:53:47 -07:00
Brent Simmons
cb173d89cc Merge branch 'mac-candidate' 2019-08-11 22:09:26 -07:00
Brent Simmons
495662f888 Add, to About window, credit for Ryan Dotson for the Help Book. Also add a link to the How to Support NetNewsWire tech note. 2019-08-11 22:08:24 -07:00
Brent Simmons
316a1b22ff Merge branch 'mac-candidate' 2019-08-11 21:58:48 -07:00
Brent Simmons
bf3e26e827 Bump version to 5.0b1. 2019-08-11 21:58:27 -07:00
Brent Simmons
ef4c52169a Merge branch 'mac-candidate' 2019-08-10 14:27:16 -07:00
Brent Simmons
40369eaca0 Change the URL of the Help book to include a /mac/ directory, so we can have separate help books for Mac and iOS. 2019-08-10 14:26:51 -07:00
Brent Simmons
965ce4ebe1 Merge branch 'mac-candidate' 2019-08-03 11:05:41 -07:00
Brent Simmons
536ac205a0 Fix crash when making a feed via AppleScript and the feed already exists. 2019-08-03 11:04:52 -07:00
Brent Simmons
49f17e5d14 Merge branch 'mac-candidate' 2019-08-02 14:03:30 -07:00
Brent Simmons
4b5dd7cd17 Fix some AppleScript terminology conflicts. Change account.type too account.accountType. Change local account to onmymac. 2019-08-02 14:03:04 -07:00
Brent Simmons
03afab8e6d Merge branch 'mac-candidate' 2019-08-02 12:44:51 -07:00
Brent Simmons
ccd1d4bdc1 Wire up the account name for scripting. 2019-08-02 12:44:24 -07:00
Brent Simmons
2277e95a83 Merge branch 'mac-candidate' 2019-08-01 22:51:24 -07:00
Brent Simmons
5d97e89e91 Replace the contents property with allFeeds — which returns all the feeds, including those inside folders. This is distinct from the feeds element, which returns just top-level feeds. 2019-08-01 22:51:03 -07:00
Brent Simmons
8d80d2aed1 Merge branch 'mac-candidate' 2019-08-01 21:52:57 -07:00
Brent Simmons
e800b13f01 The accounts property returns all accounts. 2019-08-01 21:52:12 -07:00
Brent Simmons
e845e3bd35 Merge branch 'mac-candidate' 2019-07-29 19:56:49 -07:00
Brent Simmons
31e089fc1d Add an active property to the scripting definition for Account. 2019-07-29 19:56:22 -07:00
Brent Simmons
34326863ea Merge branch 'mac-candidate' 2019-07-28 16:01:12 -07:00
Brent Simmons
887f8e0b53 Check to see if the timeline already has the expected representedObjects when the sidebar selection (apparently) has changed. If so, then don’t set the representedObjects again, and don’t knock the user out of search mode if searching. 2019-07-28 16:00:43 -07:00
Brent Simmons
2fcadf9748 Merge branch 'mac-candidate' 2019-07-28 15:31:45 -07:00
Brent Simmons
2441de960f Skip reloading the sidebar after the tree controller rebuilds when the rebuilt version is the same as the previous version. This saves some cycles, and it’s part of fixing #791. 2019-07-28 15:31:17 -07:00
Brent Simmons
d8f1dcf23e Merge branch 'mac-candidate' 2019-07-27 22:53:53 -07:00
Brent Simmons
44ec6a026d Get the unread count from the timeline for the currently selected node in the sidebar. This ensures that transients in the timeline are accounted for. (The database query for the unread count wouldn’t necessarily match.) 2019-07-27 22:53:27 -07:00