Commit Graph

252 Commits

Author SHA1 Message Date
Maurice Parker c51f5f44e0 Add eclipses to truncated timeline text. Issue #1072 2019-09-29 14:07:33 -05:00
Maurice Parker 5dfb4f6488 Fix off center timeline titles 2019-09-27 20:21:46 -05:00
Maurice Parker f3a939b49d Fix dark mode timeline titles 2019-09-27 20:04:49 -05:00
Maurice Parker ca4a7f8b0b Add Feed Inspector 2019-09-27 19:45:09 -05:00
Maurice Parker 9c8f5b7d65 Remove chevrons from timeline. Issue #1067 2019-09-26 20:01:13 -05:00
Maurice Parker f24799f16a Slightly round the inner image for avatars 2019-09-26 15:50:05 -05:00
Maurice Parker 4e239a44e1 Reload the title view icon again after it becomes available 2019-09-23 20:53:09 -05:00
Maurice Parker 3cd33902cf Add small icon to timeline title view 2019-09-21 17:59:58 -05:00
Maurice Parker 6f962ecb42 Fix avatar background composition 2019-09-19 13:41:07 -05:00
Maurice Parker 0fcbcb50e0 Change unread indicator to use secondary accent color 2019-09-18 09:56:10 -05:00
Maurice Parker 8b732e5353 Switch from drawing clear color to drawing background color to reset reused avatar views 2019-09-18 09:47:58 -05:00
Maurice Parker 36f4366e70 Use correct icons on timeline swipe for unread and starred 2019-09-18 02:57:32 -05:00
Maurice Parker db2ee18299 Unify the colori scheme into primary and secondary accent colors 2019-09-18 02:49:57 -05:00
Maurice Parker 372fb06716 Implement different icons for each individual smartfeed 2019-09-17 20:26:49 -05:00
Maurice Parker 73b7436c62 Remove old flush cache code 2019-09-17 17:11:47 -05:00
Maurice Parker fe3fa220bb Port TimelineAvatarView to iOS 2019-09-17 17:00:23 -05:00
Maurice Parker 31b506b85a Work around SwiftUI on bugs on iPadOS so that we can add accounts on the iPad 2019-09-11 20:50:03 -05:00
Maurice Parker 856006a19f Fixed timeline loading bug for portrait on the iPad 2019-09-11 10:41:48 -05:00
Maurice Parker 8545252265 Remove the usage of IndexPaths for the interface between the coordinator and the timeline 2019-09-11 09:11:33 -05:00
Maurice Parker 8076cac266 Convert timeline to use the diffable datasource to lookup articles instead of the coordinator's article table 2019-09-10 20:32:03 -05:00
Maurice Parker 411413d783 Remove unnecessary selection that was causing the search function to crash 2019-09-10 16:18:40 -05:00
Maurice Parker bceccd76b5 Restore the timeline selection lost while transitioning to three panel mode 2019-09-10 08:06:43 -05:00
Maurice Parker 8b901819a6 Make table views scroll even if the root split is collapsed 2019-09-08 08:30:08 -05:00
Maurice Parker 7d8a0234b6 changed to queue a reload of all visible cells when a favicon comes in 2019-09-06 17:22:12 -05:00
Maurice Parker a6f6462afd Make arrow key scrolling work like it does on the Mac timeline 2019-09-06 13:45:45 -05:00
Maurice Parker c8b5b10edd Check if the split is collapsed to see if we are maintaining the selection 2019-09-06 11:22:35 -05:00
Maurice Parker aa7c60ee3a Prevent row selection on iPhone as keeping selected rows highlighted is an iPad only feature 2019-09-06 11:11:28 -05:00
Maurice Parker d0570d16a8 Prevent attempt to restore article selection when there are no articles 2019-09-06 10:38:02 -05:00
Maurice Parker 9f6203e839 Improve launch performance and fix Search home page quick action 2019-09-06 10:29:00 -05:00
Maurice Parker 73828e5115 Remove the coordinator dependency from KeyboadManager as it wasn't needed 2019-09-05 14:37:07 -05:00
Maurice Parker 7a452e2a3c Add keyboard arrow key navigation 2019-09-04 21:06:29 -05:00
Maurice Parker 68143aa2c5 Implement keyboard shortcut infrastructure and first shortcuts 2019-09-04 16:24:16 -05:00
Maurice Parker 17a5d291f4 Remove become and resign first responder code in Feeds and Timeline 2019-09-03 20:39:00 -05:00
Maurice Parker 640faaa114 Simplify the article replacement logic 2019-09-03 16:07:02 -05:00
Maurice Parker b7ba2c809c Use better function for looking up article index 2019-09-03 13:43:59 -05:00
Jim Correia 061872b7ff Simplified/corrected highlighted/selected appearance of feed and timeline cells.
- Set the highlighted text color on labels in table cells. This will be used
  for both the highlight and selected states automatically. (And since it is
  used for both states, we avoid anachronistic state where we have black
  text on a dark blue background in light mode as we transition from none ->
  highlighted -> selected.)

- Keep the selected/highlighted overrides to adjust colors for non-UIControl
  subelements.
2019-09-02 22:39:01 -07:00
Jim Correia 932f6fdd30 Added NNWTableViewCell; a base class for cells with the NNW selection color.
Defined a semantic color for the selection color which is identical to
netNewsWireBlue.

MasterFeedTableViewCell and MasterTimelineTableViewCell now subclass
NNWTableViewCell and no longer directly customize their selected background
view.
2019-09-02 22:38:42 -07:00
Maurice Parker b768877e23 Use correct delegate methods to begin and end searching 2019-09-02 12:40:14 -05:00
Maurice Parker 746c06d147 Prevent automated scrolling when selecting an article in the timeline 2019-09-02 12:05:11 -05:00
Maurice Parker c405fdf583 Implement search home page quick action 2019-09-01 17:41:46 -05:00
Maurice Parker dfc3046bf0 Clear the timeline when the user begins searching 2019-09-01 14:49:56 -05:00
Maurice Parker 858bdb7f21 Rename AppCoordinator to SceneCoordinator as that name better defines its purpose 2019-09-01 12:43:07 -05:00
Maurice Parker c9858a0457 Show and hide scope bar based on editing state 2019-08-31 16:39:59 -05:00
Maurice Parker fe2e0155da Add scoped searching of articles 2019-08-31 15:53:47 -05:00
Maurice Parker d9ce01591f Implement full article search 2019-08-31 11:50:34 -05:00
Maurice Parker ca0bdb3d35 Change to not animate on timeline fetcher changes 2019-08-30 14:42:33 -05:00
Maurice Parker 07ca61f7cf Convert the timeline to use diffable datasources 2019-08-30 14:17:05 -05:00
Maurice Parker 3ab1412dc6 Preserve article selection when articles are downloaded (for iPad only) 2019-08-30 02:39:54 -05:00
Maurice Parker 86a302f787 Prevent selecting of items that may not show the current article selection as is done on the iPhone 2019-08-29 17:49:21 -05:00
Maurice Parker 8e583c2fad Prevent scrolling when reloading and reselecting a cell. 2019-08-29 14:04:15 -05:00
Maurice Parker 379ba49fd5 Fix select position getting lost on refreshes 2019-08-29 11:53:36 -05:00
Maurice Parker d7c90106d1 Change to directly modify the avatar image instead of calling reload on the cells 2019-08-26 15:37:15 -05:00
Maurice Parker 0b48c3893d Change AppCoordinator to directly call controller API's since that matches the Coordinator pattern better than sending them notifications 2019-08-25 11:38:04 -05:00
Maurice Parker 5b1c0485c5 Add NSUserActivity for reading articles 2019-08-24 14:57:51 -05:00
Maurice Parker c752d0b699 Optimize table cell loading so that we are no longer reloading all visible cells when an image is downloaded 2019-08-21 19:37:19 -05:00
Maurice Parker 71343b9e72 Add Share context menu for timeline 2019-08-19 18:09:38 -05:00
Maurice Parker badc2d3e25 Add open in browser context menu item 2019-08-19 17:38:30 -05:00
Maurice Parker de7970314d Add mark all as read for feed functionality 2019-08-19 17:26:09 -05:00
Maurice Parker 40a80356f1 Move business logic out of controller into coordinator where we typically keep it 2019-08-19 16:03:07 -05:00
Maurice Parker 6087951824 Remove context menu titles as they didn't provide any additional context 2019-08-19 15:49:42 -05:00
Maurice Parker 3245223b24 Add Select Feed context menu 2019-08-19 15:45:52 -05:00
Maurice Parker eeebb30467 Implement Mark Older as Read for timeline 2019-08-18 17:34:53 -05:00
Maurice Parker aabe950b2b Add initial support for timeline context menus 2019-08-16 13:19:06 -05:00
Maurice Parker e39972bd64 Correct First Unread button to select the first unread in the timeline and show article in detail view. Issue #695 2019-08-03 17:07:43 -05:00
Maurice Parker 02575c31fe Change selected table row text to be white. Issue #693 2019-08-03 16:25:35 -05:00
Maurice Parker 54f6607621 Keep table selections when root split isn't collapsed 2019-08-02 10:25:47 -05:00
Maurice Parker adb6309872 In Three Pane Mode only show the progress indicator on the Feeds controller 2019-07-27 14:49:07 -05:00
Maurice Parker cf674d67b1 Show no selection when timeline is selected in Three Panel Mode 2019-07-27 14:36:01 -05:00
Maurice Parker b25e789aef Prevent refresh errors from keeping the refreshControl visible when error dialogs are displayed. 2019-07-18 15:16:54 -05:00
Maurice Parker 8b6e2fa517 Move more logic out of MasterTimelineViewController and into AppCoordinator 2019-07-06 12:31:07 -05:00
Maurice Parker 4884aebbfd Encapsulate more of the AppCoordinate API 2019-07-06 11:32:19 -05:00
Maurice Parker 15754684a4 Move more navigation responsibilities into the AppCoordinator 2019-07-05 17:45:39 -05:00
Maurice Parker fcf2937394 Rename NavStateController to AppCoordinator because we are redesigning it to be the Coordinator pattern 2019-06-29 13:35:12 -05:00
Maurice Parker 5f045706e4 Removed usaged of UIApplication.present 2019-06-27 14:21:07 -05:00
Maurice Parker 0ac9abdd52 Navigate back to feeds after marking all as read 2019-06-25 17:39:07 -05:00
Maurice Parker aff14b19ee Force unread indicator to be redisplayed to get rid of missing unread indicators 2019-06-25 15:43:30 -05:00
Maurice Parker 2ee72125ba Support dark mode for small avatars on iOS 2019-06-20 11:58:26 -05:00
Maurice Parker d794240bd9 Merge branch 'mac-candidate' 2019-06-19 11:31:38 -05:00
Maurice Parker 716653c235 Implement NetNewsWire Blue for cell selection and tint. Issue #691 & #692 2019-06-18 18:31:37 -05:00
Maurice Parker ae2c4b9d25 Update timeline to use new semantic colors (darkmode support) 2019-06-18 17:47:13 -05:00
Maurice Parker 40b9be6709 center smaller avatars on a solid color background image to make all avatars a consistent size 2019-06-14 15:33:13 -05:00
Maurice Parker 00ee775170 Made timeline layout tweaks to make indicator, avatar, and first line of text line up better. Issue #689 2019-05-31 17:58:39 -05:00
Maurice Parker e348a1f9ed Remove layout caching that was causing seemly random layout issues. Issue #714 2019-05-31 16:59:02 -05:00
Phil Viso 6168f01822 Updated margins and sizing of unread indicator to match the mail app. Issue #690 2019-05-27 18:46:57 -05:00
Maurice Parker c61949bc04 Add account name to network error messages and prevent background iOS errors from displaying alerts 2019-05-26 11:54:32 -05:00
Maurice Parker da7dcc2405 Remove quality assurance checks from avatar image in timeline 2019-05-19 13:03:07 -05:00
Maurice Parker a5a5eb1df0 Reuse layout calcs when possible on timeline 2019-04-29 17:45:12 -05:00
Maurice Parker ac93b91df9 Add accessibility layout to timeline 2019-04-29 17:19:08 -05:00
Maurice Parker bf45cb89e9 Set table estimated row height to improve scrolling performance 2019-04-29 16:29:53 -05:00
Maurice Parker 0451ed9e70 Made number of lines in timeline configurable. 2019-04-29 15:29:00 -05:00
Maurice Parker b4e2acb5ce Make responsive to dynamic font changes. 2019-04-29 14:50:56 -05:00
Maurice Parker e37d4ddd2f Implement new timeline layout. 2019-04-29 14:40:14 -05:00
Maurice Parker 2dcde1ab8e Create generic feed icon and timeline avatar 2019-04-29 07:07:57 -05:00
Maurice Parker ffc364f7cf Change to have mark as read be the default action on timeline swiping instead of starred 2019-04-29 06:01:53 -05:00
Maurice Parker da8c40d38f Change how avatars are selected so that poor quality avatars are passed up for their feed favicon 2019-04-29 05:51:47 -05:00
Maurice Parker 2e178dbebc Add content mode to prevent stretching of avatar images less than 48x48 2019-04-28 19:27:58 -05:00
Maurice Parker bf50c7a7e3 Update the nav controller title so that the back bar button item in iPad portrait has a valid title 2019-04-28 18:53:57 -05:00
Maurice Parker 2724dbf4f2 Align separator start with the text on the timeline 2019-04-28 16:08:02 -05:00
Maurice Parker d7391b208d implement dynamic type for master feed list 2019-04-28 10:31:35 -05:00
Maurice Parker b62565f651 Remove content mode from avatar as they are prescaled. 2019-04-27 09:47:36 -05:00
Maurice Parker 895b9c44f8 Prevent star image from distorting. 2019-04-26 06:30:00 -05:00
Maurice Parker 12d4d2dbb1 Rename classes to more accurately describe their usage in the application. 2019-04-23 08:00:27 -05:00