Commit Graph

499 Commits

Author SHA1 Message Date
Maurice Parker 9a82d2e233
Merge pull request #2121 from rizwankce/fix/in-app-browser-shortcut
fix open in app browser for mac and iOS
2020-05-29 10:13:07 -05:00
Rizwan Mohamed Ibrahim d671029828
refactor open in app browser for mac and iOS 2020-05-29 19:26:20 +05:30
Rizwan Mohamed Ibrahim eb7ac0f076
fix open in app browser for mac and iOS 2020-05-29 15:44:32 +05:30
Nate Weaver 41d96be8b4 Revert toolbar item updating 2020-05-25 21:25:52 -05:00
Nate Weaver 1ab17b2574 Add a preference for the browser to use to open articles
- Selectable in General Preferences
- Toolbar item now updates to show the browser's icon
2020-05-25 21:24:49 -05:00
Nate Weaver 0c2d057860 Add defaultBrowserID user default and make the appropriate toolbar item use that browser's icon 2020-05-25 21:19:50 -05:00
Nate Weaver b8220d3a9c Show the current default browser in the "Open in Browser" toolbar item 2020-05-25 21:19:29 -05:00
Brent Simmons 64eec7ad6b
Merge pull request #2100 from Wevah/open-in-background-inversion
Make shift key invert the "open in background" preference
2020-05-23 16:06:47 -07:00
Martin Nash 3e48be050e Updated function name to openInBrowserUsingOppositeOfSettings 2020-05-21 22:28:30 -07:00
Martin Nash 834be9edff 2099 | Keyboard shortcut to open in browser in background/foreground contrary to user preference.
- Add openInBrowserAlternate() function
- Add shit-modified entries to to GlobalKeyboardShortcuts.plist to trigger new function
2020-05-20 22:15:00 -07:00
Nate Weaver 5cd8dc9d5d Also let the Command key invert the background pref in web views 2020-05-20 20:08:13 -05:00
Nate Weaver 1e1fc06e7b Clean up shift-key checking and add it to more places 2020-05-20 19:59:21 -05:00
Nate Weaver 24338b135e Don't do shift-key detection in Browser 2020-05-20 19:54:25 -05:00
Nate Weaver e79cafc82e Make shift key invert the "open in background" preference
- Also add an appropriate menu item.
2020-05-20 19:41:23 -05:00
Maurice Parker a6b58beac7 Hide the account field for Popular and All reddit types 2020-05-12 14:14:39 -05:00
Maurice Parker fdfd91e53e Change Popular Reddit description 2020-05-12 10:17:58 -05:00
Maurice Parker 8434e7fa1f Add sort option to Add Reddit Feed dialog 2020-05-10 16:19:38 -05:00
Maurice Parker 06e91aa8b7 Add the Add Reddit Feed dialog 2020-05-10 11:44:30 -05:00
Maurice Parker 7ab4ca4291 Delete dead code 2020-05-10 11:04:45 -05:00
Maurice Parker faab33ab2e Save and toggle full screen state. Issue #2053 2020-05-09 14:14:46 -05:00
Jonathan Bennett a37bfd5d74 Adds an account behavior to disable folders
Some sync services (Feed Wrangler) don't support folders. This behavior removes the account from the UI when adding new folders.
2020-05-07 10:03:04 -04:00
Maurice Parker b6a0057439 Fix bug where Unread feed could get filtered even while selected. 2020-05-02 16:44:24 -05:00
Maurice Parker 6ba862244a Add placeholder text for Twitter search 2020-05-02 16:31:42 -05:00
Maurice Parker 3bc4b9e4b2 Hide filter button when searching 2020-05-02 13:25:48 -05:00
Nate Weaver 37f1ebc025 Remove the color parameter as it's no longer needed 2020-05-01 01:45:12 -05:00
Nate Weaver c555646fb2 Add attributed title support in the timeline 2020-05-01 01:42:43 -05:00
Maurice Parker 86fb98c17b
Revert "WIP: Title tags" 2020-04-24 20:24:24 -05:00
Nate Weaver b437ddab5c Move NSAttributedString+NetNewsWire into Shared/Extensions 2020-04-24 18:25:56 -05:00
Nate Weaver fde4f53f42 Documentation comments 2020-04-24 16:20:41 -05:00
Nate Weaver 154e78b0c0 Add a comment about why these constants differ between OSs 2020-04-24 16:20:41 -05:00
Nate Weaver 26415f0c62 Assign multiple attributes in one go rather than one at a time 2020-04-24 16:20:41 -05:00
Nate Weaver df4ea1479a Tweak comment 2020-04-24 16:20:41 -05:00
Nate Weaver d3e6606cf5 Use a constant for clarity 2020-04-24 16:20:41 -05:00
Nate Weaver 6aff83481f Make attributed titles work on iOS 2020-04-24 16:20:41 -05:00
Nate Weaver dc787620c5 Use API that works on both macOS and iOS 2020-04-24 16:20:41 -05:00
Nate Weaver ba73e3289a Remove redundant call to updateTextFieldText() 2020-04-24 16:20:41 -05:00
Nate Weaver d84ed6068f Add a convenience initializer for attributed strings from an html string 2020-04-24 16:20:41 -05:00
Nate Weaver 2a00b4a4a9 Keep monospace fonts monospaced; use a variable for the current symbolic traits 2020-04-24 16:20:41 -05:00
Nate Weaver 39255a8422 Initialize baseWeight outside the enumeration 2020-04-24 16:20:41 -05:00
Nate Weaver a6411c7afa Check for semibold base font before changing bold text to heavy 2020-04-24 16:20:41 -05:00
Nate Weaver 57a6561733 Use superscript/subscript font feature 2020-04-24 16:20:41 -05:00
Nate Weaver 3d509a94d4 Add attributed title support in the timeline 2020-04-24 16:20:40 -05:00
Maurice Parker ee92cf69d2 Merge branch 'extension-point' 2020-04-24 13:34:13 -05:00
Nate Weaver 37ae46ea4c Merge more styles and fix styling of tables with explicit thead/tbody/tfoot
Also use :matches() to simplify some rules.

# Conflicts:
#	Mac/MainWindow/Detail/styleSheet.css
#	iOS/Resources/styleSheet.css
2020-04-23 23:21:22 -05:00
Maurice Parker 211a9c329f Make screen name entry tolerant of @ usage. 2020-04-23 11:42:00 -05:00
Maurice Parker 0369d976fa Add twitter URL creation logic 2020-04-22 11:25:49 -05:00
Maurice Parker c37bbe2fbb Fix add button UI rules bug 2020-04-22 07:36:22 -05:00
Maurice Parker adf2d75f95 Added Twitter add UI rules 2020-04-22 05:04:39 -05:00
Maurice Parker 0ff0c87932 Add the new twitter add dialog 2020-04-21 21:25:45 -05:00
Maurice Parker 0e7c47b04e Refactored add window code to allow for multiple types of feed add window 2020-04-21 18:33:07 -05:00
Maurice Parker b7a37e2a25 Make mouseover/mouseout work with anchors that nest 2020-04-20 12:14:43 -05:00
Maurice Parker d0d29fd7da Merge branch 'master' into extension-point 2020-04-19 19:01:11 -05:00
Nate Weaver 2a6d9994ea Move shared CSS into its own file 2020-04-19 18:38:33 -05:00
Maurice Parker eeb7b518a8 Change how showIcons is determined to take into consideration empty bylines 2020-04-19 17:29:11 -05:00
Maurice Parker ac41c7af69 Added timestamp to retweets 2020-04-18 16:27:19 -05:00
Maurice Parker 2a0d75cf23 Add rendering as HTML 2020-04-18 10:41:18 -05:00
Maurice Parker 1778a270d6 Show byline in timeline for single feed timelines when available. 2020-04-18 07:53:56 -05:00
Maurice Parker 9b39165018 Merge branch 'master' into extension-point 2020-04-16 16:37:18 -05:00
Maurice Parker afdfe5fe71 Merge branch 'ios-release' 2020-04-16 16:36:53 -05:00
Maurice Parker 96dd4bb731 Merge branch 'master' into extension-point 2020-04-16 13:37:38 -05:00
Brent Simmons 6d9eda442f Remove userDeleted support. The read-items filter seems to fill the need to hide things. We’re simplifying the backend by removing this unused feature. 2020-04-12 17:12:36 -07:00
Maurice Parker 61b755486a Flesh out the ExtensionPointManager a little 2020-04-08 13:46:15 -05:00
Maurice Parker 3459f23461 Merge branch 'master' into accent-color-experimental 2020-04-06 09:20:44 -05:00
zgjie bcfd75ff68 Replace the `firstElementPassingTest` function come from RSCore with the native function `first(where:)`. 2020-04-06 02:06:24 +08:00
Maurice Parker 40ea5243c6 Removed notification we no longer needed to use to refresh the Feeds and Sidebar. 2020-04-01 20:31:32 -05:00
Maurice Parker 2afdd26c9d Change function names using the find suffix to use the existing suffix to match precedent. 2020-03-29 12:00:02 -05:00
Maurice Parker 6ce82fc28b Implement CloudKit feed add. 2020-03-29 03:43:20 -05:00
Maurice Parker 649972f57f Created the Developer build which has some functionality disabled for those without access to the API keys needed. 2020-03-28 16:51:41 -05:00
Maurice Parker e23cc4d8a6 Merge branch 'master' into accent-color-experimental 2020-03-28 00:56:53 -05:00
Maurice Parker 9a180bf083 Deleted obsolete code. 2020-03-27 18:35:41 -05:00
Maurice Parker 17ec88801a Automatically remove Feed items if they should be filtered. Issue #1950 2020-03-27 18:00:03 -05:00
Maurice Parker fdf8d2c5e9 Merge branch 'master' into accent-color-experimental 2020-03-23 21:59:04 -05:00
Maurice Parker 203f5cf7e7 Lighten timeline fonts 2020-03-23 21:58:35 -05:00
Maurice Parker b1a9494c19 Merge branch 'master' into accent-color-experimental 2020-03-23 21:44:14 -05:00
Maurice Parker 5afc3c55f8 Change timeline layout to increase information density. Issue #1938 2020-03-23 21:43:54 -05:00
Maurice Parker 68c2feba4f Merge branch 'master' into accent-color-experimental 2020-03-22 16:23:13 -05:00
Maurice Parker 532ac38ee4 Add Feeds Read Filter button. 2020-03-22 16:19:33 -05:00
Maurice Parker 36b53766d6 Add view options and filter to timeline. Issue #1937 2020-03-22 15:39:37 -05:00
Maurice Parker a8d3872490 Merge branch 'master' into accent-color-experimental 2020-03-22 10:39:46 -05:00
Maurice Parker 2f3482d260 Remove border on nested tables. 2020-03-21 17:14:39 -05:00
Maurice Parker 9bb110a622 Don't filter feeds when a download occurs. 2020-03-20 10:36:04 -05:00
Maurice Parker cc7887857a Fix block quote css bug. 2020-03-20 08:34:25 -05:00
Maurice Parker 6a384d99e6 Darken and lighten the accent color for the article view. 2020-03-20 08:13:39 -05:00
Maurice Parker 1e1fce59da Use system accent color to tint the article view 2020-03-20 06:41:38 -05:00
Maurice Parker a0db54568e Pull in styles that made it into iOS, but were forgotten on Mac. 2020-03-19 07:51:46 -05:00
Maurice Parker 14c0c0b516 Add pre and table styles that didn't make it over with the other revisions. 2020-03-18 16:46:14 -05:00
Maurice Parker 770206df60 Merge branch 'ios-release' 2020-03-17 17:19:31 -05:00
Maurice Parker 36841602a5 Change article rendering to use loadHTMLString instead of JavaScript. Issue #1923 2020-03-17 17:18:24 -05:00
Maurice Parker a65e28f408 Fix stretched timeline cells caused by scrolling on state restoration. 2020-03-17 02:05:50 -05:00
Maurice Parker ca5d17358d Added darkmode blockquote color. 2020-03-17 00:11:10 -05:00
Maurice Parker 6dfda37773 Add styles that got added to iOS but were forgotten for macOS. 2020-03-16 18:34:34 -05:00
Maurice Parker 0276c19459 Add Clean Up command. Issue #1912 2020-03-15 18:02:55 -05:00
Maurice Parker cba00b6d45 Added image luminescence processing to IconView so that pure white feed icons are visible. Issue #1731 2020-03-14 17:19:06 -05:00
Maurice Parker 5b5eaf6bb7 Merge branch 'ios-release' 2020-03-14 17:13:25 -05:00
Maurice Parker 118ce73c08 Change focus when the sidebar is shown or hidden. Issue #1004 2020-03-14 14:36:18 -05:00
Nate Weaver 76dd3abff2 Properly style footnotes that have been absoluted 2020-03-12 18:32:42 -05:00
Maurice Parker b31c18a721 Reduce the article padding to 32px from 64px. Issue #1885 2020-03-12 12:54:11 -05:00
Maurice Parker e0d8e35831 Don't remove filtered feeds on refreshes or other times we call batch update did perform. 2020-03-12 12:32:08 -05:00
Maurice Parker 343f705cd7 Fix article read filter which wasn't persisting correctly. 2020-03-12 12:07:01 -05:00
Maurice Parker 202ee57697 Coalesce more rebuild commands to make the unread count items appear more smoothly. 2020-03-11 14:49:17 -06:00
Maurice Parker d94e090094 Replace Mark Older as Read with Mark Above and Mark Below. 2020-03-08 16:15:17 -07:00
Maurice Parker fc447121d6 Save window state to user defaults. Issue #1852 2020-03-05 17:42:17 -07:00
Maurice Parker 7bc5a7946f Refactor so that state could be restored from alternate sources (such as UserDefaults). 2020-03-05 16:42:54 -07:00
Maurice Parker adb312bccb Add article state restoration. 2020-03-04 18:16:58 -07:00
Maurice Parker de38ba9f5b Added feed selection restoration. 2020-03-04 15:40:40 -07:00
Maurice Parker ceef6116f9 Persist and restore per window per feed timeline filter state. 2020-03-03 18:13:43 -08:00
Maurice Parker ae8f36d300 Save sidebar expanded state. 2020-03-03 17:10:03 -08:00
Maurice Parker 94d04e3cc2 Change restore and save func names to be more consistent. 2020-03-03 15:36:22 -08:00
Maurice Parker 1a41d4f265 Change window frame and controller splits to use new per window state restoration. 2020-03-03 11:26:33 -08:00
Maurice Parker 72e5915fb8 Refactor state restoration so that the MainWindowController has control of state restoration order. 2020-03-03 10:54:37 -08:00
Maurice Parker e920235038 Remove references to windows when they close so that they will deallocate. 2020-03-02 18:06:55 -08:00
Maurice Parker b6ff9e8ff4 Simplify the sidebar filter state preservation. 2020-03-02 17:55:36 -08:00
Maurice Parker eaa99db5c7 Initial support for multiple windows and state preservation. 2020-03-02 17:46:31 -08:00
Maurice Parker 94c6ca428f Merge branch 'mac-release' 2020-03-01 16:32:31 -08:00
Maurice Parker dc20aa0e22
Merge pull request #1833 from Wevah/embedded-widget-fix
Embedded widget fix
2020-03-01 14:25:23 -08:00
Maurice Parker 1c55e0c8a9 Don't show select in sidebar if the web feed is already selected. Issue #1843 2020-03-01 11:07:24 -08:00
Maurice Parker 80858adced Exclude currently selected article from feed filter. Issue #1841 2020-02-29 17:05:56 -08:00
Maurice Parker 5eed42721e Change so that feeds aren't filtered on select feed in sidebar if they are already visible. 2020-02-29 16:30:13 -08:00
Maurice Parker dac4c2ffb0 Disclose feed in side bar when selected from context menu even if the feed is filtered. Issue #1805 2020-02-29 16:24:14 -08:00
Maurice Parker 4b2f08e759 Refactor select web feed in sidebar to use the delegate pattern instead of a notification. 2020-02-29 15:50:13 -08:00
Maurice Parker d459c0927b Change smart feeds to ignore feed filter when programmatically selected.
Change selected item to ignore feed filter.  Issue #1805
2020-02-29 15:10:41 -08:00
Maurice Parker d1cd205eff Rebuild the side bar by coalescing unread count changes when the read feeds filter is active. Issue #1823 2020-02-29 14:15:37 -08:00
Maurice Parker c17ce1ceaa Make articles older than a specified period unable to be marked as unread. Issue #1407 2020-02-29 10:30:35 -08:00
Nate Weaver 82f8951c96 Don't force iframe height to auto
Prevents truncating of YouTube embeds without needing a wrapper div.
2020-02-28 08:24:42 -06:00
Nate Weaver bedaa75eb8 Set max-width to 44em (792px with an 18px font-size) 2020-02-28 07:47:19 -06:00
Maurice Parker 380614afc3 Change focus to smart feed when selected via hotkey. Issue #1009 2020-02-27 16:50:35 -08:00
Maurice Parker 8d57fd193c Make the star swipe background color yellow. Issue #1015 2020-02-27 16:27:12 -08:00
Maurice Parker 85bd20ca80 Stop media playback when the main window is closed. Issue #1646 2020-02-27 12:15:41 -08:00
Maurice Parker a465045888 Save last used folder name when adding a feed. Issue #1462 2020-02-27 11:27:41 -08:00
Maurice Parker 2ae021960b Move account files to the documents directory and out of the shared container. Issue #1784 2020-02-12 16:21:48 -08:00
Nate Weaver e6c2c32456 Standardize on tabs 2020-01-30 06:19:54 -06:00
Nate Weaver 447cc44b8e Put <title> and <base> in the <head> instead of <body>
This also means renderHTML() is no longer needed.
2020-01-30 06:15:14 -06:00
Maurice Parker dd5633b5ae Change to use the correct URL when reloading an image. 2020-01-27 16:27:13 -07:00
Maurice Parker 3a99e6430f Make the article icon code specify the desired article so that it can't pull the wrong one by mistake. Issue #1707 2020-01-27 12:58:32 -07:00
Maurice Parker 81e71051ef Change to reload the page.html file instead of using its string value. 2020-01-26 20:45:49 -07:00
Nate Weaver 3635176d58 --table-border-color -> --table-cell-border-color; add Mac table styles 2020-01-20 21:59:40 -06:00
Phil Dokas d3ecb68708 Positions the footnote popover on top of other content 2020-01-17 13:41:12 -08:00
Nate Weaver b35215d03b Update for pending RSCore String updates 2020-01-17 13:45:38 -06:00
Maurice Parker 3c1668c178 Make Feedbin/Twitter video usable. Issue #718 2020-01-17 12:17:38 -07:00
Nate Weaver 6eac3781ba Update to latest RSCore
Update use of OMPLString().
2020-01-13 22:20:57 -06:00
Nate Weaver 58c90feccf Update to latest RSCore 2020-01-13 15:32:13 -06:00
Nate Weaver ca429153ce Update to latest RSCore 2020-01-11 01:30:40 -06:00
Nate Weaver 6dc442c264 Update to latest RSCore 2020-01-08 23:40:55 -06:00
Brent Simmons 26bb2b8eaf Remove references to Article.bannerImageURL. We can bring it back if/when we start using it. 2019-12-28 20:53:36 -08:00
Brent Simmons 15184aa3f1 Finish changes mandated by DatabaseQueue changes. 2019-12-16 22:45:59 -08:00
Maurice Parker 58b24f3349 Rename callback: to completion: 2019-12-14 18:01:34 -07:00
Maurice Parker e303d64c1d Refresh feeds and sidebar when downloaded articles update all their unread counts. Issue #1430 2019-12-10 18:17:54 -07:00
Nate Weaver c66ed35799 Add WordPress specific emoji style 2019-12-06 00:31:37 -06:00
Brent Simmons ebd7c68396 Merge mac-release — remove attachments. 2019-12-04 22:36:08 -08:00
Brent Simmons 3ead2c63bc Remove attachments from the app, since we’re not using attachments in any way. We could always add it back later. 2019-12-03 23:03:15 -08:00