Commit Graph

203 Commits

Author SHA1 Message Date
Maurice Parker 8ff2776d88 Make sure we have only one web view in the view hierarchy after navigation. Issue #2075 2020-05-15 10:45:05 -05:00
Maurice Parker 225c98a70e
Merge pull request #2073 from rizwankce/open-in-safari-shortcut
Keyboard shortcuts for "Open in App Browser"
2020-05-15 04:38:26 -05:00
Rizwan Mohamed Ibrahim c9ebb6bd75
adds "Open In App Browser" shortcut 2020-05-15 12:39:33 +05:30
Maurice Parker 8500324eb2
Merge pull request #2041 from stuartbreckenridge/mail-fix-ios
mailto links now open on iOS
2020-05-14 07:26:26 -05:00
Rizwan Mohamed Ibrahim a9aefd252e
adds keyboard shortcuts
- toggle side bar on timeline
- toggle readers view on article
- go to settings on global
2020-05-13 17:29:59 +05:30
Brian Sanders 737f4bfdf5 Adds "Find in Article" activity to the share sheet
addresses #1750
2020-05-11 17:08:44 -04:00
Maurice Parker ccb813f6ec Allow autoplay on iOS 2020-05-10 12:21:35 -05:00
Maurice Parker 715804fe64 Merge branch 'ios-release' 2020-05-07 11:34:02 -05:00
Maurice Parker 46a96a7d50 Serialize access to the web view provider. Issue #2043 2020-05-07 11:32:11 -05:00
Maurice Parker 2d8cbb8017 Merge branch 'ios-release' 2020-05-06 18:39:55 -05:00
Maurice Parker 211e44fff5 Remove flash when changing out the web view upon returning to the foreground 2020-05-06 17:35:38 -05:00
Maurice Parker 14d8e9af30 Merge branch 'ios-release' 2020-05-06 15:12:25 -05:00
Maurice Parker 5f60b84b8b Reset all the web views when coming back to the foreground incase one of them is unavailable now 2020-05-06 14:53:09 -05:00
Stuart Breckenridge f58ac4d160
Wraps Alert strings in `NSLocalizedString`
Also removes `tel` scheme handling.
2020-05-04 13:25:02 +08:00
Stuart Breckenridge e825a5d516
Adds handling of `tel` url schemes 2020-05-03 22:37:01 +08:00
Stuart Breckenridge f901436211
mailto links now open on iOS
fixes #2036

Extends `URL` with an email address `var` for `mailto` schemes and adds a decisionHandler for `mailto` schemes on `WebViewController`. If the device cannot send mail, an alert is displayed.
2020-05-03 21:33:57 +08:00
Maurice Parker a48cbfe1ca Add code to show the Feed Inspector when the feed icon in the article view is pressed. Issue #1931 2020-04-28 21:26:57 -05:00
Maurice Parker f1357c0a23 Merge branch 'ios-release' 2020-04-21 20:25:14 -05:00
Rizwan Mohamed Ibrahim 108da4ccf4
Fix buttons a11y label for close and share button for image vc
Image View Controller buttons both close and share don't have correct
a11y label. This will add the localised label
2020-04-21 22:14:58 +05:30
Maurice Parker afdfe5fe71 Merge branch 'ios-release' 2020-04-16 16:36:53 -05:00
Maurice Parker 928e93c074 Remove web view recycling as this seems to contribute to the blank article problem on iPadOS 2020-04-16 16:26:53 -05:00
Maurice Parker 46f614e960 Merge branch 'ios-release' 2020-04-12 11:50:11 -05:00
Maurice Parker 7064d5d8f5 Fix regression where navigating back and paging back from an article happened at the same time. 2020-04-12 11:48:14 -05:00
Maurice Parker e6c5d2f199 Merge branch 'ios-release' 2020-04-11 15:59:37 -05:00
Maurice Parker 7c266d65ee Force the frame to center when displaying. Issue #1983 2020-04-11 15:58:48 -05:00
zgjie bcfd75ff68 Replace the `firstElementPassingTest` function come from RSCore with the native function `first(where:)`. 2020-04-06 02:06:24 +08:00
Maurice Parker 649972f57f Created the Developer build which has some functionality disabled for those without access to the API keys needed. 2020-03-28 16:51:41 -05:00
Maurice Parker 36841602a5 Change article rendering to use loadHTMLString instead of JavaScript. Issue #1923 2020-03-17 17:18:24 -05:00
Maurice Parker 37cf7fae1d Fix regression that prevented Always Show Reader View from working. 2020-03-16 07:58:51 -05:00
Maurice Parker 07dc4f1f10 Don't start the article extractor if we only want to store the article. Issue #1494 2020-03-14 06:31:14 -05:00
Maurice Parker 7922efab1e
Merge pull request #1899 from flowinho/ios-release
Hide articleExtractor and actionBarButtonItem
2020-03-13 15:13:33 -05:00
Flowinho ce428d2cc6 Hide articleExtractor and actionBarButtonItem 2020-03-13 20:21:18 +01:00
Maurice Parker 47e42fab0a Removed old debugging statement. 2020-03-12 16:01:13 -05:00
Flowinho da64f65c7b Fixes close button icon distortion
This bug was caused by an inaccessible property of UIButton. Since the button was setup in IB using a system button with a custom icon, it’s imageView property is only accessible in code. The “view” content-mode in IB is misleading here, as it affects the UIButton.view NOT UIButton.ImageView.

- Set content-mode of the buttons imageview to scaleAspectFit.
2020-03-12 21:54:50 +01:00
Flowinho feacda1c3b HOTFIX silly me 2020-03-12 21:33:02 +01:00
Flowinho 91247b7f16 Adding dynamic width algorithm to the titleLabel
This commit adds multiple functionalities at once:

- The background of the image title now features rounded corners with a radius of 6 - which is consistent to iOS appearace.
- The background of the image title now is enlarged to make sure the letters do not touch the borders of the view. (This was a finding during implementation).
- The background of the image title is now removed when no title is present (memory optimization / prevention of unwanted optical glitches).

The title label now resizes itself depending on the devices it’s displazed on.

- On iPhone it will take 92% percent of available screen width.
- On iPhone it will 80% of available screen width.
- This works for all device orientations.

The numbers are derived from my personal preference when implementing it.
2020-03-12 21:23:57 +01:00
Maurice Parker 22b9e7b54b Don't reset the windowScrollY position on every page render and don't set it if JavaScript returns it corrupted. Issue #1883 2020-03-11 19:45:45 -05:00
Maurice Parker 27b1443def Remove dispatch code that didn't seem to help and caused us to not be able to find the correct view controller when setting the article. Issue #1881 2020-03-11 18:17:09 -06:00
Maurice Parker 76d5f4a073 Remove flush and restore of web view queues. Issue #1882 2020-03-11 17:02:16 -06:00
Maurice Parker cd5e491f00 Fix issue where full screen wouldn't come back after being engaged and moving to the timeline. (Regression) 2020-02-26 16:02:36 -08:00
Maurice Parker 9e3f061fcb Dispatch the page controller setting since it is unreliable. Issue #1756 & Issue #1808 2020-02-25 18:06:02 -08:00
Maurice Parker 5a5abb0b87 Ensure that the dom is fully loaded on *all* web views before being made available to process JavaScript. Issue #1756 & Issue #1808 2020-02-25 15:10:51 -08:00
Maurice Parker 0e72811429 Implement mark as unread window for accounts that need it. Issue #1407 2020-02-18 13:49:29 -08:00
Maurice Parker 8acd6a039a Change event used to stop web view activity (video and image zooming) so that it doesn't interfere with the image zooming transition. 2020-02-18 11:08:38 -08:00
Maurice Parker e3b32847f9 Stop image zooming on swipes and video playback on button presses. Issue #1801 2020-02-18 09:49:54 -08:00
Maurice Parker 58b8a9adb0 Render article on to be recycled web view and delay new web view showing to 0.3. Issue #1780 2020-02-13 17:35:34 -08:00
Maurice Parker d01e9cef42 Remove unintended web view load when changing the article. 2020-02-13 16:08:44 -08:00
Maurice Parker 2ae021960b Move account files to the documents directory and out of the shared container. Issue #1784 2020-02-12 16:21:48 -08:00
Maurice Parker 31b72221f8 Rollback delay that was causing blank articles to be shown. Issue #1780 2020-02-09 11:57:07 -08:00
Brent Simmons eb770f4494 Merge branch 'ios-candidate' of https://github.com/Ranchero-Software/NetNewsWire into ios-candidate 2020-02-08 17:22:03 -08:00
Brent Simmons cac67f8ac4 Use percent-encoding — via URLComponents — on the articleID in the nnwImageIcon URL scheme. 2020-02-08 17:21:55 -08:00
Maurice Parker bdd79aead5 Delay swapping out the web view until the new web view has had a chance to render. Issue #1780 2020-02-08 16:55:16 -08:00
Maurice Parker e5a9205747 Always reload the web view when the showing state changes. Issue #1775 2020-02-06 11:41:06 -08:00
Maurice Parker 268c20da56 Set all the web view delegates to nil when recycling to prevent unintended behaviors. Issue #1777 2020-02-06 10:36:39 -08:00
Maurice Parker d1f1ca22b6 Add a hack to prevent horizontal scrolling on iPad. Issue #1714 2020-02-05 13:46:59 -08:00
Maurice Parker dfd6be5fa6 Flush are rebuild web view queue when suspending and restoring the app. Issue #1563 2020-02-04 16:00:26 -08:00
Maurice Parker 8ed9958631 Change full article setting to enable or disable the feature. Issue #1773 2020-02-04 11:24:06 -08:00
Maurice Parker 596575c0e8 Delay making the initial web view available to give it some time to load the DOM. Issue #1756 2020-02-01 16:41:10 -08:00
Maurice Parker 8cb28b63b8 Always swap out the web view to prevent white flashing between articles and make loading faster. 2020-01-31 21:07:08 -07:00
Maurice Parker a0f429448f Call completions immediately if the previous WebViewController was deallocated because the iPad was rotated. Issue #1757 2020-01-30 18:48:51 -07:00
Maurice Parker ab8deab726 Correct object ownership to remove retain cycle 2020-01-30 12:53:27 -07:00
Nate Weaver 447cc44b8e Put <title> and <base> in the <head> instead of <body>
This also means renderHTML() is no longer needed.
2020-01-30 06:15:14 -06:00
Maurice Parker f9589faa59 Keep queued WKWebViews in a hidden view until they are needed. Issue #1563 2020-01-29 17:39:40 -07:00
Maurice Parker c293bc3a12 Animate timeline article selection and scrolling when done via article swiping. Issue #1732 2020-01-29 16:31:50 -07:00
Maurice Parker f96bb9c3e0 Store more article view controller state when destroying and recreating them. Issue #1729 2020-01-29 11:30:52 -07:00
Maurice Parker dd5633b5ae Change to use the correct URL when reloading an image. 2020-01-27 16:27:13 -07:00
Maurice Parker 3a99e6430f Make the article icon code specify the desired article so that it can't pull the wrong one by mistake. Issue #1707 2020-01-27 12:58:32 -07:00
Maurice Parker 470f2159e8 Remove dead code left from when WebViewController was split from ArticleViewController. 2020-01-27 11:50:28 -07:00
Maurice Parker 97d6c69431 Change to always reload the page when rendering an article. Issue #1713 2020-01-26 20:29:58 -07:00
Maurice Parker 4a63b28c73 Change how next and previous articles are selected so that animation timings can't impact them. Issue #1707 2020-01-26 14:21:04 -07:00
Maurice Parker bc5a8c3705 Reset scroll position when article is reset. Issue #1716 2020-01-26 13:01:03 -07:00
Maurice Parker 785775801a Don't force cast scrollY as it might not always be set. Issue #1685 2020-01-25 15:36:43 -07:00
Maurice Parker deab8f8c6c Change to stop recycling the article view controller when switching panel modes on the iPad. Issue #1570 2020-01-21 11:05:47 -07:00
Maurice Parker 61c854b031 Fix animation layer stripping. Issue #1668 2020-01-20 13:16:03 -07:00
Martin Hartl 3370b834b0 Stop media playback when article will disappear 2020-01-20 19:46:23 +01:00
Maurice Parker 7e35bd1ec4 Remove unused parameter. It was obsoleted, but not removed. 2020-01-19 15:36:19 -07:00
Maurice Parker 88f565e03f Use the DOM Y position to restore the scroll offset. This mostly fixes Issue #1494. 2020-01-19 11:48:26 -07:00
Maurice Parker f0d8a9038d Reload the web view every 10 renderings to clean it up. Issue #1487 2020-01-18 11:59:24 -07:00
Maurice Parker 34984551c6 Fully reload the page when the content size changes. Issue #1642 2020-01-17 12:53:50 -07:00
Maurice Parker f9e529bd3b Fix multiwindow auto layout errors. Issue #1636 2020-01-16 21:29:10 -07:00
Maurice Parker 2584462bc1 Fix scrolling code so that it takes into consideration the content is under the bars now. Issue #1633 2020-01-16 19:40:13 -07:00
Maurice Parker 4eedd96507 Fix regression that prevented Safari from opening from Activity dialog. 2020-01-15 18:23:09 -07:00
Maurice Parker 3e604e0b34 Load the feed article if the extracted article fails to parse. Issue #1542 2020-01-15 17:34:02 -07:00
Maurice Parker c384362a78 Set extractor button state on viewDidLoad. Issue #1627 2020-01-15 17:28:37 -07:00
Kiel Gillard 0d0b6b8fa6 Gives iOS a chance to open universal links. #1625 2020-01-16 09:56:51 +11:00
Martin Hartl c739d77817 Provide dedicated TitleActivityItemSource when sharing to Omnifocus and Things 2020-01-11 09:12:41 +01:00
Maurice Parker f1e01bd43f Automatically show the nav and toolbars when separating controllers. Issue #1593 2020-01-09 21:22:29 -07:00
Maurice Parker 1b1b3e796e Shoehorn the controller into the little area allowed for context previews in landscape. Issue #1569 2020-01-09 21:11:13 -07:00
Maurice Parker 9fedf68b3f Add action to Share button to open in Safari. Issue #1573 2020-01-09 18:27:52 -07:00
Maurice Parker 3115abc72e Enhance accessibility for toggle toolbar buttons. Issue #1581 2020-01-09 14:38:25 -07:00
Maurice Parker 96c781f468 Change so that we don't crash if the article extractor completes and its delegate is deallocated. Issue #1566 2020-01-08 11:22:11 -07:00
Maurice Parker 15569e62b2 Prevent crash when the web view load hasn't set up the tap zone constraints. Issue #1564 2020-01-08 10:54:41 -07:00
Maurice Parker c2d298b836 Add the image title text to zoomed images. Issue #1468 2019-12-31 18:06:27 -07:00
Maurice Parker f0a5309786 Fix bug that prevented first article from being selected on iPad. 2019-12-31 17:06:13 -07:00
Maurice Parker af76e44c0f Changed ArticleViewController to utilize UIPageViewController to provide gesture based navigation. 2019-12-31 16:55:39 -07:00
Maurice Parker 00ed368683 Change the full screen tap zone to be the center of the navigation bar instead of the whole navigation bar. Issue #1450. 2019-12-26 12:21:56 -07:00
Brent Simmons 15184aa3f1 Finish changes mandated by DatabaseQueue changes. 2019-12-16 22:45:59 -08:00
Maurice Parker 6f2e6a7d9a Add mask back in so that the zoom image doesn't overlay the bars when zooming back. 2019-12-10 17:54:14 -07:00
Maurice Parker 9b3793968f Change image zoom animation to take safe area into consideration when determining image origin. Issue #1425 2019-12-09 14:29:17 -07:00
Maurice Parker 2ea8253e25 Make navigation and toolbars transparent. Issue #1413 2019-12-07 11:53:53 -07:00