Commit Graph

304 Commits

Author SHA1 Message Date
Brent Simmons 5ffe3bb948 Move existingToolbarItem function to NSToolbar category in RSCore. 2018-02-17 20:45:15 -08:00
Brent Simmons a633c49a6c Move toolbar and sharing service delegates from MainWindowController to separate objects. 2018-02-17 20:33:30 -08:00
Brent Simmons 054c7fb409 Remove unused references to AppNavigationKeyPressed. 2018-02-17 18:26:17 -08:00
Brent Simmons 2325e7edbc Move the isOpen property from specific window controllers to the NSWindowController extension in RSCore. 2018-02-17 18:22:57 -08:00
Brent Simmons 9d39ae2de4 Create and use AppImages.swift for widely-referenced images. 2018-02-17 18:19:25 -08:00
Brent Simmons 58a1a92481 Remove isDisplayingSheet property now that it’s part of an NSWindowController extension. 2018-02-17 18:14:51 -08:00
Brent Simmons 95268db09b Use CoalescingQueue with the refresh progress indicator in the sidebar. 2018-02-17 18:10:00 -08:00
Brent Simmons c5ed540194 Use CoalescingQueue.standard instead of one created by AppDelegate. 2018-02-17 17:45:05 -08:00
Brent Simmons c8fa1b71d9 Create and use a fetchAndMergeArticlesQueue (coalescing queue) for TimelineViewController. 2018-02-17 15:29:55 -08:00
Brent Simmons b3ea268807 Use appDelegate’s coalescing queue to update toolbar items. 2018-02-17 15:20:07 -08:00
Brent Simmons 7bcb8f7d12 Use appDelegate’s coalescing queue for reloading visible cells. 2018-02-17 15:16:30 -08:00
Brent Simmons 8e18c85b58 Remove no-longer-valid comment. 2018-02-17 12:36:18 -08:00
Brent Simmons c048b6bea0 Delete now-unused data source methods from TimelineViewController.. 2018-02-17 12:29:57 -08:00
Brent Simmons 673686ca68 Create TimelineDataSource as part of making TimelineViewController less big. 2018-02-17 12:21:15 -08:00
Brent Simmons 21f262e953 Make mark-as-starred menu item work; make it validate; change its name as needed. 2018-02-17 12:01:14 -08:00
Brent Simmons ce5b60cfe8 Update mark-as-starred toolbar item tooltip during validation. 2018-02-17 10:32:32 -08:00
Brent Simmons 1603d0b3f2 Make progress on the star/unstar command and on updating its toolbar item. 2018-02-16 22:35:04 -08:00
Brent Simmons e1a51b8acd When updating a timeline that’s already displaying, merge articles by articleID, so that updated versions replace older versions. 2018-02-16 21:21:27 -08:00
Brent Simmons d081f041f8 Skip group rows when going to next unread. Fix #273. 2018-02-15 17:50:31 -08:00
Brent Simmons 2f21dbf6be Remove extraneous get { from a bunch of read-only accessors. 2018-02-14 13:14:25 -08:00
Brent Simmons 0762074e91 Support display of articles in the timeline from multiple items selected in the sidebar. As a side effect: fix #295. 2018-02-12 22:13:37 -08:00
Brent Simmons f2228120b5 Make SidebarOutlineDataSource a separate object. Move data source methods out of SidebarViewController. 2018-02-12 22:02:51 -08:00
Brent Simmons e773df33e3 Start work on saving main window state. 2018-02-12 13:31:43 -08:00
Brent Simmons 09b8cd7811 Support the Copy command in the timeline. Fix #114. 2018-02-12 13:04:07 -08:00
Brent Simmons 81e56ba84b Implement and validate the Copy command for the sidebar. Fix #115. 2018-02-11 22:10:28 -08:00
Brent Simmons 1aac355418 Make all senders parameters for actions optional — Any? instead of AnyObject or Any. 2018-02-11 18:58:50 -08:00
Brent Simmons 46e0f781f8 Skip clearing undo stack when timeline view changes articles. Fix #341. 2018-02-11 17:45:02 -08:00
Brent Simmons c8d2fac9a6 Rename MarkReadOrUnreadCommand to MarkStatusCommand and make it handle starring/unstarring and deleting/undeleting. Also: add contextual menu for smart feeds in the sidebar. 2018-02-11 12:59:35 -08:00
Brent Simmons f5bfadfb33 Make the UnreadFeed conform to ArticleFetcher. It now displays articles in the timeline when selected. 2018-02-10 13:00:53 -08:00
Brent Simmons 9ac2d7d033 Create a WKWebView subclass (ugh) in order to hide items in its contextual menu. Fix #120. 2018-02-10 11:16:09 -08:00
Brent Simmons d46ae4df33 Add contextual menu to timeline. 2018-02-09 23:16:12 -08:00
Brent Simmons 46cae22987 Use the menu.takeItems method. 2018-02-09 22:10:52 -08:00
Brent Simmons 582fd62080 Start work on timeline contextual menus. 2018-02-08 13:24:43 -08:00
Olof Hellman dcd2ee94f9 Merge remote-tracking branch 'brentsimmons/master' 2018-02-08 00:12:33 -08:00
Olof Hellman 395af1420e implement 'current article' property of the application
Also, fix the unique-id based accessors (the four byte code  for id was
wrong in the sdef)
Add valueIn<Key>WithUniqueID accessors
Add a few protocols and protocol implementations for the AppDelegate
and MainWindowControllor so as to expose needed functionality for
scriptability
2018-02-08 00:11:52 -08:00
Brent Simmons 765a91dd34 Restore selection in timeline after reload due to font size change. 2018-02-07 21:48:51 -08:00
Brent Simmons 2797c607c3 Update row height in timeline when font setting changes. 2018-02-07 21:46:54 -08:00
Brent Simmons 78530dbb96 Change the name of the Show/Hide Sidebar command as needed. Fix #98. 2018-02-07 21:42:33 -08:00
Brent Simmons a3a9d467dc Show the contextual menu for all selected items in the sidebar when the clicked row is part of the selection. 2018-02-07 21:23:18 -08:00
Brent Simmons 4491c5f443 Make the sidebar contextual menu refer to the clicked row rather than the selected row. 2018-02-07 13:25:17 -08:00
Brent Simmons d59058c014 Show a contextual menu in the sidebar. Create and wire-up SidebarContextualMenuDelegate. 2018-02-07 13:17:28 -08:00
Brent Simmons 1f0123db36 Remove code setting the sidebarViewController on SidebarOutlineView, since it doesn’t use it. 2018-02-07 13:11:40 -08:00
Brent Simmons 03b1440045 Reorder UTI types in FeedPasteboardWriter to be like the order in ArticlePasteboardWriter. 2018-02-04 13:45:26 -08:00
Brent Simmons 6b14d6e8d3 Remove temporarily the Delete menu item from the sidebar gear menu. 2018-02-04 12:15:59 -08:00
Brent Simmons c26c705de0 Make Mark All as Read command in sidebar gear menu work. 2018-02-04 11:45:51 -08:00
Brent Simmons 2999641572 Move MainWindowController+ContextualMenus to SidebarViewController+ContextualMenus, where it always should have been. 2018-02-04 11:19:24 -08:00
Brent Simmons 27c5ffa5eb Add new-feed and new-folder commands to the sidebar gear menu when there’s no selection. 2018-02-03 21:30:30 -08:00
Brent Simmons 68d0885b0d Get rename sheet working, finally. 2018-02-03 21:04:28 -08:00
Brent Simmons ae840b31bc Continue progress on rename sheet. 2018-02-03 20:30:23 -08:00
Brent Simmons 01729378f3 Make further progress on rename sheet. 2018-02-03 18:49:29 -08:00
Brent Simmons a03562eee8 Make further progress on the rename sheet. 2018-02-03 16:05:59 -08:00
Brent Simmons e7ce12869c Disable commands to add a feed or add a folder if the window is already displaying a sheet. Fix #319. 2018-02-03 10:56:12 -08:00
Brent Simmons 9fce370967 Try again to check in the added outlets. 2018-02-02 23:01:12 -08:00
Brent Simmons 70a3e6cc89 Wire up outlets for the rename sheet. 2018-02-02 23:00:09 -08:00
Brent Simmons 50dcf436d9 Change Cocoa imports to AppKit imports, because we don’t need CoreData imported (which Cocoa imports). 2018-02-02 22:51:32 -08:00
Brent Simmons 6347ac7888 Merge branch 'master' of https://github.com/brentsimmons/Evergreen 2018-02-02 21:56:52 -08:00
Brent Simmons 920be7b0d1 Start work on the sidebar gear menu. There are commands there now. They don’t all work. 2018-02-02 21:56:17 -08:00
Daniel Jalkut a291f1e93c Merge branch 'fix-toolbar-validation' into xcode9.3 2018-01-29 11:49:47 -05:00
Daniel Jalkut e4136c2165 Sender should be Any? to reflect the fact it may be nil. This nuance seems to make the difference on Xcode 9.3/Swift 4.1 between crashing or not. Without this change, refreshing crashes every time, presumably because Swift is making assumptions about the parameter being non-nil and refreshProgressDidChange calls it explicitly with a nil parameter. 2018-01-29 11:48:09 -05:00
Daniel Jalkut d7f13ca4be Change from flatMap to new compactMap rename in Xcode 9.3. 2018-01-29 11:19:54 -05:00
Brent Simmons 2d7d903bca Create and use a SidebarGearMenuDelegate to show a menu when the gear menu in the sidebar is clicked. 2018-01-28 16:09:18 -08:00
Brent Simmons 285e3971d7 Re-sort the timeline when sort direction changes. Fix #65. 2018-01-28 11:45:18 -08:00
Brent Simmons 78e8823f23 Merge branch 'master' of https://github.com/brentsimmons/Evergreen 2018-01-28 11:33:58 -08:00
Brent Simmons ffd11b91ef Register for UserDefaults.didChangeNotification instead of using KVO on NSUserDefaultsController. 2018-01-28 11:33:45 -08:00
Brent Simmons 28c4ea82e5 Consider sort direction when sorting the Article array for the timeline. 2018-01-28 11:33:04 -08:00
Brent Simmons 144bccd45e
Merge pull request #305 from michaeljtsai/master
Share button now supports "EagleFiler Import" and "Add to Reading List".
2018-01-28 10:51:45 -08:00
Brent Simmons b32d45cd60 Add isOpen property to MainWindowController. 2018-01-27 15:04:45 -08:00
Brent Simmons 3ff00b7eb0 Make Go > Today, Unread, Starred commands work. Fix #310. 2018-01-27 12:39:07 -08:00
Brent Simmons bc1fe05e91 Move sentence about bindings to the right section. 2018-01-23 21:07:29 -08:00
Michael Tsai 063ed29d5d Share button now supports "EagleFiler Import" and "Add to Reading List".
List .URL before .string in the pasteboard types because otherwise the system will not propose sharing services that receive URLs but not text.
2018-01-22 11:02:29 -05:00
Brent Simmons 394274f1e5 Continue progress on inspector. 2018-01-21 11:35:50 -08:00
Brent Simmons 807ad99aad Add new articles to the timeline when a feed that affects the timeline gets new articles. Fix #166. 2018-01-20 16:54:18 -08:00
Brent Simmons 9fea9c2d12 Create and use fetchUnsortedArticles(for:), which is common code that needed to be a separate function. 2018-01-17 22:03:13 -08:00
Brent Simmons 21f1863cd0 Unbreak the build by commenting out some in-progress code. 2018-01-17 21:51:24 -08:00
Brent Simmons 6b059671f5 Make progress on reloading timeline when feed updates. 2018-01-17 17:28:09 -08:00
Brent Simmons c3bcf82713 Make the send-to-Micro.blog command work. Need some tweaking, but it mostly does the job. 2018-01-11 22:18:46 -08:00
Brent Simmons ccc699741d Decrease the opacity of the placeholder color for avatars in the timeline. 2018-01-09 21:33:13 -08:00
Brent Simmons 8b2f9b333a Make feed icons and favicons show up more quickly and reliably in the timeline. 2018-01-09 21:09:09 -08:00
Brent Simmons 1b0648cd18 Make feed icons show up more promptly and reliably in the timeline. 2018-01-08 21:34:39 -08:00
Brent Simmons 0a1642abdf Draw a white unread indicator in the timeline when the cell is selected and emphasized. Fix #112. 2018-01-06 14:33:16 -08:00
Brent Simmons 0d4a58e2ab Create and use an NSTableView extension method: indexesOfAvailableRowsPassingTest. 2018-01-06 12:12:31 -08:00
Brent Simmons cfcfe2b4b5 Make reloading the timeline cells even more efficient upon avatar-download. 2018-01-06 11:56:32 -08:00
Brent Simmons f9b4e192e0 Make updating the timeline cells more efficient after downloading an avatar. 2018-01-06 11:18:03 -08:00
Brent Simmons 45f3f49a1f Fix bug where user avatars wouldn’t always show up in the timeline view promptly. 2018-01-05 13:22:16 -08:00
Brent Simmons 665561e5eb Show avatars in the timeline at the right times. 2018-01-04 21:20:09 -08:00
Brent Simmons e2c36caeee Move favicons in the detail view to the right. They’re show when available and there’s no other feed icon or user avatar. 2018-01-03 13:14:14 -08:00
Brent Simmons 4bb5270860 Move template and style sheet to same group as ArticleRenderer. 2018-01-03 13:07:05 -08:00
Brent Simmons 867e775e69 Show feed icons and avatars in the timeline. 2017-12-31 12:10:30 -08:00
Brent Simmons b35193b823 Make timeline cell height calculation reliable by considering all the rects, instead of assuming that one or another is the determining rect. 2017-12-31 12:08:25 -08:00
Brent Simmons 04c35dc1bf Comment out code for showing favicons in the timeline, since I don’t think we’re going to do that. But not totally sure yet. 2017-12-30 16:12:49 -08:00
Brent Simmons befc5efc77 Show feed names and favicons in timeline when appropriate.
I don’t quite like this. Maybe avatars are better.
2017-12-30 12:45:10 -08:00
Brent Simmons 0c54e61fbc Update the showFeedNames timeline property based on what will be shown in the timeline. 2017-12-30 10:56:58 -08:00
Brent Simmons 5dd20264bf Use feed icon’s gathered from HTML metadata. 2017-12-29 20:41:41 -08:00
Brent Simmons d2d7369d6a Show favicon in detail view when available and when there’s no user avatar or feed icon. 2017-12-29 20:04:43 -08:00
Brent Simmons 7f7f9c5166 Add note about messy code. 2017-12-29 19:03:52 -08:00
Brent Simmons 65fcbf00bf Show just one avatar in detail view. Make date a permalink, when available. 2017-12-29 18:59:04 -08:00
Brent Simmons 4be6df2c56 Continue experimentation with detail view avatars. 2017-12-29 17:10:50 -08:00
Brent Simmons 708e46ed18 Make progress on showing avatars in the detail view. 2017-12-29 12:21:19 -08:00
Brent Simmons d7e5c88b8f Create byline for detail view. 2017-12-29 11:31:47 -08:00
Brent Simmons a210dd2318 Make detail status bar show only on mouseover of a link. Don’t have an always-present view of the permalink. (We’ll see how this goes.) 2017-12-28 18:41:01 -08:00