Daniel Jalkut
2e652351ec
Implement the WKUIDelegate method that is reached when JavaScript in a web view invokes window.open(). This ensures that attempts to open links from code, such as from the YouTube embedded video player, work as expected. Fixes #3088 .
2021-07-27 17:34:48 -04:00
Maurice Parker
f9af3c786b
Merge branch 'ios-candidate'
2021-05-25 20:12:50 -05:00
Brent Simmons
9d2c8f000f
Create and use IconImageCache. It centralizes and de-dupes logic for getting feed/article images, and it caches the results, which helps performance.
2021-05-08 12:42:44 -07:00
Chris Campbell
364f3a7639
Prevent infinite loop in DetailWebView.setFrameSize()
...
DetailWebView.setFrameSize() calls bigSurOffsetFix(), which changes the window's frame, which ultimately calls setFrameSize() again (which calls bigSurOffsetFix(), etc). In practice, this isn't causing an infinite loop (I think NSWindow.setFrame(_:display:) is smart enough to prevent reentrancy) but it's still dangerous to have such a glaring logic error in the code.
2021-04-30 00:52:15 -04:00
Chris Campbell
bf77d77669
Expand workaround for macOS 11 WebView origin offset bug. Fixes #2916
...
Move the code that twiddles the window frame from DetailWebView.viewDidEndLiveResize() into a new bigSurOffsetFix() API so it can also be called by setFrameSize() when the frame size is changed outside of a live resize.
2021-04-30 00:02:10 -04:00
Duncan Babbage
9092d075a0
Handle links with unencoded spaces. Fixes #3069
2021-04-28 22:49:32 +12:00
Stuart Breckenridge
5af2643479
standardised naming
2021-04-19 11:21:00 +08:00
Stuart Breckenridge
d4130e7c65
Corrects naming convention
...
[iOS]
Twitter: Notify about new tweets
Reddit: Notify about new posts
Default: Notify about new articles
+ Fixes alignment issues in the inspector view
[macOS]
Twitter: Show notifications for new tweets
Reddit: Show notifications for new posts
Default: Show notifications for new articles
2021-04-19 11:10:57 +08:00
Maurice Parker
77dd2e5e22
Merge branch 'mac-release' into main
2021-04-15 14:31:52 -05:00
Maurice Parker
3955151daf
Make sure mark as read completes before searching for the next unread. Fixes #2952
2021-04-15 14:29:49 -05:00
Stuart Breckenridge
4e517a6db4
Disable Reader View
...
This commit:
- adds a `isFeedProvider: Bool` property to `WebFeed`
- if `isFeedProvider` is `true`, the article extractor is disabled on the inspector, hidden from the context menu, and the toolbar button is disabled. Additionally, if `isFeedProvider` is `true`, `isArticleExtractorAlwaysOn` returns `false` and cannot be set to `true`.
2021-04-09 07:47:14 +08:00
Maurice Parker
b1a0b649a5
Merge pull request #2972 from j-f1/read-unread
...
Update swipe actions on macOS to match iOS
2021-04-07 03:47:27 -05:00
Jed Fox
3609b6f977
Add labels to swipe actions to match iOS
2021-04-06 17:34:05 -04:00
Maurice Parker
ea6cece955
Merge branch 'mac-release' into main
2021-04-03 09:30:42 -05:00
Maurice Parker
1ab727a128
Make symbol images images scale correctly. Fixes #2957
2021-04-01 11:12:48 -05:00
Jed Fox
4750e9b93a
Add dir=auto to page.html
2021-03-29 17:20:09 -04:00
Maurice Parker
95234706e1
Fix issue where next unread wasn't wrapping around. Fixes #2942
2021-03-29 14:33:08 -05:00
Maurice Parker
fb9114538c
Modified the Timeline so that it can handle duplicate articleIDs
2021-03-28 06:30:49 -05:00
Maurice Parker
ab5421f533
Merge branch 'mac-release' into main
2021-03-27 17:21:49 -05:00
Maurice Parker
42e6e1397d
Signal that the mouse exited the link when an article gets reloaded. Fixes #2877
2021-03-15 20:14:30 -05:00
Maurice Parker
78b9444274
Remove extra unused parameter in delegate signature
2021-03-15 20:10:42 -05:00
Maurice Parker
52f11ff538
Add validateFeed parameter to createWebFeed
2021-03-15 18:01:12 -05:00
Maurice Parker
f1e4d70481
Simplify the folder copy logic
2021-03-15 17:47:53 -05:00
Maurice Parker
d57cb7b21f
Delete obsolete code
2021-03-15 17:35:23 -05:00
Maurice Parker
7e4e7091e2
Delete obsolete code
2021-03-15 17:33:12 -05:00
Maurice Parker
bf76cb810d
Change to always copy between accounts. Fixes #2871
2021-03-11 19:43:05 -06:00
Stuart Breckenridge
e2f21c15c2
formatting
2021-03-08 14:12:32 +08:00
Stuart Breckenridge
f630cb16db
comments
2021-03-08 10:30:58 +08:00
Stuart Breckenridge
a59df3e6fc
Moves frame tweaking to end of liveResize
2021-03-08 10:28:51 +08:00
Stuart Breckenridge
27b9326d07
fixes #2823
2021-03-08 10:06:30 +08:00
Stuart Breckenridge
2e12f5a078
removes code comment
2021-03-07 21:34:52 +08:00
Stuart Breckenridge
86981a0c5b
#2597
...
Fixes #2597 : Toggles a small window height change to get webview to behave on macOS 11.
2021-03-07 16:47:39 +08:00
Stuart Breckenridge
7a653db1dd
typo
2021-03-07 15:51:43 +08:00
Stuart Breckenridge
8dc6e4e332
Contraint Changes
...
• Fixes #2850
• #2634: resizing vertically downards (expanding) is smooth
2021-03-07 14:21:30 +08:00
Maurice Parker
d0e3ec6d1c
Fix variable name
2021-03-06 16:25:44 -06:00
Maurice Parker
a7abde04ab
Fix variable name
2021-03-06 16:25:10 -06:00
Maurice Parker
2ca06eeae7
Remove containing box for web view. Fixes #2848
2021-03-05 12:45:15 -06:00
Collin Donnell
035759947a
Fix #2833 : Titlebar is overlapped by toolbar in fullscreen
...
Fix issue where detail web view would be overlapped by the toolbar in full screen by setting web view constraints to use the `safeAreaLayoutGuide` in macOS 11+.
2021-02-27 19:02:13 -06:00
Collin Donnell
593569175c
Fix #2833 : Titlebar is overlapped by toolbar in fullscreen
...
Fix issue where detail web view would be overlapped by the toolbar in full screen by setting web view constraints to use the `safeAreaLayoutGuide` in macOS 11+.
2021-02-27 16:32:57 -08:00
Maurice Parker
74298e7cde
Add hidden GruberFeedDoubleClickMarkAsRead preference
2021-02-26 17:38:26 -06:00
Maurice Parker
1f159a5bff
Change drag-n-drop behavior to default to copy when dragging between accounts
2021-02-22 18:50:29 -06:00
Maurice Parker
afd9a47abd
Change so that we only show one error dialog when folder moves/copies can't find one or more feeds.
2021-02-22 17:50:30 -06:00
Maurice Parker
931b1f9afd
Show Folder as it is created to give better visual feedback that a folder copy was successful. Fixes #2815
2021-02-22 17:14:41 -06:00
Maurice Parker
25ee970562
Remove async call since the Big Sur bug that it was working around appears to be fixed. Fixes #2791
2021-02-22 12:17:43 -06:00
Maurice Parker
731d0d0d88
Show Folder as it is created to give better visual feedback that a folder copy was successful. Fixes #2815
2021-02-16 14:24:21 -06:00
Maurice Parker
ca294c7528
Remove async call since the Big Sur bug that it was working around appears to be fixed. Fixes #2791
2021-02-15 17:49:28 -06:00
Stuart Breckenridge
1e578828e9
: class chnaged to : AnyObject for protocols
2021-02-06 07:06:45 +08:00
Stuart Breckenridge
e88327be78
You can’t toggle an optional Bool
2021-02-02 13:25:06 +08:00
Stuart Breckenridge
aa0a5d2269
Checks for notification permissions
...
If notifications are authorised, the toggle will work.
Otherwise, an alert is shown giving the user required information to enable notifications.
2021-02-02 11:54:47 +08:00
Stuart Breckenridge
62ed7492eb
Adds checkmarks
...
Also adds notification to keep Inspector in sync.
2021-02-02 10:26:34 +08:00
