Commit Graph

281 Commits

Author SHA1 Message Date
Martin Hartl 5ee491ebee Replace “Mark Older as Read” actions with “Mark Above/Below as Read” actions 2020-01-03 09:00:25 +01:00
Maurice Parker e26a00ddfe Enable pull to refresh on timeline and change refresh indicator to better show when it is successfully pulled. Issue #1520 2020-01-02 21:08:21 -07:00
Brent Simmons 26bb2b8eaf Remove references to Article.bannerImageURL. We can bring it back if/when we start using it. 2019-12-28 20:53:36 -08:00
Maurice Parker 61370dd04d Fix so that we don't try to scroll before the datasource has been fully applied to the table. Issue #1463 2019-12-24 17:34:47 -07:00
Brent Simmons 15184aa3f1 Finish changes mandated by DatabaseQueue changes. 2019-12-16 22:45:59 -08:00
Maurice Parker 43bf65b7a6 Rename occurrences of completionHandler to completion. 2019-12-14 17:14:55 -07:00
Maurice Parker 7a6b818f57 Only reset the timeline under certain conditions. Issue #1422 2019-12-08 18:14:33 -07:00
Brent Simmons ebd7c68396 Merge mac-release — remove attachments. 2019-12-04 22:36:08 -08:00
Brent Simmons 3ead2c63bc Remove attachments from the app, since we’re not using attachments in any way. We could always add it back later. 2019-12-03 23:03:15 -08:00
Maurice Parker 81c4756f97 Persist article read filters across application launches. Issue #1349 2019-11-27 11:43:36 -06:00
Maurice Parker 5c4cd072ce Make next unread button work with new async feed functionality. 2019-11-24 13:37:56 -06:00
Maurice Parker a052bbe74e Fix title flashing in after navigation bar is shown. Issue #1336 2019-11-24 10:47:09 -06:00
Maurice Parker b5525e1a9e Restore back button items. Issue #1337 2019-11-24 10:33:13 -06:00
Maurice Parker 00094858fa Remove filter button from All Unread timeline. 2019-11-24 03:47:29 -06:00
Maurice Parker 4296c243ff Implement custom previews for context menus to crop cell separators. Issue #1221 2019-11-23 22:15:29 -06:00
Maurice Parker d8b324e3da Change nav bar so that if it is hidden and animating itself showing, you don't see the navbar items moving into place. 2019-11-23 18:00:51 -06:00
Maurice Parker dd7431d5cb Remove obsolete code. 2019-11-22 15:23:21 -06:00
Maurice Parker eea5d6f327 Change ReadFilter to ReadFilterType and differentiate the ReadFilter from the query filter. 2019-11-22 09:40:39 -06:00
Maurice Parker a5b4d570af Change ReadFilter case unavailable to alwaysRead 2019-11-22 09:32:27 -06:00
Maurice Parker 654f40a98e Add always on unread "filter" to Unread. 2019-11-21 20:31:58 -06:00
Maurice Parker 2d210a3f17 Delete dead code 2019-11-21 20:12:31 -06:00
Maurice Parker 6d8fca01ea Filter async requests based on ReadFilter. 2019-11-21 19:54:35 -06:00
Maurice Parker e8826130a4 Add timeline filter button 2019-11-21 18:22:43 -06:00
Maurice Parker d1af8a9f0a Increase height of timeline unread indicator. Issue #1320 2019-11-19 18:58:18 -06:00
Maurice Parker 985cef6b49 Remove title from timeline back button. Issue #1319 2019-11-19 18:16:03 -06:00
Maurice Parker 189995e6c7 Remove title from article back button. Issue #1318 2019-11-19 18:03:19 -06:00
Maurice Parker bdf9add8f1 Populate timeline asynchronously and restore timeline after search. Issues #1307 & #1308 2019-11-19 11:16:43 -06:00
Maurice Parker fc235a029e Remove toolbar autohiding and add optional fullscreen mode. 2019-11-18 19:12:24 -06:00
Maurice Parker 397d8e8ffa Update picker for Share Extension to be hierarchical and use icons. Issue #1269 2019-11-16 19:44:01 -06:00
Maurice Parker 5283d2efbe Implement Feed protocol. 2019-11-15 06:19:14 -06:00
Maurice Parker 06bd5b3a6f Renamed Feed and related classes/instances to WebFeed 2019-11-14 20:11:41 -06:00
Maurice Parker 0c33f6c496 Animate disclosing the feed when using Go to Feed. 2019-11-13 15:41:41 -06:00
Maurice Parker 38535910ef Change Select Feed to Go to Feed. Issue #1240 2019-11-13 15:22:22 -06:00
Maurice Parker 315ac3ee12 Remove code that wasn't actually hiding the search bar 2019-11-13 09:36:05 -06:00
Maurice Parker d8b1b6c236 Stop adjusting the scroll position on every appearance. 2019-11-11 20:45:14 -06:00
Maurice Parker 766cd2f868 Save and restore scroll position when transitioning between three column mode and normal. Issue #1242 2019-11-11 16:59:42 -06:00
Maurice Parker 0df4498fa3 Add customize timeline layout setting 2019-11-08 17:16:09 -06:00
Maurice Parker 560f36621f Add IconImage to encapsulate our icon processing logic 2019-11-05 18:05:57 -06:00
Maurice Parker 292e3789f4 Remove animation speed setting. Issue #1234 2019-11-04 14:19:13 -06:00
Maurice Parker f138c2d9aa Fix timeline secondary label coloring 2019-11-04 11:47:44 -06:00
Maurice Parker 44533399e6 Fix timeline bug where vibrancy could be lost 2019-11-03 16:34:57 -06:00
Maurice Parker 21d5c321b4 Hide search controller when no items are present. Related to Issue #1195 2019-11-03 08:36:14 -06:00
Brent Simmons bef824b02f Merge branch 'master' of https://github.com/brentsimmons/NetNewsWire 2019-11-02 18:20:06 -07:00
Brent Simmons 1ac3c8fec7 Add just a little padding to timeline cells to help break up the BIG WALL O’ TEXT feeling. 2019-11-02 18:19:57 -07:00
Maurice Parker 3f46c0e939 Make unread indicator animatable 2019-11-02 20:15:48 -05:00
Maurice Parker 8fb87a7c87 Update label animations to match cell selection fading and changed table animation speeds to 1.5. Issue #1237 2019-11-02 19:57:01 -05:00
Maurice Parker 6a0c5ac31b Fix issue where search bar sometimes wouldn't appear. 2019-11-02 11:49:44 -05:00
Maurice Parker b78b996e88 Animate Select Feed context menu result. Issue #1220 2019-10-31 20:55:08 -05:00
Maurice Parker 51acc5972f Prevent the search bar from appearing on rotation. Issue #1171 2019-10-30 16:08:03 -05:00
Maurice Parker d63a743550 Rename MasterTimelineAvatarView to AvatarView 2019-10-29 19:23:29 -05:00
Maurice Parker 46cd259110 Use feed icon when available for timeline title image 2019-10-28 21:33:13 -05:00
Maurice Parker cee1d5dc4d Rollback change that caused the search to not appear. Issue #1199 2019-10-28 21:12:09 -05:00
Maurice Parker 66b6d43408 Update Feeds to use higher resolution images when available. Issue #1208 2019-10-28 20:57:26 -05:00
Maurice Parker 55b9310f9c Move avatar property setting to class 2019-10-28 20:01:15 -05:00
Brent Simmons d1987c650e Roll back the timeline background color change. Remove the white accent view. 2019-10-26 11:09:34 -07:00
Maurice Parker e1a571fab3 Remove separator accent when switching to darkmode 2019-10-25 15:56:09 -05:00
Maurice Parker 21aaf71cbf Update timeline theme. Issue #1169 2019-10-25 15:52:32 -05:00
Maurice Parker cf7ea99cb6 Delete timeline unread count animation. Issue #1174 2019-10-25 15:03:13 -05:00
Maurice Parker 6a281c7672 Replace Mark All as Read with progress indicator. Issues #1157 and #1165 2019-10-25 13:34:59 -05:00
Maurice Parker 3f81cd9b96 Make sure that the search bar doesn't appear on device rotation. Issue #1171 2019-10-24 12:46:53 -05:00
Maurice Parker 2e489d4093 Rollback timeline unread and star animations 2019-10-23 11:08:34 -05:00
Maurice Parker be52fde08b Change Timeline Feed icon to 32x32 2019-10-23 09:15:13 -05:00
Maurice Parker 7b51a272b0 Only clear Feed/Timeline selection after view begins to appear. Issue #1156 2019-10-22 19:20:35 -05:00
Maurice Parker 528284999f Correct vibrancy configuration for Settings 2019-10-22 03:31:25 -05:00
Maurice Parker d9a165151d Rename to VibrantTableViewCell 2019-10-22 02:35:47 -05:00
Maurice Parker 00f100e3a3 Renamed TimelineStringFormatter to ArticleStringFormatter now that it is used for much more than the timelines 2019-10-20 02:28:00 -05:00
Maurice Parker 3faa9d7cde Animate timeline star and unread indicators 2019-10-15 20:59:42 -05:00
Maurice Parker 8656753423 Rename MarkArticlesReadAlertController to UndoAvailableAlertController to better reflect its new purpose 2019-10-10 15:13:20 -05:00
Maurice Parker 7e30bba16a Fix next unread and first unread timeline animations 2019-10-09 21:39:11 -05:00
Maurice Parker ba8d1dfa83 Convert parameter usages of automated to animated 2019-10-09 21:24:56 -05:00
Maurice Parker d5031b0c1e Prevent timeline title animation on load 2019-10-08 09:19:50 -05:00
Phil Viso 93ab639509 Updated modal copy. Copy update removed the need for separate versions of the modal. 2019-10-07 21:13:00 -05:00
Phil Viso b963d97922 Show an alert the first time mark all as read is tapped 2019-10-07 19:48:58 -05:00
Phil Viso 461c681a9d Added a flag to suppress mark all as read warning alert 2019-10-07 19:33:30 -05:00
Maurice Parker 9a4d915e0b Move read toggle to be swipe-right on timeline 2019-10-03 15:55:16 -05:00
Maurice Parker f4d58bd7a7 Animate the timeline unread count indicator 2019-10-01 09:49:07 -05:00
Maurice Parker 77ba42f102 Add unread count to the timeline 2019-09-30 20:01:02 -05:00
Maurice Parker bacff92434 Make timeline favicon have a background in darkmode when the favicon is too dark 2019-09-30 02:54:19 -05:00
Maurice Parker 1f26a91af9 Prevent scrolling while reloading cells Issue #1085 2019-09-29 15:53:50 -05:00
Maurice Parker c51f5f44e0 Add eclipses to truncated timeline text. Issue #1072 2019-09-29 14:07:33 -05:00
Maurice Parker 5dfb4f6488 Fix off center timeline titles 2019-09-27 20:21:46 -05:00
Maurice Parker f3a939b49d Fix dark mode timeline titles 2019-09-27 20:04:49 -05:00
Maurice Parker ca4a7f8b0b Add Feed Inspector 2019-09-27 19:45:09 -05:00
Maurice Parker 9c8f5b7d65 Remove chevrons from timeline. Issue #1067 2019-09-26 20:01:13 -05:00
Maurice Parker f24799f16a Slightly round the inner image for avatars 2019-09-26 15:50:05 -05:00
Maurice Parker 4e239a44e1 Reload the title view icon again after it becomes available 2019-09-23 20:53:09 -05:00
Maurice Parker 3cd33902cf Add small icon to timeline title view 2019-09-21 17:59:58 -05:00
Maurice Parker 6f962ecb42 Fix avatar background composition 2019-09-19 13:41:07 -05:00
Maurice Parker 0fcbcb50e0 Change unread indicator to use secondary accent color 2019-09-18 09:56:10 -05:00
Maurice Parker 8b732e5353 Switch from drawing clear color to drawing background color to reset reused avatar views 2019-09-18 09:47:58 -05:00
Maurice Parker 36f4366e70 Use correct icons on timeline swipe for unread and starred 2019-09-18 02:57:32 -05:00
Maurice Parker db2ee18299 Unify the colori scheme into primary and secondary accent colors 2019-09-18 02:49:57 -05:00
Maurice Parker 372fb06716 Implement different icons for each individual smartfeed 2019-09-17 20:26:49 -05:00
Maurice Parker 73b7436c62 Remove old flush cache code 2019-09-17 17:11:47 -05:00
Maurice Parker fe3fa220bb Port TimelineAvatarView to iOS 2019-09-17 17:00:23 -05:00
Maurice Parker 31b506b85a Work around SwiftUI on bugs on iPadOS so that we can add accounts on the iPad 2019-09-11 20:50:03 -05:00
Maurice Parker 856006a19f Fixed timeline loading bug for portrait on the iPad 2019-09-11 10:41:48 -05:00
Maurice Parker 8545252265 Remove the usage of IndexPaths for the interface between the coordinator and the timeline 2019-09-11 09:11:33 -05:00
Maurice Parker 8076cac266 Convert timeline to use the diffable datasource to lookup articles instead of the coordinator's article table 2019-09-10 20:32:03 -05:00
Maurice Parker 411413d783 Remove unnecessary selection that was causing the search function to crash 2019-09-10 16:18:40 -05:00
Maurice Parker bceccd76b5 Restore the timeline selection lost while transitioning to three panel mode 2019-09-10 08:06:43 -05:00
Maurice Parker 8b901819a6 Make table views scroll even if the root split is collapsed 2019-09-08 08:30:08 -05:00
Maurice Parker 7d8a0234b6 changed to queue a reload of all visible cells when a favicon comes in 2019-09-06 17:22:12 -05:00
Maurice Parker a6f6462afd Make arrow key scrolling work like it does on the Mac timeline 2019-09-06 13:45:45 -05:00
Maurice Parker c8b5b10edd Check if the split is collapsed to see if we are maintaining the selection 2019-09-06 11:22:35 -05:00
Maurice Parker aa7c60ee3a Prevent row selection on iPhone as keeping selected rows highlighted is an iPad only feature 2019-09-06 11:11:28 -05:00
Maurice Parker d0570d16a8 Prevent attempt to restore article selection when there are no articles 2019-09-06 10:38:02 -05:00
Maurice Parker 9f6203e839 Improve launch performance and fix Search home page quick action 2019-09-06 10:29:00 -05:00
Maurice Parker 73828e5115 Remove the coordinator dependency from KeyboadManager as it wasn't needed 2019-09-05 14:37:07 -05:00
Maurice Parker 7a452e2a3c Add keyboard arrow key navigation 2019-09-04 21:06:29 -05:00
Maurice Parker 68143aa2c5 Implement keyboard shortcut infrastructure and first shortcuts 2019-09-04 16:24:16 -05:00
Maurice Parker 17a5d291f4 Remove become and resign first responder code in Feeds and Timeline 2019-09-03 20:39:00 -05:00
Maurice Parker 640faaa114 Simplify the article replacement logic 2019-09-03 16:07:02 -05:00
Maurice Parker b7ba2c809c Use better function for looking up article index 2019-09-03 13:43:59 -05:00
Jim Correia 061872b7ff Simplified/corrected highlighted/selected appearance of feed and timeline cells.
- Set the highlighted text color on labels in table cells. This will be used
  for both the highlight and selected states automatically. (And since it is
  used for both states, we avoid anachronistic state where we have black
  text on a dark blue background in light mode as we transition from none ->
  highlighted -> selected.)

- Keep the selected/highlighted overrides to adjust colors for non-UIControl
  subelements.
2019-09-02 22:39:01 -07:00
Jim Correia 932f6fdd30 Added NNWTableViewCell; a base class for cells with the NNW selection color.
Defined a semantic color for the selection color which is identical to
netNewsWireBlue.

MasterFeedTableViewCell and MasterTimelineTableViewCell now subclass
NNWTableViewCell and no longer directly customize their selected background
view.
2019-09-02 22:38:42 -07:00
Maurice Parker b768877e23 Use correct delegate methods to begin and end searching 2019-09-02 12:40:14 -05:00
Maurice Parker 746c06d147 Prevent automated scrolling when selecting an article in the timeline 2019-09-02 12:05:11 -05:00
Maurice Parker c405fdf583 Implement search home page quick action 2019-09-01 17:41:46 -05:00
Maurice Parker dfc3046bf0 Clear the timeline when the user begins searching 2019-09-01 14:49:56 -05:00
Maurice Parker 858bdb7f21 Rename AppCoordinator to SceneCoordinator as that name better defines its purpose 2019-09-01 12:43:07 -05:00
Maurice Parker c9858a0457 Show and hide scope bar based on editing state 2019-08-31 16:39:59 -05:00
Maurice Parker fe2e0155da Add scoped searching of articles 2019-08-31 15:53:47 -05:00
Maurice Parker d9ce01591f Implement full article search 2019-08-31 11:50:34 -05:00
Maurice Parker ca0bdb3d35 Change to not animate on timeline fetcher changes 2019-08-30 14:42:33 -05:00
Maurice Parker 07ca61f7cf Convert the timeline to use diffable datasources 2019-08-30 14:17:05 -05:00
Maurice Parker 3ab1412dc6 Preserve article selection when articles are downloaded (for iPad only) 2019-08-30 02:39:54 -05:00
Maurice Parker 86a302f787 Prevent selecting of items that may not show the current article selection as is done on the iPhone 2019-08-29 17:49:21 -05:00
Maurice Parker 8e583c2fad Prevent scrolling when reloading and reselecting a cell. 2019-08-29 14:04:15 -05:00
Maurice Parker 379ba49fd5 Fix select position getting lost on refreshes 2019-08-29 11:53:36 -05:00
Maurice Parker d7c90106d1 Change to directly modify the avatar image instead of calling reload on the cells 2019-08-26 15:37:15 -05:00
Maurice Parker 0b48c3893d Change AppCoordinator to directly call controller API's since that matches the Coordinator pattern better than sending them notifications 2019-08-25 11:38:04 -05:00
Maurice Parker 5b1c0485c5 Add NSUserActivity for reading articles 2019-08-24 14:57:51 -05:00
Maurice Parker c752d0b699 Optimize table cell loading so that we are no longer reloading all visible cells when an image is downloaded 2019-08-21 19:37:19 -05:00
Maurice Parker 71343b9e72 Add Share context menu for timeline 2019-08-19 18:09:38 -05:00
Maurice Parker badc2d3e25 Add open in browser context menu item 2019-08-19 17:38:30 -05:00
Maurice Parker de7970314d Add mark all as read for feed functionality 2019-08-19 17:26:09 -05:00
Maurice Parker 40a80356f1 Move business logic out of controller into coordinator where we typically keep it 2019-08-19 16:03:07 -05:00
Maurice Parker 6087951824 Remove context menu titles as they didn't provide any additional context 2019-08-19 15:49:42 -05:00
Maurice Parker 3245223b24 Add Select Feed context menu 2019-08-19 15:45:52 -05:00
Maurice Parker eeebb30467 Implement Mark Older as Read for timeline 2019-08-18 17:34:53 -05:00
Maurice Parker aabe950b2b Add initial support for timeline context menus 2019-08-16 13:19:06 -05:00
Maurice Parker e39972bd64 Correct First Unread button to select the first unread in the timeline and show article in detail view. Issue #695 2019-08-03 17:07:43 -05:00
Maurice Parker 02575c31fe Change selected table row text to be white. Issue #693 2019-08-03 16:25:35 -05:00
Maurice Parker 54f6607621 Keep table selections when root split isn't collapsed 2019-08-02 10:25:47 -05:00
Maurice Parker adb6309872 In Three Pane Mode only show the progress indicator on the Feeds controller 2019-07-27 14:49:07 -05:00
Maurice Parker cf674d67b1 Show no selection when timeline is selected in Three Panel Mode 2019-07-27 14:36:01 -05:00
Maurice Parker b25e789aef Prevent refresh errors from keeping the refreshControl visible when error dialogs are displayed. 2019-07-18 15:16:54 -05:00
Maurice Parker 8b6e2fa517 Move more logic out of MasterTimelineViewController and into AppCoordinator 2019-07-06 12:31:07 -05:00
Maurice Parker 4884aebbfd Encapsulate more of the AppCoordinate API 2019-07-06 11:32:19 -05:00