Commit Graph

340 Commits

Author SHA1 Message Date
Maurice Parker 9240c8e8a9 Add space between section header and feed url, since macOS doesn't add it like it should 2020-07-18 20:22:41 -05:00
Maurice Parker 68f4ea88c9 Hide home url section if one isn't available 2020-07-18 20:18:57 -05:00
Maurice Parker 86a38edabd
Merge pull request #2283 from stuartbreckenridge/hotfix/inspector-tweaks
Inspector tweaks
2020-07-18 19:57:18 -05:00
Maurice Parker 8cbc18c45e Refactor TimelineModel to use Combine more fully 2020-07-18 19:56:30 -05:00
Stuart Breckenridge 03c60a2979
Adds default cancel keyboard shortcut 2020-07-19 08:25:26 +08:00
Stuart Breckenridge 526a98f326
Switches to AppAssets 2020-07-19 08:12:20 +08:00
Stuart Breckenridge 4d227e7e2c
Inspector tweaks
- [x] Account Inspector should have an Active toggle (see iOS)
 - [x] Feed Inspector Home Page should open the link in browser when tapped
- [x] Feed Inspector Home Page should have a browser icon (see iOS)
- [x] Feed Inspector Home Page URL should line wrap
- [x] Feed Inspector Feed URL should be copiable (currently this is a long press on iOS)
- [x] Feed Inspector Feed URL should line wrap
- [x] Inspector should use inset style on iOS
2020-07-19 07:57:25 +08:00
Maurice Parker 9732ca10f3 Made Sidebar Combine correct 2020-07-18 17:10:45 -05:00
Maurice Parker d36870028a Refactor Combine code to make it more readable 2020-07-18 16:53:30 -05:00
Maurice Parker 271f7433d4 Use a table to look up TimelineItem position instead of spinning through the TimelineItems 2020-07-18 16:36:20 -05:00
Maurice Parker 3899fe7fd9 Use the fetch filter option to speed up timeline rendering 2020-07-18 16:12:10 -05:00
Maurice Parker 6a33060473 Fix sidebar rename bug 2020-07-18 15:24:48 -05:00
Maurice Parker 876f978347 Standardize notification handling on Combine instead of selectors 2020-07-18 15:20:15 -05:00
Maurice Parker 5845925b3a
Merge pull request #2278 from stuartbreckenridge/feature/feed-inspector
Notifications/Reader View/InspectorModel
2020-07-18 10:57:22 -05:00
Stuart Breckenridge 5fb44a30ea
actually updates readerview value 2020-07-18 21:46:39 +08:00
Stuart Breckenridge 5a7c3111ce
Removes rename 2020-07-18 21:24:06 +08:00
Stuart Breckenridge 0e2b8fd514
Adds `InspectorModel`
`InspectorModel` covers previous management of notifications, reader view, and name changes.
2020-07-18 21:21:59 +08:00
Stuart Breckenridge dece406f56
Confirm changed to Done 2020-07-18 19:31:56 +08:00
Maurice Parker 1a46167355
Merge pull request #2277 from stuartbreckenridge/feature/feed-inspector
Update InspectorView.swift
2020-07-18 05:24:20 -05:00
Stuart Breckenridge f525081f6e
Update InspectorView.swift 2020-07-18 18:23:07 +08:00
Maurice Parker 69c92e795b
Merge pull request #2276 from stuartbreckenridge/feature/feed-inspector
Inspector Views
2020-07-18 05:00:15 -05:00
Maurice Parker e391b29353 Implement the Mark All as Read button 2020-07-18 04:58:46 -05:00
Maurice Parker 40e0a1b676 Launch with correct views instead of using placeholder text views 2020-07-18 04:35:44 -05:00
Stuart Breckenridge 8f8afb5dbb
Inspector View
Inspector Views for macOS and iOS
2020-07-18 17:34:04 +08:00
Maurice Parker be60b112d0 Remove computed properties from TimelineItem 2020-07-17 20:55:18 -05:00
Maurice Parker 2a4a13ed13 Implement mark all as read in feed context menu for timeline 2020-07-17 20:29:53 -05:00
Maurice Parker 644e9da1c0 Implement open in browser timeline context menu item. 2020-07-17 20:08:49 -05:00
Maurice Parker a102b9f63d Add marking starred and read context menu items to Timeline 2020-07-17 19:46:05 -05:00
Maurice Parker 538d886bf4 Correct about/below mark as read to take into account multiple select 2020-07-17 18:15:42 -05:00
Maurice Parker 11bd3dce22 Change sidebar context menu to use trailing closure syntax 2020-07-17 18:05:26 -05:00
Maurice Parker 067041195d Implement Mark Above and Mark Below context menu items. 2020-07-17 17:59:35 -05:00
Maurice Parker 37a84395fe Add in missing file 2020-07-17 17:34:11 -05:00
Maurice Parker 048da0bf79 Separate the sidebar context menu into a standalone different file 2020-07-17 17:27:08 -05:00
Maurice Parker 78fdf0a0d0 Enable open in browser toolbar button. 2020-07-17 17:08:08 -05:00
Maurice Parker 74b878fa6f Disable safari and share toolbar buttons when no articles are selected 2020-07-17 13:55:54 -05:00
Stuart Breckenridge 19d4afc467
On macOS, just change the colorScheme 2020-07-17 22:33:38 +08:00
Stuart Breckenridge b739f6dd61
Improves behaviour of dark/light changes on iOS 2020-07-17 22:18:10 +08:00
Maurice Parker 8f7b8160a1 Make Timeline text layout like current apps 2020-07-16 19:36:20 -05:00
Maurice Parker cdf8ad1277 Remove web provider queue flush on multiplatform 2020-07-16 13:44:19 -05:00
Maurice Parker 2b0f6f4e77 Deselect articles when switching selected feeds 2020-07-16 12:27:40 -05:00
Maurice Parker e5bf13edca Tweak API to stop web view controller rebuiding 2020-07-16 11:51:33 -05:00
Maurice Parker 364bcf9d4d Implement new ArticleView API for iOS 2020-07-16 11:42:07 -05:00
Maurice Parker 5f573fc985 Make article rendering stop flashing! 2020-07-16 11:14:05 -05:00
Maurice Parker 9836fb781c Rename variable to make its intent clear 2020-07-16 10:53:54 -05:00
Maurice Parker 92f6ee3f42 Coalesce refresh progress updates 2020-07-15 21:32:56 -05:00
Maurice Parker 46762bf297 Implement refresh progress bar for macOS 2020-07-15 21:24:22 -05:00
Maurice Parker 69fa598d99 Enable refresh button on macOS 2020-07-15 20:09:11 -05:00
Maurice Parker e34dbd48ee Move error handling to SceneNavigationView 2020-07-15 20:06:29 -05:00
Maurice Parker cf233f4825
Merge pull request #2259 from stuartbreckenridge/feature/mac-preferences
Mac Preferences
2020-07-15 19:16:19 -05:00
Maurice Parker 30d1f77405 Implement pull to refresh on iOS 2020-07-15 16:52:57 -05:00
Maurice Parker 2b84469fb4 Refactored refresh progress so that it doesn't crash on the mac anymore 2020-07-15 15:32:04 -05:00
Maurice Parker f32b0bfdc3 Change to use a view instead of a function for the navigation wrapper 2020-07-15 15:25:41 -05:00
Maurice Parker 367bd90ec9 Fix refresh progress compile error 2020-07-15 13:43:24 -05:00
Maurice Parker deee6c13f5 Remove progress indicator and next unread from timeline until we can properly show and hide them. 2020-07-15 13:00:38 -05:00
Maurice Parker c8077ad214 Separated refresh progress model from SceneModel again 2020-07-15 12:56:19 -05:00
Stuart Breckenridge 0904ff519f
moves preferredColorScheme to App level. 2020-07-15 11:16:16 +08:00
Maurice Parker 31068f90a0 Implement macOS share button 2020-07-14 17:10:53 -05:00
Maurice Parker e6bd17f8f9 Remove commented code 2020-07-14 13:53:23 -05:00
Stuart Breckenridge 4982211e27
WiP on Edit Accounts and ColorScheme 2020-07-14 14:57:55 +08:00
Maurice Parker dc023e681b Implement share/activity button on iOS 2020-07-13 20:18:39 -05:00
Maurice Parker da08219ca3 Add more button state and standardize button syntax 2020-07-13 17:24:40 -05:00
Maurice Parker 7643ddc173 Remove specific button state enums as they were overkill 2020-07-13 16:26:53 -05:00
Maurice Parker 4bb88363e7 Change to only resort when sort parameters change 2020-07-13 16:06:42 -05:00
Maurice Parker ffa579446e Only add section header padding for macOS 2020-07-13 12:00:59 -05:00
Maurice Parker b79a1aef0c Put in the padding that Apple left off of the section headers 2020-07-13 11:58:44 -05:00
Maurice Parker 543048b981 Add context menu divider to match existing macOS design 2020-07-13 11:43:27 -05:00
Maurice Parker c29960ddda Clean up navigation handling for the timeline 2020-07-13 11:37:21 -05:00
Maurice Parker 17e1247ff0 Add sort control for macOS 2020-07-12 19:43:25 -05:00
Maurice Parker 3a67f2cd8e Change navigation title for macOS so that it shows the Feed 2020-07-12 17:45:38 -05:00
Maurice Parker 809e6542e0 Fix bug in unfiltering a filtered timeline 2020-07-12 17:30:35 -05:00
Maurice Parker d7a4bddc72 Make timeline filter maintain it state for each timeline individually 2020-07-12 16:48:39 -05:00
Maurice Parker 2ebec7801c Fix read filter accessibility labels (help) 2020-07-12 15:03:43 -05:00
Maurice Parker 6c236fc0e3 Implement Timeline read filter 2020-07-12 14:43:52 -05:00
Maurice Parker 22e2c0b0e6 Add sidebar read filter 2020-07-12 10:52:42 -05:00
Maurice Parker 9f4a037c8f Rebuild sidebar items when the unread count changes 2020-07-12 09:54:39 -05:00
Stuart Breckenridge 31b93c5d13
small refactoring 2020-07-12 14:07:52 +08:00
Maurice Parker 2eb20c86af Refactor timeline code to be more clear 2020-07-11 20:11:01 -05:00
Maurice Parker 6891f76241 Fix smart feed feed lookup 2020-07-11 19:56:42 -05:00
Maurice Parker 7998b5450b Enabled toolbar buttons for read and star 2020-07-11 19:52:28 -05:00
Maurice Parker 92ac91d9d5 Delete dead code 2020-07-11 18:47:44 -05:00
Maurice Parker 184ef57576 Implement Timeline multiselect 2020-07-11 18:22:47 -05:00
Maurice Parker cf79d3f508 Merge branch 'master' of https://github.com/Ranchero-Software/NetNewsWire 2020-07-11 12:48:58 -05:00
Maurice Parker 360f7a07bf Implement Sidebar multiselect for macOS 2020-07-11 12:47:13 -05:00
Stuart Breckenridge 61c42171c7
2237
Fixes #2237 accent colours on web feeds.
2020-07-12 00:07:37 +08:00
Maurice Parker 20d989f1b8
Revert "Widget Work in Progress" 2020-07-11 09:48:34 -05:00
Maurice Parker 3eda1de825
Merge pull request #2249 from stuartbreckenridge/feature/widget
Widget Work in Progress
2020-07-11 09:36:50 -05:00
Stuart Breckenridge c3d4834879
Moves to monitoring changes in scene phase 2020-07-11 21:02:46 +08:00
Stuart Breckenridge 9991b3760e
Removes print statements and reorgs code 2020-07-11 20:22:21 +08:00
Stuart Breckenridge 1cc5f3cc30
Widget Updates
• Can now read data written by main app
• Has preview capability in widget gallery
• Still to solve using ORGANIZATION_IDENTIFIER
2020-07-11 17:01:09 +08:00
Maurice Parker 2f99cd01c1 Fix the width of the indicator so that it would stop reflowing the cell when changed to star 2020-07-10 10:13:18 -05:00
Stuart Breckenridge a45ba35b24
Initial widget work
• Latest data is saved out to JSON at various points.
• Technote on widget usage.
• Widget target added.
2020-07-10 23:10:12 +08:00
Maurice Parker bf8a52d710 Update the timeline with status changes 2020-07-09 20:10:52 -05:00
Maurice Parker 2d57945e98 Implement Read and Star button functionality 2020-07-09 18:44:51 -05:00
Maurice Parker 3e61c7044b Stub out mark as read and star functionality 2020-07-09 16:34:47 -05:00
Alex Faber 5b50e8cdd2 OPT: Cleanup Add Folder view on Mac, change SceneNavigationView to support multiple sheet types. 2020-07-09 21:09:50 +02:00
Maurice Parker aa4d191d1d Fixed Article Toolbar item placement on iPad 2020-07-09 09:57:39 -05:00
Maurice Parker 91f2479b96
Merge pull request #2234 from stuartbreckenridge/fix/2193
Fix 2193
2020-07-09 08:10:42 -05:00
Maurice Parker 897474a637 Fixed the font for macOS article view 2020-07-09 07:47:47 -05:00
Stuart Breckenridge 771fe21422
Tidy up 2020-07-09 17:36:17 +08:00
Stuart Breckenridge f4deab1361
Updates title to match current app 2020-07-09 17:04:04 +08:00
Stuart Breckenridge 9830a977a0 Add Web Feed Colours
Icons in the picker now use accent colour.
2020-07-09 16:58:04 +08:00
Maurice Parker f5855f032d Revert to a less obnoxious status bar color 2020-07-08 22:43:16 -05:00
Maurice Parker 107a8fd550 Implement macOS web view mouse over events 2020-07-08 22:27:59 -05:00
Maurice Parker 5abf222c8a Merge branch 'swiftui' of https://github.com/Ranchero-Software/NetNewsWire into swiftui 2020-07-08 20:13:08 -05:00
Maurice Parker 5583b21616
Merge pull request #2232 from stuartbreckenridge/swiftui
Multi-selection on macOS #2164
2020-07-08 20:12:23 -05:00
Stuart Breckenridge 4c11667ff7
Moves selection to SidebarModel 2020-07-09 07:15:47 +08:00
Maurice Parker a87a692d7e Fix class file name misspelling 2020-07-08 17:50:18 -05:00
Maurice Parker 79691a1988 Add reader view icon to macOS toolbar 2020-07-08 17:34:35 -05:00
Maurice Parker 0e3ee19e3a Made Article View match system accent color 2020-07-08 17:26:53 -05:00
Maurice Parker 2ab82d5680 Make timeline unread indicator use the control accent color on macOS 2020-07-08 16:22:15 -05:00
Maurice Parker 739c14fb99 Don't remove from queue until completion handler is called 2020-07-08 16:00:48 -05:00
Maurice Parker 3f036e91d3 Do not remove the view from the queue until it has navigated 2020-07-08 13:44:13 -05:00
Maurice Parker f138908e43 Complete dequeue even if web view fails to initialize 2020-07-08 13:39:44 -05:00
Maurice Parker cdb43404c5 Removed obsolete javascript setting 2020-07-08 10:48:05 -05:00
Maurice Parker c1bf903bff Suppress macOS menu items we don't want to show the user 2020-07-08 10:24:16 -05:00
Maurice Parker 6f055b5923 Implement ArticleView for macOS 2020-07-08 10:20:04 -05:00
Stuart Breckenridge 91bc4a0c30
fixes iOS build 2020-07-08 22:04:26 +08:00
Stuart Breckenridge ab0fbc99c3
Merge branch 'multi-select' into swiftui 2020-07-08 21:41:59 +08:00
Stuart Breckenridge 18f7d82f7a
white space removal 2020-07-08 21:40:09 +08:00
Stuart Breckenridge af4849642c
Adds multi-select to macOS sidebar
This hacks around property observers to get to a model that almost works.
2020-07-08 21:39:39 +08:00
Maurice Parker 909dcb3f93 Made ArticleExtractorButtonState a shared enum 2020-07-08 02:27:16 -05:00
Maurice Parker 59c3015fff Made web view preloading code and scheme handler shared code 2020-07-07 19:31:24 -05:00
Maurice Parker 900766d780 Remove icons from macOS context menus since they aren't supported 2020-07-07 17:02:17 -05:00
Maurice Parker 8064e65e68 Move Mac toolbar to SceneNavigationView so that it operates properly. Issue #2217 2020-07-07 16:05:26 -05:00
Maurice Parker 2e94ae9e8e Add basic support for Article view on iOS 2020-07-06 21:14:05 -05:00
Maurice Parker 43ea26ddc2 Standardize Asset Catalog case part 2 2020-07-06 16:50:48 -05:00
Maurice Parker c829478aa6 Standardize Asset Catalog case part 1 2020-07-06 16:49:58 -05:00
Maurice Parker 06a1a5f28b Merge branch 'pr/2218' into swiftui 2020-07-06 16:39:36 -05:00
Maurice Parker e5ad208730 Fix iOS background colors 2020-07-06 16:14:43 -05:00
Maurice Parker fcf0c1ad1c Implement Settings About Section. Issue #2174 2020-07-06 15:30:32 -05:00
Stuart Breckenridge d8df24e997 removes reference to old appSettings var 2020-07-06 20:18:50 +08:00
Stuart Breckenridge 10924caf7f Fixes #2171
Slider is now used in lieu of a stepper. To do that, `timelineIconDimensions` had to be changed from an `Int` to a `Double`.
2020-07-06 17:54:11 +08:00
Maurice Parker 958de0c0d9 Remove VisualEffectBlur and split ArticleView into target specific files 2020-07-06 01:44:35 -05:00
Maurice Parker 6695fcfca7 Refactor sidebar styling to remove duplicate code 2020-07-06 01:32:43 -05:00
Maurice Parker bcbb38c120 Change to initialize Refresh when the onAppear event happens so that we quit crashing on macOS 2020-07-05 19:49:07 -05:00
Maurice Parker aca4cdf4ec fixed asset catalog 2020-07-05 19:36:43 -05:00
Maurice Parker 6c5655191e Implement hack to hide disclosure chevrons 2020-07-05 19:21:23 -05:00
Maurice Parker 9126ec424d Align unread counts on iOS 2020-07-05 19:09:23 -05:00
Maurice Parker 1389008b31 Add Article toolbar 2020-07-05 18:53:18 -05:00
Maurice Parker 5b0c397739 Add filter buttons to navigation bar 2020-07-05 15:11:45 -05:00
Maurice Parker 14601fc96b Change how next unread image is scaled up 2020-07-05 15:01:02 -05:00
Maurice Parker eb8f6e0c03 Refactor the Timeline toolbar to be a modifier like Sidebar's is 2020-07-05 14:52:04 -05:00
Maurice Parker 8b81548457 Rename SidebarToolbar to SidebarToolbarModifer 2020-07-05 14:45:19 -05:00
Maurice Parker 3e2bf6f301
Merge pull request #2213 from stuartbreckenridge/swiftui
Add Feed Folder Picker
2020-07-05 14:23:23 -05:00
Stuart Breckenridge ad4aaf9a19 Add Feed Folder Picker
Fixes #2193:

• Containers with indentation are supported
• Small icon provider is used
• AssetCatalog updated with SF Symbol images for desktop, iPad, iPhone.
• Title page doesn’t work at the current time.
2020-07-05 09:06:53 +08:00
Maurice Parker 49c86bd578 Add Get Info to Sidebar context menu 2020-07-04 14:13:12 -05:00
Maurice Parker 3f7401994d Made Sidebar context menu code simpler 2020-07-04 12:16:21 -05:00
Maurice Parker 5d43635780 Move directly referenced images to AppAssets 2020-07-04 11:57:51 -05:00
Maurice Parker 7cebe7e70f Fixed case for FaviconTemplateImage 2020-07-04 10:32:42 -05:00
Maurice Parker 4cb28cfc20 Fixed Favicon asset name. 2020-07-04 10:24:37 -05:00