Commit Graph

2847 Commits

Author SHA1 Message Date
Maurice Parker
bf572633f8 Enable drag and drop between accounts 2019-09-03 13:27:23 -05:00
Maurice Parker
960f09826b Add separator line to section headers so that they don't look smooshed together when collapsed 2019-09-03 13:00:31 -05:00
Maurice Parker
4bce625f18 Clear search results when no timeline fetcher is specified 2019-09-03 12:25:27 -05:00
Maurice Parker
2a00c879f8 Change to animate search results changes 2019-09-03 12:12:42 -05:00
Maurice Parker
2e71cc573d Cap the possible destination index used during Feed moves 2019-09-03 12:07:18 -05:00
Maurice Parker
d5adbccd5b
Merge pull request #949 from correia/issue-948
Fix for issue #948 — bad highlight state for table cell views in light mode.
2019-09-03 11:56:14 -05:00
Jim Correia
061872b7ff Simplified/corrected highlighted/selected appearance of feed and timeline cells.
- Set the highlighted text color on labels in table cells. This will be used
  for both the highlight and selected states automatically. (And since it is
  used for both states, we avoid anachronistic state where we have black
  text on a dark blue background in light mode as we transition from none ->
  highlighted -> selected.)

- Keep the selected/highlighted overrides to adjust colors for non-UIControl
  subelements.
2019-09-02 22:39:01 -07:00
Jim Correia
932f6fdd30 Added NNWTableViewCell; a base class for cells with the NNW selection color.
Defined a semantic color for the selection color which is identical to
netNewsWireBlue.

MasterFeedTableViewCell and MasterTimelineTableViewCell now subclass
NNWTableViewCell and no longer directly customize their selected background
view.
2019-09-02 22:38:42 -07:00
Maurice Parker
0d6dbb6df3 Fix broken select next where it wasn't going to the next available fetcher in the Feeds scene 2019-09-02 17:28:28 -05:00
Maurice Parker
613cea5c7a Change next unread function so that it skips the current article even if that article is marked as unread 2019-09-02 17:24:20 -05:00
Maurice Parker
fafb7de868 Remove Refresh shortcut item 2019-09-02 16:05:55 -05:00
Maurice Parker
93b702f170 Automatically copy any url in the pasteboard to the feed field for feed adds 2019-09-02 15:54:49 -05:00
Maurice Parker
c5fed06581 Add refresh home screen shortcut. 2019-09-02 15:45:09 -05:00
Maurice Parker
2c4531f481 Add the Add scene as a home page quick action. 2019-09-02 15:14:26 -05:00
Brent Simmons
563b4a8320
Merge pull request #945 from correia/correia-separators
Add optional separators in the timeline view.
2019-09-02 10:44:53 -07:00
Maurice Parker
b768877e23 Use correct delegate methods to begin and end searching 2019-09-02 12:40:14 -05:00
Maurice Parker
746c06d147 Prevent automated scrolling when selecting an article in the timeline 2019-09-02 12:05:11 -05:00
Jim Correia
c8920ca5a6 Added optional separators in the timeline view.
The timeline now optionally includes "Mail style" separators (behind a
hidden default — "CorreiaSeparators" — which defaults to NO).
2019-09-02 09:13:21 -07:00
Maurice Parker
c405fdf583 Implement search home page quick action 2019-09-01 17:41:46 -05:00
Maurice Parker
33882ab276 Add Home Page Quick Actions 2019-09-01 16:54:07 -05:00
Maurice Parker
189af8d816 Invalidate user activities when collapsed and returning to Feeds scene 2019-09-01 15:31:11 -05:00
Maurice Parker
1a9acdcc50 Remove TreeController from Delete command as it is no longer used there 2019-09-01 14:56:27 -05:00
Maurice Parker
dfc3046bf0 Clear the timeline when the user begins searching 2019-09-01 14:49:56 -05:00
Maurice Parker
a5298f0381 Refactor mark as read for articles to be in the SceneCoordinator instead of in the DetailViewController 2019-09-01 12:52:06 -05:00
Maurice Parker
858bdb7f21 Rename AppCoordinator to SceneCoordinator as that name better defines its purpose 2019-09-01 12:43:07 -05:00
Maurice Parker
56c81bba1f Delete code that was doing an unnecessary rebuild of the treeController. This will be done by the controllers receiving the batch update notification. 2019-09-01 10:57:08 -05:00
Maurice Parker
6cf1e4539d Merge branch 'mac-release' 2019-09-01 10:51:22 -05:00
Maurice Parker
8560ce33f4 Merge branch 'mac-release' of https://github.com/brentsimmons/NetNewsWire into mac-release 2019-09-01 10:49:46 -05:00
Maurice Parker
e31dec7c44 Call completion handler when there are no feeds associated with the folder being removed. Issue #938 2019-09-01 10:49:35 -05:00
Maurice Parker
43fb7dff9f Fix bug that prevented new folders from appearing in the Feeds 2019-09-01 10:29:30 -05:00
Maurice Parker
397d75c6f6 Restore animation when adds and deletes happen to feed items 2019-09-01 10:11:03 -05:00
Brent Simmons
30e5f33a29 Remove note in README about NNW not yet shipping. 2019-08-31 22:38:49 -07:00
Brent Simmons
1b26b1ece5
Merge pull request #932 from correia/bug-901
Fix for bug #901 — first web view load flashes white in dark mode
2019-08-31 22:27:31 -07:00
Jim Correia
e7e77d362c Fix for bug #901 — first web view load flashes white in dark mode
The fix used for iOS (keep a queue of preloaded web views) isn't appropriate
for macOS since the first view is used immediately. That approach would
solve the flash of white when first searching, but not the flash of white
when launching the application.

Instead, use a modification of the original solution used for iOS:

    - wrap the web view in a box with an appropriate background color
    - hide the web view at creation
    - show the web view after* the first load

This doesn't suffer the latency problem that the same solution on iOS had
because the first load is always local, "No Selection" HTML.

[*] Showing the view immediately after the first load still causes the flash
    to white. Waiting 0.05 seconds avoids this. That's a fairly terrible hack,
    but I don't have a better solution at present.
2019-08-31 22:14:56 -07:00
Maurice Parker
27883632d0 Fix bug that prevented reading article user activities from being restored 2019-08-31 20:23:14 -05:00
Maurice Parker
87030a5921 Implement stateRestorationActivity to save most relevant current user activity 2019-08-31 19:30:21 -05:00
Maurice Parker
ecec048716 Merge branch 'mac-release' 2019-08-31 18:31:10 -05:00
Maurice Parker
fabea36a91
Merge pull request #930 from correia/bug-921
Only enable "Open in Browser" when a single article is selected.
2019-08-31 18:29:07 -05:00
Jim Correia
cdfdc06142 Only enable "Open in Browser" when a single article is selected.
Fixes bug #921.
2019-08-31 16:02:21 -07:00
Maurice Parker
407bd296db Merge branch 'master' of https://github.com/brentsimmons/NetNewsWire 2019-08-31 17:37:49 -05:00
Maurice Parker
988ac1bbd8 Correct label color to specify correct platform 2019-08-31 17:37:42 -05:00
Maurice Parker
6caff148dd
Merge pull request #928 from correia/placeholder-content
Use noContentHTML rather than noSelectionHTML for prepared web views.
2019-08-31 17:20:52 -05:00
Jim Correia
5f11c42fc2 Use noContentHTML rather than noSelectionHTML for prepared web views.
Added a noContentHTML to ArticleRenderer. Use that for the initial content
for queued web views so that we don't see a temporary flash of "No
Selection" when pushing to an article that doesn't load instantly.
2019-08-31 15:03:03 -07:00
Maurice Parker
c9858a0457 Show and hide scope bar based on editing state 2019-08-31 16:39:59 -05:00
Maurice Parker
fe2e0155da Add scoped searching of articles 2019-08-31 15:53:47 -05:00
Maurice Parker
ba36572497
Merge pull request #927 from correia/correia/webview-layout
Added missing constraints to the web container view in the Detail scene.
2019-08-31 15:27:52 -05:00
Maurice Parker
80a8559823
Merge pull request #926 from correia/correia/limit-webview-queue-size
Limit the size of the queue maintained by DetailViewControllerWebViewProvider.
2019-08-31 15:27:24 -05:00
Jim Correia
77cf92ec13 Added missing constraints to the web container view in the Detail scene. 2019-08-31 13:20:23 -07:00
Jim Correia
52ad2623a8 Limit the size of the queue maintained by DetailViewControllerWebViewProvider. 2019-08-31 13:16:46 -07:00
Maurice Parker
8335a5cb48
Merge pull request #924 from correia/correia/white-flash-on-load
Fix flash on white when loading detail view controller in dark mode
2019-08-31 15:02:20 -05:00