1c06eb27e8
Create separate private extension. Make misc. code formatting changes to match current thinking.
2019-10-23 22:33:21 -07:00
6f29497ec8
Move NSTextFieldDelegate conformance to separate extension.
...
Handle the optional nil case in controlTextDidChange.
2019-10-23 22:27:08 -07:00
c01b2c6269
Merge pull request #1145 from Wevah/add-folder-button-fix
...
Disable "Add Folder" button when the text field is empty
2019-10-23 22:22:12 -07:00
06b0e35739
Move Protocol declaration to top of ExportOPMLAccessoryViewController.swift. As critical API, it needs to be easy to spot.
...
Create separation extensions — one for protocol conformance, one for private methods — ExportOPMLController.
Make minor code formatting change: instead of { return } — which is hard to set a breakpoint on — move the return to its own line.
Remove an internal access qualifier, since internal is default and implied.
2019-10-23 22:00:14 -07:00
77fc1bd8fe
Merge branch 'master' into feature/feed-wrangler
...
# Conflicts:
# submodules/RSCore
2019-10-23 21:10:57 -04:00
4b1a19360c
Use glyphs from SF Symbols for table row swipe actions
...
(Thin font weight.)
2019-10-23 15:05:12 -05:00
8c8ab39b0c
Change the local account icon
2019-10-23 14:21:55 -05:00
8e37881ed8
Protect against unrecognized protocol errors when building for MAC_APP_STORE or TEST.
2019-10-22 19:44:06 -04:00
471c8ce667
Switch to SPUUpdater and establish our own single instance of this updater in the app delegate. If we're building for App Store or a TEST build, don't even initialize Sparkle.
2019-10-22 19:33:00 -04:00
e80a5f92bb
Readd the SUUpdater code
2019-10-22 16:42:17 -05:00
d4816506f2
Disable sparkle for test builds
2019-10-22 16:13:08 -05:00
37e77a9596
Make delegate-less init() fail since a delegate is currently required
2019-10-22 12:14:38 -05:00
e7278017d9
Forgo notifications entirely, and use a delegate instead
2019-10-22 12:14:38 -05:00
a762052264
Don't use block-based notification observing
2019-10-22 12:14:38 -05:00
7e98869080
Use an accessory view instead of an intermediate sheet for OPML export
2019-10-22 12:14:38 -05:00
48fb3ebc18
Curled some quotes
2019-10-22 19:58:05 +09:00
b8e1fb1ab4
Omit the Advanced preferences tab from MAS build.
2019-10-21 18:47:06 -04:00
d5c6ea253e
Fix the sandbox migration script to properly reference NetNewsWire.
2019-10-21 11:16:01 -04:00
272af29031
First step towards supporting MAS and sandboxing. Add new targets for MAS variations of direct-distribution apps. Enable sandboxing in both targets.
2019-10-21 10:22:27 -04:00
00f100e3a3
Renamed TimelineStringFormatter to ArticleStringFormatter now that it is used for much more than the timelines
2019-10-20 02:28:00 -05:00
b5d7ce8e8c
Disable "Add Folder" button when the text field is empty
2019-10-19 12:31:47 -05:00
74b1d56cbf
Merge branch 'mac-release'
2019-10-18 17:38:22 -07:00
a11e900a93
Get the y scroll position in the detail view using window.pageYOffset instead of document.body.scrollTop. It appears the latter may be broken — at any rate, it just returns 0 on Catalina. (On Mojave, use the same method as before, so as not to risk a regression.)
2019-10-18 17:37:56 -07:00
1d45796220
Merge mac-release.
2019-10-17 22:11:35 -07:00
56fab24cec
Make importing NetNewsWire 3 subscriptions a one-step process — use an accessory view in the NSOpenPanel. Also: refactor to use immutable structs instead of classes; use static methods on structs; reduce API surface; don’t flatten sub-folders (let the OPML importer handle the flattening, which it already does).
2019-10-17 13:25:11 -07:00
f010f2693d
disable Feed Wrangler account creation
2019-10-16 09:24:55 -04:00
86caa869fc
Merge branch 'master' into feature/feed-wrangler
...
# Conflicts:
# Frameworks/Account/Account.xcodeproj/project.pbxproj
2019-10-16 05:48:03 -04:00
51373885b4
Change javascript event handlers to use event.target.matches instead of walking the dom to install event handlers
2019-10-15 09:04:21 -05:00
9e18361043
Merge branch 'mac-release'
2019-10-14 20:59:26 -05:00
19145505c5
Add the ability to import NNW 3 Subscription plist files. Issue #1129
2019-10-14 20:45:58 -05:00
427c0da0d3
Fix build error in FetchRequestQueue.
2019-10-13 22:19:49 -07:00
31a2afb067
Fix crashing bug in FetchRequestQueue by making sure the completion is called not more than once from FetchRequestOperation. Fix #1133 .
2019-10-13 22:08:05 -07:00
c5e0d96adb
Merge changes from mac-release, including performance fix.
2019-10-13 19:08:27 -07:00
a1f26898c8
Split Mac and iOS specific javascript into individual files.
2019-10-13 15:47:11 -05:00
099172d9d2
Empty the database articles cache when NetNewsWire moves to the background. This helps prevent the cache from growing forever.
2019-10-12 15:06:21 -07:00
ee1f26899c
Add Test build configuration
2019-10-11 17:38:01 -05:00
a3a694333a
Disable Sparke's check for updates on DEBUG builds
2019-10-11 15:07:41 -05:00
cc9a9435d7
Add provisioning profile. On Signing 7 Capabilities, import provisioning profile.
2019-10-09 21:51:13 -07:00
31c1dc40e3
Fix leading for super and subscript in the article view
2019-10-08 22:15:49 -07:00
f7e235a1fb
Remove padding from code blocks that was causing weird indentation
2019-10-07 11:05:22 -05:00
be89df884d
The Debug menu can now be enabled in release builds.
...
`defaults write com.ranchero.NetNewsWire-Evergreen ShowDebugMenu -bool YES`
Toggling the Web Inspector uses SPI, so it's always excluded from the Debug
menu when building for the Mac App Store.
2019-10-06 17:56:53 -07:00
e4134c3256
Add iCloud capability.
2019-10-06 16:53:02 -07:00
6707fdcbd1
Double clicking a feed in the side bar opens the feed's homepage in the browser. Issue #1099
2019-10-05 11:44:21 +10:00
c50ed3e44c
Improve article extractor error graphic
2019-10-04 08:19:26 -05:00
c4b6cbe49e
Allow article extractor to be tried again after Mercury parser failure
2019-10-04 07:55:42 -05:00
269b9315b2
Revert "Add iCloud entitlement to enable Handoff"
...
This reverts commit 27bd9ba919
2019-10-04 07:11:44 -05:00
27bd9ba919
Add iCloud entitlement to enable Handoff
2019-10-04 07:03:39 -05:00
3d343eb91d
Prevent pre tags from wrapping. Issue #1089
2019-10-03 18:27:48 -05:00
0000e03083
Add the ability to handoff from iOS to Mac
2019-10-03 15:49:27 -05:00
9203444552
Add deep linking to Mac app.
2019-10-03 11:39:48 -05:00
56a92e7938
Adds unit testing and implements fixes for unread counts, icons, missing metadata and more.
2019-10-03 18:06:49 +10:00
e3c50db7e8
Optimize PNG’s
2019-10-02 22:52:50 -04:00
cc187875d9
Add initial support for per feed notifications
2019-10-02 19:42:16 -05:00
ef29334a41
Use os_log() instead of NSLog()
2019-10-02 11:18:52 -05:00
f67b7df5a9
Add row swipe action for Mark/Unmark Starred
2019-10-02 11:16:01 -05:00
bc32fc1cb9
Add row swipe action for Mark Read/Unread
2019-10-02 11:16:01 -05:00
28dc85f4b0
Merge branch 'mac-release'
2019-09-29 22:47:02 -07:00
098128fd0a
Use new Slack group URL with Help menu command. Fix #1087 .
2019-09-29 22:46:40 -07:00
27478b0f6f
Make r and u both just toggle read status. Update keyboard shortcuts HTML documentation to match.
2019-09-29 22:44:32 -07:00
b62a7afa10
Add keyboard shortcut for toggling starred status — s key. Fix #875 .
2019-09-29 22:34:31 -07:00
7c26921487
Change Feed Inspector Reader View setting layout
2019-09-28 06:20:06 -05:00
50428f3179
Allow adding Feed Wrangler accounts
2019-09-28 01:59:49 -04:00
6536dbf2a5
Use correct account method for adding folders
2019-09-27 06:38:43 -05:00
465b6e789b
Sends and receives unread statuses #1058 . Also implements OMPL import #1043 .
2019-09-27 08:26:18 +10:00
d961a73f28
Removed inadvertent code change
2019-09-26 15:30:38 -05:00
0a2cbfde22
Knock the corner off the inner image when it is visible
2019-09-26 14:31:43 -05:00
f25c0e0b57
Original implementation was only aware of multimarkdown style footnote markup.
...
This commit includes support for DaringFireball style footnotes
2019-09-26 20:20:53 +12:00
b721f74e17
Merge branch 'mac-release'
2019-09-25 17:09:21 -05:00
c4ee1edb69
Add externalID to Folder and persist it to OPML file. Issue #1060
2019-09-25 17:01:09 -05:00
a381361b56
Merge branch 'master' of https://github.com/brentsimmons/NetNewsWire
2019-09-25 12:18:28 +12:00
98befac78c
Animate reader view button
2019-09-24 16:34:11 -05:00
0d99136961
544 Simple darkmode style for popovers
2019-09-23 20:38:46 +12:00
4c54d2c4ff
544 adds and positions the arrow on the popover bubble
...
An arrow element is now inserted into the dom to orient the bubble to the fnref
element that opened it. This is offset in the opposite direction to the bubble
if the bubble overhangs one side or the other.
Additionally, if both sides overhang then no positioning takes place. This
is the first step towards supporting more narrow windows and mobile clients.
2019-09-23 20:25:00 +12:00
af5d510c80
#544 Better handling of the footnote reverse links
...
* Uses a stylesheet to hide the reverse link in the popover rather than monkeying around with the dom in JS
* Javascript event handler catches clicks on the reverse buttons in the footnote list at the bottom of the page
and scrolls the document back to the source, rather than opening the document in a browser window.
2019-09-23 19:56:58 +12:00
0c99a5f523
Remove enableWebInspectorMenuItem outlet
...
Fixes a console warning about the removed property.
2019-09-22 15:19:23 -05:00
5fea81971b
#554 newsfoot.js and css are included in the page
...
These changes are the bare minimum required to get footnotes to appear and function on the article page.
* The newsfoot.js script now wraps everything in an IIFE to prevent bleed to other scripts
* Stylesheets are included in the main stylesheet, with the colors extracted out into separate selectors
Currently missing the arrow pointing to the footnote link, and no consideration exists for mobile presentation
beyond a max-width: 100vh on the footnote popover.
2019-09-22 14:06:51 +12:00
548eaac5fa
Maid Reader View button more legible
2019-09-21 15:16:55 -05:00
9d54a1de74
Enable always on Reader View for feeds
2019-09-21 15:03:42 -05:00
b49aeca577
Moved page.html location information to ArticleRenderer
2019-09-21 12:36:35 -05:00
0c00150849
Externalize javascript code into separate main.js file
2019-09-21 04:34:11 -05:00
ba45144c2a
Merge branch 'mac-release'
2019-09-21 03:57:41 -05:00
3decd23c45
Convert iOS to use Javascript rendering
2019-09-20 20:33:28 -05:00
710abf30c7
Make stylesheet external to page.html
2019-09-20 19:28:13 -05:00
cdf643c2a6
Make iFrames responsive.
2019-09-20 17:21:01 -07:00
9c6d47eaa1
Merge branch 'pr/1033'
2019-09-20 17:51:27 -05:00
1bcc1eda44
Implement disallowing feeds in the root folder for specified accounts
2019-09-20 15:37:10 -05:00
a85df5bd09
Add Feedly icon. Issue #1031
2019-09-20 14:47:40 -05:00
af0d6c9022
Implement AccountBehaviors so that we don't have to keep adding boolean flags to account
2019-09-20 11:34:31 -05:00
d67c9144f5
Add Reader View is always on preference for Feeds
2019-09-19 19:49:11 -05:00
567d762ea4
Fix button animation resets
2019-09-19 17:30:54 -05:00
76056e4fef
Add menu and keyboard shortcut to Reader
2019-09-19 17:25:36 -05:00
6a7d1df423
Change image references to use AppAsserts per our standard
2019-09-19 15:44:31 -05:00
d3a5bdf6d3
Merge branch 'mac-release'
2019-09-19 11:59:01 -05:00
502f5656b8
Don't hide the Web Inspector menu item since the entire Debug menu is removed for release builds
2019-09-19 11:27:04 -05:00
180cc39904
Negate MAC_APP_STORE
...
Oops. (Was un-negated for testing.)
2019-09-19 11:19:25 -05:00
4a0bbeacc2
Disable Web Inspector for App Store builds
...
- Hide the "Enable Web Inspector" menu item.
- #if-out notifications/defaults/etc.
- Make toggleWebInspectorEnabled(_) a no-op.
2019-09-19 10:38:17 -05:00
0b6683d073
Render with evaluateJavaScript.
...
Replaced loadHTMLString based rendering for improved performance.
2019-09-18 22:03:23 -07:00
20ecba1649
Add tooltip to Reader button
2019-09-18 20:40:58 -05:00
3b5a6f2576
Don't allow the article extraction button to toggle if it isn't working.
2019-09-18 20:03:01 -05:00
7ec3160273
Made article extractor button brighter
2019-09-18 19:45:22 -05:00
Brent Simmons
Jonathan Bennett
Nate Weaver
Maurice Parker
Daniel Jalkut
Ryan Dotson
Phil Dokas
Jim Correia
Kiel Gillard
Ramy Majouji
Andrew Brehaut
Ben Ubois