Commit Graph

257 Commits

Author SHA1 Message Date
Martin Hartl 5cbfe3b071 Include Mark All as Read in Feeds list context menu 2019-12-30 21:16:50 +01:00
Maurice Parker 5c4d8aeba7 Verify that the parent node to be expanded is a Folder before trying to expand it. 2019-12-28 10:58:15 -07:00
Maurice Parker 8fb92e119a Auto expand accounts that may have been suspended as collapsed when disclosing a feed. Issue #1440 2019-12-19 09:38:53 -07:00
Maurice Parker 58b24f3349 Rename callback: to completion: 2019-12-14 18:01:34 -07:00
Maurice Parker 43bf65b7a6 Rename occurrences of completionHandler to completion. 2019-12-14 17:14:55 -07:00
Maurice Parker 1a26f21d03 Remove context menus from all header sections, not just the accounts. 2019-12-11 14:42:45 -07:00
Maurice Parker b95a692876 Remove interactions and gesture recognizers from recycled section headers. Issue #1432 2019-12-11 14:29:32 -07:00
Maurice Parker 1f924a80fa Restore feed selection after initial layout so that the visible area tests are correct. 2019-11-29 17:36:22 -06:00
Maurice Parker ebd7f4904d Persist the Feeds Read filter across application launches. Issue #1349 2019-11-26 20:23:12 -06:00
Maurice Parker 4a9e79cd1e Persist and restore container expanded state across application launches. Issue #1361 2019-11-26 16:33:11 -06:00
Maurice Parker 3d1f68a877 Fix suggestion for upward dragging drop zones. Issue #1360 2019-11-26 13:42:25 -06:00
Maurice Parker 6a56936850 Moved expanded state away from Node so that it won't get lost on rebuilds. Issue #1346 2019-11-24 18:29:00 -06:00
Maurice Parker b5525e1a9e Restore back button items. Issue #1337 2019-11-24 10:33:13 -06:00
Maurice Parker 4296c243ff Implement custom previews for context menus to crop cell separators. Issue #1221 2019-11-23 22:15:29 -06:00
Maurice Parker c8cfcae8e3 Fix drag and drop targeting bugs. 2019-11-22 19:59:25 -06:00
Maurice Parker dd7431d5cb Remove obsolete code. 2019-11-22 15:23:21 -06:00
Maurice Parker 89e9a7b80e Add filter button show/hide unread feeds. Issue #1311 2019-11-21 15:55:50 -06:00
Maurice Parker 150e50082c Fix drag and drop target bugs 2019-11-21 13:22:33 -06:00
Maurice Parker f818a1618f Implement drag and drop feed arrangement. 2019-11-20 20:28:24 -06:00
Maurice Parker 985cef6b49 Remove title from timeline back button. Issue #1319 2019-11-19 18:16:03 -06:00
Maurice Parker bdf9add8f1 Populate timeline asynchronously and restore timeline after search. Issues #1307 & #1308 2019-11-19 11:16:43 -06:00
Maurice Parker 5283d2efbe Implement Feed protocol. 2019-11-15 06:19:14 -06:00
Maurice Parker 06bd5b3a6f Renamed Feed and related classes/instances to WebFeed 2019-11-14 20:11:41 -06:00
Maurice Parker f5cd5d7067 Reload expanded node so that the disclosure arrow is correct. 2019-11-14 15:39:11 -06:00
Maurice Parker ef84acc02d Implement better scroll interference avoidance strategy. 2019-11-13 15:31:14 -06:00
Maurice Parker 38535910ef Change Select Feed to Go to Feed. Issue #1240 2019-11-13 15:22:22 -06:00
Maurice Parker 2fd2b8b1b0 Update the refresh indicator since time when coming to the foreground. 2019-11-13 13:43:02 -06:00
Maurice Parker bed5cfa94d Only apply cell updates to the correct feed icon notification 2019-11-05 19:57:15 -06:00
Maurice Parker 560f36621f Add IconImage to encapsulate our icon processing logic 2019-11-05 18:05:57 -06:00
Maurice Parker d4f9e73438 Fix bug where dragging a feed onto an empty account failed. Issue #1255 2019-11-05 07:12:51 -06:00
Maurice Parker 292e3789f4 Remove animation speed setting. Issue #1234 2019-11-04 14:19:13 -06:00
Maurice Parker 274950a500 Removed extraneous row selection. 2019-11-03 19:44:13 -06:00
Maurice Parker 8fb87a7c87 Update label animations to match cell selection fading and changed table animation speeds to 1.5. Issue #1237 2019-11-02 19:57:01 -05:00
Maurice Parker 7c1deb3309 Increase Feeds animation speed. Issue #1227 2019-11-01 11:55:11 -05:00
Maurice Parker 18bee355e0 Fix section header separator antialiasing issues. Issue #1226 2019-11-01 11:40:52 -05:00
Maurice Parker b78b996e88 Animate Select Feed context menu result. Issue #1220 2019-10-31 20:55:08 -05:00
Maurice Parker 0c32e8de14 Don't try to scale the favicon for the master feed list. 2019-10-31 15:25:45 -05:00
Maurice Parker 280f754217 Reload nodes who's unread counts change as that could change the cell layout 2019-10-30 20:38:57 -05:00
Maurice Parker 42f4332023 Fix crash that can happen if updateUI is called before the UI is fully setup 2019-10-30 04:04:13 -05:00
Maurice Parker d537799969 Give disclosure triangles their own gutter. Issue #1210 2019-10-29 17:55:49 -05:00
Maurice Parker 66b6d43408 Update Feeds to use higher resolution images when available. Issue #1208 2019-10-28 20:57:26 -05:00
Maurice Parker 8cb080da6d Implement custom separator since the builtin separator is crazy when animating adds and deletes. Issue #1192 2019-10-28 19:52:50 -05:00
Maurice Parker 29efea3d00 Set estimated row height for tableview cells 2019-10-28 17:18:44 -05:00
Maurice Parker 473053e813 Update the updated since label on every appearance 2019-10-25 17:07:40 -05:00
Maurice Parker 6a281c7672 Replace Mark All as Read with progress indicator. Issues #1157 and #1165 2019-10-25 13:34:59 -05:00
Maurice Parker 9376fcd64a Added deactivate context menu for accounts. 2019-10-23 20:22:31 -05:00
Maurice Parker f0d1cf6239 Add Account Inspector context menu item for Accounts 2019-10-23 19:58:18 -05:00
Maurice Parker 17af3f28bf Hide unread account information unless the Account is collapsed. Issue #1159 2019-10-23 08:53:09 -05:00
Maurice Parker 7b51a272b0 Only clear Feed/Timeline selection after view begins to appear. Issue #1156 2019-10-22 19:20:35 -05:00
Maurice Parker 8656753423 Rename MarkArticlesReadAlertController to UndoAvailableAlertController to better reflect its new purpose 2019-10-10 15:13:20 -05:00
Maurice Parker ba8d1dfa83 Convert parameter usages of automated to animated 2019-10-09 21:24:56 -05:00
Phil Viso 93ab639509 Updated modal copy. Copy update removed the need for separate versions of the modal. 2019-10-07 21:13:00 -05:00
Phil Viso b963d97922 Show an alert the first time mark all as read is tapped 2019-10-07 19:48:58 -05:00
Phil Viso 461c681a9d Added a flag to suppress mark all as read warning alert 2019-10-07 19:33:30 -05:00
Phil Viso 50250c13de Made delete action destructive 2019-10-04 22:03:31 -05:00
Maurice Parker 09a3a03fc4 Add Get Info context menu option 2019-09-28 07:00:18 -05:00
Maurice Parker 08f7e6d1a4 Fix to only animate the disclosure chevron with button presses 2019-09-27 11:54:50 -05:00
Maurice Parker c33cd8f988 Remove folder icons and feed indenting. Issue #1063 2019-09-26 20:40:32 -05:00
Maurice Parker 59f58ca424 Move disclosure chevrons to the left hand side. Issue #1063 2019-09-26 19:43:17 -05:00
Maurice Parker f1819fb39c Use correct name for display 2019-09-23 12:05:44 -05:00
Maurice Parker 124997feca Reset feed to feed metadata relationship on reload 2019-09-22 21:20:01 -05:00
Maurice Parker 4f401099b6 Fix empty space that sometimes appeared between the first section and the navigation bar of Feeds 2019-09-14 19:51:23 -05:00
Maurice Parker 979fcbc013 Don't update feed selection for zero rows. 2019-09-12 13:49:23 -05:00
Maurice Parker 7ec360a81e Delete unnecessary node reload 2019-09-11 17:20:33 -05:00
Maurice Parker be84fc5a6b Simplify the section and folder expand/collapse logic 2019-09-11 16:53:27 -05:00
Maurice Parker 1b97aad79c Simplify code by moving the expanded indicator to Node 2019-09-11 15:24:38 -05:00
Maurice Parker ab38e755d3 Move apply snapshot to the viewWillAppear callback to prevent table artifacts 2019-09-11 14:33:39 -05:00
Maurice Parker d8513385e1 More refactoring to remove IndexPath dependencies 2019-09-11 05:45:35 -05:00
Maurice Parker 7278a86523 Refactor to reduce usage of IndexPath's in SceneCoordinator 2019-09-11 05:33:54 -05:00
Maurice Parker aac3c86561 Ensure that selected feed is visible when transitioning to three panel mode 2019-09-10 16:38:59 -05:00
Maurice Parker e3361abc77 Force the scroll even if the currently selected row is the same 2019-09-10 07:48:40 -05:00
Maurice Parker 98761510dd Reload visible cells after expanding/collapsing folders since the folder row might not get updated 2019-09-09 10:06:13 -05:00
Maurice Parker 9dc8f8d37a Clear the timeline if the deleted feed is showing in the timeline 2019-09-08 08:40:15 -05:00
Maurice Parker 8b901819a6 Make table views scroll even if the root split is collapsed 2019-09-08 08:30:08 -05:00
Maurice Parker a6f6462afd Make arrow key scrolling work like it does on the Mac timeline 2019-09-06 13:45:45 -05:00
Maurice Parker c8b5b10edd Check if the split is collapsed to see if we are maintaining the selection 2019-09-06 11:22:35 -05:00
Maurice Parker aa7c60ee3a Prevent row selection on iPhone as keeping selected rows highlighted is an iPad only feature 2019-09-06 11:11:28 -05:00
Maurice Parker cc1c45095c Make feeds become first responder on load so that the keyboard is ready to go on initial app launch 2019-09-06 10:52:21 -05:00
Maurice Parker 9b17293f4e Fix bugs in automated routing on application launch 2019-09-06 07:29:36 -05:00
Maurice Parker 6d24ea642a Add expand and collapse all folders shortcuts 2019-09-05 16:38:33 -05:00
Maurice Parker 734ce4bc67 Rename expand and collapse functions to be more descriptive 2019-09-05 16:08:57 -05:00
Maurice Parker 953259f0d3 Add selected row expanding and collapsing keyboard shortcuts 2019-09-05 16:04:07 -05:00
Maurice Parker c9fd7d01d9 Add delete feed keyboard shortcut 2019-09-05 15:54:58 -05:00
Maurice Parker afce6ff26f Add keyboard shortcuts for Add Feed and Add Folder 2019-09-05 15:07:35 -05:00
Maurice Parker 73828e5115 Remove the coordinator dependency from KeyboadManager as it wasn't needed 2019-09-05 14:37:07 -05:00
Maurice Parker ac37443dbb Stubbed out menu item keyboard shortcuts and implemented the numbered ones 2019-09-05 13:14:14 -05:00
Maurice Parker 7a452e2a3c Add keyboard arrow key navigation 2019-09-04 21:06:29 -05:00
Maurice Parker 68143aa2c5 Implement keyboard shortcut infrastructure and first shortcuts 2019-09-04 16:24:16 -05:00
Maurice Parker 17a5d291f4 Remove become and resign first responder code in Feeds and Timeline 2019-09-03 20:39:00 -05:00
Maurice Parker e6a4338a86 Restore the feed selection if an account containing the selection is expanded 2019-09-03 13:59:22 -05:00
Maurice Parker 4bce625f18 Clear search results when no timeline fetcher is specified 2019-09-03 12:25:27 -05:00
Maurice Parker 2e71cc573d Cap the possible destination index used during Feed moves 2019-09-03 12:07:18 -05:00
Maurice Parker 1a9acdcc50 Remove TreeController from Delete command as it is no longer used there 2019-09-01 14:56:27 -05:00
Maurice Parker 858bdb7f21 Rename AppCoordinator to SceneCoordinator as that name better defines its purpose 2019-09-01 12:43:07 -05:00
Maurice Parker 397d75c6f6 Restore animation when adds and deletes happen to feed items 2019-09-01 10:11:03 -05:00
Maurice Parker 27883632d0 Fix bug that prevented reading article user activities from being restored 2019-08-31 20:23:14 -05:00
Maurice Parker 87030a5921 Implement stateRestorationActivity to save most relevant current user activity 2019-08-31 19:30:21 -05:00
Maurice Parker 762710266d Reload all cells when a batch update completes because we might be out of sync even though we called apply on the datasource. This can happen when moving a feed into and out of a folder. 2019-08-30 16:19:06 -05:00
Maurice Parker 197fc0170e Optimize and fix unread count updates 2019-08-29 14:35:18 -05:00
Maurice Parker be8c14bc65 Change to reload the individual row instead of just changing its contents 2019-08-28 20:21:50 -05:00
Maurice Parker 7062744758 Make sure we manually correct some state when using diffable datasources 2019-08-28 20:08:30 -05:00
Maurice Parker 89a38fa2b5 Change Feeds to use diffable data sources 2019-08-28 18:06:27 -05:00
Maurice Parker 9c66f6160e Clean activities when the associated data is deleted 2019-08-28 11:30:40 -05:00
Maurice Parker a0b11da438 Prevent autolayout from messing with our manually set frames 2019-08-25 20:00:34 -05:00
Maurice Parker 0b48c3893d Change AppCoordinator to directly call controller API's since that matches the Coordinator pattern better than sending them notifications 2019-08-25 11:38:04 -05:00
Maurice Parker 7f024586bb Add navigation and toolbar theming for light mode. Issue #698 2019-08-23 12:27:45 -05:00
Maurice Parker 5a5a66d59f Remove unneeded notifications 2019-08-22 16:50:20 -05:00
Maurice Parker d67b9193c5 Add large titles to Feeds controller (again) 2019-08-22 11:16:07 -05:00
Maurice Parker c4e2420966 Change to get currently selected unread count item from total number of articles shown in timeline 2019-08-21 13:10:08 -05:00
Maurice Parker 64fd5016a9 Commenting out feed context menus due to buggy implementation in Beta 6 2019-08-20 05:43:39 -05:00
Maurice Parker 6087951824 Remove context menu titles as they didn't provide any additional context 2019-08-19 15:49:42 -05:00
Maurice Parker 3245223b24 Add Select Feed context menu 2019-08-19 15:45:52 -05:00
Maurice Parker 3cbf9f45a3 Add weak self usage in a couple needed places 2019-08-16 13:54:19 -05:00
Maurice Parker 066616b005 Add new images used in context menus to AppAssets where they belong 2019-08-16 13:27:41 -05:00
Maurice Parker 2f5225163d Center the pop over arrow in the button the same way that Apple does in Mail 2019-08-16 12:14:55 -05:00
Maurice Parker 7ac18029ea Add additional swipe menu More to handle new actions 2019-08-15 19:46:31 -05:00
Maurice Parker e8bbe9efbf Add Folder context menu 2019-08-15 17:46:42 -05:00
Maurice Parker e88210bbb7 Add copy url actions for feeds 2019-08-15 15:19:23 -05:00
Maurice Parker c03c444997 Add initial context menu items for feeds. 2019-08-15 13:19:02 -05:00
Maurice Parker 1eb8da7749 Rearrange some code to put them in the correct sections 2019-08-15 12:42:25 -05:00
Maurice Parker 54f6607621 Keep table selections when root split isn't collapsed 2019-08-02 10:25:47 -05:00
Maurice Parker 2ab3ff76fb Make settings button work second split controller is installed 2019-08-01 07:10:02 -05:00
Maurice Parker ccd0385220 Prevent flicker when selected feed's unread count changes. 2019-07-30 13:08:58 -05:00
Maurice Parker 978aeeee80 Restore selection when currently select feed unread count changes 2019-07-27 15:05:21 -05:00
Maurice Parker adb6309872 In Three Pane Mode only show the progress indicator on the Feeds controller 2019-07-27 14:49:07 -05:00
Maurice Parker b25e789aef Prevent refresh errors from keeping the refreshControl visible when error dialogs are displayed. 2019-07-18 15:16:54 -05:00
Maurice Parker 6e59c56515 Move more logic out of MasterFeedViewController and into AppCoordinator 2019-07-06 12:25:45 -05:00
Maurice Parker 4884aebbfd Encapsulate more of the AppCoordinate API 2019-07-06 11:32:19 -05:00
Maurice Parker 15754684a4 Move more navigation responsibilities into the AppCoordinator 2019-07-05 17:45:39 -05:00
Maurice Parker 19f8f8bc97 Fix missing settings button on iPhone 2019-06-29 13:53:34 -05:00
Maurice Parker fcf2937394 Rename NavStateController to AppCoordinator because we are redesigning it to be the Coordinator pattern 2019-06-29 13:35:12 -05:00
Maurice Parker 188bacee25 Move nav state ownership to MasterFeedViewController 2019-06-27 16:30:24 -05:00
Maurice Parker 5f045706e4 Removed usaged of UIApplication.present 2019-06-27 14:21:07 -05:00
Maurice Parker 95d4395416 Fix feed / folder rename for iOS 2019-06-26 06:23:08 -05:00
Maurice Parker b877e4dc83 Move NavState ownership to the AppDelegate 2019-06-25 12:10:07 -05:00
Maurice Parker e8e0f3b8bd Temporarily disabled SwiftUI compiling 2019-06-23 17:41:41 -05:00
Maurice Parker 58459631e4 Add SwiftUI account detail view 2019-06-13 14:30:56 -05:00
Maurice Parker 902304c723 Convert Settings to use SwiftUI 2019-06-11 16:59:16 -05:00
Maurice Parker e8992dac95 Fix issue where deletes were crashing the app. Issue #702 2019-06-05 17:42:35 -05:00
Maurice Parker e7c339fb09 Update iOS to work with the latest Account API 2019-05-30 17:41:56 -05:00
Maurice Parker c61949bc04 Add account name to network error messages and prevent background iOS errors from displaying alerts 2019-05-26 11:54:32 -05:00
Phil Viso 1271fc9081 Update UI when accounts change or when account state changes 2019-05-19 19:18:28 -05:00
Phil Viso 8c28160f91 Always clear selection on viewWillAppear 2019-05-19 18:39:15 -05:00
Phil Viso 2f82f05721 Improved sizing of add feed modal on iPad 2019-05-19 17:47:33 -05:00
Phil Viso 90ea9ebb50 Disable add new item button when there are no active accounts 2019-05-19 16:08:48 -05:00
Maurice Parker 0398021345 Restore feed if second part of move fails. 2019-05-16 12:42:01 -05:00
Maurice Parker 2401c96c99 Update iOS to work with latest from the Accounts framework 2019-05-09 17:30:36 -05:00
Maurice Parker e45362bffc Update iOS to work with new delete API. 2019-05-09 07:28:51 -05:00
Maurice Parker 636468bbf0 Implement active account processing functionality 2019-05-02 06:01:30 -05:00
Maurice Parker bf50c7a7e3 Update the nav controller title so that the back bar button item in iPad portrait has a valid title 2019-04-28 18:53:57 -05:00