Commit Graph

7455 Commits

Author SHA1 Message Date
Brent Simmons fa0744ed2c
Merge pull request #3100 from greenbuffo/fix/2916
Expand workaround for macOS 11 WebView origin offset bug. Fixes #2916
2021-05-01 11:16:50 -07:00
Chris Campbell 364f3a7639
Prevent infinite loop in DetailWebView.setFrameSize()
DetailWebView.setFrameSize() calls bigSurOffsetFix(), which changes the window's frame, which ultimately calls setFrameSize() again (which calls bigSurOffsetFix(), etc). In practice, this isn't causing an infinite loop (I think NSWindow.setFrame(_:display:) is smart enough to prevent reentrancy) but it's still dangerous to have such a glaring logic error in the code.
2021-04-30 00:52:15 -04:00
Chris Campbell bf77d77669
Expand workaround for macOS 11 WebView origin offset bug. Fixes #2916
Move the code that twiddles the window frame from DetailWebView.viewDidEndLiveResize() into a new bigSurOffsetFix() API so it can also be called by setFrameSize() when the frame size is changed outside of a live resize.
2021-04-30 00:02:10 -04:00
Brent Simmons f73facdef7
Merge pull request #3099 from babbage/bugfix/3037-unread-onload
Mark as read just before display. Fixes #3037
2021-04-29 10:18:53 -07:00
Brent Simmons ec3916f37b
Merge pull request #3097 from babbage/bugfix/3084-footnotes-pt2-mac
Capture fully resolved footnote backlinks. Extends #3084 for macOS
2021-04-29 10:18:10 -07:00
Brent Simmons ec1b0f8bcd
Merge pull request #3095 from babbage/bugfix/3084-footnotes-pt2-ios
Capture fully resolved footnote backlinks. Extends #3084
2021-04-29 10:17:53 -07:00
Duncan Babbage bc056e4952 Mark as read just before display. Fixes #3037
Marking an article as read just before navigating to it prevents the read status from flashing unread/read on display when swiping to new unread articles, or navigating with the next article toolbar button.
2021-04-29 22:46:52 +12:00
Duncan Babbage 00f1bdce97 Capture fully resolved footnote backlinks. Extends #3084 2021-04-29 20:04:59 +12:00
Duncan Babbage 16a3a20156 Capture fully resolved footnote backlinks. Extends #3084 2021-04-29 19:57:08 +12:00
Brent Simmons eddc763c52
Merge pull request #3089 from babbage/bugfix/3043-footnotes
Handle footnote backlinks that lack css classes and ids. Fixes #3084 for iOS
2021-04-28 21:56:56 -07:00
Brent Simmons c89a7c3db7
Merge pull request #3091 from babbage/bugfix/3043-footnotes-mac
Handle footnote backlinks that lack css classes and ids. Fixes #3084 for macOS
2021-04-28 21:56:36 -07:00
Brent Simmons 790218501b
Merge pull request #3079 from babbage/bugfix/3069
Handle links with unencoded spaces. Fixes #3069
2021-04-28 21:55:46 -07:00
Duncan Babbage 73bbb67d64 Handle footnote backlinks w/o css classes. Fixes #3084 2021-04-29 10:23:58 +12:00
Duncan Babbage e5a21cfee6 Handle footnote backlinks w/o css classes. Fixes #3084 2021-04-29 10:17:02 +12:00
Duncan Babbage 9092d075a0 Handle links with unencoded spaces. Fixes #3069 2021-04-28 22:49:32 +12:00
Brent Simmons 6b77602694
Merge pull request #3087 from babbage/bugfix/macos-build
Add required closure to macOS AppDelegate
2021-04-27 18:02:36 -07:00
Brent Simmons 3d49fd8e76
Merge pull request #3086 from babbage/feature/mac-PersistentSmartFeeds
Always show Smart Feeds on macOS. Fixes #3052 on macOS
2021-04-27 18:02:00 -07:00
Brent Simmons 45d62ec20d
Merge pull request #3085 from babbage/feature/ios-PersistentSmartFeeds
Always show smart feeds on iOS. Fixes #3052 on iOS
2021-04-27 18:01:21 -07:00
Brent Simmons 8e34187821
Merge pull request #3083 from babbage/docs/spm
Minor technotes updates
2021-04-27 18:00:15 -07:00
Duncan Babbage 336f3e7a17 Technotes: Swift Packages, AppDefaults not DB5
Revise additonal reference to Git submodules.
2021-04-27 16:50:05 +12:00
Duncan Babbage 2ea86c1e14 Incorporate closure from mac-release
Enables ios-candidate branch to build macOS target.
2021-04-27 13:07:09 +12:00
Duncan Babbage a4d9f018f6 Always show Smart Feeds. Fixes #3052
Display Smart Feeds always, even when read articles are being hidden and all articles from a feed have been marked as read, and even when there are no items in a Smart Feed.
2021-04-27 12:28:06 +12:00
Duncan Babbage c84fe751e6 Always show Smart Feeds. Fixes #3052
Display Smart Feeds always, even when read articles are being hidden and all articles from a feed have been marked as read, and even when there are no items in a Smart Feed.
2021-04-27 12:27:42 +12:00
Brent Simmons 2fd7d8549e
Merge pull request #3078 from babbage/patch-1
Update Coding Guidelines
2021-04-25 20:04:00 -07:00
Duncan Babbage e0d5dd69a2
Update Coding Guidelines
Minor edit, as discussed in NNW Slack.
2021-04-26 14:36:07 +12:00
Brent Simmons 2e81c050dc
Merge pull request #3073 from babbage/feature/VoiceOverRead
Improve accessibility action labels for MasterTimelineCell in iOS
2021-04-25 19:00:25 -07:00
Duncan Babbage 7e71814011 Rename accessibility action labels as per #3072 2021-04-26 08:19:31 +12:00
Brent Simmons 7f939f266b
Merge pull request #3075 from stuartbreckenridge/ios-fix-3055
Adds API URL example for FreshRSS on iOS
2021-04-25 12:25:32 -07:00
Brent Simmons 2779ac4d69
Merge pull request #3074 from stuartbreckenridge/mac-fix-3055
Adds API URL example for FreshRSS on macOS
2021-04-25 12:25:14 -07:00
Stuart Breckenridge 2023d59e5a
adds helper text
fixes #3055 on iOS
2021-04-25 16:46:24 +08:00
Stuart Breckenridge 858672fdaf
fix on release branch 2021-04-25 13:31:15 +08:00
Brent Simmons 1d4ef582a7 Simplify iconImage:didSet. Move background color update to a private helper function. 2021-04-24 17:55:48 -07:00
Brent Simmons 954a676cbe
Merge pull request #3064 from stuartbreckenridge/fix/3035
Fixes #3035
2021-04-24 11:57:23 -07:00
Brent Simmons 9540316e6f
Merge pull request #3065 from stuartbreckenridge/fix/3062
Fixes #3062
2021-04-24 11:56:16 -07:00
Brent Simmons 694389f87f
Merge pull request #3066 from stuartbreckenridge/fix/3036
Fixes #3036
2021-04-24 11:55:32 -07:00
Brent Simmons 19c43ac5cc
Merge pull request #3068 from stuartbreckenridge/mac-release
Fixes #3056 on Mac
2021-04-24 11:50:06 -07:00
Brent Simmons ecfe26b78c
Merge pull request #3067 from stuartbreckenridge/fix/3056
Changes NewsBlur behavior for include_hidden
2021-04-24 11:48:45 -07:00
Stuart Breckenridge 72e68a62f8
further typo fix 2021-04-24 19:11:53 +08:00
Stuart Breckenridge 7afd2e1e21
Fixes #3056 on Mac 2021-04-24 15:52:38 +08:00
Stuart Breckenridge 5cc59981ce
Changes NewsBlur behavior for include_hidden
`include_hidden` is now `false`.
#closes 3056
2021-04-24 15:42:16 +08:00
Stuart Breckenridge d0c3f05f0e
Delete change to Remove 2021-04-24 15:16:20 +08:00
Stuart Breckenridge 925bbadecb
Fixes #3062 2021-04-24 15:10:26 +08:00
Stuart Breckenridge 15fb5637ff
Fixes #3035
MarkAllAsReadAction will check for and handle SmartFeeds.
2021-04-24 15:05:11 +08:00
Brent Simmons f7762dcaaf Update release notes for iOS. 2021-04-21 22:25:27 -07:00
Brent Simmons 08b3115c63 Bump version number. 2021-04-21 22:10:28 -07:00
Brent Simmons 3842e1c368
Merge pull request #3032 from stuartbreckenridge/fix/code-sign-xcode12_5
Adds —deep code sign flag for Xcode 12.5
2021-04-21 19:02:12 -07:00
Stuart Breckenridge 036dbf297c
Adds —deep code sign flag for Xcode 12.5 2021-04-22 09:43:07 +08:00
Brent Simmons 77cd189c75
Merge pull request #3021 from stuartbreckenridge/fix/3014
Naming convention for notification options
2021-04-21 18:02:11 -07:00
Stuart Breckenridge cde7bf9589
restores storyboard to previous commit 2021-04-22 09:00:06 +08:00
Brent Simmons 6ed3b1227e
Merge pull request #3010 from uruha-komachin/main
Fixed missing argument `validateFeed:`
2021-04-21 17:05:20 -07:00