Commit Graph

5271 Commits

Author SHA1 Message Date
Flowinho da64f65c7b Fixes close button icon distortion
This bug was caused by an inaccessible property of UIButton. Since the button was setup in IB using a system button with a custom icon, it’s imageView property is only accessible in code. The “view” content-mode in IB is misleading here, as it affects the UIButton.view NOT UIButton.ImageView.

- Set content-mode of the buttons imageview to scaleAspectFit.
2020-03-12 21:54:50 +01:00
Maurice Parker 9cab5ca46c
Merge pull request #1888 from flowinho/ios-release
Adding dynamic width algorithm to the titleLabel
2020-03-12 15:34:01 -05:00
Flowinho feacda1c3b HOTFIX silly me 2020-03-12 21:33:02 +01:00
Flowinho 91247b7f16 Adding dynamic width algorithm to the titleLabel
This commit adds multiple functionalities at once:

- The background of the image title now features rounded corners with a radius of 6 - which is consistent to iOS appearace.
- The background of the image title now is enlarged to make sure the letters do not touch the borders of the view. (This was a finding during implementation).
- The background of the image title is now removed when no title is present (memory optimization / prevention of unwanted optical glitches).

The title label now resizes itself depending on the devices it’s displazed on.

- On iPhone it will take 92% percent of available screen width.
- On iPhone it will 80% of available screen width.
- This works for all device orientations.

The numbers are derived from my personal preference when implementing it.
2020-03-12 21:23:57 +01:00
Maurice Parker b31c18a721 Reduce the article padding to 32px from 64px. Issue #1885 2020-03-12 12:54:11 -05:00
Maurice Parker e0d8e35831 Don't remove filtered feeds on refreshes or other times we call batch update did perform. 2020-03-12 12:32:08 -05:00
Maurice Parker 429a48dd2a
Merge pull request #1884 from flowinho/ios-release
Added missing constraints to the UISwitch elements
2020-03-12 12:13:06 -05:00
Maurice Parker 343f705cd7 Fix article read filter which wasn't persisting correctly. 2020-03-12 12:07:01 -05:00
Flowinho 97c79202fc Added missing constraints to the UISwitch elements 2020-03-12 17:56:43 +01:00
Maurice Parker 22b9e7b54b Don't reset the windowScrollY position on every page render and don't set it if JavaScript returns it corrupted. Issue #1883 2020-03-11 19:45:45 -05:00
Maurice Parker 27b1443def Remove dispatch code that didn't seem to help and caused us to not be able to find the correct view controller when setting the article. Issue #1881 2020-03-11 18:17:09 -06:00
Maurice Parker 76d5f4a073 Remove flush and restore of web view queues. Issue #1882 2020-03-11 17:02:16 -06:00
Maurice Parker 38981d01bd Don't remove items from Feeds list when batch update is performed. Issue #1879 2020-03-11 15:19:55 -06:00
Maurice Parker 202ee57697 Coalesce more rebuild commands to make the unread count items appear more smoothly. 2020-03-11 14:49:17 -06:00
Maurice Parker 9007ed4b06 Changed so that Feeds and Timeline clear read items if necessary on manual refresh commands. Issues #1834, #1856, and #1845 2020-03-11 14:47:00 -06:00
Maurice Parker 326322ead6
Merge pull request #1876 from flowinho/ios-candidate
iOS: Account Login Field should switch first responder on return #1870
2020-03-11 11:23:48 -06:00
Flowinho b178fe93af Call action on return if password was added
This is an obvious change.
2020-03-11 14:02:06 +01:00
Flowinho 66fae15f64 Remove redundant code to lessen LOC
- Less code - less bugs.
- Also resign the first responder when the user presses the action button
2020-03-11 13:43:02 +01:00
Flowinho 386efd632b Changing UIContentType from username to email adress
Add responder switch to streamline login flow

This change achieves two things:

- When the user presses Return and the email field is selected, the cursor now switches to the password field (as expected by the user).
- It enables iOS to pick up login and password field and enables password autofill.
2020-03-11 13:43:02 +01:00
Maurice Parker 45bae1cd58 Merge branch 'master' of https://github.com/Ranchero-Software/NetNewsWire 2020-03-10 15:28:29 -07:00
Brent Simmons 5a349e3f47
Merge pull request #1869 from paramaggarwal/patch-1
Update README to reflect launch on iOS
2020-03-09 23:55:08 -04:00
Param Aggarwal 7e30d4afba
Update README to reflect launch on iOS 2020-03-10 09:24:18 +05:30
Maurice Parker d94e090094 Replace Mark Older as Read with Mark Above and Mark Below. 2020-03-08 16:15:17 -07:00
Maurice Parker fc447121d6 Save window state to user defaults. Issue #1852 2020-03-05 17:42:17 -07:00
Maurice Parker 7bc5a7946f Refactor so that state could be restored from alternate sources (such as UserDefaults). 2020-03-05 16:42:54 -07:00
Maurice Parker 59e4cf8695 Make foremost window key when show main window keyboard shortcut or menu item used. 2020-03-04 18:22:15 -07:00
Maurice Parker adb312bccb Add article state restoration. 2020-03-04 18:16:58 -07:00
Maurice Parker de38ba9f5b Added feed selection restoration. 2020-03-04 15:40:40 -07:00
Brent Simmons dc99d5b071 Bump version to 39. 2020-03-04 13:27:29 -08:00
Maurice Parker ceef6116f9 Persist and restore per window per feed timeline filter state. 2020-03-03 18:13:43 -08:00
Maurice Parker ae8f36d300 Save sidebar expanded state. 2020-03-03 17:10:03 -08:00
Maurice Parker 94d04e3cc2 Change restore and save func names to be more consistent. 2020-03-03 15:36:22 -08:00
Maurice Parker 7d8feba24b Remove file coordinator usage from account files. Issue #1821 2020-03-03 11:39:04 -08:00
Maurice Parker 1a41d4f265 Change window frame and controller splits to use new per window state restoration. 2020-03-03 11:26:33 -08:00
Maurice Parker 72e5915fb8 Refactor state restoration so that the MainWindowController has control of state restoration order. 2020-03-03 10:54:37 -08:00
Maurice Parker e920235038 Remove references to windows when they close so that they will deallocate. 2020-03-02 18:06:55 -08:00
Maurice Parker b6ff9e8ff4 Simplify the sidebar filter state preservation. 2020-03-02 17:55:36 -08:00
Maurice Parker eaa99db5c7 Initial support for multiple windows and state preservation. 2020-03-02 17:46:31 -08:00
Michele Volpato ee0f982e93 Remove unneeded whitespaces 2020-03-02 22:33:59 +01:00
Michele Volpato 115405f1f0 Fix progress bar width, add contraints to progress label 2020-03-02 22:25:57 +01:00
Maurice Parker 5755dd0844 Finish merge of mac-release. 2020-03-01 16:33:05 -08:00
Maurice Parker 94c6ca428f Merge branch 'mac-release' 2020-03-01 16:32:31 -08:00
Maurice Parker 66054ca735 Deleted unused keys. 2020-03-01 15:06:23 -08:00
Maurice Parker dc20aa0e22
Merge pull request #1833 from Wevah/embedded-widget-fix
Embedded widget fix
2020-03-01 14:25:23 -08:00
Maurice Parker 6828cd7325
Merge pull request #1832 from Wevah/article-max-width
Set max-width to 44em (792px with an 18px font-size)
2020-03-01 14:24:04 -08:00
Maurice Parker 1c55e0c8a9 Don't show select in sidebar if the web feed is already selected. Issue #1843 2020-03-01 11:07:24 -08:00
Maurice Parker 80858adced Exclude currently selected article from feed filter. Issue #1841 2020-02-29 17:05:56 -08:00
Maurice Parker 5eed42721e Change so that feeds aren't filtered on select feed in sidebar if they are already visible. 2020-02-29 16:30:13 -08:00
Maurice Parker dac4c2ffb0 Disclose feed in side bar when selected from context menu even if the feed is filtered. Issue #1805 2020-02-29 16:24:14 -08:00
Maurice Parker 4b2f08e759 Refactor select web feed in sidebar to use the delegate pattern instead of a notification. 2020-02-29 15:50:13 -08:00