Commit Graph

2387 Commits

Author SHA1 Message Date
Maurice Parker e31dec7c44 Call completion handler when there are no feeds associated with the folder being removed. Issue #938 2019-09-01 10:49:35 -05:00
Brent Simmons 1b26b1ece5
Merge pull request #932 from correia/bug-901
Fix for bug #901 — first web view load flashes white in dark mode
2019-08-31 22:27:31 -07:00
Jim Correia e7e77d362c Fix for bug #901 — first web view load flashes white in dark mode
The fix used for iOS (keep a queue of preloaded web views) isn't appropriate
for macOS since the first view is used immediately. That approach would
solve the flash of white when first searching, but not the flash of white
when launching the application.

Instead, use a modification of the original solution used for iOS:

    - wrap the web view in a box with an appropriate background color
    - hide the web view at creation
    - show the web view after* the first load

This doesn't suffer the latency problem that the same solution on iOS had
because the first load is always local, "No Selection" HTML.

[*] Showing the view immediately after the first load still causes the flash
    to white. Waiting 0.05 seconds avoids this. That's a fairly terrible hack,
    but I don't have a better solution at present.
2019-08-31 22:14:56 -07:00
Maurice Parker fabea36a91
Merge pull request #930 from correia/bug-921
Only enable "Open in Browser" when a single article is selected.
2019-08-31 18:29:07 -05:00
Jim Correia cdfdc06142 Only enable "Open in Browser" when a single article is selected.
Fixes bug #921.
2019-08-31 16:02:21 -07:00
Maurice Parker c1216bf7bb Merge branch 'mac-release' of https://github.com/brentsimmons/NetNewsWire into mac-release 2019-08-30 10:40:25 -05:00
Maurice Parker a69be4117a Retrieve statuses before articles during sync process and default starred articles to read if there isn't an unread status Issue #868 2019-08-30 10:39:52 -05:00
Brent Simmons 29efae42fd Update Apple events privacy statement to refer to article instead of news item. 2019-08-28 21:40:56 -07:00
Brent Simmons d468961d81 Update version and build number. 2019-08-28 21:40:21 -07:00
Brent Simmons a7c373b445 Update to latest RSCore. 2019-08-28 21:37:55 -07:00
Brent Simmons 1c2d5a677a Update to latest RSParser, which includes fix for detecting RDF feeds that lack an XML header. 2019-08-28 21:24:35 -07:00
Maurice Parker 3279a25581 Cache home page to feed icon relationship 2019-08-26 19:40:30 -05:00
Maurice Parker 1a3e2784ae Optimize table cell reloading when feed images are made available 2019-08-26 12:54:23 -05:00
Brent Simmons c3aebe7868 Bump version and build. 2019-08-23 21:59:44 -07:00
Brent Simmons 739eb5183e Bump version and build numbers. 2019-08-23 18:31:04 -07:00
Brent Simmons dd62a3325a Center the main window on first run. 2019-08-23 18:30:28 -07:00
Brent Simmons 4bead42b5a Center prefs window after switching to the proper view. 2019-08-23 18:30:14 -07:00
Brent Simmons cc7321e936 Center the preferences window. Fix #769. 2019-08-23 16:22:06 -07:00
Brent Simmons 3447ebcec0 Reload data after a batch update. Fix #872. 2019-08-23 15:52:07 -07:00
Brent Simmons e140d51e4b Bump version and build number. 2019-08-21 21:42:48 -07:00
Brent Simmons 849830f494 Refetch articles for smart feeds and folders, if selected, when a feed or folder is deleted. Fix #838. 2019-08-21 21:41:56 -07:00
Brent Simmons bffda93700 Give has(feed) a default implementation in Container.swift. 2019-08-21 21:07:40 -07:00
Brent Simmons fe2d329301 Make has(feed) a Container protocol method. 2019-08-21 21:05:47 -07:00
Brent Simmons edd9b1cc91 Remove HelpBook folder, since the help book now has a separate repo. 2019-08-21 20:56:53 -07:00
Brent Simmons f513741ddb Start work on filtering timeline so that articles from deleted feeds never show up. 2019-08-21 13:23:46 -07:00
Brent Simmons 98ec923c67 Replace, in default feeds for new users, Om Malik and Xcoders with Rose Orchard and Michael Tsai. 2019-08-21 13:06:26 -07:00
Brent Simmons e524d48c1d Add credit to Joe Heck in the About window for difficult infrastructure. 2019-08-19 14:38:18 -07:00
Brent Simmons 588dbb0ce5 Add prefs to Advanced prefs pane to 1) check for updates automatically, and 2) choose to download test or release builds. The default will be release builds only, since most people don’t want test builds. 2019-08-18 16:07:37 -07:00
Brent Simmons 5670989c29 Do initial layout of revised Advanced preferences (which now include updates preferences). 2019-08-17 16:58:39 -07:00
Brent Simmons 8d7e238386 Change default SUFeedURL to release builds appcast. Add FeedURLForTestBuilds to store the URL for test builds. 2019-08-17 11:04:54 -07:00
Brent Simmons 3aae7ad328 Now using manual build numbers, because I messed up and built from the wrong branch. I should be able to figure out how to get back to automated build numbers — but it can wait till after 5.0 ships. 2019-08-14 00:20:42 -07:00
Brent Simmons f86c32b414 Bump version to b4. 2019-08-14 00:13:50 -07:00
Brent Simmons 8cb9aefeec Bump version to 5.0b3. 2019-08-13 21:24:15 -07:00
Brent Simmons 2bbd135c9e Update appropriate counts in the sidebar when the timeline’s unread count changes. Fix #829. 2019-08-13 21:07:39 -07:00
Brent Simmons fc0fc2055e Get the unread count from the timeline, instead of the database, only for the Today feed and only if it’s selected and it’s the only node selected. 2019-08-13 20:29:04 -07:00
Brent Simmons cf1b3843ee Add a SmartFeedType to smart feeds so the sidebar can tell them apart. 2019-08-13 20:28:28 -07:00
Brent Simmons 62258683c8 Add Ryan’s word-wrap change to mac-candidate. 2019-08-13 20:07:42 -07:00
Brent Simmons bfe3a15b9d Bump version to 5.0b2. Remove how-to-support thing from About box. 2019-08-12 09:53:47 -07:00
Brent Simmons f8c8fc5f34 Fix crashing bug with marking all as read via contextual menu. Implement feed.fetchUnreadArticles. 2019-08-12 09:43:29 -07:00
Brent Simmons 495662f888 Add, to About window, credit for Ryan Dotson for the Help Book. Also add a link to the How to Support NetNewsWire tech note. 2019-08-11 22:08:24 -07:00
Brent Simmons bf3e26e827 Bump version to 5.0b1. 2019-08-11 21:58:27 -07:00
Brent Simmons 40369eaca0 Change the URL of the Help book to include a /mac/ directory, so we can have separate help books for Mac and iOS. 2019-08-10 14:26:51 -07:00
Brent Simmons 13797c6693 Remove no-longer-needed removal of that weird character Six Colors uses in some of their headlines. 2019-08-04 23:02:09 -07:00
Brent Simmons 536ac205a0 Fix crash when making a feed via AppleScript and the feed already exists. 2019-08-03 11:04:52 -07:00
Brent Simmons 4b5dd7cd17 Fix some AppleScript terminology conflicts. Change account.type too account.accountType. Change local account to onmymac. 2019-08-02 14:03:04 -07:00
Brent Simmons ccd1d4bdc1 Wire up the account name for scripting. 2019-08-02 12:44:24 -07:00
Brent Simmons 5d97e89e91 Replace the contents property with allFeeds — which returns all the feeds, including those inside folders. This is distinct from the feeds element, which returns just top-level feeds. 2019-08-01 22:51:03 -07:00
Brent Simmons 6c20af63e5 Merge branch 'mac-candidate' of https://github.com/brentsimmons/NetNewsWire into mac-candidate 2019-08-01 21:52:16 -07:00
Brent Simmons e800b13f01 The accounts property returns all accounts. 2019-08-01 21:52:12 -07:00
Brent Simmons 0b00d74462
Merge pull request #821 from olofhellman/mac-candidate
fix failing Applescript test by disabling it
2019-07-31 13:05:37 -07:00