Commit Graph

403 Commits

Author SHA1 Message Date
Maurice Parker b31c18a721 Reduce the article padding to 32px from 64px. Issue #1885 2020-03-12 12:54:11 -05:00
Maurice Parker e0d8e35831 Don't remove filtered feeds on refreshes or other times we call batch update did perform. 2020-03-12 12:32:08 -05:00
Maurice Parker 343f705cd7 Fix article read filter which wasn't persisting correctly. 2020-03-12 12:07:01 -05:00
Maurice Parker 202ee57697 Coalesce more rebuild commands to make the unread count items appear more smoothly. 2020-03-11 14:49:17 -06:00
Maurice Parker d94e090094 Replace Mark Older as Read with Mark Above and Mark Below. 2020-03-08 16:15:17 -07:00
Maurice Parker fc447121d6 Save window state to user defaults. Issue #1852 2020-03-05 17:42:17 -07:00
Maurice Parker 7bc5a7946f Refactor so that state could be restored from alternate sources (such as UserDefaults). 2020-03-05 16:42:54 -07:00
Maurice Parker adb312bccb Add article state restoration. 2020-03-04 18:16:58 -07:00
Maurice Parker de38ba9f5b Added feed selection restoration. 2020-03-04 15:40:40 -07:00
Maurice Parker ceef6116f9 Persist and restore per window per feed timeline filter state. 2020-03-03 18:13:43 -08:00
Maurice Parker ae8f36d300 Save sidebar expanded state. 2020-03-03 17:10:03 -08:00
Maurice Parker 94d04e3cc2 Change restore and save func names to be more consistent. 2020-03-03 15:36:22 -08:00
Maurice Parker 1a41d4f265 Change window frame and controller splits to use new per window state restoration. 2020-03-03 11:26:33 -08:00
Maurice Parker 72e5915fb8 Refactor state restoration so that the MainWindowController has control of state restoration order. 2020-03-03 10:54:37 -08:00
Maurice Parker e920235038 Remove references to windows when they close so that they will deallocate. 2020-03-02 18:06:55 -08:00
Maurice Parker b6ff9e8ff4 Simplify the sidebar filter state preservation. 2020-03-02 17:55:36 -08:00
Maurice Parker eaa99db5c7 Initial support for multiple windows and state preservation. 2020-03-02 17:46:31 -08:00
Maurice Parker 94c6ca428f Merge branch 'mac-release' 2020-03-01 16:32:31 -08:00
Maurice Parker dc20aa0e22
Merge pull request #1833 from Wevah/embedded-widget-fix
Embedded widget fix
2020-03-01 14:25:23 -08:00
Maurice Parker 1c55e0c8a9 Don't show select in sidebar if the web feed is already selected. Issue #1843 2020-03-01 11:07:24 -08:00
Maurice Parker 80858adced Exclude currently selected article from feed filter. Issue #1841 2020-02-29 17:05:56 -08:00
Maurice Parker 5eed42721e Change so that feeds aren't filtered on select feed in sidebar if they are already visible. 2020-02-29 16:30:13 -08:00
Maurice Parker dac4c2ffb0 Disclose feed in side bar when selected from context menu even if the feed is filtered. Issue #1805 2020-02-29 16:24:14 -08:00
Maurice Parker 4b2f08e759 Refactor select web feed in sidebar to use the delegate pattern instead of a notification. 2020-02-29 15:50:13 -08:00
Maurice Parker d459c0927b Change smart feeds to ignore feed filter when programmatically selected.
Change selected item to ignore feed filter.  Issue #1805
2020-02-29 15:10:41 -08:00
Maurice Parker d1cd205eff Rebuild the side bar by coalescing unread count changes when the read feeds filter is active. Issue #1823 2020-02-29 14:15:37 -08:00
Maurice Parker c17ce1ceaa Make articles older than a specified period unable to be marked as unread. Issue #1407 2020-02-29 10:30:35 -08:00
Nate Weaver 82f8951c96 Don't force iframe height to auto
Prevents truncating of YouTube embeds without needing a wrapper div.
2020-02-28 08:24:42 -06:00
Nate Weaver bedaa75eb8 Set max-width to 44em (792px with an 18px font-size) 2020-02-28 07:47:19 -06:00
Maurice Parker 380614afc3 Change focus to smart feed when selected via hotkey. Issue #1009 2020-02-27 16:50:35 -08:00
Maurice Parker 8d57fd193c Make the star swipe background color yellow. Issue #1015 2020-02-27 16:27:12 -08:00
Maurice Parker 85bd20ca80 Stop media playback when the main window is closed. Issue #1646 2020-02-27 12:15:41 -08:00
Maurice Parker a465045888 Save last used folder name when adding a feed. Issue #1462 2020-02-27 11:27:41 -08:00
Maurice Parker 2ae021960b Move account files to the documents directory and out of the shared container. Issue #1784 2020-02-12 16:21:48 -08:00
Nate Weaver e6c2c32456 Standardize on tabs 2020-01-30 06:19:54 -06:00
Nate Weaver 447cc44b8e Put <title> and <base> in the <head> instead of <body>
This also means renderHTML() is no longer needed.
2020-01-30 06:15:14 -06:00
Maurice Parker dd5633b5ae Change to use the correct URL when reloading an image. 2020-01-27 16:27:13 -07:00
Maurice Parker 3a99e6430f Make the article icon code specify the desired article so that it can't pull the wrong one by mistake. Issue #1707 2020-01-27 12:58:32 -07:00
Maurice Parker 81e71051ef Change to reload the page.html file instead of using its string value. 2020-01-26 20:45:49 -07:00
Nate Weaver 3635176d58 --table-border-color -> --table-cell-border-color; add Mac table styles 2020-01-20 21:59:40 -06:00
Phil Dokas d3ecb68708 Positions the footnote popover on top of other content 2020-01-17 13:41:12 -08:00
Nate Weaver b35215d03b Update for pending RSCore String updates 2020-01-17 13:45:38 -06:00
Maurice Parker 3c1668c178 Make Feedbin/Twitter video usable. Issue #718 2020-01-17 12:17:38 -07:00
Nate Weaver 6eac3781ba Update to latest RSCore
Update use of OMPLString().
2020-01-13 22:20:57 -06:00
Nate Weaver 58c90feccf Update to latest RSCore 2020-01-13 15:32:13 -06:00
Nate Weaver ca429153ce Update to latest RSCore 2020-01-11 01:30:40 -06:00
Nate Weaver 6dc442c264 Update to latest RSCore 2020-01-08 23:40:55 -06:00
Brent Simmons 26bb2b8eaf Remove references to Article.bannerImageURL. We can bring it back if/when we start using it. 2019-12-28 20:53:36 -08:00
Brent Simmons 15184aa3f1 Finish changes mandated by DatabaseQueue changes. 2019-12-16 22:45:59 -08:00
Maurice Parker 58b24f3349 Rename callback: to completion: 2019-12-14 18:01:34 -07:00
Maurice Parker e303d64c1d Refresh feeds and sidebar when downloaded articles update all their unread counts. Issue #1430 2019-12-10 18:17:54 -07:00
Nate Weaver c66ed35799 Add WordPress specific emoji style 2019-12-06 00:31:37 -06:00
Brent Simmons ebd7c68396 Merge mac-release — remove attachments. 2019-12-04 22:36:08 -08:00
Brent Simmons 3ead2c63bc Remove attachments from the app, since we’re not using attachments in any way. We could always add it back later. 2019-12-03 23:03:15 -08:00
Maurice Parker e05fdc99dd Change to use show/hide verbiage in menu items instead of check marks 2019-11-24 04:29:15 -06:00
Maurice Parker 21648a498f Make selection restore when toggling read feeds. 2019-11-22 11:57:06 -06:00
Maurice Parker 5ac14fb910 Add read filter toggle for articles. Issue #130. 2019-11-22 11:47:03 -06:00
Maurice Parker 7667dbf60e Add hide read feeds menu option 2019-11-22 10:55:54 -06:00
Maurice Parker 387b867d71 Shim Mac interface to FeedRequestOperation until article filtering is enabled on the Mac. 2019-11-22 09:43:42 -06:00
Maurice Parker 6d8fca01ea Filter async requests based on ReadFilter. 2019-11-21 19:54:35 -06:00
Maurice Parker 56d43f8f2d Do a full reload of the article when rearranging the UI to accommodate for split screen color changes. 2019-11-20 18:16:54 -06:00
Maurice Parker 188c1f8d8e Reload article image on image load notifications. 2019-11-18 19:44:31 -06:00
Maurice Parker 991ef26a1f Change to remember last selected Folder when adding a Feed. Issue #1306 2019-11-16 19:57:05 -06:00
Maurice Parker 5283d2efbe Implement Feed protocol. 2019-11-15 06:19:14 -06:00
Maurice Parker 06bd5b3a6f Renamed Feed and related classes/instances to WebFeed 2019-11-14 20:11:41 -06:00
Maurice Parker 15e62a0750 Update Mac app to work with latest ActivityManager. 2019-11-14 15:35:19 -06:00
Maurice Parker ec2b23c9f0 Change Feed Inspector to use same IconView class as other places in code displaying feed icons. 2019-11-12 15:52:07 -06:00
Maurice Parker c366a55cb5 Change to use Favicon generator. 2019-11-12 15:36:03 -06:00
Maurice Parker 0d2583948a Add additional assets for Article Extractor Button for when the app is inactive. 2019-11-12 13:05:52 -06:00
Maurice Parker 701070f2dd Make Article icons/avatars match Timeline icons/avatars. Issue #1273 2019-11-12 09:22:23 -06:00
Maurice Parker 560f36621f Add IconImage to encapsulate our icon processing logic 2019-11-05 18:05:57 -06:00
Brent Simmons 4cb602f24a Merge mac-release. 2019-10-26 12:44:33 -07:00
Brent Simmons 759f89ec84
Merge pull request #1170 from Wevah/row-swipe-icons
Use glyphs from SF Symbols for table row swipe actions
2019-10-26 12:25:22 -07:00
Daniel Jalkut 2903e4507b Remove references to WebKit preferences that are not pertinent in 10.15. 2019-10-26 14:23:44 -04:00
Brent Simmons f8376b807a Restore two-step process for OPML exporting. 2019-10-24 21:12:58 -07:00
Brent Simmons 1c06eb27e8 Create separate private extension. Make misc. code formatting changes to match current thinking. 2019-10-23 22:33:21 -07:00
Brent Simmons 6f29497ec8 Move NSTextFieldDelegate conformance to separate extension.
Handle the optional nil case in controlTextDidChange.
2019-10-23 22:27:08 -07:00
Brent Simmons c01b2c6269
Merge pull request #1145 from Wevah/add-folder-button-fix
Disable "Add Folder" button when the text field is empty
2019-10-23 22:22:12 -07:00
Brent Simmons 06b0e35739 Move Protocol declaration to top of ExportOPMLAccessoryViewController.swift. As critical API, it needs to be easy to spot.
Create separation extensions — one for protocol conformance, one for private methods — ExportOPMLController.

Make minor code formatting change: instead of { return } — which is hard to set a breakpoint on — move the return to its own line.

Remove an internal access qualifier, since internal is default and implied.
2019-10-23 22:00:14 -07:00
Nate Weaver 4b1a19360c Use glyphs from SF Symbols for table row swipe actions
(Thin font weight.)
2019-10-23 15:05:12 -05:00
Nate Weaver 37e77a9596 Make delegate-less init() fail since a delegate is currently required 2019-10-22 12:14:38 -05:00
Nate Weaver e7278017d9 Forgo notifications entirely, and use a delegate instead 2019-10-22 12:14:38 -05:00
Nate Weaver a762052264 Don't use block-based notification observing 2019-10-22 12:14:38 -05:00
Nate Weaver 7e98869080 Use an accessory view instead of an intermediate sheet for OPML export 2019-10-22 12:14:38 -05:00
Maurice Parker 00f100e3a3 Renamed TimelineStringFormatter to ArticleStringFormatter now that it is used for much more than the timelines 2019-10-20 02:28:00 -05:00
Nate Weaver b5d7ce8e8c Disable "Add Folder" button when the text field is empty 2019-10-19 12:31:47 -05:00
Brent Simmons 74b1d56cbf Merge branch 'mac-release' 2019-10-18 17:38:22 -07:00
Brent Simmons a11e900a93 Get the y scroll position in the detail view using window.pageYOffset instead of document.body.scrollTop. It appears the latter may be broken — at any rate, it just returns 0 on Catalina. (On Mojave, use the same method as before, so as not to risk a regression.) 2019-10-18 17:37:56 -07:00
Brent Simmons 1d45796220 Merge mac-release. 2019-10-17 22:11:35 -07:00
Brent Simmons 56fab24cec Make importing NetNewsWire 3 subscriptions a one-step process — use an accessory view in the NSOpenPanel. Also: refactor to use immutable structs instead of classes; use static methods on structs; reduce API surface; don’t flatten sub-folders (let the OPML importer handle the flattening, which it already does). 2019-10-17 13:25:11 -07:00
Maurice Parker 51373885b4 Change javascript event handlers to use event.target.matches instead of walking the dom to install event handlers 2019-10-15 09:04:21 -05:00
Maurice Parker 9e18361043 Merge branch 'mac-release' 2019-10-14 20:59:26 -05:00
Maurice Parker 19145505c5 Add the ability to import NNW 3 Subscription plist files. Issue #1129 2019-10-14 20:45:58 -05:00
Brent Simmons 427c0da0d3 Fix build error in FetchRequestQueue. 2019-10-13 22:19:49 -07:00
Brent Simmons 31a2afb067 Fix crashing bug in FetchRequestQueue by making sure the completion is called not more than once from FetchRequestOperation. Fix #1133. 2019-10-13 22:08:05 -07:00
Maurice Parker a1f26898c8 Split Mac and iOS specific javascript into individual files. 2019-10-13 15:47:11 -05:00
Phil Dokas 31c1dc40e3 Fix leading for super and subscript in the article view 2019-10-08 22:15:49 -07:00
Maurice Parker f7e235a1fb Remove padding from code blocks that was causing weird indentation 2019-10-07 11:05:22 -05:00
Kiel Gillard 6707fdcbd1 Double clicking a feed in the side bar opens the feed's homepage in the browser. Issue #1099 2019-10-05 11:44:21 +10:00
Maurice Parker c4b6cbe49e Allow article extractor to be tried again after Mercury parser failure 2019-10-04 07:55:42 -05:00
Maurice Parker 3d343eb91d Prevent pre tags from wrapping. Issue #1089 2019-10-03 18:27:48 -05:00
Maurice Parker 0000e03083 Add the ability to handoff from iOS to Mac 2019-10-03 15:49:27 -05:00
Maurice Parker 9203444552 Add deep linking to Mac app. 2019-10-03 11:39:48 -05:00
Nate Weaver ef29334a41 Use os_log() instead of NSLog() 2019-10-02 11:18:52 -05:00
Nate Weaver f67b7df5a9 Add row swipe action for Mark/Unmark Starred 2019-10-02 11:16:01 -05:00
Nate Weaver bc32fc1cb9 Add row swipe action for Mark Read/Unread 2019-10-02 11:16:01 -05:00
Brent Simmons 27478b0f6f Make r and u both just toggle read status. Update keyboard shortcuts HTML documentation to match. 2019-09-29 22:44:32 -07:00
Brent Simmons b62a7afa10 Add keyboard shortcut for toggling starred status — s key. Fix #875. 2019-09-29 22:34:31 -07:00
Maurice Parker 6536dbf2a5 Use correct account method for adding folders 2019-09-27 06:38:43 -05:00
Maurice Parker d961a73f28 Removed inadvertent code change 2019-09-26 15:30:38 -05:00
Maurice Parker 0a2cbfde22 Knock the corner off the inner image when it is visible 2019-09-26 14:31:43 -05:00
Andrew Brehaut f25c0e0b57 Original implementation was only aware of multimarkdown style footnote markup.
This commit includes support for DaringFireball style footnotes
2019-09-26 20:20:53 +12:00
Andrew Brehaut a381361b56 Merge branch 'master' of https://github.com/brentsimmons/NetNewsWire 2019-09-25 12:18:28 +12:00
Maurice Parker 98befac78c Animate reader view button 2019-09-24 16:34:11 -05:00
Andrew Brehaut 0d99136961 544 Simple darkmode style for popovers 2019-09-23 20:38:46 +12:00
Andrew Brehaut 4c54d2c4ff 544 adds and positions the arrow on the popover bubble
An arrow element is now inserted into the dom to orient the bubble to the fnref
element that opened it. This is offset in the opposite direction to the bubble
if the bubble overhangs one side or the other.

Additionally, if both sides overhang then no positioning takes place. This
is the first step towards supporting more narrow windows and mobile clients.
2019-09-23 20:25:00 +12:00
Andrew Brehaut af5d510c80 #544 Better handling of the footnote reverse links
* Uses a stylesheet to hide the reverse link in the popover rather than monkeying around with the dom in JS
* Javascript event handler catches clicks on the reverse buttons in the footnote list at the bottom of the page
  and scrolls the document back to the source, rather than opening the document in a browser window.
2019-09-23 19:56:58 +12:00
Andrew Brehaut 5fea81971b #554 newsfoot.js and css are included in the page
These changes are the bare minimum required to get footnotes to appear and function on the article page.
 * The newsfoot.js script now wraps everything in an IIFE to prevent bleed to other scripts
 * Stylesheets are included in the main stylesheet, with the colors extracted out into separate selectors

Currently missing the arrow pointing to the footnote link, and no consideration exists for mobile presentation
beyond a max-width: 100vh on the footnote popover.
2019-09-22 14:06:51 +12:00
Maurice Parker 9d54a1de74 Enable always on Reader View for feeds 2019-09-21 15:03:42 -05:00
Maurice Parker b49aeca577 Moved page.html location information to ArticleRenderer 2019-09-21 12:36:35 -05:00
Maurice Parker 0c00150849 Externalize javascript code into separate main.js file 2019-09-21 04:34:11 -05:00
Maurice Parker ba45144c2a Merge branch 'mac-release' 2019-09-21 03:57:41 -05:00
Maurice Parker 3decd23c45 Convert iOS to use Javascript rendering 2019-09-20 20:33:28 -05:00
Maurice Parker 710abf30c7 Make stylesheet external to page.html 2019-09-20 19:28:13 -05:00
Ben Ubois cdf643c2a6 Make iFrames responsive. 2019-09-20 17:21:01 -07:00
Maurice Parker 9c6d47eaa1 Merge branch 'pr/1033' 2019-09-20 17:51:27 -05:00
Maurice Parker 1bcc1eda44 Implement disallowing feeds in the root folder for specified accounts 2019-09-20 15:37:10 -05:00
Maurice Parker af0d6c9022 Implement AccountBehaviors so that we don't have to keep adding boolean flags to account 2019-09-20 11:34:31 -05:00
Maurice Parker 567d762ea4 Fix button animation resets 2019-09-19 17:30:54 -05:00
Maurice Parker 76056e4fef Add menu and keyboard shortcut to Reader 2019-09-19 17:25:36 -05:00
Maurice Parker 6a7d1df423 Change image references to use AppAsserts per our standard 2019-09-19 15:44:31 -05:00
Maurice Parker d3a5bdf6d3 Merge branch 'mac-release' 2019-09-19 11:59:01 -05:00
Nate Weaver 4a0bbeacc2 Disable Web Inspector for App Store builds
- Hide the "Enable Web Inspector" menu item.
- #if-out notifications/defaults/etc.
- Make toggleWebInspectorEnabled(_) a no-op.
2019-09-19 10:38:17 -05:00
Ben Ubois 0b6683d073 Render with evaluateJavaScript.
Replaced loadHTMLString based rendering for improved performance.
2019-09-18 22:03:23 -07:00
Maurice Parker 3b5a6f2576 Don't allow the article extraction button to toggle if it isn't working. 2019-09-18 20:03:01 -05:00
Maurice Parker 8cd6f107e5 Add basic Article Content extraction 2019-09-18 18:15:55 -05:00
Maurice Parker 786a4e48c4 Merge branch 'mac-release' 2019-09-17 15:01:01 -05:00
Nate Weaver 0c89bc43c1 Use a bridging header for the Web Inspector API instead of KVC 2019-09-17 06:55:55 -05:00
Nate Weaver 4f405009f5 Use a selector instead of a block for the notification observation 2019-09-17 05:04:05 -05:00
Nate Weaver e39fa31bf7 Add a menu item to the Debug menu to enable the Web Inspector
Just enables the "Inspect Element" item in a WKWebView's contextual menu at the moment.
2019-09-17 05:04:05 -05:00
Brent Simmons b075226685 Merge mac-release. 2019-09-16 22:32:08 -07:00
Brent Simmons 66d9333999 Make minor code formatting changes so that TimelineViewController matches our current thinking. Also delete some commented-out and unused code. 2019-09-16 22:27:17 -07:00
Brent Simmons d16acfcca8 Merge branch 'mac-release' 2019-09-16 22:10:17 -07:00
Brent Simmons f7c9cc1dbd Remove no-longer needed machinery for updating the timeline on dark-mode/light-mode appearance changes. 2019-09-16 22:09:58 -07:00
Brent Simmons 1ece325112 Merge mac-release. 2019-09-16 20:09:04 -07:00
Brent Simmons a05fd61085 Merge branch 'imagecache' into mac-release 2019-09-16 20:07:31 -07:00
Brent Simmons a225d52ba3 Use the new TimelineAvatarView instead of an NSImageView in TimelineTableCellView. 2019-09-16 20:01:30 -07:00
Brent Simmons 506b621e5d Draw the avatar background in TimelineAvatarView only if the icon is too short vertically. 2019-09-16 20:00:32 -07:00
Maurice Parker 444771dfae Merge branch 'mac-release' 2019-09-16 18:16:13 -05:00
Maurice Parker 1d7cbe5596 Fix super wide div's. Issue #1010 2019-09-16 18:12:56 -05:00